summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Improves STD output/readability in combinationdom finn2019-07-14
| | | | | | | | with debug output. Added \n char to specific standard output Signed-off-by: dom finn <dom.finn00@gmail.com>
* Merge pull request #3564 from giuseppe/cgroupsv2-no-controllers-last-pathOpenShift Merge Robot2019-07-13
|\ | | | | cgroupsv2: do not enable controllers for the last component
| * cgroupsv2: do not enable controllers for the last componentGiuseppe Scrivano2019-07-12
| | | | | | | | | | | | | | | | | | | | | | do not automatically enable the controllers for the last path component. It is necessary as once there are enabled controllers in a cgroup, it won't possible to add processes to it. Fix conmon being moved to the correct cgroup path when using --cgroup-manager cgroupfs. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #3563 from giuseppe/fix-single-mapping-rootlessOpenShift Merge Robot2019-07-12
|\ \ | | | | | | spec: fix userns with less than 5 gids
| * | spec: fix userns with less than 5 gidsGiuseppe Scrivano2019-07-12
| |/ | | | | | | | | | | | | when the container is running in a user namespace, check if gid=5 is available, otherwise drop the option gid=5 for /dev/pts. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #3537 from QiWang19/volumeabsOpenShift Merge Robot2019-07-12
|\ \ | | | | | | fix bug convert volume host path to absolute
| * | fix bug convert volume host path to absoluteQi Wang2019-07-10
| | | | | | | | | | | | | | | | | | fix #3504 If --volume host:dest host is not a named volume, convert the host to a absolute directory path. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Merge pull request #3534 from cevich/img_sys_tstOpenShift Merge Robot2019-07-12
|\ \ \ | | | | | | | | Cirrus: Execute system-tests during image-validation
| * | | Cirrus: Update to freshly built cache-imagesChris Evich2019-07-12
| | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | Cirrus: Execute system-tests during image-validationChris Evich2019-07-12
| | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | Cirrus: Fix missing removal of packaged podmanChris Evich2019-07-12
|/ / / | | | | | | | | | | | | | | | This was originally intended, but somehow omitted from #1936 Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #3557 from rhatdan/envOpenShift Merge Robot2019-07-12
|\ \ \ | | | | | | | | Add support for --env-host
| * | | Fix spelling mistakes in man pages and other docsDaniel J Walsh2019-07-11
| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | Add glob parsing for --env flagDaniel J Walsh2019-07-11
| | | | | | | | | | | | | | | | | | | | | | | | Sometimes you want to add a few environmen variables based on the last field being a "*". Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | Add support for -env-hostDaniel J Walsh2019-07-11
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | This flag passes the host environment into the container. The basic idea is to leak all environment variables from the host into the container. Environment variables from the image, and passed in via --env and --env-file will override the host environment. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #3558 from mheon/fix_pod_removeOpenShift Merge Robot2019-07-11
|\ \ \ | | | | | | | | Fix a bug where ctrs could not be removed from pods
| * | | Fix a bug where ctrs could not be removed from podsMatthew Heon2019-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using pod removal worked, but container removal was missing the most critical step - the actual removal. Must have been accidentally removed during a refactor. Fixes #3556 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #3552 from baude/golangcilint2OpenShift Merge Robot2019-07-11
|\ \ \ \ | | | | | | | | | | golangci-lint pass number 2
| * | | | golangci-lint pass number 2baude2019-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | clean up and prepare to migrate to the golangci-linter Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #3491 from giuseppe/rlimit-hostOpenShift Merge Robot2019-07-11
|\ \ \ \ \ | | | | | | | | | | | | podman: add --ulimit host
| * | | | | podman: add --ulimit hostGiuseppe Scrivano2019-07-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add a simple way to copy ulimit values from the host. if --ulimit host is used then the current ulimits in place are copied to the container. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #3470 from QazerLab/docs/system-testsOpenShift Merge Robot2019-07-11
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update the testing documentation with system tests.
| * | | | | | Update the testing documentation with system tests.Danila Kiver2019-07-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add Bats installation procedure. Signed-off-by: Danila Kiver <danila.kiver@mail.ru>
* | | | | | | Merge pull request #3554 from giuseppe/fix-cgroupfs-cleanupOpenShift Merge Robot2019-07-11
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | cgroups: fix a leak when using cgroupfs
| * | | | | | | cgroups: fix a leak when using cgroupfsGiuseppe Scrivano2019-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | be sure to load all the existing handlers, so that they can also be freed in addition to the handlers we treat differently. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | | | | cgroups: attempt a recursive rmdirGiuseppe Scrivano2019-07-11
| | |_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if the cgroup cannot be deleted, then attempt to delete all its subdirectories and try again. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | | Merge pull request #3545 from cevich/fix_binary_releaseOpenShift Merge Robot2019-07-11
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | Cirrus: Fix #3543: Failure in 'release' task
| * | | | | | Cirrus: Fix #3543: Failure in 'release' taskChris Evich2019-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Normally when testing PRs, the final task to run is 'success'. It's purpose is three-fold: - Notify on IRC that a PR passed all testing. - Block merging of a PR unless all dependent tasks are successful. - When successful, publish cached binary release archives. Mistakenly, the 'release' task was not made dependent upon the 'success' task. Since 'success' only runs for PRs, this was causing post-merge failures due to the 'release' task not finding any release archives - the tasks which generate them are still running. Fix this by making the 'release' task depend upon the same items as the 'success' task. This will ensure it only runs as the very last step, for both PRs and on branches (post-merge). Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | | | | Cirrus: Fix 473d06045 / enable build_without_cgoChris Evich2019-07-10
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | Merge pull request #3527 from adrianreber/finishOpenShift Merge Robot2019-07-11
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Correctly set FinishedTime for checkpointed container
| * | | | | Correctly set FinishedTime for checkpointed containerAdrian Reber2019-07-11
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | During 'podman container checkpoint' the finished time was not set. This resulted in a strange container status after checkpointing: Exited (0) 292 years ago During checkpointing FinishedTime is now set to time.now(). Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | | Merge pull request #3521 from baude/golangcilint1OpenShift Merge Robot2019-07-11
|\ \ \ \ \ | |_|_|_|/ |/| | | | first pass of corrections for golangci-lint
| * | | | first pass of corrections for golangci-lintbaude2019-07-10
| |/ / / | | | | | | | | | | | | Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #3538 from giuseppe/fix-some-regressionsOpenShift Merge Robot2019-07-10
|\ \ \ \ | | | | | | | | | | runtime: drop spurious message log
| * | | | runtime: drop spurious message logGiuseppe Scrivano2019-07-10
| |/ / / | | | | | | | | | | | | | | | | | | | | fix a regression introduced by 1d36501f961889f554daf3c696fe95443ef211b6 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #3367 from baude/varlinkmoreOpenShift Merge Robot2019-07-10
|\ \ \ \ | |/ / / |/| | | account for varlink calls that dont use more
| * | | account for varlink calls that dont use morebaude2019-07-10
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the commit and pull varlink endpoints were not working correctly when 'more' was not being specified. Fixes: #3317 Fixes: #3318 Fixes: #3526 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #3106 from cevich/cirrus_releaseOpenShift Merge Robot2019-07-10
|\ \ \ | | | | | | | | Cirrus: Automate releasing of tested binaries
| * | | Cirrus: Automate releasing of tested binariesChris Evich2019-07-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It's desirable to make archives available of builds containing actual tested content. While not official distro-releases, these will enable third-party testing, experimentation, and development for both branches (e.g. "master") and pull requests (e.g. "pr3106"). * Add a Makefile targets for archiving both regular podman binaries and the remote-client. Encode release metadata within these archives so that their exact source can be identified. * Fix bug with cross-compiling remote clients for the Windows and Darwin platforms. * Add unit-testing of cross-compiles for Windows and Darwin platforms. * A few small CI-script typo-fixes * Add a script which operates in two modes: 1. Call Makefile targets which produce release archives. Upload the archive to Cirrus-CI's built-in caching system using reproducible cache keys. 2. Utilize reproduced cache keys to attempt download of cache from each tasks. When successful, parse the file's release metadata, using it to name the archive file. Upload all recovered archives to a publicly accessible storage bucket for future reference. * Update the main testing task to call the script in mode #1 for all primary platforms. * Add a new `$SPECIALMODE` task to call the script in mode #1 for Windows and Darwin targets. * Add a new 'release' task to the CI system, dependent upon all other tasks. This new tasks executes the script in mode #2. * Update CI documentation Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #3506 from giuseppe/cgroup2-improvementsOpenShift Merge Robot2019-07-10
|\ \ \ \ | | | | | | | | | | cgroups: support creating cgroupsv2 paths
| * | | | cgroups: skip not existing cpuacct filesGiuseppe Scrivano2019-07-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if the cpuacct file doesn't exist, ignore it instead of erroring out. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1728242 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | cgroups: support creating cgroupsv2 pathsGiuseppe Scrivano2019-07-10
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | drop the limitation of not supporting creating new cgroups v2 paths. Every controller enabled /sys/fs/cgroup will be propagated down to the created path. This won't work for rootless cgroupsv2, but it is not an issue for now, as this code is used only by CRI-O. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #3536 from edsantiago/tabularasa_before_system_testOpenShift Merge Robot2019-07-10
|\ \ \ \ | | | | | | | | | | make localsystem: wipe all user config state
| * | | | make localsystem: wipe all user config stateEd Santiago2019-07-09
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CI is experiencing failures in the system_test step, caused by podman commands issuing the following warning: time="2019-07-09T13:30:19-04:00" level=error msg="User-selected graph driver \"overlay\" overwritten by graph driver \"vfs\" from database - delete libpod local files to resolve Hypothesis: integration tests, which run just before us, are leaving user config files in an unstable state. Workaround: delete all user cache and config and db before running system tests. This should be safe, and should be a NOP when running as root. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #3529 from giuseppe/healthcheck-rootlessOpenShift Merge Robot2019-07-09
|\ \ \ \ | | | | | | | | | | healthcheck: support rootless mode
| * | | | healthcheck: support rootless modeGiuseppe Scrivano2019-07-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | now that dbus authentication works fine from a user namespace (systemd 241 works fine), we can enable rootless healthchecks. It uses "systemd-run --user" for creating the healthcheck timer and communicates with the user instance of systemd listening at $XDG_RUNTIME_DIR/systemd/private. Closes: https://github.com/containers/libpod/issues/3523 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #3501 from adrianreber/randomOpenShift Merge Robot2019-07-09
|\ \ \ \ \ | | | | | | | | | | | | Randomize IP addresses during checkpoint/restore tests
| * | | | | Use random IP addresses during checkpoint/restore testsAdrian Reber2019-07-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This tries to reduce CI errors which might happen due to parallel CI runs which all are using the same IP addresses. Using random addresses should reduce the possibility of parallel tests using the same IP address. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | | | Merge pull request #3480 from mheon/potential_ps_test_fixOpenShift Merge Robot2019-07-09
|\ \ \ \ \ \ | | | | | | | | | | | | | | Restart failed containers in tests
| * | | | | | Restart failed containers in testsMatthew Heon2019-07-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we're waiting for a container to come up with healthchecks, and it's not even running, there's no point to waiting further. Instead, let's restart the container and continue waiting. This may fix some flakes we're seeing with 'podman port' tests. Then again, all the tests there seem to fail, not just a single test flaking - so I bet there's some other underlying cause. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-27 05:18:27 +0000