| Commit message (Collapse) | Author | Age |
|---|
| |\
| |
| | |
Update metalinter dependency
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
While we have these string literals on repeated on multiple places in the
library, I cannot see real tangible benefit extracting these to constants
considering following facts:
(1) while 'unknown' or 'host' are repeated, they are often times used in
different context and thus perhaps worth extra const per each use.
(2) while these string literals repeat, the library is full of string literals
with special meaning that should be made constants too
(3) readability would suffer
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| | |
| |
| |
| |
| |
| | |
Addressing goconst warning: 3 other occurrence(s) of "Unknown" found
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| | |
| |
| |
| |
| |
| |
| | |
Addressing:
ineffectual assignment to err (ineffassign)
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Redefining err by := operator within block makes this err variable block local.
Addressing lint:
libpod/oci.go:368:3:warning: ineffectual assignment to err (ineffassign)
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Not just nil.
Addressing:
pkg/varlinkapi/images.go:273:15:warning: ineffectual assignment to err (ineffassign)
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| | |
| |
| |
| | |
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We fixated on old metalinter dependency in past based on experience of
metalinter being oftentimes broke and hence broking our build. See
762f508d9ca97cdbaee6053b663e98aee9cae081 in cri-o for more details.
Now, dated metalinter is messing up with my environment (like it is
panicing on containters/storage) so let's see if we can move to more
current version of metalinter.
Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
|
| |\ \
| | |
| | | |
Set --force-rm for podman build to true by default
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since we use buildah containers for the build process, the
user will not know if we have any buildah containers lingering
due to a failed build. Setting this to true by default till
we figure out a better way to solve this.
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
| |\ \ \
| | | |
| | | | |
Bump to v0.11.1.1
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |/ / /
| | |
| | |
| | | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |\ \ \
| | | |
| | | | |
Add release notes for 0.11.1.1
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |\ \ \ \
| |/ / /
|/| | | |
Vendor in containers/storage
|
| |/ / /
| | |
| | |
| | | |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
|
| |\ \ \
| | | |
| | | | |
Increase pidWaitTimeout to 60s
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
At scale, it appears that we sometimes hit the 1000ms timeout to create
the PID file when a container is created or executed.
Increasing the value to 60s should help when running a lot of containers
in heavy-loaded environment.
Related #1495
Fixes #1816
Signed-off-by: Emilien Macchi <emilien@redhat.com>
|
| |\ \ \
| | | |
| | | | |
Cirrus: Add master branch testing status badge
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Engineers get testing status via their PR's but another round of testing
happens post-merge, without any direct feedback. Fix this in a small
way, by adding a dynamic status badge on the front-page. If this
turns red, it means Cirrus-CI testing of the master branch failed
for some reason.
Nearly always it's something harmless, but once and a while, this
catches really nasty problems caused by merge-sequence issues.
Having that feedback on the front page ensures the right people will
eventually get called into action.
Signed-off-by: Chris Evich <cevich@redhat.com>
|
| |\ \ \
| | | |
| | | | |
rootless: call IsRootless just once
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
we are calling this function several times, it is worth to store its
result and re-use it.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| |\ \ \ \
| | | | |
| | | | | |
Bump golang to v1.10 in install.md
|
| |/ / / /
| | | |
| | | |
| | | | |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
|
| |\ \ \ \
| | | | |
| | | | | |
Standardized container image for gofmt and lint
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Having a standardized image allows uniform application of format and
lint checking across multiple host platforms. This ensures all
contributors and disparate CI systems to play by a common set of basic
rules. It also makes it easier to maintain the common rules over-time.
Signed-off-by: Chris Evich <cevich@redhat.com>
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Make list of approvers same as reviewers
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Can't see any reason for a difference here. If you can review, you can approve.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
vendor: update ostree-go
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | | |/ / /
| |/| | |
| | | | |
| | | | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| |\ \ \ \ \
| |/ / / /
|/| | | | |
Cleanup podman spec to not show git checkout is dirty
|
| |/ / / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Currently we modify the git checkout which ends up showing that the checkout is dirty. This patch sets the PYTHON_VERSION so that python code will handle
it correctly without having to modify the actual code.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\ \ \ \
| | | | |
| | | | | |
Add space between num & unit in images output
|
| | | |_|/
| |/| |
| | | |
| | | | |
Signed-off-by: Qi Wang <qiwan@redhat.com>
|
| |\ \ \ \
| | | | |
| | | | | |
Update troubleshooting guide to deal with rootless path
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We had a breaking change to rootless containers' temporary files
directories in Podman 0.11.1. Document a workaround to make the
change no longer working.
Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
troubleshooting.md: add a recipe for rootless ping
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
remove $-prefix from (most) shell examples
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
For the shell examples related to building and installing podman, remove the
shell prompt indicator character '$'.
This makes copying and pasting lines much easier.
Retain the prompt indicator for the post-install shell examples, since they
(often) mix shell commands and shell command output, so it serves a useful
purpose to distinguish them.
Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
|
| |\ \ \ \ \ \ \
| |_|_|_|_|/ /
|/| | | | | | |
docs: Fix duplicated entry for pod-container-unmount
|
| | | |_|_|/ /
| |/| | | |
| | | | | |
| | | | | | |
Signed-off-by: Xavier Krantz <xakraz@gmail.com>
|
| |\ \ \ \ \ \
| |/ / / / /
|/| | | | | |
Better document rootless containers
|
| |/ / / / /
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Need to return an error pointing user in right direction if rootless podman
fails, because of no /etc/subuid or /etc/subgid files.
Also fix up man pages to better describe rootless podman.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
rm -f now removes a paused container
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
We now can remove a paused container by sending it a kill signal while it
is paused. We then unpause the container and it is immediately killed.
Also, reworked how the parallelWorker results are handled to provide a
more consistent approach to how each subcommand implements it. It also
fixes a bug where if one container errors, the error message is duplicated
when printed out.
Signed-off-by: baude <bbaude@redhat.com>
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Accurately update state if prepare() partially fails
|
