summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* runlabel: use shlex for splitting commandsValentin Rothberg2018-11-16
| | | | | | | | Use github.com/google/shlex for splitting commands instead of splitting at whitespaces. This way, we avoid accidentally splitting single string arguments into mutliple ones. Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
* Merge pull request #1813 from rhatdan/versionOpenShift Merge Robot2018-11-16
|\ | | | | Add version command to pypodman
| * Add version command to pypodmanDaniel J Walsh2018-11-15
| | | | | | | | | | | | | | | | | | | | pypodman does not currently support the version command. We want to have as close to the same functionality between podman and pypodman, so adding this command. Also had to fix some validate errors. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #1756 from isimluk/update-dependent-metalinterOpenShift Merge Robot2018-11-16
|\ \ | | | | | | Update metalinter dependency
| * | Lint: Silence few given goconst lint warningsŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While we have these string literals on repeated on multiple places in the library, I cannot see real tangible benefit extracting these to constants considering following facts: (1) while 'unknown' or 'host' are repeated, they are often times used in different context and thus perhaps worth extra const per each use. (2) while these string literals repeat, the library is full of string literals with special meaning that should be made constants too (3) readability would suffer Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | Lint: Extract constant unknownPackageŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | Addressing goconst warning: 3 other occurrence(s) of "Unknown" found Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | Lint: Tests: add missing assertionsŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | Addressing: ineffectual assignment to err (ineffassign) Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | Lint: Do not ignore errors from docker run command when selinux enabledŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | Redefining err by := operator within block makes this err variable block local. Addressing lint: libpod/oci.go:368:3:warning: ineffectual assignment to err (ineffassign) Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | Lint: InspectImage varlink api should return errors that occurredŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | Not just nil. Addressing: pkg/varlinkapi/images.go:273:15:warning: ineffectual assignment to err (ineffassign) Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | Lint: Exclude autogenerated files from lint testŠimon Lukašík2018-11-10
| | | | | | | | | | | | Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | Lint: Update metalinter dependencyŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fixated on old metalinter dependency in past based on experience of metalinter being oftentimes broke and hence broking our build. See 762f508d9ca97cdbaee6053b663e98aee9cae081 in cri-o for more details. Now, dated metalinter is messing up with my environment (like it is panicing on containters/storage) so let's see if we can move to more current version of metalinter. Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
* | | Merge pull request #1769 from umohnani8/buildOpenShift Merge Robot2018-11-16
|\ \ \ | |_|/ |/| | Set --force-rm for podman build to true by default
| * | Set --force-rm for podman build to true by defaultUrvashi Mohnani2018-11-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | Since we use buildah containers for the build process, the user will not know if we have any buildah containers lingering due to a failed build. Setting this to true by default till we figure out a better way to solve this. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | | Merge pull request #1821 from mheon/bump-0.11.1.1Matthew Heon2018-11-15
|\ \ \ | | | | | | | | Bump to v0.11.1.1
| * | | Bump gitvalidation epochMatthew Heon2018-11-15
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * | | Bump to v0.11.2-devMatthew Heon2018-11-15
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
| * | | Bump to v0.11.1.1v0.11.1.1Matthew Heon2018-11-15
|/ / / | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
* | | Merge pull request #1819 from mheon/release_notes_0.11.1.1Matthew Heon2018-11-15
|\ \ \ | | | | | | | | Add release notes for 0.11.1.1
| * | | Add release notes for 0.11.1.1Matthew Heon2018-11-15
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
* | | | Merge pull request #1820 from TomSweeneyRedHat/dev/tsweeney/storeven1Matthew Heon2018-11-15
|\ \ \ \ | |/ / / |/| | | Vendor in containers/storage
| * | | Vendor in containers/storageTomSweeneyRedHat2018-11-15
|/ / / | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #1818 from EmilienM/issue/1816OpenShift Merge Robot2018-11-15
|\ \ \ | | | | | | | | Increase pidWaitTimeout to 60s
| * | | Increase pidWaitTimeout to 60sEmilien Macchi2018-11-15
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At scale, it appears that we sometimes hit the 1000ms timeout to create the PID file when a container is created or executed. Increasing the value to 60s should help when running a lot of containers in heavy-loaded environment. Related #1495 Fixes #1816 Signed-off-by: Emilien Macchi <emilien@redhat.com>
* | | Merge pull request #1814 from cevich/cirrus_badgeOpenShift Merge Robot2018-11-14
|\ \ \ | | | | | | | | Cirrus: Add master branch testing status badge
| * | | Cirrus: Add master branch testing status badgeChris Evich2018-11-14
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Engineers get testing status via their PR's but another round of testing happens post-merge, without any direct feedback. Fix this in a small way, by adding a dynamic status badge on the front-page. If this turns red, it means Cirrus-CI testing of the master branch failed for some reason. Nearly always it's something harmless, but once and a while, this catches really nasty problems caused by merge-sequence issues. Having that feedback on the front page ensures the right people will eventually get called into action. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #1812 from giuseppe/rootless-onceOpenShift Merge Robot2018-11-14
|\ \ \ | | | | | | | | rootless: call IsRootless just once
| * | | rootless: call IsRootless just onceGiuseppe Scrivano2018-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | we are calling this function several times, it is worth to store its result and re-use it. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #1811 from TomSweeneyRedHat/dev/tsweeney/gov1.10OpenShift Merge Robot2018-11-13
|\ \ \ \ | | | | | | | | | | Bump golang to v1.10 in install.md
| * | | | Bump golang to v1.10 in install.mdTomSweeneyRedHat2018-11-13
|/ / / / | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #1804 from cevich/lint_verify_imageOpenShift Merge Robot2018-11-13
|\ \ \ \ | | | | | | | | | | Standardized container image for gofmt and lint
| * | | | Standardized container image for gofmt and lintChris Evich2018-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having a standardized image allows uniform application of format and lint checking across multiple host platforms. This ensures all contributors and disparate CI systems to play by a common set of basic rules. It also makes it easier to maintain the common rules over-time. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #1809 from rhatdan/jediOpenShift Merge Robot2018-11-13
|\ \ \ \ \ | | | | | | | | | | | | Make list of approvers same as reviewers
| * | | | | Make list of approvers same as reviewersDaniel J Walsh2018-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Can't see any reason for a difference here. If you can review, you can approve. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #1807 from giuseppe/vendor-ostree-goOpenShift Merge Robot2018-11-13
|\ \ \ \ \ \ | |/ / / / / |/| | | | | vendor: update ostree-go
| * | | | | vendor: update ostree-goGiuseppe Scrivano2018-11-13
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | | vendor.conf: fix typoGiuseppe Scrivano2018-11-13
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #1805 from rhatdan/rpmOpenShift Merge Robot2018-11-13
|\ \ \ \ \ | |/ / / / |/| | | | Cleanup podman spec to not show git checkout is dirty
| * | | | Cleanup podman spec to not show git checkout is dirtyDaniel J Walsh2018-11-12
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | Currently we modify the git checkout which ends up showing that the checkout is dirty. This patch sets the PYTHON_VERSION so that python code will handle it correctly without having to modify the actual code. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #1803 from QiWang19/issuebuildah1051OpenShift Merge Robot2018-11-12
|\ \ \ \ | | | | | | | | | | Add space between num & unit in images output
| * | | | Add space between num & unit in images outputQi Wang2018-11-12
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #1802 from mheon/troubleshooting_rootlessOpenShift Merge Robot2018-11-12
|\ \ \ \ | | | | | | | | | | Update troubleshooting guide to deal with rootless path
| * | | | Update troubleshooting guide to deal with rootless pathMatthew Heon2018-11-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We had a breaking change to rootless containers' temporary files directories in Podman 0.11.1. Document a workaround to make the change no longer working. Signed-off-by: Matthew Heon <matthew.heon@gmail.com>
* | | | | Merge pull request #1779 from giuseppe/troubleshoot-unprivileged-pingOpenShift Merge Robot2018-11-12
|\ \ \ \ \ | | | | | | | | | | | | troubleshooting.md: add a recipe for rootless ping
| * | | | | troubleshooting.md: add a recipe for rootless pingGiuseppe Scrivano2018-11-12
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #1794 from jmtd/patch-1OpenShift Merge Robot2018-11-12
|\ \ \ \ \ \ | | | | | | | | | | | | | | remove $-prefix from (most) shell examples
| * | | | | | remove $-prefix from (most) shell examplesJonathan Dowland2018-11-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For the shell examples related to building and installing podman, remove the shell prompt indicator character '$'. This makes copying and pasting lines much easier. Retain the prompt indicator for the post-install shell examples, since they (often) mix shell commands and shell command output, so it serves a useful purpose to distinguish them. Signed-off-by: Jonathan Dowland <jdowland@redhat.com>
* | | | | | | Merge pull request #1799 from xakraz/fixes/doc_containersOpenShift Merge Robot2018-11-12
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | docs: Fix duplicated entry for pod-container-unmount
| * | | | | | docs: Fix duplicated entry for pod-container-unmountXavier Krantz2018-11-11
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | Signed-off-by: Xavier Krantz <xakraz@gmail.com>
* | | | | | Merge pull request #1795 from rhatdan/userOpenShift Merge Robot2018-11-12
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Better document rootless containers
| * | | | | Better document rootless containersDaniel J Walsh2018-11-10
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Need to return an error pointing user in right direction if rootless podman fails, because of no /etc/subuid or /etc/subgid files. Also fix up man pages to better describe rootless podman. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-16 07:39:57 +0000