summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Ensure that --net=host/pod/container/none warn with -pMatthew Heon2020-11-04
| | | | | | | | | | | | Setting port mappings only works when CNI is configuring our network (or slirp4netns, in the rootless case). This is not the case with `--net=host`, `--net=container:`, and joining the network namespace of the pod we are part of. Instead of allowing users to do these things and then be confused why they do nothing, let's match Docker and return a warning that your port mappings will do nothing. Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #8157 from rhatdan/volumesOpenShift Merge Robot2020-10-28
|\ | | | | Add test cases to cover podman volume
| * Add test cases to cover podman volumeYuhui Jiang2020-10-27
| | | | | | | | | | | | | | | | | | | | | | | | Add test cases to cover below podman volume subcommand: create ls inspect rm prune Signed-off-by: Yuhui Jiang <yujiang@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #8102 from ashley-cui/inspectOpenShift Merge Robot2020-10-27
|\ \ | | | | | | Add pod, volume, network to inspect package
| * | Add pod, volume, network to inspect packageAshley Cui2020-10-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman inspect only had the capabilities to inspect containers and images. if a user wanted to inspect a pod, volume, or network, they would have to use `podman network inspect`, `podman pod inspect` etc. Docker's cli allowed users to inspect both volumes and networks using regular inspect, so this commit gives the user the functionality If the inspect type is not specified using --type, the order of inspection is: containers images volumes networks pods meaning if container that has the same name as an image, podman inspect would return the container inspect. To avoid duplicate code, podman network inspect and podman volume inspect now use the inspect package as well. Podman pod inspect does not because podman pod inspect returns a single json object while podman inspect can return multiple) Signed-off-by: Ashley Cui <acui@redhat.com>
* | | Merge pull request #8121 from baude/clioptsresourcesOpenShift Merge Robot2020-10-27
|\ \ \ | | | | | | | | set resources only when specified
| * | | set resources only when specifiedbaude2020-10-27
| | | | | | | | | | | | | | | | | | | | | | | | when using the compatibility endpoint to create a container, we should only set certain resources when we are provided a value for them or we result in fields with zero values. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #8141 from afbjorklund/podman-remote-host-port-masterOpenShift Merge Robot2020-10-27
|\ \ \ \ | | | | | | | | | | Add support for host keys for non-22 ports
| * | | | Add support for host keys for non-22 portsAnders F Björklund2020-10-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When not using the standard SSH port (22), the port is appended to the hostname (in brackets) like so: "host" -> "[host]:1234" Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com> (cherry picked from commit 8794e8db1ce3088d633911454d6d36c4e939e126)
* | | | | Merge pull request #8133 from xordspar0/cpu-limit-detailsOpenShift Merge Robot2020-10-27
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Add more details about how CPU limits work
| * | | | | Add more details about how CPU limits workJordan Christiansen2020-10-27
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
* | | | | | Merge pull request #8134 from xordspar0/cpu.max-permissionOpenShift Merge Robot2020-10-27
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Document how to enable CPU limit delegation
| * | | | | | Document how to enable CPU limit delegationJordan Christiansen2020-10-27
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
* | | | | | Merge pull request #8145 from ↵OpenShift Merge Robot2020-10-27
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/common-0.26.2 Bump github.com/containers/common from 0.26.0 to 0.26.3
| * | | | | build(deps): bump github.com/containers/common from 0.26.0 to 0.26.3Daniel J Walsh2020-10-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/common](https://github.com/containers/common) from 0.26.0 to 0.26.3. - [Release notes](https://github.com/containers/common/releases) - [Commits](containers/common@v0.26.0...v0.26.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #8164 from Luap99/journal-eventsOpenShift Merge Robot2020-10-27
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Improve the journal event reading
| * | | | | Improve the journal event readingPaul Holzinger2020-10-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the AddMatch/SeekTail conflict. This prevents reading unnecessary journal entries which could cause errors. Also wrap the sdjournal errors to provide better error messages. Fixes #8125 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | | Merge pull request #8151 from vrothberg/fix-8148OpenShift Merge Robot2020-10-27
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | image list: check for all errors
| * | | | | image list: check for all errorsValentin Rothberg2020-10-27
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For unknown historical reasons, some errors were ignored when listing images. I assume that the basic assumption was that if we can properly list images, we can also successfully compute their sizes which turned out to be wrong. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #8094 from rhatdan/cidfileOpenShift Merge Robot2020-10-27
|\ \ \ \ \ | |/ / / / |/| | | | The cidfile should be created when the container is created
| * | | | The cidfile should be created when the container is createdDaniel J Walsh2020-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently if you run an interactive session of podman run and specifiy the --cidfile option, the cidfile will not get created until the container finishes running. If you run a detached container, it will get created right away. This Patch creates the cidfile as soon as the container is created. This could allow other tools to use the cidefile on all running containers. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #8149 from edsantiago/batsOpenShift Merge Robot2020-10-27
|\ \ \ \ \ | | | | | | | | | | | | System tests: cleanup, make more robust
| * | | | | System tests: cleanup, make more robustEd Santiago2020-10-26
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - run test: preserve --runtime test: use a random executable path. And, clean up better. - run test: "look up correct image name" test: use random strings; test both without and with a :tag - events test: use random label strings, add more filter tests Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #8144 from vrothberg/auto-updateOpenShift Merge Robot2020-10-27
|\ \ \ \ \ | | | | | | | | | | | | auto update: mark it as non-experimental
| * | | | | auto update: mark it as non-experimentalValentin Rothberg2020-10-26
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Auto updates have inititally been marked as experimental which allowed us to receive initital feedback from the community. More than half a year has passed and we are now confident to mark `podman-auto-update` as stable. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #8155 from edsantiago/pr_title_againOpenShift Merge Robot2020-10-27
|\ \ \ \ \ | |_|/ / / |/| | | | Yet another iteration on PR title plugin
| * | | | Yet another iteration on PR title pluginEd Santiago2020-10-26
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR #8147 made things worse: it's not valid YAML. This at least is valid YAML. I have no idea if it yields the desired result, and we won't even know until it gets merged, but at least it won't cause fatal syntax errors. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #8147 from vrothberg/fix-pr-title-actionOpenShift Merge Robot2020-10-26
|\ \ \ \ | | | | | | | | | | pr update action: fix errors on master branch
| * | | | pr update action: fix errors on master branchValentin Rothberg2020-10-26
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The action fails on the master branch as the regex does not match. The error in this scenario is unfortunate and not of much value as we do not want to change PR titles on the master branch. To fix it, entirely disable the action on the master branch which in restrospective may be a better approach as we do not fire off the action. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #8138 from vrothberg/main-pr-title-update-actionOpenShift Merge Robot2020-10-26
|\ \ \ \ | | | | | | | | | | add GitHub action to add non-main branch to PR title
| * | | | add GitHub action to add non-main branch to PR titleValentin Rothberg2020-10-25
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a GitHub action to add the name of the target branch as prefix to the title of a pull request. It is easy to miss the target of a given pull request which has already caused issues of commits going into non-main branches without intention. We have already used this action on the `v2.0.5-rhel` branch with limited success. Fortunately, the upstream implemented our feature request to support adding the _target_ branch name (rather than the source) to the PR title, which is what we need. Any non-main branch from this commit forward will now be clearly marked. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #8059 from ↵OpenShift Merge Robot2020-10-26
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/spf13/cobra-1.1.1 Bump github.com/spf13/cobra from 1.1.0 to 1.1.1
| * | | Bump github.com/spf13/cobra from 1.1.0 to 1.1.1dependabot-preview[bot]2020-10-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](https://github.com/spf13/cobra/compare/v1.1.0...v1.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8119 from matejvasek/cp-extract-flag-fixOpenShift Merge Robot2020-10-26
|\ \ \ \ | |_|_|/ |/| | | fix: respect "--extract" flag for podman cp
| * | | fix: podman-cp respects "--extract" flagMatej Vasek2020-10-25
|/ / / | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #8096 from ypu/log-driver-testOpenShift Merge Robot2020-10-25
|\ \ \ | |_|/ |/| | Tests: Check different log driver can work with podman logs
| * | Tests: Check different log driver can work with podman logsYiqiao Pu2020-10-22
| | | | | | | | | | | | | | | | | | | | | | | | Add a check step in podman run --log-driver test. Prefer to add it here as it already has a loop to cover all different drivers in this test. Signed-off-by: Yiqiao Pu <ypu@redhat.com>
* | | Merge pull request #8116 from ↵OpenShift Merge Robot2020-10-24
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/buildah-1.16.5 Bump github.com/containers/buildah from 1.16.4 to 1.16.5
| * | | Bump github.com/containers/buildah from 1.16.4 to 1.16.5dependabot-preview[bot]2020-10-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/buildah](https://github.com/containers/buildah) from 1.16.4 to 1.16.5. - [Release notes](https://github.com/containers/buildah/releases) - [Changelog](https://github.com/containers/buildah/blob/master/CHANGELOG.md) - [Commits](https://github.com/containers/buildah/compare/v1.16.4...v1.16.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8103 from baude/eventlabelsOpenShift Merge Robot2020-10-23
|\ \ \ \ | |_|_|/ |/| | | filter events by labels
| * | | filter events by labelsbaude2020-10-23
|/ / / | | | | | | | | | | | | | | | adding the ability to filter evens by the container labels. this requires that container labels be added to the events data being recorded and subsequently read. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #8109 from matejvasek/inspect-apiv2-rootfsOpenShift Merge Robot2020-10-23
|\ \ \ | |/ / |/| | fix: /image/{name or id}/json returns RootFS layers
| * | src: nil checkMatej Vasek2020-10-22
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | src: add nil checksMatej Vasek2020-10-22
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * | fix: /image/{name}/json returns RootFS layersMatej Vasek2020-10-22
| | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #8111 from Luap99/fix-missing-resolv.confOpenShift Merge Robot2020-10-22
|\ \ \ | | | | | | | | Don't error if resolv.conf does not exists
| * | | Don't error if resolv.conf does not existsPaul Holzinger2020-10-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the resolv.conf file is empty we provide default dns servers. If the file does not exists we error and don't create the container. We should also provide the default entries in this case. This is also what docker does. Fixes #8089 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #8053 from rhatdan/detachkeysOpenShift Merge Robot2020-10-22
|\ \ \ \ | | | | | | | | | | podman create doesn't support creating detached containers
| * | | | podman create doesn't support creating detached containersDaniel J Walsh2020-10-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Detached containers and detach keys are only created with the podman run, i exec, and start commands. We do not store the detach key sequence or the detach flags in the database, nor does Docker. The current code was ignoreing these fields but documenting that they can be used. Fix podman create man page and --help output to no longer indicate that --detach and --detach-keys works. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #8110 from lsm5/cap-net-rawOpenShift Merge Robot2020-10-22
|\ \ \ \ \ | | | | | | | | | | | | replace net_raw with setuid
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-18 12:43:04 +0000