summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #10610 from cdoern/healthCheckOpenShift Merge Robot2021-06-23
|\ | | | | Edited compat handling code for containers/json status and added python tests
| * Health Check is not handled in the compat LibpodToContainerJSONcdoern2021-06-23
| | | | | | | | | | | | | | | | Added parsing and handling for the healthCheck status within containers.go. Also modified tests fixes #10457 Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | Merge pull request #10696 from cdoern/libpodStatsOpenShift Merge Robot2021-06-23
|\ \ | | | | | | Podman Stats additional features
| * | Podman Stats additional featurescdoern2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | added Avg Cpu calculation and CPU up time to podman stats. Adding different feature sets in different PRs, CPU first. resolves #9258 Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | Merge pull request #10676 from Procyhon/13062021_manpageOpenShift Merge Robot2021-06-23
|\ \ \ | | | | | | | | [CI:DOCS] UPDATE manpages with MANPAGE_SYNTAX
| * | | [CI:DOCS] UPDATE manpages with MANPAGE_SYNTAXAlexander Richter2021-06-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MANPAGE_SYNTAX was edited. The following manpages have been adapted to the MANPAGE_SYNTAX: - podman-container-prune - podman-container-restore The following manpages have had little changes: - podman-attach - podman-auto-update - podman-commit - podman-completion - podman-container-checkpoint - podman-container-cleanup - podman-container-exists Signed-off-by: Alexander Richter <67486332+Procyhon@users.noreply.github.com>
* | | | Merge pull request #10739 from vrothberg/fix-10682OpenShift Merge Robot2021-06-23
|\ \ \ \ | | | | | | | | | | create: support images with invalid platform
| * | | | create: support images with invalid platformValentin Rothberg2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Much to my regret, there is a number of images in the wild with invalid platforms breaking the platform checks in libimage that want to make sure that a local image is matching the expected platform. Imagine a `podman run --arch=arm64 fedora` with a local amd64 fedora image. We really shouldn't use the local one in this case and pull down the arm64 one. The strict platform checks in libimage in combination with invalid platforms in images surfaced in Podman being able to pull an image but failing to look it up in subsequent presence checks. A `podman run` would hence pull such an image but fail to create the container. Support images with invalid platforms by vendoring the latest HEAD from containers/common. Also remove the partially implemented pull-policy logic from Podman and let libimage handle that entirely. However, whenever --arch, --os or --platform are specified, the pull policy will be forced to "newer". This way, we pessimistically assume that the local image has an invalid platform and we reach out to the registry. If there's a newer image (i.e., one with a different digest), we'll pull it down. Please note that most of the logic has either already been implemented in libimage or been moved down which allows for removing some clutter from Podman. [NO TESTS NEEDED] since c/common has new tests. Podman can rely on the existing tests. Fixes: #10648 Fixes: #10682 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #10759 from dilyanpalauzov/masterDaniel J Walsh2021-06-23
|\ \ \ \ \ | | | | | | | | | | | | markdown/*: typos 'a image'
| * | | | | markdown/*: typos 'a image'Дилян Палаузов2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Insisting on “DCO” imposes formalities, that serve self-purpose. One cannot assume that the submitter has time or will to read texts about symbolism in software contributions. If the system wants to see the text nrEAUIEUAIe eanuitdnuae EAIUEAUIAIE »ℓ§444.3.72b)°»°ℓ§euaieauuae in each commit, people will write this, or any other text, that the system wants to see. All such text, which presence is mandated by the system, has the same value. Signed-off-by: Дилян Палаузов <git-dpa@aegee.org>
* | | | | | Merge pull request #10752 from vrothberg/fix-10730OpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] push/pull docs: clarify supported transports
| * | | | | | [CI:DOCS] push/pull docs: clarify supported transportsValentin Rothberg2021-06-23
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The man pages of podman push/pull were incomplete in explaining all supported transports. To keep things simple, explain the defaults, refer to containers-transports(5) and give some examples. Fixes: #10730 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #10758 from vrothberg/unflakeOpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | disable tty-size exec checks in system tests
| * | | | | disable tty-size exec checks in system testsValentin Rothberg2021-06-23
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in #10710, the additional checks for podman-exec added by commit 666f555aa52b are extremely flaky and appear in nearly every PR I have see this week. Let's temporarily disable the checks and reenable them on #10710 is fixed. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #10754 from Luap99/sync-lockOpenShift Merge Robot2021-06-23
|\ \ \ \ \ | |/ / / / |/| | | | getContainerNetworkInfo: lock netNsCtr before sync
| * | | | getContainerNetworkInfo: lock netNsCtr before syncPaul Holzinger2021-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `syncContainer()` requires the container to be locked, otherwise we can end up with undefined behavior. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #10741 from Luap99/test-ocicniOpenShift Merge Robot2021-06-22
|\ \ \ \ \ | | | | | | | | | | | | Do not use inotify for OCICNI
| * | | | | Do not use inotify for OCICNIPaul Holzinger2021-06-22
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Podman does not need to watch the cni config directory. If a network is not found in the cache, OCICNI will reload the networks anyway and thus even podman system service should work as expected. Also include a change to not mount a "new" /var by default in the rootless cni ns, instead try to use /var/lib/cni first and then the parent dir. This allows users to store cni configs under /var/... which is the case for the CI compose test. [NO TESTS NEEDED] Fixes #10686 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #10697 from kwshi/rmi-dangling-parent-docsOpenShift Merge Robot2021-06-22
|\ \ \ \ \ | |/ / / / |/| | | | [CI:DOCS] docs: specify `rmi` removes dangling parents
| * | | | docs: podman-rmi removes dangling parent imagesKye Shi2021-06-21
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Kye Shi <shi.kye@gmail.com>
* | | | | Merge pull request #10719 from ↵OpenShift Merge Robot2021-06-22
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | containers/dependabot/go_modules/k8s.io/api-0.21.2 Bump k8s.io/api from 0.21.1 to 0.21.2
| * | | | Bump k8s.io/api from 0.21.1 to 0.21.2dependabot[bot]2021-06-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #10742 from vrothberg/fix-10675OpenShift Merge Robot2021-06-21
|\ \ \ \ \ | | | | | | | | | | | | logs: k8s-file: restore poll sleep
| * | | | | logs: k8s-file: restore poll sleepValentin Rothberg2021-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 84b55eec2796 attempted to fix a race waiting for the container died event. Previously, Podman slept for duration of the polling frequence which I considerred to be a mistake. As it turns out, I was mistaken since the file logger will, in fact, NOT read until EOF and then stop logging but stop logging immediately _after_ it woke up. [NO TESTS NEEDED] as the race condition cannot be hit reliably. Fixes: #10675 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | | logs: k8s-file: fix spurious error logsValentin Rothberg2021-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the suprious "Error: nil" messages. Also add some more context to logged error messages which makes error sources more obvious. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #10734 from mgoltzsche/fix-dns-detectionOpenShift Merge Robot2021-06-21
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix systemd-resolved detection.
| * | | | | Fix systemd-resolved detection.Max Goltzsche2021-06-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously podman failed when run in an environment where 127.0.0.53 is the only nameserver but systemd-resolved is not used directly. In practice this happened when podman was run within an alpine container that used the host's network and the host was running systemd-resolved. This fix makes podman ignore a file not found error when reading /run/systemd/resolve/resolv.conf. Closes #10733 [NO TESTS NEEDED] Signed-off-by: Max Goltzsche <max.goltzsche@gmail.com>
* | | | | | Merge pull request #10723 from rhatdan/tmpdirOpenShift Merge Robot2021-06-21
|\ \ \ \ \ \ | | | | | | | | | | | | | | fix systemcontext to use correct TMPDIR
| * | | | | | fix systemcontext to use correct TMPDIRDaniel J Walsh2021-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Users are complaining about read/only /var/tmp failing even if TMPDIR=/tmp is set. This PR Fixes: https://github.com/containers/podman/issues/10698 [NO TESTS NEEDED] No way to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | | Merge pull request #10068 from flouthoc/masterOpenShift Merge Robot2021-06-20
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [CI:DOCS] Add support for `podman login --verbose`
| * | | | | | | Add support for podman login --verboseflouthoc2021-06-19
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | Signed-off-by: flouthoc <flouthoc.git@gmail.com>
* | | | | | | Merge pull request #10718 from ↵OpenShift Merge Robot2021-06-20
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.32.3 Bump github.com/containers/storage from 1.32.2 to 1.32.3
| * | | | | | Bump github.com/containers/storage from 1.32.2 to 1.32.3dependabot[bot]2021-06-18
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.32.2 to 1.32.3. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.32.2...v1.32.3) --- updated-dependencies: - dependency-name: github.com/containers/storage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | | Merge pull request #10721 from ↵OpenShift Merge Robot2021-06-20
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | | | | | | | | | | | | | containers/dependabot/go_modules/k8s.io/apimachinery-0.21.2 Bump k8s.io/apimachinery from 0.21.1 to 0.21.2
| * | | | | Bump k8s.io/apimachinery from 0.21.1 to 0.21.2dependabot[bot]2021-06-18
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.21.1 to 0.21.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.21.1...v0.21.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #10727 from mheon/add_run_uid_to_tmpfilesOpenShift Merge Robot2021-06-19
|\ \ \ \ \ | |/ / / / |/| | | | [CI:DOCS] Add an entry for `/run/user-$UID/libpod` to tmpfiles
| * | | | Add an entry for `/run/user-$UID/libpod` to tmpfilesMatthew Heon2021-06-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The systemd-tmpfiles configuration is meant preserve important paths in /tmp that are used by Podman against deletion by systemd. However, not all paths we previously used were included. Some older versions used the `/tmp/use-$UID/libpod` directory instead (when `/run/user/$UID` was unavailable). Add an entry for these old paths to ensure tmpfiles treats the directory correctly. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1960948 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #10690 from rhatdan/VENDOROpenShift Merge Robot2021-06-18
|\ \ \ \ \ | | | | | | | | | | | | Vendor in containers/common v0.40.0
| * | | | | Vendor in containers/common v0.40.0Daniel J Walsh2021-06-17
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #10711 from mtrmac/format-docsOpenShift Merge Robot2021-06-17
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix documentation of the --format option of podman push
| * | | | | Fix documentation of the --format option of podman pushMiloslav Trmač2021-06-17
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It affects all transports; and without --format, we try several manifest formats. [NO TESTS NEEDED] Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | | | | Merge pull request #10688 from jwhonce/bz/1855983OpenShift Merge Robot2021-06-17
|\ \ \ \ \ | | | | | | | | | | | | Scrub podman commands to use report package
| * | | | | Scrub podman commands to use report packageJhon Honce2021-06-16
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor podman commands that have drifted from using c/common report pkg. Report pkg is needed to implement go template functions. Removed obsolete code from podman which exists in c/common. Latest template library added default newlines and method to remove them. Incorporated needed changes in c/common PR below. Depends on https://github.com/containers/common/pull/624 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1855983 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #10692 from cevich/fix_clone_failOpenShift Merge Robot2021-06-16
|\ \ \ \ \ | |/ / / / |/| | | | [CI:DOCS] Fix multi-arch image build clone:failure
| * | | | Fix multi-arch image build clone:failureChris Evich2021-06-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A suspected recent change in docker (in github-actions Ubuntu environment) results in a error: ``` cannot clone: Operation not permitted Error: cannot re-exec process ``` Fix this by using podman to execute the container instead of docker. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #10699 from cevich/track_temp_double_tags2OpenShift Merge Robot2021-06-16
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Cirrus: Prevent BZ1965743 workaround pruning
| * | | | | Cirrus: Prevent BZ1965743 workaround pruningChris Evich2021-06-16
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A hidden non-obvious corner-case of temporary changes introduced by https://github.com/containers/podman/pull/10451 could be unintended pruning of some ubuntu images. This could be impactful if for some reason the `.cirrus.yml: use c5521575421149184 for Ubuntu` commit is reverted beyond 30-days (the disused image-prune interval) and the _old_ images are needed (for an unforeseen reason). Mitigate this by temporarily including the old images in the timestamp updating task. This commit may be reverted (and the problem ignored) if new VM images are built and deployed for all OS's (i.e. replacing the Fedora/Ubuntu tag split workaround needed for the BZ). Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #10683 from Luap99/exec-resizeOpenShift Merge Robot2021-06-16
|\ \ \ \ \ | |/ / / / |/| | | | Fix resize race with podman exec -it
| * | | | Fix resize race with podman exec -itPaul Holzinger2021-06-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When starting a process with `podman exec -it` the terminal is resized after the process is started. To fix this allow exec start to accept the terminal height and width as parameter and let it resize right before the process is started. Fixes #10560 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #10451 from giuseppe/test-ENOSYSOpenShift Merge Robot2021-06-16
|\ \ \ \ \ | | | | | | | | | | | | tests: update CI images