summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #11468 from Luap99/play-kube-slirpOpenShift Merge Robot2021-09-08
|\ | | | | fix play kube --network options
| * fix play kube --network optionsPaul Holzinger2021-09-08
| | | | | | | | | | | | | | | | | | | | | | | | Commit 092902b45555 introduced advanced network options for podman play kube. However this never worked because it unconditionally set the network mode to bridge after it parsed the network option. Added a test to ensure the correct mode is set. Truly fixes #10807 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #11477 from raoulbhatia/fix-testvol-errorOpenShift Merge Robot2021-09-08
|\ \ | | | | | | test/testvol/main.go: Fix missing arguments to Errorf()
| * | test/testvol/main.go: Fix missing arguments to Errorf()Raoul Bhatia2021-09-08
|/ / | | | | | | | | | | | | | | | | | | | | | | go test -v -p 1 -tags apparmor,ostree,seccomp,selinux,systemd github.com/containers/podman/v2/test/testvol results in the following error: > test/testvol/main.go:227:10: Errorf format %s reads arg #1, but call has 0 args > test/testvol/main.go:233:10: Errorf format %s reads arg #1, but call has 0 args This patch passes req.Name as an argument to the Errorf() call Signed-off-by: Raoul Bhatia <raoul.bhatia@radarcs.com>
* | Merge pull request #11453 from jonpspri/qemu-apple-silicon-bios-fdOpenShift Merge Robot2021-09-08
|\ \ | | | | | | QEMU Apple Silicon: Find BIOS FD wherever
| * | QEMU Apple Silicon: Find BIOS FD whereverJonathan Springer2021-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QEmu normally install BIOS images under `/usr/local` prefix, but Homebrew installs them under `/opt/homebrew`. This change searches both locations and then puts back to an unpathed name if it doesn't find the BIOS. (I imitated other architectures' implemenations in that failback behavior.) [NO TESTS NEEDED] Signed-off-by: Jonathan Springer <jonpspri@gmail.com>
* | | Merge pull request #11471 from mheon/checkpointedOpenShift Merge Robot2021-09-08
|\ \ \ | | | | | | | | Add Checkpointed bool to Inspect
| * | | Add Checkpointed bool to InspectMatthew Heon2021-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When inspecting a container, we now report whether the container was stopped by a `podman checkpoint` operation via a new bool in the State portion of inspected, `Checkpointed`. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #11473 from nalind/build-context-as-rootOpenShift Merge Robot2021-09-08
|\ \ \ \ | |/ / / |/| | | pkg/bindings/images.nTar(): set ownership of build context to 0:0
| * | | pkg/bindings/images.nTar(): set ownership of build context to 0:0Nalin Dahyabhai2021-09-07
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When attempting to run remote builds, users with UID/GID values that were high enough that they wouldn't be mapped into their default user namespace configurations would see their builds fail when the server attempted to extract the build contexts that they supplied, and failed to set ownership of the build context content to the UID/GID that were originally assigned to them. When archiving the build context at the client, set ownership of everything to 0:0, which we know is always mapped. Both ADD and COPY require that we set the ownership of newly-added content to 0:0 (unless the --chown flag is used), so throwing away the original ownership information doesn't hurt, anyway. As usual, tarballs that we extract as part of ADD aren't going to be affected. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | Merge pull request #11431 from jmguzik/secrets-ls-filtersOpenShift Merge Robot2021-09-07
|\ \ \ | | | | | | | | Add filtering functionality to http api secrets list
| * | | Add filtering functionality to http api secrets listJakub Guzik2021-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Filtering is missing in both compat API and libpod API, while docker has filtering functinality. This commit enables filtering option using name and id in both libpod and http API. Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | | Merge pull request #11467 from jesperpedersen/changelogOpenShift Merge Robot2021-09-07
|\ \ \ \ | | | | | | | | | | Remove changelog.txt from the repository
| * | | | Remove changelog.txt from the repositoryjesperpedersen2021-09-07
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The changelog.txt file hasn't been kept in sync with release tags, especially on main, so remove it. The release notes will be featured in RELEASE_NOTES.md. Signed-off-by: jesperpedersen <jesper.pedersen@redhat.com> [NO TESTS NEEDED]
* | | | Merge pull request #11437 from MichaelAnckaert/fix-11418OpenShift Merge Robot2021-09-07
|\ \ \ \ | | | | | | | | | | [NO TESTS NEEDED] Fix #11418 - Default TMPDIR to /tmp on OS X
| * | | | Fix #11418 - Default TMPDIR to /tmp on OS XMichael Anckaert2021-09-04
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Michael Anckaert <michael.anckaert@sinax.be>
* | | | | Merge pull request #11427 from flouthoc/kube-pod-logsOpenShift Merge Robot2021-09-07
|\ \ \ \ \ | | | | | | | | | | | | kube: Add support for `podman pod logs`.
| * | | | | kube: Add support for podman pod logsAditya Rajan2021-09-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Following PR adds support for `kubectl` like `pod logs` to podman. Usage `podman pod logs <podIDorName` gives a stream of logs for all the containers within the pod with **containername** as a field. Just like **`kubectl`** also supports `podman pod logs -c ctrIDorName podIDorName` to limit the log stream to any of the specificied container which belongs to pod. Signed-off-by: Aditya Rajan <arajan@redhat.com>
* | | | | | Merge pull request #11434 from coypoop/patch1OpenShift Merge Robot2021-09-07
|\ \ \ \ \ \ | | | | | | | | | | | | | | Spell "build linux darwin" as "build !windows".
| * | | | | | Spell "build linux darwin" as "build !windows".Maya Rashish2021-09-03
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Equivalent for supported platforms, and makes it easier to support additional unix-like OSes. [NO TESTS NEEDED] Signed-off-by: Maya Rashish <maya@NetBSD.org>
* | | | | | Merge pull request #11466 from jelly/doc_api_restartOpenShift Merge Robot2021-09-07
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | [CI:DOCS] Document default timeout for libpod API Container Restart
| * | | | | Document default timeout for libpod API Container RestartJelle van der Waa2021-09-07
| | |_|_|/ | |/| | | | | | | | | | | | | Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | | | | Merge pull request #11459 from vrothberg/fix-11438OpenShift Merge Robot2021-09-07
|\ \ \ \ \ | |/ / / / |/| | | | generate systemd: handle --restart
| * | | | generate systemd: handle --restartValentin Rothberg2021-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Handle custom restart policies of containers when generating the unit files; those should be set on the unit level and removed from ExecStart flags. Fixes: #11438 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #11464 from vrothberg/fix-11461OpenShift Merge Robot2021-09-07
|\ \ \ \ \ | | | | | | | | | | | | logs -f: file: fix dead lock
| * | | | | logs -f: file: fix dead lockValentin Rothberg2021-09-07
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a dead lock in the file log driver where one goroutine would wait on the tail to hit EOF but reading is blocked for the function to return. Fixes: 11461 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #11402 from Luap99/macvlan-docOpenShift Merge Robot2021-09-07
|\ \ \ \ \ | | | | | | | | | | | | network create: add warning for deprecated macvlan flag
| * | | | | network create: add warning for deprecated macvlan flagPaul Holzinger2021-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The macvlan driver is not deprecated, only the --macvlan flag is. Remove the flag from the man page since it is deprecated and add a warning to podman network create if it is used. [NO TESTS NEEDED] Fixes #11400 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | | Merge pull request #11442 from scottschreckengaust/mainOpenShift Merge Robot2021-09-07
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Adding `-cpu host` for qemu for MacOS
| * | | | | Fix warning of unsupported feature on MacOSScott Schreckengaust2021-09-06
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding the `-cpu host` option to the `addArchOptions` function for darwin removes the warning message, "host doesn't support requested feature: CPUID.80000001H:ECX.svm [bit 2]" by qemu-system-x86_64 when using the `podman machine start` command on MacOS Closes #11421 [NO TESTS NEEDED] Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
* | | | | Merge pull request #11463 from flouthoc/cgroup-info-fix-panicOpenShift Merge Robot2021-09-07
|\ \ \ \ \ | | | | | | | | | | | | cgroup-info: check if user.slice is valid before accessing value
| * | | | | cgroup-info: check if user.slice is valid before accessing valueAditya Rajan2021-09-07
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Prevent hitting `panic: runtime error: index out of range [1] with length 1` while performing `podman info` when unexpected values for user.slice is found. [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
* | | | | Merge pull request #11451 from jonpspri/qemu-apple-silicon-hvf-tcgOpenShift Merge Robot2021-09-06
|\ \ \ \ \ | | | | | | | | | | | | Qemu TCG Accel fallback for Apple Silicon. Iss #10577
| * | | | | TCG Accel fallback for Apple Silicon. Iss #10577Jonathan Springer2021-09-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cause qemu to fall back to using TCG acceleration when HVP acceleration is not available on Darwin Aarch64. Qemu prints a warning which it is desirable to leave to embarrass the upstream Qemu into approving the HVF patches. [NO TESTS NEEDED] Signed-off-by: Jonathan Springer <jspringer@us.ibm.com> Signed-off-by: Jonathan Springer <jonpspri@gmail.com>
* | | | | | Merge pull request #11432 from Utopiah/patch-1OpenShift Merge Robot2021-09-05
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Example says there is not IP then in the next command suggests to use it
| * | | | | | Example says there is not IP then in the next command suggests to use itFabien Benetou2021-09-05
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | Signed-off-by: Utopiah <fabien-services@benetou.fr>
* | | | | | Merge pull request #11445 from 1995parham/mainOpenShift Merge Robot2021-09-05
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add localhost into hosts based on network mode
| * | | | | feat: add localhost into hosts if the networking mode is not hostParham Alvani2021-09-04
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Parham Alvani <1995parham@tuta.io>
* | | | | Merge pull request #11441 from jesperpedersen/readmeOpenShift Merge Robot2021-09-05
|\ \ \ \ \ | | | | | | | | | | | | Bump release to 3.3.1
| * | | | | Bump release to 3.3.1jesperpedersen2021-09-04
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: jesperpedersen <jesper.pedersen@redhat.com> [NO TESTS NEEDED]
* | | | | Merge pull request #11439 from coypoop/libvirt-unusedOpenShift Merge Robot2021-09-04
|\ \ \ \ \ | |/ / / / |/| | | | Remove unused stubs intended to start a machine with libvirt
| * | | | Remove unused stubs intended to start a machine with libvirtMaya Rashish2021-09-03
| | |_|/ | |/| | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: Maya Rashish <maya@NetBSD.org>
* | | | Merge pull request #11428 from guillaumerose/missingcheckOpenShift Merge Robot2021-09-03
|\ \ \ \ | | | | | | | | | | machine: always check error of net.Dial, even after last try
| * | | | machine: always check error of net.Dial, even after last tryGuillaume Rose2021-09-03
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When net.Dial always fail in the above loop, the code following the loop is executed. This error check prevents this. [NO TESTS NEEDED] Signed-off-by: Guillaume Rose <gurose@redhat.com>
* | | | Merge pull request #11414 from edsantiago/batsOpenShift Merge Robot2021-09-03
|\ \ \ \ | |/ / / |/| | | auto-update systemd test: skip on RHEL
| * | | auto-update systemd test: skip on RHELEd Santiago2021-09-02
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "auto-update using systemd" test is failing on RHEL rootless. Reason: it uses journalctl, which does not work on RHEL rootless. Solution: add skip_if_journald_unavailable. ALSO: add debugging info to test failure. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #11410 from jesperpedersen/issue11408OpenShift Merge Robot2021-09-02
|\ \ \ | |/ / |/| | [#11408] podman help machine init
| * | [#11408] podman help machine initjesperpedersen2021-09-02
| | | | | | | | | | | | | | | | | | Signed-off-by: jesperpedersen <jesper.pedersen@redhat.com> [NO TESTS NEEDED]
* | | Merge pull request #11406 from flouthoc/manifest-rm-only-manifestOpenShift Merge Robot2021-09-02
|\ \ \ | | | | | | | | manifest: `rm` should not remove referenced images.
| * | | manifest: rm should not remove referenced images.Aditya Rajan2021-09-02
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Following PR makes sure that `podman manifest rm <list>` only removes the named manifest list and not referenced images. Bumping and squashing c/common to v0.43.3-0.20210902095222-a7acc160fb25 in same commit in order to make sure build commit test passes. Signed-off-by: Aditya Rajan <arajan@redhat.com>