summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* README: update "out of scope" sectionValentin Rothberg2019-02-25
| | | | | | | Also mention that Podman does/will not support `docker-compose`. Fixes: https://github.com/containers/libpod/issues/746#issuecomment-467011211 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #2419 from rhatdan/playOpenShift Merge Robot2019-02-24
|\ | | | | Fix play to show up in podman help
| * Fix play to show up in podman helpDaniel J Walsh2019-02-23
| | | | | | | | | | | | Also change generate cli calls to match other commands. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2416 from rhatdan/networkOpenShift Merge Robot2019-02-24
|\ \ | | | | | | Allow dns settings with --net=host
| * | Allow dns settings with --net=hostDaniel J Walsh2019-02-23
| |/ | | | | | | | | | | | | | | This seems to be a needless restriction. We make a copy of the hosts /etc/resolv.conf file, so these changes to not modify the host. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2413 from baude/remotepodstopOpenShift Merge Robot2019-02-24
|\ \ | | | | | | Enable more podman-remote pod commands
| * | Enable more podman-remote pod commandsbaude2019-02-22
| | | | | | | | | | | | | | | | | | enable pod start, stop, and kill subcommands for the remote-client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2400 from rhatdan/pullOpenShift Merge Robot2019-02-23
|\ \ \ | | | | | | | | Switch defaults for podman build versus buildah
| * | | Switch defaults for podman build versus buildahDaniel J Walsh2019-02-23
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Switch defaults for --layers, --force-rm and --pull-always from buildah to podman. Only override default values. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2404 from baude/remoteerrorsOpenShift Merge Robot2019-02-23
|\ \ \ | |/ / |/| | make remote-client error messaging more robust
| * | make remote-client error messaging more robustbaude2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | the remote-client is currently weak for carrying error messages over the varlink interface and displaying something useful to users and developers for the purposes of debug. this is a starting point to improve that user experience. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2393 from giuseppe/reexec-into-same-wdOpenShift Merge Robot2019-02-23
|\ \ \ | | | | | | | | rootless: force same cwd when re-execing
| * | | tests, rootless: use relative path for export testGiuseppe Scrivano2019-02-22
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | rootless: force same cwd when re-execingGiuseppe Scrivano2019-02-22
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | when joining an existing namespace, we were not maintaining the current working directory, causing commands like export -o to fail when they weren't referring to absolute paths. Closes: https://github.com/containers/libpod/issues/2381 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2401 from TomSweeneyRedHat/dev/tsweeney/buildah1.7OpenShift Merge Robot2019-02-22
|\ \ \ | |/ / |/| | Vendor Buildah v1.7
| * | Vendor Buildah v1.7TomSweeneyRedHat2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Vendors in Buildah 1.7 into Podman. Also the latest imagebuilder and changes for `build --target` Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2406 from rhatdan/errorsOpenShift Merge Robot2019-02-22
|\ \ \ | | | | | | | | Exit with errors not just logging error
| * | | Exit with errors not just logging errorDaniel J Walsh2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Several commands were logging errors but exiting with a 0 exit code. This patch cleans these up. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #2410 from giuseppe/cp-rootless-supportOpenShift Merge Robot2019-02-22
|\ \ \ \ | |_|/ / |/| | | cmd: support rootless mode for cp command
| * | | cmd: support rootless mode for cp commandGiuseppe Scrivano2019-02-22
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #2403 from giuseppe/fix-runtimeOpenShift Merge Robot2019-02-22
|\ \ \ \ | |_|/ / |/| | | podman: --runtime has higher priority on runtime_path
| * | | podman: --runtime has higher priority on runtime_pathGiuseppe Scrivano2019-02-22
| | |/ | |/| | | | | | | | | | | | | | | | if --runtime is specified, then it has higher priority on the runtime_path option, which was added for backward compatibility. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2386 from baude/cobravalidationOpenShift Merge Robot2019-02-22
|\ \ \ | |_|/ |/| | Improve command line validation
| * | hide --latest on the remote-clientbaude2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | in the case of the remote-client, it was decided to hide the latest flag to avoid confusion for end-users on what the "last" container, volume, or pod are. Signed-off-by: baude <bbaude@redhat.com>
| * | Improve command line validationbaude2019-02-22
| |/ | | | | | | | | | | | | Use the checkallandlatest function to validate flag usage as part of the cobra command args validation. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2402 from baude/remotepodinspectOpenShift Merge Robot2019-02-22
|\ \ | |/ |/| podman-remote pod inspect|exists
| * podman-remote pod inspect|existsbaude2019-02-22
| | | | | | | | | | | | | | | | enable the remote client to be able to inspect a pod. also, bonus of enabling the podman pod exists command which returns a 0 or 1 depending on whether the given pod exists. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2411 from cevich/ubuntu_go111Daniel J Walsh2019-02-22
|\ \ | | | | | | Cirrus: Install Go 1.11 on Ubuntu VMs
| * | Cirrus: Install Go 1.11 on Ubuntu VMsChris Evich2019-02-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no native package for this, so the packaged version must also be installed, otherwise all the support/dependencies would be removed also (like go-md2man). Fix this by installing from the google released tarball, into /usr/local/go and set $GOROOT to point there. Also, include a small fix for hack/get_ci_vm.sh not installing testing dependencies because of an old assumption. ***CIRRUS: REBUILD IMAGES*** Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Add 20m extra timeout for UbuntuChris Evich2019-02-22
|/ / | | | | | | | | | | | | Tests running slower than normally-slow, bump timeout to allow them to pass until better solution (for slow Ubuntu tests) can be found. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #2389 from baude/issue2388OpenShift Merge Robot2019-02-22
|\ \ | | | | | | add newline to images output
| * \ Merge pull request #4 from edsantiago/pr2389_updateBrent Baude2019-02-21
| |\ \ | | | | | | | | update: remove duplicate newline
| | * | update: remove duplicate newlineEd Santiago2019-02-21
| |/ / | | | | | | | | | Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | add newline to images outputbaude2019-02-20
| | | | | | | | | | | | | | | | | | | | | | | | ensure a final newline is always added to images output. fixes #2388 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2350 from mheon/lock_renumberOpenShift Merge Robot2019-02-21
|\ \ \ | |_|/ |/| | Add lock renumbering
| * | Fix typo in commentMatthew Heon2019-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Do not make renumber shut down the runtimeMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The original intent behind the requirement was to ensure that, if two SHM lock structs were open at the same time, we should not make such a runtime available to the user, and should clean it up instead. It turns out that we don't even need to open a second SHM lock struct - if we get an error mapping the first one due to a lock count mismatch, we can just delete it, and it cleans itself up when it errors. So there's no reason not to return a valid runtime. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add podman system renumber commandMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | This command allows for renumbering Podman locks after an upgrade to Podman with SHM locks from a 1.0 or earlier branch, or after the number of locks was changed. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add ability to get a runtime that renumbersMatthew Heon2019-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Recreate SHM locks when renumbering on count mismatchMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we're renumbering locks, we're destroying all existing allocations anyways, so destroying the old lock struct is not a particularly big deal. Existing long-lived libpod instances will continue to use the old locks, but that will be solved in a followon. Also, solve an issue with returning error values in the C code. There were a few places where we return ERRNO where it was not set, so make them return actual error codes). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Move RenumberLocks into runtime initMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can't do renumbering after init - we need to open a potentially invalid locks file (too many/too few locks), and then potentially delete the old locks and make new ones. We need to be in init to bypass the checks that would otherwise make this impossible. This leaves us with two choices: make RenumberLocks a separate entrypoint from NewRuntime, duplicating a lot of configuration load code (we need to know where the locks live, how many there are, etc) - or modify NewRuntime to allow renumbering during it. Previous experience says the first is not really a viable option and produces massive code bloat, so the second it is. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Remove locks from volumesMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was looking into why we have locks in volumes, and I'm fairly convinced they're unnecessary. We don't have a state whose accesses we need to guard with locks and syncs. The only real purpose for the lock was to prevent concurrent removal of the same volume. Looking at the code, concurrent removal ought to be fine with a bit of reordering - one or the other might fail, but we will successfully evict the volume from the state. Also, remove the 'prune' bool from RemoveVolume. None of our other API functions accept it, and it only served to toggle off more verbose error messages. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Expand renumber to also renumber pod locksMatthew Heon2019-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add ability to rewrite pod configs in the databaseMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | Necessary for rewriting lock IDs as part of renumber. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add initial version of renumber backendMatthew Heon2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | Renumber is a way of renumbering container locks after the number of locks available has changed. For now, renumber only works with containers. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Add a function for overwriting container configMatthew Heon2019-02-21
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #2385 from baude/remoteloadOpenShift Merge Robot2019-02-21
|\ \ \ | | | | | | | | podman-remote load image
| * | | podman-remote load imagebaude2019-02-21
|/ / / | | | | | | | | | | | | | | | | | | enable the ability to load an image into remote storage using the remote client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2394 from vrothberg/vendor-image-v1.4OpenShift Merge Robot2019-02-21
|\ \ \ | |/ / |/| | vendor containers/image v1.4
| * | vendor containers/image v1.4Valentin Rothberg2019-02-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This requires some additional changes to the dependencies since the progress-bar library has been changed to github.com/vbauerster/mpb. Please refer to the following link for the release notes: https://github.com/containers/image/releases/tag/v1.4 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>