summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Podman containers/pods prune should throw an error if user adds argsDaniel J Walsh2020-10-01
| | | | | | | We are not currently checking if a user accidently adds an argument to all podman * prune commands. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #7735 from QiWang19/manifest-inspectOpenShift Merge Robot2020-10-01
|\ | | | | fix allowing inspect manifest of non-local image
| * fix allowing inspect manifest of non-local imageQi Wang2020-09-30
| | | | | | | | | | | | | | Add support of `podman manifest inspect` returning manifest list of non-local manifest. Close #https://github.com/containers/podman/issues/7726 Signed-off-by: Qi Wang <qiwan@redhat.com>
* | Merge pull request #7835 from Luap99/network-test-cleanupOpenShift Merge Robot2020-10-01
|\ \ | | | | | | Fix some flakes in the e2e network tests.
| * | Fix some flakes in the e2e network tests.Paul Holzinger2020-10-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The network test created config files with random filenames but the network name was static. Since the tests can run in parallel podman was not able to distinguish the networks. We need to make sure that each test has its own config file and network name. This helps to prevent unnecessary flakes. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #7846 from rhatdan/rootlessOpenShift Merge Robot2020-10-01
|\ \ \ | | | | | | | | Attempt to test all Broken SkipIfRootless FIXME
| * | | Attempt to test all Broken SkipIfRootless FIXMEDaniel J Walsh2020-09-30
| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #7864 from rhatdan/volumeOpenShift Merge Robot2020-10-01
|\ \ \ \ | | | | | | | | | | Volume prune should not pass down the force flag
| * | | | Volume prune should not pass down the force flagDaniel J Walsh2020-10-01
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman volume prune -f Should just tell the prune command to not prompt for confirmation. It should not be passing the prune flag into the API. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #7851 from zhangguanzhang/fix-apiv2-ctr-workdir-and-envOpenShift Merge Robot2020-10-01
|\ \ \ \ | |/ / / |/| | | [apiv2] don't ignore the ENV and WorkDir from the image
| * | | fix: The container created by APIV2 has an incorrect Env and WorkDirzhangguanzhang2020-10-01
| | | | | | | | | | | | | | | | Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
* | | | Merge pull request #7848 from cevich/fix_testsOpenShift Merge Robot2020-10-01
|\ \ \ \ | | | | | | | | | | Fix two e2e tests
| * | | | Distinguish userns vs containerized testsChris Evich2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The systemd test was inaccurately being skipped when a userns env. var. flag was set. At best this is confusing to new developers, and at worse it actively blocks an otherwise legitimate class of tests. Improve the accuracy of skip-logic by adding/using a purpose built set of functions. Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | | Fix ubuntu exec_testChris Evich2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Test passes on Fedora because the registry server is one of the defaults. However it is not typically configured on Ubuntu hosts, and therefor this test can fail. While specifying the FQIN in the dockerfile text is not an ideal solution, it cannot negatively affect other tests which utilize `podmanTest.BuildImage`. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #7858 from jwhonce/wip/http_proxyOpenShift Merge Robot2020-10-01
|\ \ \ \ \ | | | | | | | | | | | | Support --http-proxy for remote builds
| * | | | | Support --http-proxy for remote buildsJhon Honce2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Fix misspelled parameter * add http-proxy support for builds http_proxy must be set in the podman.service unit file, for example Environment=http_proxy=<value> Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | Merge pull request #7823 from vrothberg/fix-6381OpenShift Merge Robot2020-10-01
|\ \ \ \ \ \ | |/ / / / / |/| | | | | image look up: consult registries.conf
| * | | | | image look up: consult registries.confValentin Rothberg2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When looking up local images, take the unqualified-serach registries of the registries.conf into account (on top of "localhost/"). Also extend the integration tests to prevent future regressions. Fixes: #6381 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | | pkg/registries: add a retiring noteValentin Rothberg2020-09-30
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The registries package should be retired. It was introduced as an easier to use wrapper around c/image `sysregistries` which has been replaced by `sysregistriesv2` a long while ago. Users should either use the `sysregistriesv2` package directly or, even better, we cache the config in libpod's image runtime to prevent redundant (and ~expensive) parsing of the registries.conf files. For now, just add a note in hope we'll not forgert about it when we find time in the future. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #7834 from xordspar0/patch-1OpenShift Merge Robot2020-09-30
|\ \ \ \ \ | | | | | | | | | | | | Don't disable Go modules when generating varlink
| * | | | | Don't disable Go modules when generating varlinkJordan Christiansen2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From a fresh install of Fedora 33 Beta and a fresh clone of the repo, `make` fails with the following error when Go modules are disabled: # Only generate the varlink code on Linux (see issue #4814). GO111MODULE=off go generate ./pkg/varlink/... ../../vendor/github.com/varlink/go/cmd/varlink-go-interface-generator/main.go:12:2: cannot find package "github.com/varlink/go/varlink/idl" in any of: /usr/lib/golang/src/github.com/varlink/go/varlink/idl (from $GOROOT) /home/test/src/podman/_output/src/github.com/varlink/go/varlink/idl (from $GOPATH) pkg/varlink/generate.go:3: running "go": exit status 1 make: *** [Makefile:646: pkg/varlink/iopodman.go] Error 1 Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
* | | | | | Merge pull request #7798 from QiWang19/run-manifestOpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Use local image if input image is a manifest list
| * | | | | Use local image if input image is a manifest listQi Wang2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If run&create image returns error: image contains manifest list, not a runnable image, find the local image that has digest matching the digest from the list and use the image from local storage for the command. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | | Merge pull request #7820 from giuseppe/fix-capabilities-not-rootOpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | | | | | | | | | | | | | | capabilities: always set ambient and inheritable
| * | | | | | capabilities: always set ambient and inheritableGiuseppe Scrivano2020-09-30
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change capabilities handling to reflect what docker does. Bounding: set to caplist Inheritable: set to caplist Effective: if uid != 0 then clear; else set to caplist Permitted: if uid != 0 then clear; else set to caplist Ambient: clear Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #7847 from rhatdan/networkOpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | | | | | | | | | | | | | | Make the e2e test network cleanup more robust.
| * | | | | | Make the e2e test network cleanup more robust.Daniel J Walsh2020-09-30
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to handle removal of non existing network. This allows the `removeCNINetwork` function always to be called. This is needed by tests which are trying to remove the network manually in order to prevent flakes. Fixes #7809 Signed-off-by: Paul Holzinger <paul.holzinger@web.de> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #7833 from jwhonce/issues/7826OpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | Refactor IdleTracker to handle StateIdle transitions
| * | | | | Refactor IdleTracker to handle StateIdle transitionsJhon Honce2020-09-29
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove stutter naming for package and types * Stop treating StateIdle the same as StateClosed, rather transitions to StateIdle will keep API timeout window open * Remove redundate code Fixes #7826 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #7840 from vrothberg/remote-untagOpenShift Merge Robot2020-09-30
|\ \ \ \ \ | | | | | | | | | | | | fix remote untag
| * | | | | fix remote untagValentin Rothberg2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the remote client to untag all tags of the specified image. Instead of querying the image on the client side, support the case where both, repo and tag, are empty and remove all tags. Reuse the ABI implementation where possible. In retrospective, the libpod untag endpoint should support a slice of strings to batch remove tags rather than reaching out for each tag individually. Enable the skipped test. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #7841 from AkihiroSuda/fix-7789OpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | rootless-cni-infra v3: fix cleaning up DNS entries
| * | | | | libpod: bump up rootless-cni-infra to v3Akihiro Suda2020-09-30
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
| * | | | | rootless-cni-infra v3: fix cleaning up DNS entriesAkihiro Suda2020-09-30
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix "Old DNS entries are not cleaned up" by passing CNI_ARGS to `cnitool del`. Fix #7789 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
* | | | | Merge pull request #7831 from rhatdan/envOpenShift Merge Robot2020-09-30
|\ \ \ \ \ | | | | | | | | | | | | We already set container=podman environment variable
| * | | | | We already set container=podman environment variableDaniel J Walsh2020-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only need to set container, no need for containers Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #7825 from rhatdan/exitcodeOpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Fix handling of remove of bogus volumes, networks and Pods
| * | | | | Fix handling of remove of bogus volumes, networks and PodsDaniel J Walsh2020-09-29
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In podman containers rm and podman images rm, the commands exit with error code 1 if the object does not exists. This PR implements similar functionality to volumes, networks, and Pods. Similarly if volumes or Networks are in use by other containers, and return exit code 2. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #7827 from vrothberg/systemd-run-errorOpenShift Merge Robot2020-09-30
|\ \ \ \ \ | | | | | | | | | | | | healthchecks: return systemd-run error
| * | | | | healthchecks: return systemd-run errorValentin Rothberg2020-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In case `systemd-run` errors when creating transient unit files (and timers), create an error based on the combined output from stdout and stderr. Using the error from `exec.Command` contains the exit code only which is not useful to debug (see #7484). Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #7799 from rhatdan/rootlessOpenShift Merge Robot2020-09-30
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Make all Skips specify a reason
| * | | | | Make all Skips specify a reasonDaniel J Walsh2020-09-29
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | Always use CGROUPV2 rather then reading from system all the time. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #7832 from edsantiago/bats_run_tzOpenShift Merge Robot2020-09-30
|\ \ \ \ \ | |/ / / / |/| | | | System tests: add podman run --tz
| * | | | System tests: add podman run --tzEd Santiago2020-09-29
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | New tests for podman run --tz=EXPLICIT and =local. Requires updating our testimage by adding a fixed reference timestamp to a known file path. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #7828 from edsantiago/batsOpenShift Merge Robot2020-09-29
|\ \ \ \ | |_|_|/ |/| | | System tests: corner case for run --pull
| * | | System tests: corner case for run --pullEd Santiago2020-09-29
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Obscure corner case in which 'podman run --pull=never alpine' will actually pass *with no alpine image* if there's an image named "myalpine". (i.e. a substring match, not full string match). Fixed in #7770 but the tests that were added there do not actually test that. This adds a double-duty test for that as well as making sure that 'run --pull=never SHORTNAME' (implicit :latest) does not match our existing :YYYYMMDD image; then one more quick test to make sure that if we tag as :latest, the same --pull=never succeeds. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #7797 from rsommer/masterOpenShift Merge Robot2020-09-29
|\ \ \ | |/ / |/| | [CI:DOCS] Add section about current differences
| * | Apply suggestions from code reviewRoland Sommer2020-09-29
| | | | | | | | | | | | | | | Co-authored-by: Tom Sweeney <tsweeney@redhat.com> Signed-off-by: Roland Sommer <rol@ndsommer.de>
| * | Add section about current differencesRoland Sommer2020-09-28
| | | | | | | | | | | | | | | | | | There are some differences in behaviour between docker and podman which should be documented to help developers while transitioning. Signed-off-by: Roland Sommer <rol@ndsommer.de>
* | | Merge pull request #7788 from IceCodeNew/patch-1OpenShift Merge Robot2020-09-29
|\ \ \ | | | | | | | | Updating on supported restart policy
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-17 21:57:39 +0000