summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #11578 from jelly/handle_nil_pointer_derefOpenShift Merge Robot2021-09-15
|\ | | | | api: handle nil pointer dereference in api endpoints
| * api: handle nil pointer dereference in rest endpointsJelle van der Waa2021-09-15
| | | | | | | | | | | | | | | | When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | Merge pull request #11574 from nalind/buildah-platformsOpenShift Merge Robot2021-09-15
|\ \ | | | | | | build: take advantage of --platform lists
| * | build: take advantage of --platform listsNalin Dahyabhai2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The builder can take a list of platforms in the Platforms field of its BuildOptions argument, and we should definitely take advantage of that. The `bud-multiple-platform-values` test from buildah exercises support for this, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | Merge pull request #11586 from Luap99/docOpenShift Merge Robot2021-09-15
|\ \ \ | |_|/ |/| | [CI:DOCS] Fix example in podman machine init man page
| * | Fix example in podman machine init man pagePaul Holzinger2021-09-15
|/ / | | | | | | | | | | Fixes #11582 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #11575 from jelly/doc_all_optionOpenShift Merge Robot2021-09-14
|\ \ | | | | | | [CI:DOCS] Document `all` query parameter for /libpod/images/prune
| * | Document `all` query parameter for /libpod/images/pruneJelle van der Waa2021-09-14
| | | | | | | | | | | | Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | | Merge pull request #11561 from giuseppe/simplify-cgroups-disabled-testOpenShift Merge Robot2021-09-14
|\ \ \ | |_|/ |/| | tests: simplify --cgroups=disabled test and enable for rootless
| * | tests: enable --cgroups=disabled test for rootlessGiuseppe Scrivano2021-09-14
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | tests: simplify --cgroups=disabled testGiuseppe Scrivano2021-09-14
| | | | | | | | | | | | | | | | | | read the cgroup directly from the container. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #11170 from flouthoc/support-rootfs-overlayOpenShift Merge Robot2021-09-14
|\ \ \ | | | | | | | | rootfs: Add support for rootfs-overlay.
| * | | rootfs: Add support for rootfs-overlay and bump to buildah v1.22.1-0.202108flouthoc2021-09-14
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows users to specify a readonly rootfs with :O, in exchange podman will create a writable overlay. bump builah to v1.22.1-0.20210823173221-da2b428c56ce [NO TESTS NEEDED] Signed-off-by: flouthoc <flouthoc.git@gmail.com>
* | | Merge pull request #11569 from baude/macaarch64pullfcosOpenShift Merge Robot2021-09-14
|\ \ \ | | | | | | | | Use new aarch64 fcos repos
| * | | Use new aarch64 fcos reposbaude2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that aarch64 fcos is an official thing, we no longer need to use the side repo (for lack of a better word). We can now use the same image lookup technique as x86_64. I removed the special lookup, moved the x86_64 lookup to generic arch, and removed the arch specific files that we no longer needed. [NO TESTS NEEDED] Signed-off-by: baude <baude@redhat.com>
* | | | Merge pull request #11559 from jwhonce/wip/generatorOpenShift Merge Robot2021-09-14
|\ \ \ \ | |_|_|/ |/| | | Enhance bindings for IDE hints
| * | | Enhance bindings for IDE hintsJhon Honce2021-09-14
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Follow https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source for leading comment * Add godoc strings for all exposed methods for IDE support * Copy field godoc strings into generated code as function godoc string * Remove unused/unnecessary fields from generator.go structures * Cleanup code regarding template usage Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #11512 from cevich/use_nmcli_workaround_imagesOpenShift Merge Robot2021-09-14
|\ \ \ | | | | | | | | Cirrus: NM/CNI workaround + Remove prior-Ubuntu
| * | | Cirrus: NM/CNI workaround + Remove prior-UbuntuChris Evich2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | Ref: https://github.com/containers/automation_images/pull/88 Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #11551 from Luap99/rootlessport-restartOpenShift Merge Robot2021-09-14
|\ \ \ \ | | | | | | | | | | fix restart always with rootlessport
| * | | | libpod: rootful close binded portsPaul Holzinger2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For rootful users ports are forwarded via iptables. To make sure no other process tries to use them, libpod will bind the ports and pass the fds to conmon. There seems to be race when a container is restarted because libpod tries to bind the port before the conmon process exited. The problem only hapens with the podman service because it keeps the connection open. Once we have the fd and passed it to conmon the podman service should close the connection. To verify run `sudo ss -tulpn` and check that only the conmon process keeps the port open. Previously you would also see the podman server process listed. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | | fix restart always with rootlessportPaul Holzinger2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a container is automatically restarted due its restart policy and the container uses rootless cni networking with ports forwarded we have to start a new rootlessport process since it exits with conmon. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | | remove rootlessport socket to prevent EADDRINUSEPaul Holzinger2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we restart a container via podman restart or restart policy the rootlessport process fails with `address already in use` because the socketfile still exists. This is a regression and was introduced in commit abdedc31a25e. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #11520 from giuseppe/enable-cgroup-parent-testOpenShift Merge Robot2021-09-14
|\ \ \ \ \ | |_|_|_|/ |/| | | | test: enable --cgroup-parent test
| * | | | test: enable --cgroup-parent testGiuseppe Scrivano2021-09-14
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | and fix it for running with runc. Closes: https://github.com/containers/podman/issues/11165 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #11449 from simnalamburt/gvproxy-pathOpenShift Merge Robot2021-09-14
|\ \ \ \ | |/ / / |/| | | Make gvproxy path configurable with containers.conf
| * | | Search gvproxy with config.FindHelperBinary()Hyeon Kim2021-09-14
|/ / / | | | | | | | | | | | | | | | | | | | | | Closes #11531 [NO TESTS NEEDED] Signed-off-by: Hyeon Kim <simnalamburt@gmail.com>
* | | Merge pull request #11529 from n1hility/fix-oldfieldsOpenShift Merge Robot2021-09-13
|\ \ \ | |_|/ |/| | Add deprecated event fields for 1.22+ clients that still expect them
| * | Add deprecated fields for 1.22+ clients that still expect themJason T. Greene2021-09-10
| | | | | | | | | | | | Signed-off-by: Jason Greene <jason.greene@redhat.com>
* | | Merge pull request #11545 from rhatdan/exitcodesOpenShift Merge Robot2021-09-13
|\ \ \ | | | | | | | | If container exits with 125 podman should exit with 125
| * | | If container exits with 125 podman should exit with 125Daniel J Walsh2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | fixes: https://github.com/containers/podman/issues/11540 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #11549 from ↵OpenShift Merge Robot2021-09-13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/json-iterator/go-1.1.12 Bump github.com/json-iterator/go from 1.1.11 to 1.1.12
| * | | | Bump github.com/json-iterator/go from 1.1.11 to 1.1.12dependabot[bot]2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/json-iterator/go](https://github.com/json-iterator/go) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/json-iterator/go/releases) - [Commits](https://github.com/json-iterator/go/compare/v1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: github.com/json-iterator/go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #11440 from ashley-cui/sshOpenShift Merge Robot2021-09-13
|\ \ \ \ \ | | | | | | | | | | | | Use default username for podman machine ssh
| * | | | | Use default username for podman machine sshAshley Cui2021-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using the defaut conection for podman machine ssh, use the default username too. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | | | Merge pull request #11552 from Luap99/commonOpenShift Merge Robot2021-09-13
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | bump c/common to v0.44.0
| * | | | | bump c/common to v0.44.0Paul Holzinger2021-09-13
| | |_|_|/ | |/| | | | | | | | | | | | | Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #11550 from atykhyy/patch-2OpenShift Merge Robot2021-09-13
|\ \ \ \ \ | |_|_|/ / |/| | | | Fix #11444: remote breaks with stdout redirection
| * | | | Fix #11444: remote breaks with stdout redirectionAnton Tykhyy2021-09-13
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | `setConsoleMode` should do nothing if the handle is not a terminal. The proposed change is [exactly what `golang.org/x/term/IsTerminal()` does on Windows](https://cs.opensource.google/go/x/term/+/6886f2df:term_windows.go). [NO TESTS NEEDED] Signed-off-by: Anton Tykhyy <atykhyy@gmail.com>
* | | | Merge pull request #11548 from ↵OpenShift Merge Robot2021-09-13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.36.0 Bump github.com/containers/storage from 1.35.0 to 1.36.0
| * | | | Bump github.com/containers/storage from 1.35.0 to 1.36.0dependabot[bot]2021-09-13
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.35.0 to 1.36.0. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.35.0...v1.36.0) --- updated-dependencies: - dependency-name: github.com/containers/storage dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #11537 from TomSweeneyRedHat/dev/tsweeney/fixhyphenOpenShift Merge Robot2021-09-13
|\ \ \ \ | |/ / / |/| | | [CI:DOCS] Remove short 'a' option from all-tags
| * | | [CI:DOCS] Remove short 'a' option from all-tagsTomSweeneyRedHat2021-09-13
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | The short option 'a' for the --all-tags option in the pull page is not valid, remove it. Addresses: #11536 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #11505 from cevich/enable_rootless_unitOpenShift Merge Robot2021-09-12
|\ \ \ | | | | | | | | Cirrus: Run unit-tests rootless
| * | | Cirrus: Run unit-tests rootlessChris Evich2021-09-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously (for various reasons) the unittests were limited by the Makefile to root-only. However, experimentation via PR #11490 shows they will actually execute and pass when run as a regular user. Enable this for only the latest Fedora VMs, so as to only add one new task to the (already large) set. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #11517 from jwhonce/issues/10053OpenShift Merge Robot2021-09-12
|\ \ \ \ | | | | | | | | | | Refactor API server emphasis on logging
| * | | | Refacter API server emphasis on loggingJhon Honce2021-09-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * To aid in debugging log API request and response bodies at trace level. Events can be correlated using the X-Reference-Id. * Server now echos X-Reference-Id from client if set, otherwise generates an unique id. * Move logic for X-Reference-Id into middleware * Change uses of Header.Add() to Set() when setting Content-Type * Log API operations in Apache format using gorilla middleware * Port server code to use BaseContext and ConnContext Fixes #10053 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #11525 from rhatdan/healthcheckOpenShift Merge Robot2021-09-11
|\ \ \ \ \ | | | | | | | | | | | | Stop outputting 'healthy' on healthcheck
| * | | | | Stop outputting 'healthy' on healthcheckDaniel J Walsh2021-09-10
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should only print unhealthy if the check fails. Currently this is filling logs when users are running lots of healthchecks. Improves: https://github.com/containers/podman/issues/11157 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #11513 from Luap99/unshareOpenShift Merge Robot2021-09-11
|\ \ \ \ \ | | | | | | | | | | | | podman unshare keep exit code
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-10-05 02:21:43 +0000