summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Add CNI rootless networking troubleshooting for v2.2.1TomSweeneyRedHat2021-06-29
| | | | | | | | | A CNI container image is required for rootless networking in V2.2.1 (RHEL 8.3.1) and through v3.0.1. Add a note in the troubleshooting guide with a pointer to the documenation for that. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* Merge pull request #10811 from ↵OpenShift Merge Robot2021-06-29
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containers/ocicrypt-1.1.2 Bump github.com/containers/ocicrypt from 1.1.1 to 1.1.2
| * Bump github.com/containers/ocicrypt from 1.1.1 to 1.1.2dependabot[bot]2021-06-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/ocicrypt](https://github.com/containers/ocicrypt) from 1.1.1 to 1.1.2. - [Release notes](https://github.com/containers/ocicrypt/releases) - [Commits](https://github.com/containers/ocicrypt/compare/v1.1.1...v1.1.2) --- updated-dependencies: - dependency-name: github.com/containers/ocicrypt dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #10803 from lsm5/remove-cni-conflistOpenShift Merge Robot2021-06-29
|\ \ | |/ |/| Makefile: remove install.cni
| * Makefile: remove install.cniLokesh Mandvekar2021-06-28
| | | | | | | | | | | | | | We no longer need to install /etc/cni/net.d/87-podman-bridge.conflist so install.cni isn't needed either. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | Merge pull request #10786 from tobwen/tobwen-ETCDIROpenShift Merge Robot2021-06-28
|\ \ | |/ |/| [NO TEST NEEDED] prefix `ETCDIR` with `${PREFIX}/`
| * prefix `ETCDIR` with `${PREFIX}/`tobwen2021-06-26
|/ | | | | | `ETCDIR` isn't prefixed and led to dangling files in `DESTDIR/etc` Signed-off-by: Tobias Wendorff <1864057+tobwen@users.noreply.github.com>
* Merge pull request #10736 from trusch/feature-use-secret-configOpenShift Merge Robot2021-06-25
|\ | | | | read secret config from config file if no user data.
| * make DriverOpts name consistent.Tino Rusch2021-06-25
| | | | | | | | Signed-off-by: Tino Rusch <tino.rusch@gmail.com>
| * read secret config from config file if no user data.Tino Rusch2021-06-24
| | | | | | | | | | | | | | | | | | | | | | | | feat: read secret config from config file if the user hasn't entered explicit config values feat: allow to specify `--driver-opts opt1=val1,opt2=val2` in the secret create command to allow overriding the default values fix: show driver options in `podman secret inspect` Signed-off-by: Tino Rusch <tino.rusch@gmail.com>
* | Merge pull request #10774 from vrothberg/registriesOpenShift Merge Robot2021-06-25
|\ \ | | | | | | remove `pkg/registries`
| * | remove `pkg/registries`Valentin Rothberg2021-06-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pull the trigger on the `pkg/registries` package which acted as a proxy for `c/image/pkg/sysregistriesv2`. Callers should be using the packages from c/image directly, if needed at all. Also make use of libimage's SystemContext() method which returns a copy of a system context, further reducing the risk of unintentionally altering global data. [NO TESTS NEEDED] Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #10416 from tych0/activation-drop-FDNAMESOpenShift Merge Robot2021-06-25
|\ \ \ | | | | | | | | pkg/systemd: don't require LISTEN_FDNAMES for socket activation
| * | | pkg/systemd: don't require LISTEN_FDNAMES for socket activationTycho Andersen2021-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | LISTEN_FDNAMES is optional, the docs for sd_listen_fds() says: This information is read from the $LISTEN_FDNAMES variable, which **may** contain a colon-separated list of names. emphasis mine (indeed, the cited coreos code also suggests it is optional). This actually results in bug, since the default /contrib/systemd/system/podman.socket file doesn't set a FileDescriptorName=. podman when run with this systemd configuration *always* starts in unix socket mode since SocketActivated() will return false because the name is missing. The bug is a race with a very small window: between when podman does the unlink() and when it re-binds the socket later in the code, requests made during this time will fail since nothing is listening. There's another small race when the service stops and systemd realizes it and starts listening again. However, small this window we managed to hit it :). Let's fix this by ignoring LISTEN_FDNAMES. Since the code in cmd/podman/system/service_abi.go:restService() ignores this value anyway when setting up the socket activated stuff, there's no real loss here. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
* | | | Merge pull request #10768 from xabinapal/issue-10767OpenShift Merge Robot2021-06-25
|\ \ \ \ | |_|/ / |/| | | [NO TESTS NEEDED] Swap private and shared mount relabel options
| * | | fix: swapped volume relabel option valuesXabier Napal2021-06-24
| | | | | | | | | | | | | | | | Signed-off-by: Xabier Napal <xabiernapal@pm.me>
* | | | Merge pull request #10771 from infiniteregrets/cliOpenShift Merge Robot2021-06-24
|\ \ \ \ | |_|/ / |/| | | [NO TESTS NEEDED] Suggestions for typos/ incorrect commands for Podman CLI
| * | | [NO TESTS NEEDED] suggestions for incorrect cmdsMehul Arora2021-06-24
| | |/ | |/| | | | | | | Signed-off-by: Mehul Arora <aroram18@mcmaster.ca>
* | | Merge pull request #10760 from vrothberg/save-docsOpenShift Merge Robot2021-06-24
|\ \ \ | | | | | | | | [CI:DOCS] podman save: clarify formats and transports
| * | | [CI:DOCS] podman save: clarify formats and transportsValentin Rothberg2021-06-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Mention all supports --format values and put them into the context of supported transports. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #10773 from vrothberg/mtrmacOpenShift Merge Robot2021-06-24
|\ \ \ \ | | | | | | | | | | [CI:DOCS] add @mtrmac to OWNERS
| * | | | add @mtrmac to OWNERSValentin Rothberg2021-06-24
| | |/ / | |/| | | | | | | | | | | | | | | | | | With great power comes great `/lgtm`. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #10772 from vrothberg/fix-cpOpenShift Merge Robot2021-06-24
|\ \ \ \ | |/ / / |/| | | cp: do not allow dir->file copying
| * | | cp: do not allow dir->file copyingValentin Rothberg2021-06-24
|/ / / | | | | | | | | | | | | | | | | | | | | | Fix a bug in `podman-cp` to forbid copying directories to files. Previously, the directory was copied to the parent directory of the file which is wrong. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #10583 from rhatdan/logOpenShift Merge Robot2021-06-24
|\ \ \ | | | | | | | | Support log_tag defaults from containers.conf
| * | | Support log_tag defaults from containers.confDaniel J Walsh2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/10204 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #10766 from Procyhon/13062021_manpageOpenShift Merge Robot2021-06-24
|\ \ \ \ | |_|/ / |/| | | [CI:DOCS] Follow-up to PR 10676
| * | | [CI:DOCS] Follow-up to PR 10676Alexander Richter2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | See [PR 10676](https://github.com/containers/podman/pull/10676). Signed-off-by: Alexander Richter <67486332+Procyhon@users.noreply.github.com>
* | | | Merge pull request #10765 from umohnani8/mtabOpenShift Merge Robot2021-06-23
|\ \ \ \ | |_|_|/ |/| | | Create /etc/mtab with the correct ownership
| * | | [NO TESTS NEEDED] Create /etc/mtab with the correct ownershipUrvashi Mohnani2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create the /etc and /etc/mtab directories with the correct ownership based on what the UID and GID is for the container. This was causing issue when starting the infra container with userns as the /etc directory wasn't being created with the correct ownership. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | | | Merge pull request #10747 from jwhonce/wip/reportOpenShift Merge Robot2021-06-23
|\ \ \ \ | | | | | | | | | | Add --format to connection list
| * | | | Add --format to connection listJhon Honce2021-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for the --format option to podman system connection list. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #10756 from jmguzik/volume-prune-until-http-apiOpenShift Merge Robot2021-06-23
|\ \ \ \ \ | | | | | | | | | | | | Add support for volume prune until filter to http api
| * | | | | Add support for volume prune until filter to http apiJakub Guzik2021-06-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As stated in #10579 docker silently implements until filter for volume prune. This commit adds initial support to the HTTP API, both libpod and compat. It enables further work on that issue, such as adding cli support in the future. Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | | | | | Merge pull request #10716 from cdoern/podFlagsOpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ | | | | | | | | | | | | | | Podman Pod Create --cpus and --cpuset-cpus flags
| * | | | | | Podman Pod Create --cpus and --cpuset-cpus flagscdoern2021-06-23
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added logic and handling for two new Podman pod create Flags. --cpus specifies the total number of cores on which the pod can execute, this is a combination of the period and quota for the CPU. --cpuset-cpus is a string value which determines of these available cores, how many we will truly execute on. Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | | | Merge pull request #10610 from cdoern/healthCheckOpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ | | | | | | | | | | | | | | Edited compat handling code for containers/json status and added python tests
| * | | | | | Health Check is not handled in the compat LibpodToContainerJSONcdoern2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added parsing and handling for the healthCheck status within containers.go. Also modified tests fixes #10457 Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | | | | Merge pull request #10696 from cdoern/libpodStatsOpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ \ | |_|_|_|_|/ / |/| | | | | | Podman Stats additional features
| * | | | | | Podman Stats additional featurescdoern2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | added Avg Cpu calculation and CPU up time to podman stats. Adding different feature sets in different PRs, CPU first. resolves #9258 Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | | | | Merge pull request #10676 from Procyhon/13062021_manpageOpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ \ | | |_|_|_|_|/ | |/| | | | | [CI:DOCS] UPDATE manpages with MANPAGE_SYNTAX
| * | | | | | [CI:DOCS] UPDATE manpages with MANPAGE_SYNTAXAlexander Richter2021-06-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MANPAGE_SYNTAX was edited. The following manpages have been adapted to the MANPAGE_SYNTAX: - podman-container-prune - podman-container-restore The following manpages have had little changes: - podman-attach - podman-auto-update - podman-commit - podman-completion - podman-container-checkpoint - podman-container-cleanup - podman-container-exists Signed-off-by: Alexander Richter <67486332+Procyhon@users.noreply.github.com>
* | | | | | | Merge pull request #10739 from vrothberg/fix-10682OpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | create: support images with invalid platform
| * | | | | | | create: support images with invalid platformValentin Rothberg2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Much to my regret, there is a number of images in the wild with invalid platforms breaking the platform checks in libimage that want to make sure that a local image is matching the expected platform. Imagine a `podman run --arch=arm64 fedora` with a local amd64 fedora image. We really shouldn't use the local one in this case and pull down the arm64 one. The strict platform checks in libimage in combination with invalid platforms in images surfaced in Podman being able to pull an image but failing to look it up in subsequent presence checks. A `podman run` would hence pull such an image but fail to create the container. Support images with invalid platforms by vendoring the latest HEAD from containers/common. Also remove the partially implemented pull-policy logic from Podman and let libimage handle that entirely. However, whenever --arch, --os or --platform are specified, the pull policy will be forced to "newer". This way, we pessimistically assume that the local image has an invalid platform and we reach out to the registry. If there's a newer image (i.e., one with a different digest), we'll pull it down. Please note that most of the logic has either already been implemented in libimage or been moved down which allows for removing some clutter from Podman. [NO TESTS NEEDED] since c/common has new tests. Podman can rely on the existing tests. Fixes: #10648 Fixes: #10682 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | | | Merge pull request #10759 from dilyanpalauzov/masterDaniel J Walsh2021-06-23
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | markdown/*: typos 'a image'
| * | | | | | | | markdown/*: typos 'a image'Дилян Палаузов2021-06-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Insisting on “DCO” imposes formalities, that serve self-purpose. One cannot assume that the submitter has time or will to read texts about symbolism in software contributions. If the system wants to see the text nrEAUIEUAIe eanuitdnuae EAIUEAUIAIE »ℓ§444.3.72b)°»°ℓ§euaieauuae in each commit, people will write this, or any other text, that the system wants to see. All such text, which presence is mandated by the system, has the same value. Signed-off-by: Дилян Палаузов <git-dpa@aegee.org>
* | | | | | | | | Merge pull request #10752 from vrothberg/fix-10730OpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / |/| | | | | | | | [CI:DOCS] push/pull docs: clarify supported transports
| * | | | | | | | [CI:DOCS] push/pull docs: clarify supported transportsValentin Rothberg2021-06-23
| | |/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The man pages of podman push/pull were incomplete in explaining all supported transports. To keep things simple, explain the defaults, refer to containers-transports(5) and give some examples. Fixes: #10730 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | | | Merge pull request #10758 from vrothberg/unflakeOpenShift Merge Robot2021-06-23
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | disable tty-size exec checks in system tests
| * | | | | | | disable tty-size exec checks in system testsValentin Rothberg2021-06-23
| |/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed in #10710, the additional checks for podman-exec added by commit 666f555aa52b are extremely flaky and appear in nearly every PR I have see this week. Let's temporarily disable the checks and reenable them on #10710 is fixed. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>