summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Try disabling --rm on notify_socket testMatthew Heon2019-02-13
| | | | | | | | We have a consistent CI failure with the notify_socket test that I can't reproduce locally. There's no reason for the test to have --rm, so try removing it. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Remove a lot of '--rm' options from unit testsMatthew Heon2019-02-12
| | | | | | | | | | | | Previously, 'podman create --rm' did not work - it wouldn't error but it did nothing. It is now fixed, but unfortunately the unit tests used it a lot, in ways that just do not work when it actually functions. Begin the process of fixing now-failing tests. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Address review comments on #2319Matthew Heon2019-02-12
| | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Retain a copy of container exit file on cleanupMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | When cleaning up containers, we presently remove the exit file created by Conmon, to ensure that if we restart the container, we won't have conflicts when Conmon tries writing a new exit file. Unfortunately, we need to retain that exit file (at least until we get a workable events system), so we can read it in cases where the container has been removed before 'podman run' can read its exit code. So instead of removing it, rename it, so there's no conflict with Conmon, and we can still read it later. Fixes: #1640 Signed-off-by: Matthew Heon <mheon@redhat.com>
* Fix manual detach from containers to not wait for exitMatthew Heon2019-02-12
| | | | | | | | | | | | | | | | | | | | | | | | | At present, when manually detaching from an attached container (using the detach hotkeys, default C-p C-q), Podman will still wait for the container to exit to obtain its exit code (so we can set Podman's exit code to match). This is correct in the case where attach finished because the container exited, but very wrong for the manual detach case. As a result of this, we can no longer guarantee that the cleanup and --rm functions will fire at the end of 'podman run' - we may be exiting before we get that far. Cleanup is easy enough - we swap to unconditionally using the cleanup processes we've used for detached and rootless containers all along. To duplicate --rm we need to also teach 'podman cleanup' to optionally remove containers instead of cleaning them up. (There is an argument for just using 'podman rm' instead of 'podman cleanup --rm', but cleanup does have different semantics given that we only ever expect it to run when the container has just exited. I think it might be useful to keep the two separate for things like 'podman events'...) Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #2309 from rhatdan/helpOpenShift Merge Robot2019-02-12
|\ | | | | Don't show global flags except for podman command
| * Don't show global flags except for podman commandDaniel J Walsh2019-02-12
| | | | | | | | | | | | | | | | | | Subcommands should not be showing the global flags. This causes the important information to scroll off the screen. Also fixed a typo on runCommmand (Too many 'm's) Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2315 from baude/remotevolumermOpenShift Merge Robot2019-02-12
|\ \ | | | | | | podman-remote volume rm
| * | podman-remote volume rmbaude2019-02-11
| |/ | | | | | | | | | | | | add the ability to remove/delete volumes with the podman remote client. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2300 from baude/cleanupurfaveOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| Remove urfave/cli from libpod
| * Remove urfave/cli from libpodbaude2019-02-11
| | | | | | | | | | | | | | This is the final cleanup to remove urfave/sli from libpod. Removed old, disabled tests that have not been run in over a year. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2313 from baude/remotevolumecreateOpenShift Merge Robot2019-02-12
|\ \ | |/ |/| podman-remote volume create
| * podman-remote volume createbaude2019-02-11
| | | | | | | | | | | | create a volume using the remote client over varlink Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2307 from baude/repruneremoteOpenShift Merge Robot2019-02-11
|\ \ | | | | | | Separate remote and local commands
| * | Separate remote and local commandsbaude2019-02-11
| | | | | | | | | | | | | | | | | | | | | | | | In the previous CLI, we had an accurate depiction of commands available for the remote client and those available for the local client. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2281 from rhatdan/deleteContainerOpenShift Merge Robot2019-02-11
|\ \ \ | | | | | | | | Remove container from storage on --force
| * | | Remove container from storage on --forceDaniel J Walsh2019-02-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we can get into a state where a container exists in storage but does not exist in libpod. If the user forces a removal of this container, then we should remove it from storage even if the container is owned by another tool. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #2310 from baude/issue2304OpenShift Merge Robot2019-02-11
|\ \ \ \ | | | | | | | | | | lock and sync container before checking mountpoint
| * | | | lock and sync container before checking mountpointbaude2019-02-11
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when checking for a container's mountpoint, you must lock and sync the container or the result may be "". Fixes: #2304 Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #2306 from baude/podstatsgotemplateOpenShift Merge Robot2019-02-11
|\ \ \ \ | |/ / / |/| | | Podman pod stats -- fix GO template output
| * | | Podman pod stats -- fix GO template outputbaude2019-02-10
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Go templates were not being processed or printed correctly for podman pod stats. Added the ability to do templates as well as honor the table identifier. Fixes #2258 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2308 from giuseppe/pod-create-allow-rootlessOpenShift Merge Robot2019-02-11
|\ \ \ | | | | | | | | pod: drop invalid check for rootless
| * | | oci: do not set XDG_RUNTIME_DIR twiceGiuseppe Scrivano2019-02-11
| | | | | | | | | | | | | | | | | | | | | | | | we are doing it few lines above. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | pod: drop not valid check for rootlessGiuseppe Scrivano2019-02-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | rootless networks support port binding if the underlying slirp4netns is new enough. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #2302 from TomSweeneyRedHat/dev/tsweeney/testfix1OpenShift Merge Robot2019-02-11
|\ \ \ \ | |/ / / |/| | | Add common_test.go to single test instructions
| * | | Add common_test.go to single test instructionsTomSweeneyRedHat2019-02-09
| |/ / | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> Add e2e/test/common_test.go to the single integration test instructions. Without it the documented process fails.
* | | Merge pull request #2286 from rhatdan/troubleshootingOpenShift Merge Robot2019-02-11
|\ \ \ | |/ / |/| | Add troubleshooting information about running a rootless containers.
| * | Add troubleshooting information about running a rootless containers.Daniel J Walsh2019-02-10
|/ / | | | | | | | | | | | | Add a problem statement about shadow-utils and missing entries from /etc/subuid and /etc/subgid. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2280 from TomSweeneyRedHat/dev/tsweeney/trusty2OpenShift Merge Robot2019-02-09
|\ \ | | | | | | Update image-trust man with further comments
| * | Update image-trust man with further commentsTomSweeneyRedHat2019-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> After the last update, @mtrmac had some great suggestions which I've incorporated. I've updated the G:oogle doc and have added this PR in case it's easier to see the diffs. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #2296 from baude/psShowMountOpenShift Merge Robot2019-02-09
|\ \ \ | |_|/ |/| | Add volume mounts to PS output
| * | Add volume mounts to PS outputbaude2019-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | When listing containers, you should be able to list the mounts with something like --format "table{{".Mounts}}". Resolves: #2238 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2297 from baude/issue2246OpenShift Merge Robot2019-02-09
|\ \ \ | |/ / |/| | do not crash when displaying dangling images
| * | do not crash when displaying dangling imagesbaude2019-02-08
|/ / | | | | | | | | | | | | | | | | | | | | the previous method required a populated image template to create the headers and always selected the first image in the slice. when dealing with dangling images, they are not populated and therefore would panic. Resolves: #2246 Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2274 from baude/cobraprepOpenShift Merge Robot2019-02-08
|\ \ | | | | | | Migrate to cobra CLI
| * | Migrate to cobra CLIbaude2019-02-08
|/ / | | | | | | | | | | | | | | We intend to migrate to the cobra cli from urfave/cli because the project is more well maintained. There are also some technical reasons as well which extend into our remote client work. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2292 from nalind/remove-dead-typesOpenShift Merge Robot2019-02-07
|\ \ | | | | | | Remove some dead type declarations
| * | Remove some dead type declarationsNalin Dahyabhai2019-02-07
|/ / | | | | | | Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | Merge pull request #2290 from giuseppe/cleanup-use-correct-runtimeOpenShift Merge Robot2019-02-07
|\ \ | | | | | | cleanup: use the correct runtime
| * | cleanup: use the correct runtimeGiuseppe Scrivano2019-02-07
| | | | | | | | | | | | | | | | | | | | | make sure "containers cleanup" uses the correct runtime if it was overriden. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2271 from cevich/search_gateOpenShift Merge Robot2019-02-07
|\ \ \ | | | | | | | | Fix down/missing registry.access.redhat.com
| * | | Fix down/missing registry.access.redhat.comChris Evich2019-02-07
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This registry responds differently depending on the the platform accessing it. It also occasionally goes down or returns 404s. Improve the reliability of the e2e tests by using the registry/image used for gating pull-requests. This way, if there's a registry/networking problem, the gating test will fail and prevent anything else from running. This is a better failure to have early, rather than wait and need to re-run all the e2e tests again later. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #2288 from vrothberg/vendor-docsOpenShift Merge Robot2019-02-07
|\ \ \ | | | | | | | | Vendor docs
| * | | make vendor: always check for latest vndrValentin Rothberg2019-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | @baude and I have recently debugged a `make vendor` issue, where different versions of `vndr` leave slightly different states behind. This ultimately leads to inconsistencies with the CI, which always fetches the latest version. To avoid such issues in the future, always use the latest version of `vndr` by checking for new versions of it prior to execution. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | install.md: add section about vendoringValentin Rothberg2019-02-07
| |/ / | | | | | | | | | | | | | | | Add a section about how `make vendor` works and how to troubleshoot it. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #2287 from 4383/add-make-docOpenShift Merge Robot2019-02-07
|\ \ \ | |/ / |/| | Add varlink generate to the make documentation
| * | Add varlink generate to the make documentationHervé Beraud2019-02-07
|/ / | | | | | | | | | | | | Minor improvement who add helping comment to the varlink generate target. Signed-off-by: Hervé Beraud <hberaud@redhat.com>
* | Merge pull request #2269 from rhatdan/selinuxOpenShift Merge Robot2019-02-07
|\ \ | |/ |/| Add documentation on running systemd on SELinux systems
| * Add documentation on running systemd on SELinux systemsDaniel J Walsh2019-02-06
| | | | | | | | | | | | | | | | Lots of users are attempting to run systemd within a container. They are being blocked from running SELinux systems since they need the container_manage_cgroup which is not enabled by default. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2278 from rhatdan/varlinkOpenShift Merge Robot2019-02-07
|\ \ | | | | | | Fix handling of memory limits via varlink
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-07 00:28:07 +0000