summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* remote kill: don't wait for the container to stopValentin Rothberg2020-09-09
| | | | | | | | | | Invert the branch logic to match the comment. Docker seems to wait for the container while Podman does not. Enable the remote-disabled system test as well. Fixes: #7135 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6811 from vrothberg/multi-image-archivesOpenShift Merge Robot2020-09-09
|\ | | | | podman load/save: support multi-image docker archive
| * support multi-image (docker) archivesValentin Rothberg2020-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | Support loading and saving tarballs with more than one image. Add a new `/libpod/images/export` endpoint to the rest API to allow for exporting/saving multiple images into an archive. Note that a non-release version of containers/image is vendored. A release version must be vendored before cutting a new Podman release. We force the containers/image version via a replace in the go.mod file; this way go won't try to match the versions. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #7564 from Luap99/remote-subcmds-usageOpenShift Merge Robot2020-09-08
|\ \ | | | | | | Don't setup the Image/ContainerEngine when calling a cmd with subcmds
| * | Don't setup the Image/ContainerEngine when calling a cmd with subcmdsPaul Holzinger2020-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is no need to setup the image and container engine when calling a command with subcommands since we only print a usage message. e.g `podman`,`podman container` This also allows the remote client to show the usage message on these commands without a running endpoint. I added a test for this. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #7552 from ↵OpenShift Merge Robot2020-09-08
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/gomega-1.10.2 Bump github.com/onsi/gomega from 1.10.1 to 1.10.2
| * | | Bump github.com/onsi/gomega from 1.10.1 to 1.10.2Daniel J Walsh2020-09-08
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.10.1 to 1.10.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/gomega/compare/v1.10.1...v1.10.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #7534 from edsantiago/batsOpenShift Merge Robot2020-09-08
|\ \ \ | | | | | | | | Migrate away from docker.io
| * | | Migrate away from docker.ioEd Santiago2020-09-08
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CI and system tests currently pull some images from docker.io. Eliminate that, by: - building a custom image containing much of what we need for testing; and - copying other needed images to quay.io (Reason: effective 2020-11-01 docker.io will limit the number of image pulls). The principal change is to create a new quay.io/libpod/testimage, using the new test/system/build-testimage script, instead of relying on quay.io/libpod/alpine_labels. We also switch to using a hardcoded :YYYYMMDD tag, instead of :latest, in an attempt to futureproof our CI. This image includes 'httpd' from busybox-extras, which we use in our networking test (previously we had to pull and run busybox from docker.io). The testimage can and should be extended as needed for future tests, e.g. adding test file content or other useful tools. For the '--pull' tests which require actually pulling from the registry, I've created an image with the same name but tagged :00000000 so it will never be pulled by default. Since this image is only used minimally, it's just busybox. Unfortunately there remain two cases we cannot solve in this tiny alpine-based image: 1) docker registry 2) systemd For those, I've (manually) run: podman pull [ docker.io/library/registry:2.7 | registry.fedoraproject.org/fedora:31 ] podman tag !$ quay.io/... podman push !$ ...and amended the calling tests accordingly. I've tried to make the the smallest reasonable diff, not the smallest possible one. I hope it's a reasonable tradeoff. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #7538 from edsantiago/cap_test_robustOpenShift Merge Robot2020-09-08
|\ \ \ | |_|/ |/| | Update VM images for new crun; adapt Cap tests to work with new kernel
| * | WIP: update VM imagesEd Santiago2020-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (This is an adoption of #7533 because Brent is on PTO). Pick up new crun and crio-runc. Also: renames from useful fedora-32 and -31 to less-useful names; presumably this is needed by something-something in the new VM setup. Also: tweak two e2e tests to more properly handle a kernel (5.8.4) with a greater set of capabilities than what we or crun can yet handle. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #7559 from lsm5/additional-cross-targetsOpenShift Merge Robot2020-09-08
|\ \ \ | | | | | | | | Makefile: add cross compile targets for more arches
| * | | Makefile: add cross compile targets for more archesLokesh Mandvekar2020-09-08
| | |/ | |/| | | | | | | | | | | | | | | | This commit adds additional targets for which we provide binary packages on fedora and other distros. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #7557 from vrothberg/fix-7384OpenShift Merge Robot2020-09-08
|\ \ \ | |/ / |/| | podman stop: do not cleanup for auto-removal
| * | podman stop: do not cleanup for auto-removalValentin Rothberg2020-09-08
|/ / | | | | | | | | | | | | | | | | | | | | | | Do not perform a container clean up for containers configured for auto-removal (e.g., via `podman run --rm`). There is a small race window with the other process performing the removal where a clean up during podman-stop may fail since the container has already been removed and cleaned up. As the removing process will clean up the container, we don't have to do it during podman-stop. Fixes: #7384 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #7554 from vrothberg/follow-up-on-7444OpenShift Merge Robot2020-09-07
|\ \ | | | | | | make image parent check more robust
| * | make image parent check more robustValentin Rothberg2020-09-07
| | | | | | | | | | | | | | | | | | | | | | | | Follow up on issue #7444 and make the parent checks more robust. We can end up with an incoherent storage when, for instance, a build has been killed. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #7551 from ↵OpenShift Merge Robot2020-09-07
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.14.1 Bump github.com/onsi/ginkgo from 1.14.0 to 1.14.1
| * | | Bump github.com/onsi/ginkgo from 1.14.0 to 1.14.1dependabot-preview[bot]2020-09-07
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.14.0 to 1.14.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.14.0...v1.14.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #7539 from ↵OpenShift Merge Robot2020-09-07
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.23.4 Bump github.com/containers/storage from 1.23.2 to 1.23.4
| * | | Bump github.com/containers/storage from 1.23.2 to 1.23.4dependabot-preview[bot]2020-09-05
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.23.2 to 1.23.4. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.23.2...v1.23.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #7524 from TomSweeneyRedHat/dev/tsweeney/fusemod2OpenShift Merge Robot2020-09-07
|\ \ \ | | | | | | | | [CI:DOCS] Add note on run image fuse problem - try 2
| * | | [CI:DOCS] Add note on run image fuse problem - try 2TomSweeneyRedHat2020-09-04
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We've recently had a number of issues reported against our pre-fabricated images on quay.io and a couple of rhel repositories throwing a fuse error when run: ``` fuse: device not found, try 'modprobe fuse' first ``` The tip on modprobe fuse is not always seen by or displayed to the end user. Adding a couple of doc pointers to hopefully help. Arises from this BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1867892 and several others. Replaces: 7453 where I was going crazy with whitespace and merge issues. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #7540 from QiWang19/system-dfOpenShift Merge Robot2020-09-07
|\ \ \ | | | | | | | | Fix system df inconsistent
| * | | Fix system df inconsistentQi Wang2020-09-04
| |/ / | | | | | | | | | | | | | | | Use RWSzir as system df verbose containers size to remain consistent with the summery. Volume is reclaimable only if not used by container. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Merge pull request #7553 from saschagrunert/apparmor-fixOpenShift Merge Robot2020-09-07
|\ \ \ | |_|/ |/| | Fix unconfined AppArmor profile usage for unsupported systems
| * | Fix unconfined AppArmor profile usage for unsupported systemsSascha Grunert2020-09-07
|/ / | | | | | | | | | | | | | | If we select "unconfined" as AppArmor profile, then we should not error even if the host does not support it at all. This behavior has been fixed and a corresponding e2e test has been added as well. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | Merge pull request #7437 from openSUSE/rmOpenShift Merge Robot2020-09-06
|\ \ | | | | | | Just use `rm` for helper command to remove storage
| * | Just use `rm` for helper command to remove storageSascha Grunert2020-08-28
| | | | | | | | | | | | | | | | | | This allows to use any kind of `rm` in `$PATH` for the system tests. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | Merge pull request #7329 from Luap99/generate-systemd-remoteOpenShift Merge Robot2020-09-05
|\ \ \ | | | | | | | | APIv2 add generate systemd endpoint
| * | | APIv2 add generate systemd endpointPaul Holzinger2020-09-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for generating systemd units via the api and podman-remote. Change the GenerateSystemdReport type to return the units as map[string]string with the unit name as key. Add `--format` flag to `podman generate systemd` to allow the output to be formatted as json. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #7542 from ashley-cui/cimacbuildOpenShift Merge Robot2020-09-05
|\ \ \ \ | |_|_|/ |/| | | [CI:DOCS] Add macos build to ci
| * | | [CI:DOCS] Add macos build to ciAshley Cui2020-09-04
|/ / / | | | | | | | | | | | | | | | Adding a mac build to ci for native builds Signed-off-by: Ashley Cui <acui@redhat.com>
* | | Merge pull request #7532 from rhatdan/runOpenShift Merge Robot2020-09-02
|\ \ \ | | | | | | | | We should not be mounting /run as noexec when run with --systemd
| * | | We should not be mounting /run as noexec when run with --systemdDaniel J Walsh2020-09-02
| |/ / | | | | | | | | | | | | | | | | | | The system defaults /run to "exec" mode, and we default --read-only mounts on /run to "exec", so --systemd should follow suit. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #7422 from ↵OpenShift Merge Robot2020-09-02
|\ \ \ | |/ / |/| | | | | | | | containers/dependabot/go_modules/github.com/gorilla/mux-1.8.0 Bump github.com/gorilla/mux from 1.7.4 to 1.8.0
| * | Bump github.com/gorilla/mux from 1.7.4 to 1.8.0Daniel J Walsh2020-09-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/gorilla/mux](https://github.com/gorilla/mux) from 1.7.4 to 1.8.0. - [Release notes](https://github.com/gorilla/mux/releases) - [Commits](https://github.com/gorilla/mux/compare/v1.7.4...v1.8.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #7519 from jjzmajic/fix/vestigial-mkdirOpenShift Merge Robot2020-09-02
|\ \ \ | | | | | | | | Don't create ~/.config after removing storage.conf
| * | | Don't create ~/.config after removing storage.confjjzmajic2020-09-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #7509. There is no need to create a ~/.config directory now that ~/.config/containers/storage.conf is not created automatically. Podman has no use for it if it does not exist already. Signed-off-by: jjzmajic <uros.m.perisic@gmail.com>
* | | | Merge pull request #7426 from Edward5hen/apiv2-containers-testOpenShift Merge Robot2020-09-02
|\ \ \ \ | |_|/ / |/| | | APIv2 test: add more tests for containers
| * | | APIv2 test: add more tests for containersEdward Shen2020-09-01
| |/ / | | | | | | | | | Signed-off-by: Edward Shen <weshen@redhat.com>
* | | Merge pull request #7528 from mheon/update_master_206_realOpenShift Merge Robot2020-09-02
|\ \ \ | | | | | | | | [CI:DOCS] Update master with release notes for v2.0.6
| * | | Update master with release notes for v2.0.6Matthew Heon2020-09-01
|/ / / | | | | | | | | | | | | | | | Also update README to reflect the new release. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #7517 from baude/crioruncOpenShift Merge Robot2020-09-01
|\ \ \ | | | | | | | | use crio runc on CICID ubuntu
| * | | use crio runc on CICID ubuntuBrent Baude2020-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | when running CICD on Ubuntu where no cgroups v2, we need to use a newer runc for things like seccomp and the default ubuntu runc is not new enough. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #7470 from containers/dependabot/go_modules/k8s.io/api-0.19.0OpenShift Merge Robot2020-09-01
|\ \ \ \ | | | | | | | | | | Bump k8s.io/api from 0.18.8 to 0.19.0
| * | | | Bump k8s.io/api from 0.18.8 to 0.19.0Daniel J Walsh2020-08-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.18.8 to 0.19.0. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.18.8...v0.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #7516 from mheon/handle_no_passwd_fileOpenShift Merge Robot2020-09-01
|\ \ \ \ \ | |_|_|/ / |/| | | | Ensure rootless containers without a passwd can start
| * | | | Ensure rootless containers without a passwd can startMatthew Heon2020-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We want to modify /etc/passwd to add an entry for the user in question, but at the same time we don't want to require the container provide a /etc/passwd (a container with a single, statically linked binary and nothing else is perfectly fine and should be allowed, for example). We could create the passwd file if it does not exist, but if the container doesn't provide one, it's probably better not to make one at all. Gate changes to /etc/passwd behind a stat() of the file in the container returning cleanly. Fixes #7515 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #7514 from edsantiago/reenable_flaky_bindings_testOpenShift Merge Robot2020-08-31
|\ \ \ \ \ | |/ / / / |/| | | | bindings: reenable flaky(?) pause/unpause test