| Commit message (Collapse) | Author | Age |
|
|
|
| |
Signed-off-by: Qi Wang <qiwan@redhat.com>
|
|\
| |
| | |
Fix man page to mention race condition
|
| |
| |
| |
| |
| |
| | |
Also modify man page to talk about podman-container-logs as well as podman-logs.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
|\ \
| | |
| | | |
docs/podman-run.1.md: remove extra whitespace in --read-only
|
| | |
| | |
| | |
| | | |
Signed-off-by: Cleber Rosa <crosa@redhat.com>
|
|\ \ \
| | | |
| | | | |
fix Bug 1688041-podman image save removes existing image
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Qi Wang <qiwan@redhat.com>
|
|\ \ \ \
| |/ / /
|/| | | |
podman: do not split --env on comma
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
if --env "a=b,c" is used, do not split into a=b and c=.
Closes: https://github.com/containers/libpod/issues/2712
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
|\ \ \
| |_|/
|/| | |
Need to pass the true paramater with --syslog in cobra
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| | |
Currently cobra can not handle a boolean option without a vailue.
This change fixes an issue if you want syslog information to show up
based on the cleanup call.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
|\ \
| |/
|/| |
man pages - consistency fixes
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
podman-generate and -play had the wrong NAMEs.
podman-restart and -volume-prune the wrong SYNOPSIS.
All the rest are varying degrees of minor:
- missing a space between the NAME and description
- multi-line SYNOPSIS that could be collapsed into one
- use of UPPER CASE in synopsis instead of *asterisks*
- improper use of **double asterisks** for options
- varlink and version were transposed in podman-1
- fixed inconsistencies between the description in
the man page and that in the parent manpage. These
are too numerous for me to fix all.
Added: script that could be used in CI to prevent future
such inconsistencies. It cannot be enabled yet because
there are still 35+ inconsistencies in need of cleaning.
This will be difficult to review on github. I suggest
pulling the PR and running 'git log -1 -p | cdif | less'
'cdif' is a handy tool for colorizing individual diffs between
lines:
http://kaz-utashiro.github.io/cdif/
There are other such tools; use your favorite. Comparing
without visual highlights may be painful.
I also encourage you to run hack/man-page-checker and suggest
more fixes for the problems it's finding.
Signed-off-by: Ed Santiago <santiago@redhat.com>
|
|\
| |
| | |
Add new key and never-expiring test certificate
|
|/
|
|
|
|
|
|
| |
Former `domain.crt` was created with a one-year life and expired causing
all testing to fail. Create a replacement, along with configuration and
documentation on how to make a new certificate if ever required.
Signed-off-by: Chris Evich <cevich@redhat.com>
|
|\
| |
| | |
Cirrus: Run vendor check in parallel
|
| |
| |
| |
| |
| |
| |
| |
| | |
This task is heavily network bound, and takes way too long to include
along with the gating task. Separate it out and run it in parallel
to everything else. Also add some reasonable timeouts.
Signed-off-by: Chris Evich <cevich@redhat.com>
|
|\ \
| |/
|/| |
Cirrus: Various fixes for rootless testing
|
|/
|
|
|
|
|
|
|
| |
* Randomize the user's UID and GID
* Simplify `setup_environment.sh`
* Support new "-r" option for `hack/get_ci_vm.sh` setting up rootless
* Connect as $ROOTLESS_USER when using "-r" with `hack/get_ci_vm.sh`
Signed-off-by: Chris Evich <cevich@redhat.com>
|
|\
| |
| | |
BATS: new tests, and improvements to existing ones
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
New:
- podman exec
- podman load (requires #2674)
- CLI parsing (regression test for #2574)
Improved:
- help: test "podman NoSuchCommand", and subcommands
- help: test "podman cmd" without required args
- pod: start with --infra=false; this allows running rootless
- log: also run 'logs' after container is run
- log: test -f with two containers
Also, use helpful descriptions for skip_if_rootless
Tested on f29, root and rootless. As soon as podman-remote
supports rm, I'll start testing that too.
Signed-off-by: Ed Santiago <santiago@redhat.com>
|
|\ \
| | |
| | | |
tests: fix rootless tests
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | | |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | |
| | |
| | |
| | |
| | |
| | | |
we don't need to access the storage
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
|/ /
| |
| |
| | |
Signed-off-by: baude <bbaude@redhat.com>
|
|\ \
| | |
| | | |
support GO template {{ json . }}
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
for podman version, we now support a GO template for json output.
fixes #2671
Signed-off-by: baude <bbaude@redhat.com>
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
debarshiray/wip/rishi/podman-inspect-conmon-pid-file
Export ConmonPidFile in 'podman inspect' for containers
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This can help scripts provide a more meaningful message when coming
across issues [1] which require the container to be re-created.
[1] eg., https://github.com/containers/libpod/issues/2673
Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
|
|\ \ \ \
| |_|_|/
|/| | | |
Incorporate image inspect data in play kube
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
before, when an image signified a user, play kube ignored it. Incorporate that information.
Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
|\ \ \ \
| |_|/ /
|/| | | |
podman umount: error out if called with no args
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Inspired by #2684, I wrote a CI test to look for other such
instances in which a command is invoked without a required
argument. 'podman umount' seems to be the only one, and
solution is simple: checkAllAndLatest() already does the
check for us.
Resolve a few other problems uncovered by testing:
podman mount: indicate that CONTAINER arg is optional
podman pod stats: ditto
podman generate kube: remove check for -l (latest) flag,
it isn't actually implemented.
Signed-off-by: Ed Santiago <santiago@redhat.com>
|
|\ \ \ \
| |/ / /
|/| | |
| | | |
| | | | |
debarshiray/wip/rishi/podman-rm-exit-with-125-for-bogus-and-running
Make 'podman rm' exit with 125 if it had a bogus & a running container
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Getting a list of containers, and then deleting them are two separate
fallible steps that can run into different sets of errors. eg., in the
case of a bogus missing container and a container that's running or
paused, the first step will only trigger libpod.ErrNoSuchCtr. At this
point it might appear that the exit code ought to be 1. However, when
attempting the deletion, it will fail once more due to the status of
the running or paused container. Since libpod.ErrNoSuchCtr is no longer
the only error encountered, the exit code should be reset to 125.
This problem is currently masked for rootless usage due to commit
35432ecaae4a8372 ("rootless: fix rm when uid in the container != 0").
Fixes: 85db895012bead6b ("rm: set exit code to 1 if a specified ...")
e41279b902a334e5 ("Change exit code to 1 on podman rm ...")
Signed-off-by: Debarshi Ray <rishi@fedoraproject.org>
|
|\ \ \ \
| | | | |
| | | | | |
Cirrus: Disable master-success IRC notices
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Since `on_failure` notification is working, and IRC activity
is picking up, these messages mostly just get in the way.
Leave the PR-testing success messages in place for now,
since they're helpful when someone's waiting.
Signed-off-by: Chris Evich <cevich@redhat.com>
|
|\ \ \ \ \
| |/ / / /
|/| | | | |
Cleanup messages on podman load
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | | |
If user does not specify file or redirect for stdin, then
throw an error
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
|\ \ \ \
| | | | |
| | | | | |
Cirrus: Update VM Cache images
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Undo short-term slirp4netns workaround (#2660)
Signed-off-by: Chris Evich <cevich@redhat.com>
|
|\ \ \ \ \
| | | | | |
| | | | | | |
Fix cut and paste errors in podman-pod-inspect
|
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Help information and errors should refer to pod inspection, not container and
image inspection.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
|\ \ \ \ \ \
| |_|_|/ / /
|/| | | | | |
podman logs on created container should exit
|