summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* info: add cgroups2Giuseppe Scrivano2019-09-30
| | | | | | Closes: https://github.com/containers/libpod/issues/4080 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #4100 from cevich/cache_image_docsOpenShift Merge Robot2019-09-29
|\ | | | | Cirrus: VM Image accounting doc update
| * Cirrus: VM Image accounting doc updateChris Evich2019-09-24
| | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #4028 from cevich/add_bash_completion_supportOpenShift Merge Robot2019-09-29
|\ \ | | | | | | cirrus: Add bash-completion support
| * | Cirrus: Implement newly built VM imagesChris Evich2019-09-26
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Disable boottime Ubuntu package updateChris Evich2019-09-26
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | cirrus: Add bash-completion supportChris Evich2019-09-26
| | | | | | | | | | | | | | | | | | | | | | | | This is fairly standard thing to have on a user's workstation, supported by podman. When installed in a VM image, then it's useful for debugging with `hack/get_ci_vm.sh` at the cost of a minor increase in disk-space. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #4118 from cevich/fix_sig_proxyOpenShift Merge Robot2019-09-27
|\ \ \ | | | | | | | | Move noCache logic lower in stack
| * | | Move noCache logic lower in stackChris Evich2019-09-26
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One or more tests are not taking advantage of the local image cache. This has been observed to cause a testing flake in at least one `--sigproxy` test which uses `PodmanTestIntegration.PodmanPID()`. It has a rather short timeout of 15-seconds, which isn't always enough time to pull down a remote image. Fix this by reloacing the `noCache` logic from `PodmanTest.PodmanAsUserBase()` down the stack into `PodmanTestIntegration.makeOptions()`. This also eliminates the need to also check if a remote-client is being used - since it uses a different function. Also reverse the parameter order in `PodmanTest.PodmanBase` so that everywhere is consistently `noEvents` then `noCache`. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #4065 from mheon/unconditional_conmon_rmOpenShift Merge Robot2019-09-27
|\ \ \ | | | | | | | | Unconditionally remove conmon files before starting
| * | | Unconditionally remove conmon files before startingMatthew Heon2019-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We've been seeing a lot of issues (ref: #4061, but there are others) where Podman hiccups on trying to start a container, because some temporary files have been retained and Conmon will not overwrite them. If we're calling start() we can safely assume that we really want those files gone so the container starts without error, so invoke the cleanup routine. It's relatively cheap (four file removes) so it shouldn't hurt us that much. Also contains a small simplification to the removeConmonFiles logic - we don't need to stat-then-remove when ignoring ENOENT is fine. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #4126 from nalind/makefile-typoOpenShift Merge Robot2019-09-27
|\ \ \ \ | | | | | | | | | | Add a missing escape in the Makefile
| * | | | Add a missing escape in the MakefileNalin Dahyabhai2019-09-26
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | | | Merge pull request #4121 from jwhonce/issue/4021OpenShift Merge Robot2019-09-27
|\ \ \ \ \ | | | | | | | | | | | | Change ginkgo Wait() to Eventually() test
| * | | | | Change ginkgo Wait() to Eventually() testJhon Honce2019-09-26
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changing the test in WaitWithDefaultTimeout() to use Eventually() and gexec.Exit(). Using ExitCode() before command has really exited returns a -1, which can cause issues for tests testing for podman to return non-zero values. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #4127 from nalind/reexec-useOpenShift Merge Robot2019-09-27
|\ \ \ \ \ | | | | | | | | | | | | Correct use of reexec.Init()
| * | | | | Correct use of reexec.Init()Nalin Dahyabhai2019-09-26
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A true result from reexec.Init() isn't an error, but it indicates that main() should exit with a success exit status. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | | | Merge pull request #4124 from mheon/set_log_level_earlyOpenShift Merge Robot2019-09-27
|\ \ \ \ \ | | | | | | | | | | | | Set log-level immediately, before rootless setup
| * | | | | Set log-level immediately, before rootless setupMatthew Heon2019-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If we don't do this, we print WARN level messages that we should not be printing by default. Up one WARN message to ERROR so it still shows up by default. Fixes: #4115 Fixes: #4012 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #4116 from TomSweeneyRedHat/dev/tsweeney/fixtutreadmeOpenShift Merge Robot2019-09-27
|\ \ \ \ \ \ | | | | | | | | | | | | | | Make links relative in Tutorial README
| * | | | | | Make links relative in Tutorial READMETomSweeneyRedHat2019-09-26
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the longer html link in favor or relative links which are shorter and less error prone. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | | | Merge pull request #4120 from mheon/secresponseOpenShift Merge Robot2019-09-27
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add README note about security reporting process.
| * | | | | | Add README note about security reporting process.Matthew Heon2019-09-26
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | Merge pull request #3879 from cevich/zip_to_msiOpenShift Merge Robot2019-09-27
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Automate production of MSI release files
| * | | | | Cirrus: Upload windows MSI release fileChris Evich2019-09-24
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | Merge pull request #4117 from mheon/pod_no_nameOpenShift Merge Robot2019-09-26
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Add an error for pods without a name
| * | | | | Add an error for pods without a nameMatthew Heon2019-09-26
| | |_|_|/ | |/| | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #4109 from cgwalters/doc-custom-projectOpenShift Merge Robot2019-09-26
|\ \ \ \ \ | | | | | | | | | | | | docs/podman-derivative-api.md: New file
| * | | | | docs/podman-derivative-api.md: New fileColin Walters2019-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/debarshiray/toolbox/ was planning to vendor libpod which I disagreed with. Let's document the advantages/disadvantages as they exist today. Signed-off-by: Colin Walters <walters@verbum.org>
* | | | | | Merge pull request #4101 from QiWang19/nonexistdirOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | fix cp none exists dest path ends with '/'
| * | | | | fix cp none exists dest path ends with '/'Qi Wang2019-09-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | close #3894 This patch let podman cp return 'no such file or directory' error if DEST_PATH does not exist and ends with / when copying file. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | | Merge pull request #4104 from mheon/bump-1.6.0-rc2OpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Bump to 1.6.0-rc2
| * | | | | Bump gitvalidation epochMatthew Heon2019-09-24
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | | Bump to v1.6.0-devMatthew Heon2019-09-24
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | | Bump to v1.6.0-rc2v1.6.0-rc2Matthew Heon2019-09-24
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #4106 from vrothberg/fedoraOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Dockerfile.fedora: install packages to build catatonit
| * | | | | Dockerfile.fedora: install packages to build catatonitValentin Rothberg2019-09-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Needed to update the CI images for #4090. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #4036 from vrothberg/update-readmeOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | | | | | | | | | | | | | | Update readme
| * | | | | | README: add Communications sectionValentin Rothberg2019-09-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a `Communications` section to the README to make it more approachable for new users who want to reach the community and maintainers. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | | | | drop OWNERS link for CONTRIBUTING.mdValentin Rothberg2019-09-25
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was pointing to K8s docs and didn't really fit into the communications context. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #4091 from dylanpinn/patch-1OpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Update mac_client link in podman tutorial
| * | | | | Update mac_client linkDylan Pinn2019-09-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I fixed the mac_client tutorial link as it was returning a 404 error. Signed-off-by: Dylan Pinn <me@dylanpinn.com>
* | | | | | Merge pull request #4102 from baude/remotestdinOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | | | | | | | | | | | | | | conditionally send stdin on remote run
| * | | | | | conditionally send stdin on remote runbaude2019-09-24
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when running a container remotely, we should only be sending stdin when running with --interactive; otherwise use nil. Fixes: #4095 Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #4073 from cevich/move_ci_unit_testOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ | | | | | | | | | | | | | | Cirrus: Fail early on CI script unit test
| * | | | | | Cirrus: Fail early on CI script unit testChris Evich2019-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of running this basic checks for almost all tasks, just do them once at the beginning. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | | Merge pull request #4088 from baude/varlinkbuildoutputOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Document the required varlink build args
| * | | | | | | Document the required varlink build argsbaude2019-09-24
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The API document incorrectly documented the wrong varlink build arguments. The output attribute is required. Fixes: #3204 Signed-off-by: baude <bbaude@redhat.com>
* | | | | | | Merge pull request #4086 from mheon/cni_del_on_refreshOpenShift Merge Robot2019-09-25
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Force a CNI Delete on refreshing containers
| * | | | | | | Force a CNI Delete on refreshing containersMatthew Heon2019-09-24
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CNI expects that a DELETE be run before re-creating container networks. If a reboot occurs quickly enough that containers can't stop and clean up, that DELETE never happens, and Podman currently wipes the old network info and thinks the state has been entirely cleared. Unfortunately, that may not be the case on the CNI side. Some things - like IP address reservations - may not have been cleared. To solve this, manually re-run CNI Delete on refresh. If the container has already been deleted this seems harmless. If not, it should clear lingering state. Fixes: #3759 Signed-off-by: Matthew Heon <matthew.heon@pm.me>