summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #5515 from edsantiago/ci_sundry_small_fixesOpenShift Merge Robot2020-03-16
|\ | | | | Four small CI fixes:
| * Four small CI fixes:Ed Santiago2020-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) 'podman system info' (in logcollector): has been silently failing in special_testing_rootless, with: logcollector.sh: line 16: podman: command not found Use ./bin/podman instead of just podman; this is probably the right thing to do in the general case anyway 2) logformatter: highlight 'panic:', seen in bindings test: https://storage.googleapis.com/cirrus-ci-5385732420009984-fcae48/artifacts/containers/libpod/6693715108429824/html/integration_test.log.html 3) logformatter: handle Unicode bullet in front of 'Running', seen in bindings test. 4) logformatter: turn down contrast on BATS 'ok' results, for legibility Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #5490 from containers/dependabot/go_modules/k8s.io/api-0.17.4OpenShift Merge Robot2020-03-16
|\ \ | | | | | | Bump k8s.io/api from 0.17.3 to 0.17.4
| * | Bump k8s.io/api from 0.17.3 to 0.17.4dependabot-preview[bot]2020-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.17.3 to 0.17.4. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.17.3...v0.17.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5489 from ↵OpenShift Merge Robot2020-03-16
|\ \ \ | |_|/ |/| | | | | | | | containers/dependabot/go_modules/github.com/containers/common-0.5.0 Bump github.com/containers/common from 0.4.2 to 0.5.0
| * | Bump github.com/containers/common from 0.4.2 to 0.5.0dependabot-preview[bot]2020-03-13
| |/ | | | | | | | | | | | | | | | | Bumps [github.com/containers/common](https://github.com/containers/common) from 0.4.2 to 0.5.0. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.4.2...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5514 from vrothberg/fix-ciEd Santiago2020-03-16
|\ \ | | | | | | fix systemd generate tests
| * | fix systemd generate testsValentin Rothberg2020-03-16
|/ / | | | | | | | | | | Add the `default.target` to the failing tests. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5439 from ttys3/fixup-systemdgen-with-new-paramOpenShift Merge Robot2020-03-16
|\ \ | | | | | | systemd generator: force run container detached if CreateCommand has no detach param
| * | force run container detached if container CreateCommand missing the detach param荒野無燈2020-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the podman generated systemd service file has `Type=forking` service, so the command after `ExecStart=` should not run in front. if someone created a container and has the detach(`-d`) param missing like this ``` podman create --name ngxdemo -P nginxdemos/hello ``` and generate the file with `--new` param: ``` podman generate systemd --name --new ngxdemo ``` because `podman run xxx` has no `-d` param, so the container is not run in background and nerver exit. and systemd will fail to start the service: ``` sudo systemctl start container-ngxdemo.service Job for container-ngxdemo.service failed because a timeout was exceeded. See "systemctl status container-ngxdemo.service" and "journalctl -xe" for details. ``` Signed-off-by: 荒野無燈 <ttys3@outlook.com>
* | | Merge pull request #5252 from QiWang19/not-reset-tempdirOpenShift Merge Robot2020-03-16
|\ \ \ | | | | | | | | Fix bug podman reset to not remove $XDG_RUNTIME_DIR
| * | | Fix bug podman reset to not remove $XDG_RUNTIME_DIRQi Wang2020-03-05
| | | | | | | | | | | | | | | | | | | | | | | | In some older systems we point the temporary directory to /run/user/1000 which leads podman system reset to clear unrelated files under XDG_RUNTIME_DIR. This patch only removes files created by podman if TmpDir is the same as the XDG_RUNTIME_DIR. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #5505 from tonybenoy/tony_typoOpenShift Merge Robot2020-03-16
|\ \ \ \ | | | | | | | | | | Missing double quotes in troubleshooting guide.
| * | | | Missing double quotes in troubleshooting guide.Tony Benoy2020-03-15
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Tony Benoy <me@tonybenoy.com>
* | | | | Merge pull request #5476 from edsantiago/run_rmi_test_fixOpenShift Merge Robot2020-03-16
|\ \ \ \ \ | | | | | | | | | | | | run --rmi test: make it work
| * | | | | run --rmi test: make it workEd Santiago2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The recently-added 'run --rmi' test was not actually doing what it thinks it was doing: for one, 'run_podman | grep' is never going to work; also, the test was leaving behind stray images. Rework to do what I believe the intention was; and, combine into one test (down from two) for readability. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #5508 from baude/buildaddarchosOpenShift Merge Robot2020-03-16
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | add os|arch attributes when building
| * | | | | add os|arch attributes when buildingBrent Baude2020-03-15
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when building images, we can now add the os and arch of the image using overrides from the commandline. the commandline options set sane defaults so we use those as well. Fixes: #5503 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5496 from baude/preemptiveOpenShift Merge Robot2020-03-14
|\ \ \ \ \ | | | | | | | | | | | | eat signal 23 in signal proxy
| * | | | | eat signal 23 in signal proxyBrent Baude2020-03-13
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | due to a change in golang-1.14 and it's changes to make go funcs with tight loops preemptive, signals are now getting "through" that never were before. From the golang-1.14 announce: Goroutines are now asynchronously preemptible. As a result, loops without function calls no longer potentially deadlock the scheduler or significantly delay garbage collection. This is supported on all platforms except windows/arm, darwin/arm, js/wasm, and plan9/*. A consequence of the implementation of preemption is that on Unix systems, including Linux and macOS systems, programs built with Go 1.14 will receive more signals than programs built with earlier releases. This means that programs that use packages like syscall or golang.org/x/sys/unix will see more slow system calls fail with EINTR errors. Those programs will have to handle those errors in some way, most likely looping to try the system call again. For more information about this see man 7 signal for Linux systems or similar documentation for other systems. Fixes #5483 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5491 from ↵OpenShift Merge Robot2020-03-14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/fsnotify/fsnotify-1.4.9 Bump github.com/fsnotify/fsnotify from 1.4.7 to 1.4.9
| * | | | | Bump github.com/fsnotify/fsnotify from 1.4.7 to 1.4.9dependabot-preview[bot]2020-03-13
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.4.7 to 1.4.9. - [Release notes](https://github.com/fsnotify/fsnotify/releases) - [Changelog](https://github.com/fsnotify/fsnotify/blob/master/CHANGELOG.md) - [Commits](https://github.com/fsnotify/fsnotify/compare/v1.4.7...v1.4.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #5327 from baude/apiv2hcOpenShift Merge Robot2020-03-13
|\ \ \ \ \ | |/ / / / |/| | | | add apiv2 healthcheck code
| * | | | add apiv2 healthcheck codeBrent Baude2020-03-13
|/ / / / | | | | | | | | | | | | | | | | | | | | reworking binding and endpoint to actually work. added documentation in swagger for and various return code possibilities. add a good start on tests though we need some other container functions not yet implemented for that. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5470 from ↵OpenShift Merge Robot2020-03-12
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.16.3 Bump github.com/containers/storage from 1.16.2 to 1.16.3
| * | | | Bump github.com/containers/storage from 1.16.2 to 1.16.3dependabot-preview[bot]2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.16.2 to 1.16.3. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.16.2...v1.16.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #5484 from baude/bindingsnocolorOpenShift Merge Robot2020-03-12
|\ \ \ \ \ | | | | | | | | | | | | turn off color-mode for bindings
| * | | | | turn off color-mode for bindingsBrent Baude2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the binding ginkgo tests were using color mode which throws in a bunch of ansi garbage that makes it hard to read the logs Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #5482 from baude/removeimagefilterOpenShift Merge Robot2020-03-12
|\ \ \ \ \ \ | |/ / / / / |/| | | | | remove imagefilter for varlink remote client
| * | | | | remove imagefilter for varlink remote clientBrent Baude2020-03-12
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | the api for getting images changed to use filters but back level podman versions cannot handle it. so temporarily disabling the filtering for remote clients until the restful approach can be used. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5474 from giuseppe/detect-containers-rootlessport-child-exitOpenShift Merge Robot2020-03-12
|\ \ \ \ \ | | | | | | | | | | | | rootlessport: detect rootless-child exit
| * | | | | rootlessport: detect rootless-child exitGiuseppe Scrivano2020-03-12
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | otherwise the rootless parent process might wait indefinitely when the rootless-child process exits early. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #5469 from giuseppe/no-size-create-containerOpenShift Merge Robot2020-03-12
|\ \ \ \ \ | |_|/ / / |/| | | | create: do not calculate image size
| * | | | create: do not calculate image sizeGiuseppe Scrivano2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | calculating the image size can be an expensive operation. Avoid doing it when creating a new container since the size is not needed. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #5468 from Akasurde/5244_follow_upOpenShift Merge Robot2020-03-12
|\ \ \ \ \ | |_|/ / / |/| | | | Follow up change from #5244
| * | | | Follow up changes from #5244Abhijeet Kasurde2020-03-12
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Code review change suggested by jwhonce in https://github.com/containers/libpod/pull/5244#pullrequestreview-366574431 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
* | | | Merge pull request #5458 from baude/apiv2eventslibpodOpenShift Merge Robot2020-03-11
|\ \ \ \ | | | | | | | | | | [CI:DOCS]Add libpod event endpoint
| * | | | [CI:DOCS]Add libpod event endpointBrent Baude2020-03-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | add an endpoint for events on the libpod side of the house. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5460 from edsantiago/man_page_xrefOpenShift Merge Robot2020-03-11
|\ \ \ \ \ | | | | | | | | | | | | man page cross-reference fixes: part 2
| * | | | | man page cross-reference fixes: part 2Ed Santiago2020-03-11
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The other direction: fix or clean up elements documented in man pages but which did/do not exist in actual podman: * runlabel: add missing "-n" alias for --name And, remove man page entries for nonexistent options: * podman commit: --iidfile * podman container runlabel: --rootfs, --storage * podman create: --cpu-count There are two problems I don't know how to deal with. Both are related to main_local.go:rootCmd.PersistentFlags() : 1) podman-build.1.md documents --cni-config-dir and --runtime options, but these are not actually options under podman build; they are global options. The documentation in this man page differs from that under podman-build. 2) podman ps implements a binary --namespace option, but this option does not (cannot?) appear in --help because there's a global --namespace string option and Cobra somehow gets confused about this. Do we really intend for global options to be parsed on the right-hand side of subcommands? This strikes me as unintuitive and potentially confusing, although the fact that it has taken me this long to discover it suggests that it's not _that_ confusing. Suggestions welcome. I can file issues for 1/2 above, or simply teach my script to special-case ignore them. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #5372 from sujil02/podstatusOpenShift Merge Robot2020-03-11
|\ \ \ \ \ | | | | | | | | | | | | Update start stop api to use pod status function.
| * | | | | Update start stop api to use pod status function.Sujil022020-03-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the strat and stop api to validate pod status based on status functions rather than iterating over all the containers in the pod. (Addressing the TO-DO) Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | | | Merge pull request #5459 from mheon/bump_readme_181OpenShift Merge Robot2020-03-11
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Update version in README to v1.8.1
| * | | | | | Update version in README to v1.8.1Matthew Heon2020-03-11
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | Merge pull request #5457 from mheon/bump-1.8.1OpenShift Merge Robot2020-03-11
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | [CI:DOCS]Bump to v1.8.1
| * | | | | Bump to v1.8.2-devMatthew Heon2020-03-11
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | | | Bump to v1.8.1v1.8.1Matthew Heon2020-03-11
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #5453 from edsantiago/man_page_xrefOpenShift Merge Robot2020-03-10
|\ \ \ \ \ | | | | | | | | | | | | man pages: fix inconsistencies
| * | | | | man pages: fix inconsistenciesEd Santiago2020-03-10
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I wrote a script to cross-reference podman --help against man pages. It found a bunch of inconsistencies fix them: * options missing from man pages * options misspelled or misformatted in man pages (usually misplaced asterisks or missing dashes, but see --dns-opt) * one spurious comma in the actual source file --help This is a fix in which I iterate over 'podman CMD --help' and check for presence in man pages. The other way around (look for flags in man pages, check podman CMD --help) is probably impossible: there are too many special cases Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #5402 from vrothberg/syslogOpenShift Merge Robot2020-03-10
|\ \ \ \ \ | | | | | | | | | | | | docs: clarify bools in `podman --help`