summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* image: rework parent/child/history matchingNalin Dahyabhai2019-04-25
| | | | | | | | Rework our expectations of how images that are derived from each other look, so that we don't assume that an image that's derived from a base image always adds layers relative to that base image. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* images: add context to GetParent/IsParent/Remove/Prune...Nalin Dahyabhai2019-04-25
| | | | | | | Add a context.Context parameter to Image.GetParent(), Image.IsParent(), Image.GetChildren(), Image.Remove(), and Runtime.PruneImages(). Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* Merge pull request #2973 from baude/remoterestartOpenShift Merge Robot2019-04-24
|\ | | | | podman remote-client restart containers
| * podman remote-client restart containersbaude2019-04-24
| | | | | | | | | | | | add the ability to restart containers with the remote-client Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #3002 from vrothberg/fix-pullingOpenShift Merge Robot2019-04-24
|\ \ | | | | | | pull: special case all-tags semantics
| * | pull: special case all-tags semanticsValentin Rothberg2019-04-24
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Supporting the all-tags semantics added some non-trivial code to the pull command which does not make use of `registries.conf` and introduced some regressions such as not adhering to the configured search registries. Speacial case the all-tags flags to let existing users of all-tags continue working while others can work again. This implies that the all-tags pull does not adhere to configured search registries while the default (non-all-tags) pull does. Note that this is a purely symptomaic fix. A final solution should include Buildah and the c/image library to avoid redundant and error-prone code across the projects. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1701922 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #2994 from mheon/fix_podman_stop_allOpenShift Merge Robot2019-04-24
|\ \ | |/ |/| Fix podman stop --all attempting to stop created ctrs
| * Fix test compileMatthew Heon2019-04-24
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Trim whitespace from ps -q before comparingMatthew Heon2019-04-24
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Enhance tests for stop to check resultsMatthew Heon2019-04-24
| | | | | | | | | | | | | | | | | | None of the stop tests actually verified that containers were in a stopped state after they finished. We shouldn't take a 0 exit code to indicate that things worked - verify that ps shows no running containers. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Add extra CI tests for stopping all containersMatthew Heon2019-04-24
| | | | | | | | | | | | | | We weren't testing cases where not all containers were running when stop --all ran. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Fix podman stop --all attempting to stop created ctrsMatthew Heon2019-04-24
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #3003 from cevich/temp_selinux_workaroundOpenShift Merge Robot2019-04-24
|\ | | | | Cirrus: Temp. override container-selinux on F29
| * Cirrus: Temp. override container-selinux on F29Chris Evich2019-04-24
|/ | | | | | Also, undo oooooold runc package hack Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #2919 from rhatdan/infra_commandOpenShift Merge Robot2019-04-22
|\ | | | | Internal names do not match external names
| * Internal names do not match external namesDaniel J Walsh2019-04-18
| | | | | | | | | | | | | | | | | | | | We refer to the pause_image and pause_container in the libpod.conf description, but internally we had infra_image and infra_container. This means it the user made changes to the conf, it would not effect the actual tool using libpod. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2933 from haircommander/kube-cleanOpenShift Merge Robot2019-04-22
|\ \ | | | | | | Clean up after play kube failure
| * | Add header to play kube outputPeter Hunt2019-04-18
| | | | | | | | | | | | Signed-off-by: Peter Hunt <pehunt@redhat.com>
| * | Clean up after play kube failurePeter Hunt2019-04-18
| | | | | | | | | | | | | | | | | | | | | Before, we would half create a pod in play kube and error out if we fail. Rather, let's clean up after our failure so the user doesn't have to delete the pod themselves. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | Merge pull request #2970 from jwhonce/wip/remote_pod_pruneOpenShift Merge Robot2019-04-19
|\ \ \ | | | | | | | | Refactor of 'podman prune' to better support remote
| * | | Refactor of 'podman prune' to better support remoteJhon Honce2019-04-18
|/ / / | | | | | | | | | | | | | | | | | | | | | * Push iterations into the service not the client * Add e2e tests * Refactor to use new frameworks Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #2948 from baude/remotepauseOpenShift Merge Robot2019-04-18
|\ \ \ | |_|/ |/| | podman-remote pause|unpause
| * | podman-remote pause|unpausebaude2019-04-18
| | | | | | | | | | | | | | | | | | | | | | | | Add the ability to pause and unpause containers with the remote client. Also turned on the pause tests! Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2967 from giuseppe/fix-rootless-closeOpenShift Merge Robot2019-04-18
|\ \ \ | | | | | | | | rootless: not close more FDs than needed
| * | | rootless: not close more FDs than neededGiuseppe Scrivano2019-04-18
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we were previously closing as many FDs as they were open when we first started Podman in the range (3-MAX-FD). This would cause issues if there were empty intervals, as these FDs are later on used by the Golang runtime. Store exactly what FDs were first open in a fd_set, so that we can close exactly the FDs that were open at startup. Closes: https://github.com/containers/libpod/issues/2964 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2952 from rhatdan/changeOpenShift Merge Robot2019-04-18
|\ \ \ | | | | | | | | Fix podman command --change CMD
| * | | Fix podman command --change CMDDaniel J Walsh2019-04-17
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently in Docker if you commit with --change 'CMD a b c' The command that gets added is [/bin/sh -c "a b c"] If you commit --change 'CMD ["a","b","c"]' You get [a b c] This patch set makes podman match this behaviour. Similar change required for Entrypoint. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2965 from baude/fixcoprOpenShift Merge Robot2019-04-18
|\ \ \ | |/ / |/| | Fix COPR builds to start working again
| * | Fix COPR builds to start working againbaude2019-04-17
|/ / | | | | | | | | | | We now need systemd in the root of the COPR build for podman. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2917 from baude/remotestartOpenShift Merge Robot2019-04-17
|\ \ | | | | | | podman-remote start
| * | podman-remote startbaude2019-04-17
| | | | | | | | | | | | | | | | | | | | | enable the ability to start containers from the remote-client. also, enable start integration tests for remote testing. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2936 from haircommander/pod-pruneOpenShift Merge Robot2019-04-17
|\ \ \ | |_|/ |/| | Add podman pod prune
| * | Added remote pod prunePeter Hunt2019-04-16
| | | | | | | | | | | | Signed-off-by: Peter Hunt <pehunt@redhat.com>
| * | Add podman pod prunePeter Hunt2019-04-16
| | | | | | | | | | | | | | | | | | | | | podman system prune would leave pods be, and not prune them if they were stopped. Fix this by adding a `podman pod prune` command that prunes stopped pods similarly to containers. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | Merge pull request #2931 from TomSweeneyRedHat/dev/tsweeney/venbuildahOpenShift Merge Robot2019-04-17
|\ \ \ | |_|/ |/| | Vendor in latest Buildah
| * | Vendor in latest BuildahTomSweeneyRedHat2019-04-16
|/ / | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #2949 from baude/remotecontainercommandsOpenShift Merge Robot2019-04-16
|\ \ | |/ |/| podman-remote container commands
| * podman-remote container commandsbaude2019-04-16
| | | | | | | | | | | | | | Several container commands were ported to the remote client but had not been updated on the container submenu yet. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2934 from haircommander/kube-fileOpenShift Merge Robot2019-04-16
|\ \ | |/ |/| Add File mounts to play kube
| * Add File mounts to play kubePeter Hunt2019-04-15
| | | | | | | | | | | | Both File and FileOrCreate options are supported. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | Merge pull request #2946 from baude/segsOpenShift Merge Robot2019-04-16
|\ \ | | | | | | Fix segfaults attribute to missing options
| * | Fix segfaults attribute to missing optionsbaude2019-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | In cases where the remote client culls options to a command, we need to be sure that the lookup for that flag does not result in a nil pointer. To do so, we add a Remote attribute to the podman struct and then cli helper funcs are now aware they are remote. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2944 from mheon/fix_renumberOpenShift Merge Robot2019-04-15
|\ \ \ | | | | | | | | Call the runtime with WithRenumber() when asked by 'system renumber' command
| * | | Call the runtime with WithRenumber() when askedMatthew Heon2019-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We must have lost this at some point, rendering system renumber useless. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #2870 from rhatdan/changeOpenShift Merge Robot2019-04-15
|\ \ \ \ | | | | | | | | | | Validate ENV/LABEL Change options in varlink
| * | | | Validate ENV/LABEL Change options in varlinkDaniel J Walsh2019-04-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you pass in an invalid CHANGE ENV or LABEL option without the "=" character podman crashes. I see that there were other problems with the handling of commit --change handling. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #2939 from giuseppe/rootless-fixesOpenShift Merge Robot2019-04-15
|\ \ \ \ \ | |_|_|/ / |/| | | | rootless: cleanups
| * | | | cmd, pkg: drop commented codeGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | pod: drop dead codeGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we always create a user namespace now, so no need to check if we are running as non root. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | rootless, mount: not create namespaceGiuseppe Scrivano2019-04-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we need to check if we are able to mount the container as part of the mount command itself. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>