summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #12490 from jwhonce/issues/10974-3OpenShift Merge Robot2021-12-06
|\ | | | | Refactor podman pods to report.Formatter
| * Refactor podman pods to report.FormatterJhon Honce2021-12-06
| | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Support better compatibility output for podman pods commands See #10974 Depends on containers/common#831 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #12522 from edsantiago/minor_test_cleanupOpenShift Merge Robot2021-12-06
|\ \ | | | | | | tests: clean up FIXMEs and noise
| * | tests: clean up FIXMEs and noiseEd Santiago2021-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e2e tests: * remove two FIXMEs: * one of them is expected behavior, not a FIXME * the other is easily fixed * File issue #12521 for a real podman-remote bug, and update the Skip() message system tests: * in command-completion test, clean up stray podman-pause image (followup to #12322, in which I missed this instance). This removes distracting warnings from test logs. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #12516 from ↵OpenShift Merge Robot2021-12-06
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.3 Bump github.com/opencontainers/runc from 1.0.2 to 1.0.3
| * | | Bump github.com/opencontainers/runc from 1.0.2 to 1.0.3dependabot[bot]2021-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.2 to 1.0.3. - [Release notes](https://github.com/opencontainers/runc/releases) - [Commits](https://github.com/opencontainers/runc/compare/v1.0.2...v1.0.3) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #12519 from vrothberg/fix-9597OpenShift Merge Robot2021-12-06
|\ \ \ \ | |_|_|/ |/| | | fix remote run/start flake
| * | | fix remote run/start flakeValentin Rothberg2021-12-06
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the flake reported in #9597 with a workaround to at least stop wasting energy until the root cause has been found and fixed. It seems that a remote run returns before the container has transitioned into the `exited` state which ultimately breaks a subsequent remote start with attach. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #12518 from vrothberg/fix-12167OpenShift Merge Robot2021-12-06
|\ \ \ | |/ / |/| | e2e: fix pprof flakes
| * | e2e: fix pprof flakesValentin Rothberg2021-12-06
|/ / | | | | | | | | | | | | | | | | Give the services some more time after SIGINT to shutdown. `Eventually(session, 5)` will poll the session for the specific condition at a frequency of 10ms for at most 5 seconds. Fixes: #12167 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #12487 from jwhonce/issues/10974-2OpenShift Merge Robot2021-12-06
|\ \ | |/ |/| Refactor podman system to report.Formatter
| * Refactor podman system to report.FormatterJhon Honce2021-12-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Support better compatibility output for podman system commands * Format and content of output from podman version changed to be more compatible See #10974 Depends on containers/common#831 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #12514 from vrothberg/vendor-commonOpenShift Merge Robot2021-12-06
|\ \ | | | | | | vendor c/common@main
| * | vendor c/common@mainValentin Rothberg2021-12-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | Update the `--filter reference=...` tests to reflect recent changes in c/common. The reference values now match as specified without implicitly adding wildcards arounds. Fixes: #11905 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #12511 from n1hility/fix-win-pathOpenShift Merge Robot2021-12-06
|\ \ \ | |/ / |/| | Fixes #11416 - Trailing quote on PATH added by Windows MSI
| * | Escape trailing slash in install directory location so the closing quote is ↵Jason T. Greene2021-12-05
|/ / | | | | | | | | | | | | | | not escaped Fixes #11416 [NO NEW TESTS NEEDED] Signed-off-by: Jason Greene <jason.greene@redhat.com>
* | Merge pull request #12500 from lsm5/auto-copr3OpenShift Merge Robot2021-12-04
|\ \ | | | | | | centos 9 stream cannot use %autochangelog
| * | centos 9 stream cannot use %autochangelogLokesh Mandvekar2021-12-03
|/ / | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | Merge pull request #12491 from lsm5/auto-coprOpenShift Merge Robot2021-12-03
|\ \ | | | | | | add spec file for automated copr builds
| * | add spec file for automated copr buildsLokesh Mandvekar2021-12-03
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit along with an upstream webhook will automatically build an rpm at `rhcontainerbot/podman-next` . RPM NVR will be of the form: podman-4-$DATESTAMP.$TIMESTAMP The date and time stamps will reflect the date and time at which they were built in the COPR env which shouldn't lag the PR merge date by a lot. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | Merge pull request #12466 from ↵OpenShift Merge Robot2021-12-03
|\ \ | |/ |/| | | | | dispensable/respect_pod_yaml_spec_hostname_when_play Hostname in `spec.hostname` should be passed to infra ctr init opt
| * Hostname in `spec.hostname` should be passed to infra ctr init optwangqiang2021-12-01
| | | | | | | | | | | | Fixes https://github.com/containers/podman/issues/12393 Signed-off-by: Qiang Wang <sunsetmask@gmail.com>
* | Merge pull request #12489 from mtrmac/save-me-from-repetitionOpenShift Merge Robot2021-12-03
|\ \ | | | | | | Improve documentation of (podman image save)
| * | Fix documentation of (podman image save --compress --uncompressed)Miloslav Trmač2021-12-02
| | | | | | | | | | | | Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Improve documentation of (podman image save --format)Miloslav Trmač2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | - Don't pointlessly repeat the names - Improve documentation of the formats - Use a table, per MANPAGE_SYNTAX.md Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | | Merge pull request #12440 from umohnani8/cmOpenShift Merge Robot2021-12-03
|\ \ \ | | | | | | | | Add support for configmap volumes to play kube
| * | | Add support for configmap volumes to play kubeUrvashi Mohnani2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the k8s yaml has volumes from a configmap, play kube will now create a volume based on the data from the configmap and volume source and set it to the right path in the container accordingly. Add tests for this and update some test for ENV from configmap. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | | | Merge pull request #12360 from rhatdan/VENDOROpenShift Merge Robot2021-12-03
|\ \ \ \ | | | | | | | | | | Bump storage
| * | | | UPdate vendor of image-spec and containers/storageDaniel J Walsh2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should get rid of the nasty warning on the github site. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #12484 from machacekondra/restartSecOpenShift Merge Robot2021-12-03
|\ \ \ \ \ | | | | | | | | | | | | Add restart-sec option to systemd generate command
| * | | | | Add restart-sec option to systemd generateOndra Machacek2021-12-03
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Ondra Machacek <omachace@redhat.com>
* | | | | | Merge pull request #12486 from giuseppe/use-configured-compression-formatOpenShift Merge Robot2021-12-03
|\ \ \ \ \ \ | |/ / / / / |/| | | | | cmd, push: use the configured compression format
| * | | | | cmd, push: use the configured compression formatGiuseppe Scrivano2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] I am just changing the default value Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | | vendor: update containers/commonGiuseppe Scrivano2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #12488 from edsantiago/logformatter_fixesOpenShift Merge Robot2021-12-03
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] logformatter: fix corner case with links
| * | | | | | [CI:DOCS] logformatter: fix corner case with linksEd Santiago2021-12-02
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A test name beginning with non-alpha, e.g., "--build should ...", was not being recognized and linkified: https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/6500723916537856/html/int-podman-fedora-34-rootless-host.log.html Fix that. Also fix two other cases (single/double quotes) that were resulting in weird unreliable links. While I'm at it, add a few usability enhancements: * Colorize [SKIPPING] and [SLOW TEST] * Deemphasize '[It] testname' when it appears mid-test * Replace 'Running:' with a (deemphasized) '#' or '$' prompt Add regression tests Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #12483 from vrothberg/fix-12468OpenShift Merge Robot2021-12-02
|\ \ \ \ \ \ | |/ / / / / |/| | | | | compat API: push: report size of manifest
| * | | | | compat API: push: report size of manifestDaniel J Walsh2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't yet have a local registry running in the APIv2 tests. Tested manually. [NO NEW TESTS NEEDED] Fixes: https://github.com/containers/podman/issues/12468 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #12482 from edsantiago/e2e_haveOpenShift Merge Robot2021-12-02
|\ \ \ \ \ \ | | | | | | | | | | | | | | e2e tests: use HaveKey() and HaveLen() when possible
| * | | | | | Manual fixesEd Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a handful of instances not covered by earlier automated replacements. Found via: ack 'Expect\(len' test/e2e There are still a bunch of BeNumerically(">", ...) that cannot (yet) be handled by HaveLen(). Leave those as they are. Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | Same thing, with BeNumerically("==", x)Ed Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sed -i -e 's/Expect(len(\(.*\)))\.To(BeNumerically("==", \(.*\)))/Expect(\1).To(HaveLen(\2))/' test/e2e/*.go Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | Use HaveLen(x) instead of Expect(len(y)).To(Equal(x))Ed Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sed -i -e 's/Expect(len(\(.*\)))\.To(Equal(\(.*\)))/Expect(\1).To(HaveLen(\2))/' test/e2e/*.go Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | Same thing, for BeNumerically("==", 0)Ed Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sed -i -e 's/Expect(len(\(.*\)))\.To(BeNumerically("==", 0))/Expect(\1).To(BeEmpty())/' test/e2e/*.go Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | Use BeEmpty() instead of len(x).To(Equal(0))Ed Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sed -i -e 's/Expect(len(\(.*\)))\.To(Equal(0))/Expect(\1).To(BeEmpty())/' test/e2e/*.go Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | Same as previous, for assertions other than Equal()Ed Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sed -i -e 's/Expect(\(.*\)\[\(\".*\"\)\])\.To(\(.*\)/Expect(\1).To(HaveKeyWithValue(\2, \3)/' test/e2e/*_test.go Signed-off-by: Ed Santiago <santiago@redhat.com>
| * | | | | | e2e tests: a little more minor cleanupEd Santiago2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | sed -i -e 's/Expect(\(.*\)\[\(\".*\"\)\])\.To(Equal(/Expect(\1).To(HaveKeyWithValue(\2, /' test/e2e/*_test.go ...with two manual tweaks, because this converted: Expect(foo["bar"]).To(Equal("")) -> Expect(foo).To(HaveKeyWithValue("bar","")) It looks like the intention of the test was, instead: ...To(Not(HaveKey("bar"))) Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #12445 from wilbeibi/mainOpenShift Merge Robot2021-12-02
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [CI:DOCS] Update doc to explictly mention using ed25519 in ssh keys
| * | | | | | | Update doc to explictly mention using ed25519 in ssh keysHongyi Shen2021-12-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Hongyi Shen <wilbeibi@gmail.com>
* | | | | | | | Merge pull request #12365 from mtrmac/randomOpenShift Merge Robot2021-12-02
|\ \ \ \ \ \ \ \ | |_|_|_|_|/ / / |/| | | | | | | Don't use a global RNG, and avoid conflicts, when generating NodePorts
| * | | | | | | Ensure the generated NodePort values are uniqueMiloslav Trmač2021-11-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... at least within a single service. [NO NEW TESTS NEEDED] because testing RNGs is problematic. (We _could_ probably inject a mock RNG implementation that always returns the same value, or something like that.) Signed-off-by: Miloslav Trmač <mitr@redhat.com>