summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Revamp Libpod state strings for Docker compatMatthew Heon2022-01-17
| | | | | | | | | | | | | | | | | | | | | | | | Improve our compatibility with Docker by better handling the state strings that we print in `podman ps`. Docker capitalizes all states in `ps` (we do not) - fix this in our PS code. Also, stop normalizing ContainerStateConfigured to the "Created" state, and instead make it always be Created, with the existing Created state becoming Initialized. I didn't rename the actual states because I'm somewhat reticent to make such a large change a day before we leave for break. It's somewhat confusing that ContainerStateConfigured now returns Created, but internally and externally we're still consistent. [NO NEW TESTS NEEDED] existing tests should catch anything that broke. I also consider this a breaking change. I will flag appropriately on Github. Fixes RHBZ#2010432 and RHBZ#2032561 Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #12860 from rhatdan/cgroupsOpenShift Merge Robot2022-01-17
|\ | | | | Use CONTAINERS_CONF cgroups flag for remote API.
| * Fix cgroup mode handling in api serverDaniel J Walsh2022-01-14
| | | | | | | | | | | | | | | | | | Also change code to globably be consistent when refering to capatilized Cgroup. Fixed: https://github.com/containers/podman/issues/12550 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Standardize on capatalized CgroupsDaniel J Walsh2022-01-14
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #12882 from jmguzik/unify-filters-cmdOpenShift Merge Robot2022-01-17
|\ \ | | | | | | Unify the method of parsing filters in cmd
| * | Unify the method of parsing filters in cmdJakub Guzik2022-01-16
| | | | | | | | | | | | | | | | | | | | | | | | This commit unifies the method of filters parsing in cmd. It removes also the function redundancy. [NO NEW TESTS NEEDED] Signed-off-by: Jakub Guzik <jguzik@redhat.com>
* | | Merge pull request #12880 from ↵OpenShift Merge Robot2022-01-17
|\ \ \ | | | | | | | | | | | | | | | | eriksjolund/replace_master_branch_links_with_main_branch_links_in_docs [CI:DOCS] fix default branch links
| * | | [CI:DOCS] fix default branch linksErik Sjölund2022-01-15
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | * Replace https://github.com/containers/podman/blob/master with https://github.com/containers/podman/blob/main to match the new default branch "main". Previously the default branch was "master". The substitutions were made in the documentation but not the code. Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | Merge pull request #12881 from ↵OpenShift Merge Robot2022-01-17
|\ \ \ | | | | | | | | | | | | | | | | eriksjolund/replace_master_branch_links_with_main_branch_links_in_code fix default branch links
| * | | fix default branch linksErik Sjölund2022-01-15
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Replace https://github.com/containers/podman/blob/master with https://github.com/containers/podman/blob/main to match the new default branch "main". Previously the default branch was "master". This is the only occurence found in the code. * Replace https://raw.githubusercontent.com/containers/libpod/master with https://raw.githubusercontent.com/containers/podman/main Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | Merge pull request #12876 from ↵OpenShift Merge Robot2022-01-16
|\ \ \ | | | | | | | | | | | | | | | | eriksjolund/fix_doc_rootless_md_native_overlayfs_support [CI:DOCS] Unprivileged native overlayfs is now supported
| * | | [CI:DOCS] Unprivileged native overlayfs is now supportedErik Sjölund2022-01-15
| | | | | | | | | | | | | | | | Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #12868 from lsm5/copr-fixOpenShift Merge Robot2022-01-16
|\ \ \ \ | |_|/ / |/| | | Add rpkg template for COPR autobuild
| * | | Add rpkg template for COPR autobuildLokesh Mandvekar2022-01-14
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This commit removes .autocopr/podman.spec in favor of podman.spec.rpkg to account for new recommendations for COPR builds. The build process now enables debug packages and also uses `%gobuild` instead of `make` or `go build` to get the packages as close as possible to Fedora koji builds. https://lists.fedoraproject.org/archives/list/copr-devel@lists.fedorahosted.org/message/3JORYRKDWFMJSR35Z4LIKDEXH2T5263H/ [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #12572 from rhatdan/imageOpenShift Merge Robot2022-01-15
|\ \ \ | | | | | | | | Remove two GetImages functions from API
| * | | Remove two GetImages functions from APIDaniel J Walsh2022-01-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] This is just code cleanup. The remote API has three different GetImages functions, which I believe can be handled by just one function. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #12861 from aklajnert/recursively_copy_certsOpenShift Merge Robot2022-01-15
|\ \ \ \ | | | | | | | | | | ignition: recursively copy cert files
| * | | | Recursively copy cert files.Andrzej Klajnert2022-01-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Andrzej Klajnert <github@aklajnert.pl>
* | | | | Merge pull request #12527 from jwhonce/wip/manifest4OpenShift Merge Robot2022-01-15
|\ \ \ \ \ | | | | | | | | | | | | Refactor manifest list operations
| * | | | | Refactor manifest list operationsJhon Honce2022-01-14
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update method/function signatures use the manifest list name and images associated with the operation explicitly, in general func f(ctx context.Context, manifestListName string, ImageNames []string, options *fOptions) * Leverage gorilla/mux Subrouters to support API v3.x and v4.x for manifests * Make manifest API endpoints more RESTful * Add PUT /manifest/{id} to update existing manifests * Add manifests.Annotate to go bindings, uncommented unit test * Add DELETE /manifest/{Id} to remove existing manifest list, use PUT /manifest/{id} to remove images from a list * Deprecated POST /manifest/{id}/add and /manifest/{id}/remove, use PUT /manifest/{id} instead * Corrected swagger godoc and updated to cover API changes * Update podman manifest commands to use registry.Context() * Expose utils.GetVar() to obtain query parameters by name * Unexpose server.registerSwaggerHandlers, not sure why this was ever exposed. * Refactored code to use http.Header instead of map[string]string when operating on HTTP headers. * Add API-Version header support in bindings to allow calling explicate versions of the API. Header is _NOT_ forwarded to the API service. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #12875 from eriksjolund/fix_typo_env_podman_runOpenShift Merge Robot2022-01-15
|\ \ \ \ \ | |_|_|_|/ |/| | | | [CI:DOCS] Fix typo in --env
| * | | | [CI:DOCS] Fix typo in --envErik Sjölund2022-01-15
|/ / / / | | | | | | | | | | | | Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #12858 from rhatdan/hostsOpenShift Merge Robot2022-01-14
|\ \ \ \ | |/ / / |/| | | test/system: podman run update /etc/hosts
| * | | test/system: podman run update /etc/hostsDaniel J Walsh2022-01-14
| | |/ | |/| | | | | | | | | | | | | | | | This test case is used for covering rhbz#1902979. Signed-off-by: Alex Jia <ajia@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #12856 from fredr/issue-template/fix-linksOpenShift Merge Robot2022-01-14
|\ \ \ | | | | | | | | [CI:DOCS] troubleshooting links to main branch
| * | | troubleshooting links to main branchfredr2022-01-14
| | | | | | | | | | | | | | | | Signed-off-by: fredr <fredrik@enestad.com>
* | | | Merge pull request #12825 from elezar/update-cdiOpenShift Merge Robot2022-01-14
|\ \ \ \ | |_|/ / |/| | | Update use of CDI API
| * | | Use fully-qualified device name in CDI testEvan Lezar2022-01-14
| | | | | | | | | | | | | | | | Signed-off-by: Evan Lezar <elezar@nvidia.com>
| * | | Use new CDI APIEvan Lezar2022-01-14
| |/ / | | | | | | | | | | | | | | | | | | This change updates the CDI API to commit 46367ec063fda9da931d050b308ccd768e824364 which addresses some inconistencies in the previous implementation. Signed-off-by: Evan Lezar <elezar@nvidia.com>
* | | Merge pull request #12853 from cdoern/buildRelativeOpenShift Merge Robot2022-01-14
|\ \ \ | | | | | | | | Podman Build use absolute filepath
| * | | Podman Build use absolute filepathcdoern2022-01-13
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | podman build always finds the abs path but was never using it for the containerfile path. This was causing the remote client to be given a relative path that does not exist. Switch to evaluating and using absolute paths only. resolves #12841 Signed-off-by: cdoern <cdoern@redhat.com>
* | | Merge pull request #12849 from cdoern/podProhibitOpenShift Merge Robot2022-01-14
|\ \ \ | |/ / |/| | Prohibit --uid/gid map and --pod for container create/run
| * | Prohibit --uid/gid map and --pod for container create/runcdoern2022-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | add a check in namespaceOptions() that ensures the user is not setting a new uid/gid map if entering or creating a pod that has an infra container resolves #12669 Signed-off-by: cdoern <cdoern@redhat.com>
* | | Merge pull request #12828 from giuseppe/drop-checkOpenShift Merge Robot2022-01-13
|\ \ \ | | | | | | | | libpod: drop check for empty pod cgroup
| * | | libpod: refine check for empty pod cgroupGiuseppe Scrivano2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rootless containers do not use cgroups on cgroupv1 or if using cgroupfs, so improve the check to account for such configuration. Closes: https://github.com/containers/podman/issues/10800 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2028243 [NO NEW TESTS NEEDED] it requires rebooting and the rundir on a non tmpfs file system. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #12826 from vrothberg/force-rm-podOpenShift Merge Robot2022-01-13
|\ \ \ \ | | | | | | | | | | podman container rm: remove pod
| * | | | podman container rm: remove podValentin Rothberg2022-01-13
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Support removing the entire pod when --depend is used on an infra container. --all now implies --depend to properly support removing all containers and not error out when hitting infra containers. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #12642 from Luap99/libnetworkOpenShift Merge Robot2022-01-13
|\ \ \ \ | |/ / / |/| | | use libnetwork from c/common
| * | | Manual fixes for PR #12642:Ed Santiago2022-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip a bunch more podman-remote tests. Filed an issue for one of them (#12838), the others may not be fixable. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | podman build enable --all-platforms and --unsetenvPaul Holzinger2022-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we add support for allplatforms and unsetenv to both local and remote podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | fix buildah-bud test diffPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | upgrade test: check that network backend is cniPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we test an update from an older version we should check the the network backend is correctly set to CNI. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | use netns package from c/commonPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The netns package was moved to c/common so we should use this and remove the package from podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | update buildah to latest and use new network stackPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | Make sure buildah uses the new network stack. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | use libnetwork from c/commonPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The libpod/network packages were moved to c/common so that buildah can use it as well. To prevent duplication use it in podman as well and remove it from here. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #12836 from cdoern/podSysCtlOpenShift Merge Robot2022-01-13
|\ \ \ \ | |_|_|/ |/| | | Podman Pod Create --sysctl support
| * | | Podman Pod Create --sysctl supportcdoern2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | added support for pod wide sysctls. The sysctls supported are the same as the continer run controls. These controls are only valid if the proper namespaces are shared within the pod, otherwise only the infra ctr gets the sysctl resolves #12747 Signed-off-by: cdoern <cdoern@redhat.com>
* | | | Merge pull request #12837 from rhatdan/eventsOpenShift Merge Robot2022-01-13
|\ \ \ \ | | | | | | | | | | use events_logfile_path from containers.conf for events log.
| * | | | use events_logfile_path from containers.conf for events log.Daniel J Walsh2022-01-13
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #12644 from leahneukirchen/events-timestampOpenShift Merge Robot2022-01-13
|\ \ \ \ \ | |/ / / / |/| | | | remote events: convert TimeNano properly