summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* man pages: fix inconsistenciesEd Santiago2020-03-10
| | | | | | | | | | | | | | | | | I wrote a script to cross-reference podman --help against man pages. It found a bunch of inconsistencies fix them: * options missing from man pages * options misspelled or misformatted in man pages (usually misplaced asterisks or missing dashes, but see --dns-opt) * one spurious comma in the actual source file --help This is a fix in which I iterate over 'podman CMD --help' and check for presence in man pages. The other way around (look for flags in man pages, check podman CMD --help) is probably impossible: there are too many special cases Signed-off-by: Ed Santiago <santiago@redhat.com>
* Merge pull request #5402 from vrothberg/syslogOpenShift Merge Robot2020-03-10
|\ | | | | docs: clarify bools in `podman --help`
| * hide --trace flagValentin Rothberg2020-03-10
| | | | | | | | | | | | The tracing flag is not really something users should worry about. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * podman --help: mention defaults of boolsValentin Rothberg2020-03-10
| | | | | | | | | | | | | | | | | | While string variables are shown to expect a string argument, boolean variables are not. This easily tricks users into believing they are simple switches without arguments. Hence, explicitly mention the default to clarify it a bit more. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * docs: clarify that --syslog expects an argumentValentin Rothberg2020-03-10
| | | | | | | | | | | | | | Clarify in the man page that --syslog expexts an argument to prevent users from believing it's a switch. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5450 from baude/armOpenShift Merge Robot2020-03-10
|\ \ | | | | | | build for amd64|arm|ppc64le
| * | build for amd64|arm|ppc64leBrent Baude2020-03-10
| | | | | | | | | | | | | | | | | | to protect against architecture specific build regressions, we cross compile for multiple architectures Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5452 from mheon/release_notes_181OpenShift Merge Robot2020-03-10
|\ \ \ | | | | | | | | [CI:DOCS] Update release notes for v1.8.1 final release
| * | | Update release notes for v1.8.1 final releaseMatthew Heon2020-03-10
|/ / / | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #5448 from vrothberg/update-systemdOpenShift Merge Robot2020-03-10
|\ \ \ | |/ / |/| | update systemd & dbus dependencies
| * | update systemd & dbus dependenciesValentin Rothberg2020-03-10
| |/ | | | | | | | | | | | | | | Update the outdated systemd and dbus dependencies which are now provided as go modules. This will further tighten our dependencies and releases and pave the way for the upcoming auto-update feature. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5432 from jwhonce/wip/compat_refactorOpenShift Merge Robot2020-03-10
|\ \ | | | | | | Refactor handler packages
| * | Refactor handler packagesJhon Honce2020-03-10
|/ / | | | | | | | | | | | | To help with packaging, the handlers in pkg/api/handlers are now found in pkg/api/handler/compat. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #5437 from coandco/runlabel_set_doc_updateOpenShift Merge Robot2020-03-10
|\ \ | | | | | | Remove nonexistent --set arg from runlabel documentation
| * | Remove nonexistent --set arg from runlabel documentationClint Olson2020-03-10
| |/ | | | | | | Signed-off-by: Clint Olson <clint@populi.co>
* | Merge pull request #5353 from cpanato/GH-4414OpenShift Merge Robot2020-03-10
|\ \ | | | | | | commands: rename file and add likns to readthedocs
| * | commands: rename file and add likns to readthedocsCarlos Panato2020-03-09
| | | | | | | | | | | | Signed-off-by: Carlos Panato <ctadeu@gmail.com>
* | | Merge pull request #5435 from mheon/bump-1.8.1-rc4OpenShift Merge Robot2020-03-10
|\ \ \ | |_|/ |/| | [CI:DOCS] Bump to v1.8.1-RC4
| * | Bump to v1.8.1-devMatthew Heon2020-03-09
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump to v1.8.1-rc4v1.8.1-rc4Matthew Heon2020-03-09
|/ / | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5307 from QiWang19/security-opt-genkubeOpenShift Merge Robot2020-03-09
|\ \ | | | | | | fix security-opt generate kube
| * | fix security-opt generate kubeQi Wang2020-03-03
| | | | | | | | | | | | | | | | | | | | | fix #4950 add selinux options from --security-opt of the container to generate kube result Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | Merge pull request #5426 from ↵OpenShift Merge Robot2020-03-09
|\ \ \ | |_|/ |/| | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.16.2 Bump github.com/containers/storage from 1.16.1 to 1.16.2
| * | Bump github.com/containers/storage from 1.16.1 to 1.16.2dependabot-preview[bot]2020-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.16.1 to 1.16.2. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.16.1...v1.16.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5429 from mheon/revert_exec_changesMatthew Heon2020-03-09
|\ \ \ | | | | | | | | Revert exec changes
| * | | Revert "exec: get the exit code from sync pipe instead of file"Matthew Heon2020-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4b72f9e4013411208751df2a92ab9f322d4da5b2. Continues what began with revert of d3d97a25e8c87cf741b2e24ac01ef84962137106 in previous commit. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | Revert "Exec: use ErrorConmonRead"Matthew Heon2020-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit d3d97a25e8c87cf741b2e24ac01ef84962137106. This does not resolve the issues we expected it would, and has some unexpected side effects with the upcoming exec rework. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | Revert "exec: fix error code when conmon fails"Matthew Heon2020-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4632b81c81a73025a960e339f40bc805f8a6c70a. We are reverting #5373 as well, which lays the foundation for this commit, so it has to go as well. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #5427 from containers/systemd-defaultMatthew Heon2020-03-09
|\ \ \ \ | |/ / / |/| | | generate systemd: add `default.target` to INSTALL
| * | | rootles tutorial: remove systemd unit exampleValentin Rothberg2020-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The example was not entirely correct. Users should use `podman generate systemd` and use the output either directly or as a template for further adjustments to their needs. Keeping an example in the rootless tutorial is a maintenance burdon and can easily suggest incorrect usage patterns to users. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | generate systemd: add `default.target` to INSTALLValentin Rothberg2020-03-09
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When enabling a systemd service we can specify which target will start it by specifying it in the `[INSTALL]` section. In case of root, this is commonly set to `multi-user.target` which is used to start other essential system services such as the network manager, D-BUS and more. However, the `multi-user.target` is not enough on all systems, especially when running rootless and enabling user services. Multiple users have reported issues that there isn't even an attempt to start the service. Setting the INSTALL target to `default.target` will fix the rootless case. However, `default.target` may vary among systems. Fedora Workstation, for instance, sets the `default.target` to the graphical target (i.e., runlevel 5) while Fedora Server sets it to `multi-user.target` which is on runlevel 2 and hence way earlier in the startup sequence. As INSTALL allows for specifying multiple INSTALL targets, we can set it to `multi-user.target` to continue supporting existing workloads AND to `default.target` which MAY redundantly attempt to start it at a later point; effectively a NOP for the root case and essential for rootless. Fixes: #5423 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5424 from vrothberg/homeOpenShift Merge Robot2020-03-09
|\ \ \ | |/ / |/| | use c/storage instead of docker/docker
| * | use storage/pkg/ioutilsValentin Rothberg2020-03-09
| | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | use storage/pkg/homedirValentin Rothberg2020-03-09
|/ / | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5412 from rhatdan/tmpdirOpenShift Merge Robot2020-03-08
|\ \ | | | | | | Allow users to set TMPDIR environment
| * | Allow users to set TMPDIR environmentDaniel J Walsh2020-03-06
| | | | | | | | | | | | | | | | | | | | | Some users have small /var/tmp directories and need to be able to specify a different location for temporary files, which includes more space. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5395 from cevich/fix_fedora_minimalOpenShift Merge Robot2020-03-08
|\ \ \ | | | | | | | | Cirrus: Fix fedora-minimal mirroring
| * | | Cirrus: Fix fedora-minimal mirroringChris Evich2020-03-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Builds of this dockerfile fail on quay.io due to not being able to pull the base image. Use a fully-qualified FROM name to work around this. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #5407 from rhatdan/codespellOpenShift Merge Robot2020-03-07
|\ \ \ \ | | | | | | | | | | Fix spelling mistakes in code found by codespell
| * | | | Fix spelling mistakes in code found by codespellDaniel J Walsh2020-03-07
|/ / / / | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #5374 from baude/createOpenShift Merge Robot2020-03-07
|\ \ \ \ | | | | | | | | | | add default network for apiv2 create
| * | | | add default network for apiv2 createBrent Baude2020-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | during container creation, if no network is provided, we need to add a default value so the container can be later started. use apiv2 container creation for RunTopContainer instead of an exec to the system podman. RunTopContainer now also returns the container id and an error. added a libpod commit endpoint. also, changed the use of the connections and bindings slightly to make it more convenient to write tests. Fixes: 5366 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #5359 from TomSweeneyRedHat/dev/tsweeney/fixquayOpenShift Merge Robot2020-03-07
|\ \ \ \ \ | | | | | | | | | | | | Fix upstream dockerfile and add 'by hand' ctrfile
| * | | | | Fix upstream dockerfile and add 'by hand' ctrfileTomSweeneyRedHat2020-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The podmanimage/upstream/Dockerfile had two rpms in its build procedure that are no longer available. The atomic-registries has been removed and the md2man has been renamed. In addtion conmon was not being installed and I've added that. I've been using a Containerfile to build or rebuild a specific version of the podmanimage stored in the stable repository with a version tag. As the other Containerfiles have been updated by others, and in case anyone else needs to build it, I've added it to the repo and have also updated the readme.md. FWIW, the builds in the quay.io/podman/upstream have been failing for a while due to missing rpms. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | | | Merge pull request #5417 from mheon/bump-1.8.1-rc3OpenShift Merge Robot2020-03-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Bump to v1.8.1-RC3
| * | | | | | Bump to v1.8.1-devMatthew Heon2020-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | | | Bump to v1.8.1-rc3v1.8.1-rc3Matthew Heon2020-03-06
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #5410 from st1971/api-fixesOpenShift Merge Robot2020-03-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | APIv2: compatible api fixes
| * | | | | | Removed extraneous comments and defaults plus amended variable declarationSteve Taylor2020-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Steve Taylor <steven@taylormuff.co.uk>
| * | | | | | Removed the unnecessary codeSteve Taylor2020-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | removed defaulting of query.Size amended types.LibpodToContainer, removed hard coded true from inspect call Signed-off-by: Steve Taylor <steven@taylormuff.co.uk>