summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* image prune: remove unused images only with `--all`Valentin Rothberg2021-05-17
| | | | | | | | | | | | | | | | | | Fix a regression in `podman image prune` where unused images were accidentally removed even when `--all=false`. Extend and partially rewrite the e2e tests to make sure we're not regressing again in the future. Fixing the aforementioned issue revealed another issue in the default prune filter. While prune should remove all "dangling" images (i.e., those without tag), it removed only "intermediate" ones; dangling images without children. Remove the mistaken comment from the libimage migration. Also clarify the help message and man page. Fixes: #10350 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10357 from srcshelton/patch-1OpenShift Merge Robot2021-05-17
|\ | | | | Update to actions/stale@v3
| * Use more recent `stale` release...Stuart Shelton2021-05-16
|/ | | | | | … as currently with `v1`, `remove-stale-when-updated` is set but isn't causing labels to be updated when comments are added. Signed-off-by: Stuart Shelton <stuart@shelton.me>
* Merge pull request #10346 from Luap99/network-docOpenShift Merge Robot2021-05-16
|\ | | | | [CI:DOCS] network tutorial: update with rootless cni changes
| * network tutorial: update with rootless cni changesPaul Holzinger2021-05-15
|/ | | | | | | | Starting with podman v3.2 rootless cni will work without the rootless-cni-infra container. Update the network tutorial to reflect the latest changes and mention that the infra container can be removed. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* Merge pull request #10332 from TomSweeneyRedHat/dev/tsweeney/fixintroOpenShift Merge Robot2021-05-15
|\ | | | | [CI:DOCS] Update first line in intro page
| * [CI:DOCS] Update first line in intro pageTomSweeneyRedHat2021-05-14
|/ | | | | | | | | Remove the word `consumption` and give a better description for the first line of the introduction page. Fixes: #10325 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* Merge pull request #10341 from vrothberg/auto-update-pruneOpenShift Merge Robot2021-05-14
|\ | | | | auto-update service: prune images
| * auto-update service: prune imagesValentin Rothberg2021-05-14
| | | | | | | | | | | | | | | | | | | | | | | | | | Extend the systemd auto-update service to prune images after an update has run. As reported by a user [1], auto updates can over time cause the disk to run out of space. With Edge being a target use case, we need to make sure that systems can run without much supervision, so let's make sure to run `podman image prune` to clean up dangling images. [1] https://twitter.com/r_isc_y/status/1388981737011793921 Fixes: #10190 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #10343 from cevich/update_vm_imagesOpenShift Merge Robot2021-05-14
|\ \ | | | | | | Use updated VM images + updated automation tooling
| * | Use updated VM images + updated automation toolingChris Evich2021-05-14
|/ / | | | | | | | | | | | | | | | | Both the `containers/automation` and `containers/automation_images` have been updated with a default 'main' branch, renamed from 'master`. These images include adjusted tooling in addition to a refresh of all packages. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #10254 from jmguzik/prune-filter-cliOpenShift Merge Robot2021-05-14
|\ \ | |/ |/| Add support for cli network prune --filter flag
| * Add support for cli network prune --filter flagJakub Guzik2021-05-12
| | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
| * Move filter parsing to common utilsJakub Guzik2021-05-12
| | | | | | | | Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* | Merge pull request #10331 from redhat-et/vendorOpenShift Merge Robot2021-05-14
|\ \ | | | | | | Update go.sum
| * | make vendorIvan Font2021-05-13
|/ / | | | | | | Signed-off-by: Ivan Font <ifont@redhat.com>
* | Merge pull request #10316 from ↵OpenShift Merge Robot2021-05-12
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.30.3 Bump github.com/containers/storage from 1.30.2 to 1.30.3
| * | Bump github.com/containers/storage from 1.30.2 to 1.30.3dependabot[bot]2021-05-12
| |/ | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.30.2 to 1.30.3. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.30.2...v1.30.3) Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #10294 from Luap99/system-upgrade-testsOpenShift Merge Robot2021-05-12
|\ \ | | | | | | fix system upgrade tests
| * | fix system upgrade testsPaul Holzinger2021-05-12
| |/ | | | | | | | | | | Fix many FIXMEs in the upgrade tests. Also add a basic test for pods. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | Merge pull request #10300 from jwhonce/issues/10289OpenShift Merge Robot2021-05-12
|\ \ | | | | | | Add host.serviceIsRemote to podman info results
| * | Add host.serviceIsRemote to podman info resultsJhon Honce2021-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Developers asked for a deterministic field to verify if podman is running via API or linked directly to libpod library. $ podman info --format '{{.Host.ServiceIsRemote}}' false $ podman-remote info --format '{{.Host.ServiceIsRemote}}' true $ podman --remote info --format '{{.Host.ServiceIsRemote}}' true * docs/conf.py formatted via black Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #10239 from alvistack/master-linux-amd64OpenShift Merge Robot2021-05-12
|\ \ \ | | | | | | | | Update nix pin with `make nixpkgs`
| * | | Update nix pin with `make nixpkgs`Wong Hoi Sing Edison2021-05-12
| | |/ | |/| | | | | | | Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
* | | Merge pull request #10313 from edsantiago/batsOpenShift Merge Robot2021-05-12
|\ \ \ | | | | | | | | [CI:DOCS] hack/bats - new helper for running system tests
| * | | [CI:DOCS] hack/bats - new helper for running system testsEd Santiago2021-05-11
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Well, new to you. It's been something I've used for years. Simple, but it takes care of a lot of housekeeping, and makes it ever-so-much-more pleasant to invoke bats tests. And when it's easier to run tests, tests get run. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #10324 from containers/uncompressingOpenShift Merge Robot2021-05-12
|\ \ \ | | | | | | | | [NO TESTS NEEDED] Print "extracting" only on compressed file
| * | | Print "extracting" only on compressed fileAshley Cui2021-05-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We should only print "extracting compressed file" when the file is actually compressed Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #10222 from vrothberg/image-treeOpenShift Merge Robot2021-05-12
|\ \ \ \ | | | | | | | | | | podman image tree: restore previous behavior
| * | | | podman image tree: restore previous behaviorValentin Rothberg2021-05-12
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The initial version of libimage changed the order of layers which has now been restored to remain backwards compatible. Further changes: * Fix a bug in the journald logging which requires to strip trailing new lines from the message. The system tests did not pass due to empty new lines. Triggered by changing the default logger to journald in containers/common. * Fix another bug in the journald logging which embedded the container ID inside the message rather than the specifid field. That surfaced in a preceeding whitespace of each log line which broke the system tests. * Alter the system tests to make sure that the k8s-file and the journald logging drivers are executed. * A number of e2e tests have been changed to force the k8s-file driver to make them pass when running inside a root container. * Increase the timeout in a kill test which seems to take longer now. Reasons are unknown. Tests passed earlier and no signal-related changes happend. It may be CI VM flake since some system tests but other flaked. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #10318 from Luap99/fix-network-testOpenShift Merge Robot2021-05-12
|\ \ \ \ | | | | | | | | | | fix network restart always test
| * | | | fix network restart always testPaul Holzinger2021-05-12
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | The added test in 30544f225e73 is flaking. Podman inspect is always working so we have to check the pid instead. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #10317 from Luap99/fix-log-driverOpenShift Merge Robot2021-05-12
|\ \ \ \ | |/ / / |/| | | fix incorrect log driver in podman container image
| * | | fix incorrect log driver in podman container imagePaul Holzinger2021-05-12
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Commit 7f2c27d43fc5 added an invalid value for the log_driver in the containers.conf file inside the podman image. Fixes #10312 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #10310 from Luap99/restart-slirpOpenShift Merge Robot2021-05-11
|\ \ \ | | | | | | | | fix restart always with slirp4netns
| * | | fix restart always with slirp4netnsPaul Holzinger2021-05-11
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a container is automatically restarted due its restart policy and the container used the slirp4netns netmode, the slirp4netns process died. This caused the container to lose network connectivity. To fix this we have to start a new slirp4netns process. Fixes #8047 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #10304 from ↵OpenShift Merge Robot2021-05-11
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/opencontainers/runc-1.0.0-rc94 Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94
| * | | Bump github.com/opencontainers/runc from 1.0.0-rc93 to 1.0.0-rc94dependabot[bot]2021-05-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.0.0-rc93 to 1.0.0-rc94. - [Release notes](https://github.com/opencontainers/runc/releases) - [Commits](https://github.com/opencontainers/runc/compare/v1.0.0-rc93...v1.0.0-rc94) Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #10303 from ↵OpenShift Merge Robot2021-05-11
|\ \ \ \ | |/ / / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/coreos/go-systemd/v22-22.3.2 Bump github.com/coreos/go-systemd/v22 from 22.3.1 to 22.3.2
| * | | Bump github.com/coreos/go-systemd/v22 from 22.3.1 to 22.3.2dependabot[bot]2021-05-11
|/ / / | | | | | | | | | | | | | | | | | | Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.3.1 to 22.3.2. - [Release notes](https://github.com/coreos/go-systemd/releases) - [Commits](https://github.com/coreos/go-systemd/compare/v22.3.1...v22.3.2) Signed-off-by: dependabot[bot] <support@github.com>
* | | Merge pull request #10271 from matejvasek/fix-wait-next-exitOpenShift Merge Robot2021-05-10
|\ \ \ | | | | | | | | fix: improved "containers/{name}/wait" endpoint
| * | | fix: improved "containers/{name}/wait" endpointMatej Vasek2021-05-10
| |/ / | | | | | | | | | | | | | | | | | | | | | Using event API to detect changes to container instead of polling. Polling was unreliable, sometime change of a state might have been missed. Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | Merge pull request #10291 from edsantiago/remove_obsolete_skipsOpenShift Merge Robot2021-05-10
|\ \ \ | |_|/ |/| | Remove obsolete skips
| * | Remove obsolete skipsEd Santiago2021-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The following bugs seem to be fixed: * #6510 (e2e tests) - podman rmi gives "layer not known" * #9915 (buildah-bud tests) - podman build --arch * #10248 - spurious warning from first-ever invocation of rootless podman Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #10295 from jwhonce/issues/10154OpenShift Merge Robot2021-05-10
|\ \ \ | | | | | | | | Add client disconnect check to build handler loop
| * | | Add client disconnect to build handler loopJhon Honce2021-05-10
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] In process of debugging added request channel check and logging message to build loop. Unable to recreate build drop issue after this. 68k build iterations without fail. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #10236 from Luap99/generate-systemd-envOpenShift Merge Robot2021-05-10
|\ \ \ | | | | | | | | Add envars to the generated systemd unit
| * | | Add envars to the generated systemd unitPaul Holzinger2021-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The with --new generated systemd unit loses the environment variables when the create command only contains the key without the value. Since podman tries to lookup those values from the environment the unit can fail. This commits ensures that we will add the environment variables to the unit file when this is the case. The container environment variables are looked up in the container spec. Fixes #10101 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #10292 from rhatdan/buildahOpenShift Merge Robot2021-05-10
|\ \ \ \ | |_|/ / |/| | | Fix podman-remote build --rm=false ...
| * | | Fix podman-remote build --rm=false ...Daniel J Walsh2021-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/9869 [NO TESTS NEEDED] Since the podman-remote buildah tests will test this, and this is clearly correct. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>