summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Wire network interface into libpodPaul Holzinger2021-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make use of the new network interface in libpod. This commit contains several breaking changes: - podman network create only outputs the new network name and not file path. - podman network ls shows the network driver instead of the cni version and plugins. - podman network inspect outputs the new network struct and not the cni conflist. - The bindings and libpod api endpoints have been changed to use the new network structure. The container network status is stored in a new field in the state. The status should be received with the new `c.getNetworkStatus`. This will migrate the old status to the new format. Therefore old containers should contine to work correctly in all cases even when network connect/ disconnect is used. New features: - podman network reload keeps the ip and mac for more than one network. - podman container restore keeps the ip and mac for more than one network. - The network create compat endpoint can now use more than one ipam config. The man pages and the swagger doc are updated to reflect the latest changes. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* cni network configs set ipv6 enables correctlyPaul Holzinger2021-09-15
| | | | | | | When configs are loaded from disk we need to check if they contain a ipv6 subnet and set ipv6 enables to true in this case. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* default network: do not validate the used subnetsPaul Holzinger2021-09-15
| | | | | | | | | | | The default network should not be validated against used subnets, we have to ensure that this network can always be created even when a subnet is already used on the host. This could happen if you run a container on this net, then the cni interface will be created on the host and "block" this subnet from being used again. Therefore the next podman command tries to create the default net again and it would fail because it thinks the network is used on the host. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* network create: validate the input subnetPaul Holzinger2021-09-15
| | | | | | | Check that the given subnet does not conflict with existing ones (other configs or host interfaces). Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Merge pull request #11567 from giuseppe/cgroups-split-with-podsOpenShift Merge Robot2021-09-15
|\ | | | | libpod: honor --cgroups=split also with pods
| * libpod: honor --cgroups=split also with podsGiuseppe Scrivano2021-09-14
| | | | | | | | | | | | Honor --cgroups=split also when the container is running in a pod. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #11585 from flouthoc/bump-buildah-1-23-0OpenShift Merge Robot2021-09-15
|\ \ | | | | | | vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0
| * | build.bats: fix copy tests after containers/buildah#3486Aditya Rajan2021-09-15
| | | | | | | | | | | | | | | | | | | | | | | | Fix copy tests after https://github.com/containers/buildah/pull/3486 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@gmail.com>
| * | build: mirror --authfile to filesystem if pointing to FD instead of fileAditya Rajan2021-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Following commit makes sure that podman mirrors --authfile to a temporary file in filesystem if arg is pointing to an FD instead of actual file as FD can be only consumed once. Reference: * https://github.com/containers/buildah/pull/3498 * https://github.com/containers/buildah/issues/3070 [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
| * | vendor: Bump github.com/containers/buildah from 1.22.3 to 1.23.0Aditya Rajan2021-09-15
| | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
* | | Merge pull request #11409 from cdoern/podVolumesOpenShift Merge Robot2021-09-15
|\ \ \ | | | | | | | | Pod Volumes Support
| * | | Pod Volumes Supportcdoern2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | added support for the --volume flag in pods using the new infra container design. users can specify all volume options they can with regular containers resolves #10379 Signed-off-by: cdoern <cdoern@redhat.com>
* | | | Merge pull request #11556 from afbjorklund/distribution-infoOpenShift Merge Robot2021-09-15
|\ \ \ \ | | | | | | | | | | Show variant and codename of the distribution
| * | | | Show variant and codename of the distributionAnders F Björklund2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Along with the name (id) and the version(_id) But only show the information if is available Examples: Fedora CoreOS, Ubuntu Focal [NO TESTS NEEDED] Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
* | | | | Merge pull request #11578 from jelly/handle_nil_pointer_derefOpenShift Merge Robot2021-09-15
|\ \ \ \ \ | | | | | | | | | | | | api: handle nil pointer dereference in api endpoints
| * | | | | api: handle nil pointer dereference in rest endpointsJelle van der Waa2021-09-15
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When `?all=garbage` is passed to an API endpoint schema validation fails and err is nil. Wrapf uses err to create an error message causing a nil pointer dereference. Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | | | | Merge pull request #11574 from nalind/buildah-platformsOpenShift Merge Robot2021-09-15
|\ \ \ \ \ | | | | | | | | | | | | build: take advantage of --platform lists
| * | | | | build: take advantage of --platform listsNalin Dahyabhai2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The builder can take a list of platforms in the Platforms field of its BuildOptions argument, and we should definitely take advantage of that. The `bud-multiple-platform-values` test from buildah exercises support for this, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | | | | Merge pull request #11586 from Luap99/docOpenShift Merge Robot2021-09-15
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | [CI:DOCS] Fix example in podman machine init man page
| * | | | | Fix example in podman machine init man pagePaul Holzinger2021-09-15
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #11582 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #11575 from jelly/doc_all_optionOpenShift Merge Robot2021-09-14
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] Document `all` query parameter for /libpod/images/prune
| * | | | | Document `all` query parameter for /libpod/images/pruneJelle van der Waa2021-09-14
| | |/ / / | |/| | | | | | | | | | | | | Signed-off-by: Jelle van der Waa <jvanderwaa@redhat.com>
* | | | | Merge pull request #11561 from giuseppe/simplify-cgroups-disabled-testOpenShift Merge Robot2021-09-14
|\ \ \ \ \ | |_|/ / / |/| | | | tests: simplify --cgroups=disabled test and enable for rootless
| * | | | tests: enable --cgroups=disabled test for rootlessGiuseppe Scrivano2021-09-14
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | tests: simplify --cgroups=disabled testGiuseppe Scrivano2021-09-14
| | |_|/ | |/| | | | | | | | | | | | | | | | | | read the cgroup directly from the container. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #11170 from flouthoc/support-rootfs-overlayOpenShift Merge Robot2021-09-14
|\ \ \ \ | | | | | | | | | | rootfs: Add support for rootfs-overlay.
| * | | | rootfs: Add support for rootfs-overlay and bump to buildah v1.22.1-0.202108flouthoc2021-09-14
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allows users to specify a readonly rootfs with :O, in exchange podman will create a writable overlay. bump builah to v1.22.1-0.20210823173221-da2b428c56ce [NO TESTS NEEDED] Signed-off-by: flouthoc <flouthoc.git@gmail.com>
* | | | Merge pull request #11569 from baude/macaarch64pullfcosOpenShift Merge Robot2021-09-14
|\ \ \ \ | | | | | | | | | | Use new aarch64 fcos repos
| * | | | Use new aarch64 fcos reposbaude2021-09-14
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Now that aarch64 fcos is an official thing, we no longer need to use the side repo (for lack of a better word). We can now use the same image lookup technique as x86_64. I removed the special lookup, moved the x86_64 lookup to generic arch, and removed the arch specific files that we no longer needed. [NO TESTS NEEDED] Signed-off-by: baude <baude@redhat.com>
* | | | Merge pull request #11559 from jwhonce/wip/generatorOpenShift Merge Robot2021-09-14
|\ \ \ \ | |_|_|/ |/| | | Enhance bindings for IDE hints
| * | | Enhance bindings for IDE hintsJhon Honce2021-09-14
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * Follow https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source for leading comment * Add godoc strings for all exposed methods for IDE support * Copy field godoc strings into generated code as function godoc string * Remove unused/unnecessary fields from generator.go structures * Cleanup code regarding template usage Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #11512 from cevich/use_nmcli_workaround_imagesOpenShift Merge Robot2021-09-14
|\ \ \ | | | | | | | | Cirrus: NM/CNI workaround + Remove prior-Ubuntu
| * | | Cirrus: NM/CNI workaround + Remove prior-UbuntuChris Evich2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | Ref: https://github.com/containers/automation_images/pull/88 Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #11551 from Luap99/rootlessport-restartOpenShift Merge Robot2021-09-14
|\ \ \ \ | | | | | | | | | | fix restart always with rootlessport
| * | | | libpod: rootful close binded portsPaul Holzinger2021-09-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For rootful users ports are forwarded via iptables. To make sure no other process tries to use them, libpod will bind the ports and pass the fds to conmon. There seems to be race when a container is restarted because libpod tries to bind the port before the conmon process exited. The problem only hapens with the podman service because it keeps the connection open. Once we have the fd and passed it to conmon the podman service should close the connection. To verify run `sudo ss -tulpn` and check that only the conmon process keeps the port open. Previously you would also see the podman server process listed. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | | fix restart always with rootlessportPaul Holzinger2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a container is automatically restarted due its restart policy and the container uses rootless cni networking with ports forwarded we have to start a new rootlessport process since it exits with conmon. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | | remove rootlessport socket to prevent EADDRINUSEPaul Holzinger2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we restart a container via podman restart or restart policy the rootlessport process fails with `address already in use` because the socketfile still exists. This is a regression and was introduced in commit abdedc31a25e. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #11520 from giuseppe/enable-cgroup-parent-testOpenShift Merge Robot2021-09-14
|\ \ \ \ \ | |_|_|_|/ |/| | | | test: enable --cgroup-parent test
| * | | | test: enable --cgroup-parent testGiuseppe Scrivano2021-09-14
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | and fix it for running with runc. Closes: https://github.com/containers/podman/issues/11165 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #11449 from simnalamburt/gvproxy-pathOpenShift Merge Robot2021-09-14
|\ \ \ \ | |/ / / |/| | | Make gvproxy path configurable with containers.conf
| * | | Search gvproxy with config.FindHelperBinary()Hyeon Kim2021-09-14
|/ / / | | | | | | | | | | | | | | | | | | | | | Closes #11531 [NO TESTS NEEDED] Signed-off-by: Hyeon Kim <simnalamburt@gmail.com>
* | | Merge pull request #11529 from n1hility/fix-oldfieldsOpenShift Merge Robot2021-09-13
|\ \ \ | |_|/ |/| | Add deprecated event fields for 1.22+ clients that still expect them
| * | Add deprecated fields for 1.22+ clients that still expect themJason T. Greene2021-09-10
| | | | | | | | | | | | Signed-off-by: Jason Greene <jason.greene@redhat.com>
* | | Merge pull request #11545 from rhatdan/exitcodesOpenShift Merge Robot2021-09-13
|\ \ \ | | | | | | | | If container exits with 125 podman should exit with 125
| * | | If container exits with 125 podman should exit with 125Daniel J Walsh2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | fixes: https://github.com/containers/podman/issues/11540 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #11549 from ↵OpenShift Merge Robot2021-09-13
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/json-iterator/go-1.1.12 Bump github.com/json-iterator/go from 1.1.11 to 1.1.12
| * | | | Bump github.com/json-iterator/go from 1.1.11 to 1.1.12dependabot[bot]2021-09-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/json-iterator/go](https://github.com/json-iterator/go) from 1.1.11 to 1.1.12. - [Release notes](https://github.com/json-iterator/go/releases) - [Commits](https://github.com/json-iterator/go/compare/v1.1.11...v1.1.12) --- updated-dependencies: - dependency-name: github.com/json-iterator/go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #11440 from ashley-cui/sshOpenShift Merge Robot2021-09-13
|\ \ \ \ \ | | | | | | | | | | | | Use default username for podman machine ssh
| * | | | | Use default username for podman machine sshAshley Cui2021-09-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When using the defaut conection for podman machine ssh, use the default username too. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | | | Merge pull request #11552 from Luap99/commonOpenShift Merge Robot2021-09-13
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | bump c/common to v0.44.0
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-10-01 13:46:00 +0000