summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Refactor manifest list operationsJhon Honce2022-01-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update method/function signatures use the manifest list name and images associated with the operation explicitly, in general func f(ctx context.Context, manifestListName string, ImageNames []string, options *fOptions) * Leverage gorilla/mux Subrouters to support API v3.x and v4.x for manifests * Make manifest API endpoints more RESTful * Add PUT /manifest/{id} to update existing manifests * Add manifests.Annotate to go bindings, uncommented unit test * Add DELETE /manifest/{Id} to remove existing manifest list, use PUT /manifest/{id} to remove images from a list * Deprecated POST /manifest/{id}/add and /manifest/{id}/remove, use PUT /manifest/{id} instead * Corrected swagger godoc and updated to cover API changes * Update podman manifest commands to use registry.Context() * Expose utils.GetVar() to obtain query parameters by name * Unexpose server.registerSwaggerHandlers, not sure why this was ever exposed. * Refactored code to use http.Header instead of map[string]string when operating on HTTP headers. * Add API-Version header support in bindings to allow calling explicate versions of the API. Header is _NOT_ forwarded to the API service. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #12856 from fredr/issue-template/fix-linksOpenShift Merge Robot2022-01-14
|\ | | | | [CI:DOCS] troubleshooting links to main branch
| * troubleshooting links to main branchfredr2022-01-14
| | | | | | | | Signed-off-by: fredr <fredrik@enestad.com>
* | Merge pull request #12825 from elezar/update-cdiOpenShift Merge Robot2022-01-14
|\ \ | | | | | | Update use of CDI API
| * | Use fully-qualified device name in CDI testEvan Lezar2022-01-14
| | | | | | | | | | | | Signed-off-by: Evan Lezar <elezar@nvidia.com>
| * | Use new CDI APIEvan Lezar2022-01-14
| |/ | | | | | | | | | | | | This change updates the CDI API to commit 46367ec063fda9da931d050b308ccd768e824364 which addresses some inconistencies in the previous implementation. Signed-off-by: Evan Lezar <elezar@nvidia.com>
* | Merge pull request #12853 from cdoern/buildRelativeOpenShift Merge Robot2022-01-14
|\ \ | | | | | | Podman Build use absolute filepath
| * | Podman Build use absolute filepathcdoern2022-01-13
| |/ | | | | | | | | | | | | | | | | podman build always finds the abs path but was never using it for the containerfile path. This was causing the remote client to be given a relative path that does not exist. Switch to evaluating and using absolute paths only. resolves #12841 Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #12849 from cdoern/podProhibitOpenShift Merge Robot2022-01-14
|\ \ | |/ |/| Prohibit --uid/gid map and --pod for container create/run
| * Prohibit --uid/gid map and --pod for container create/runcdoern2022-01-13
| | | | | | | | | | | | | | | | | | add a check in namespaceOptions() that ensures the user is not setting a new uid/gid map if entering or creating a pod that has an infra container resolves #12669 Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #12828 from giuseppe/drop-checkOpenShift Merge Robot2022-01-13
|\ \ | | | | | | libpod: drop check for empty pod cgroup
| * | libpod: refine check for empty pod cgroupGiuseppe Scrivano2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | rootless containers do not use cgroups on cgroupv1 or if using cgroupfs, so improve the check to account for such configuration. Closes: https://github.com/containers/podman/issues/10800 Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2028243 [NO NEW TESTS NEEDED] it requires rebooting and the rundir on a non tmpfs file system. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #12826 from vrothberg/force-rm-podOpenShift Merge Robot2022-01-13
|\ \ \ | | | | | | | | podman container rm: remove pod
| * | | podman container rm: remove podValentin Rothberg2022-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support removing the entire pod when --depend is used on an infra container. --all now implies --depend to properly support removing all containers and not error out when hitting infra containers. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #12642 from Luap99/libnetworkOpenShift Merge Robot2022-01-13
|\ \ \ \ | |/ / / |/| | | use libnetwork from c/common
| * | | Manual fixes for PR #12642:Ed Santiago2022-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip a bunch more podman-remote tests. Filed an issue for one of them (#12838), the others may not be fixable. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | podman build enable --all-platforms and --unsetenvPaul Holzinger2022-01-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we add support for allplatforms and unsetenv to both local and remote podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | fix buildah-bud test diffPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | upgrade test: check that network backend is cniPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we test an update from an older version we should check the the network backend is correctly set to CNI. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | use netns package from c/commonPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The netns package was moved to c/common so we should use this and remove the package from podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | update buildah to latest and use new network stackPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | Make sure buildah uses the new network stack. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * | | use libnetwork from c/commonPaul Holzinger2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The libpod/network packages were moved to c/common so that buildah can use it as well. To prevent duplication use it in podman as well and remove it from here. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #12836 from cdoern/podSysCtlOpenShift Merge Robot2022-01-13
|\ \ \ \ | |_|_|/ |/| | | Podman Pod Create --sysctl support
| * | | Podman Pod Create --sysctl supportcdoern2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | added support for pod wide sysctls. The sysctls supported are the same as the continer run controls. These controls are only valid if the proper namespaces are shared within the pod, otherwise only the infra ctr gets the sysctl resolves #12747 Signed-off-by: cdoern <cdoern@redhat.com>
* | | | Merge pull request #12837 from rhatdan/eventsOpenShift Merge Robot2022-01-13
|\ \ \ \ | | | | | | | | | | use events_logfile_path from containers.conf for events log.
| * | | | use events_logfile_path from containers.conf for events log.Daniel J Walsh2022-01-13
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #12644 from leahneukirchen/events-timestampOpenShift Merge Robot2022-01-13
|\ \ \ \ \ | |/ / / / |/| | | | remote events: convert TimeNano properly
| * | | | remote events: convert TimeNano properlyLeah Neukirchen2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e.TimeNano contains nanoseconds since epoch, not just the nanoseconds after e.Time. time.Unix supports nanoseconds > 999999999 and converts them to seconds, so just passing e.TimeNano is enough. Signed-off-by: Leah Neukirchen <leah@vuxu.org>
* | | | | Merge pull request #12835 from baude/issue12815OpenShift Merge Robot2022-01-13
|\ \ \ \ \ | | | | | | | | | | | | Wait for podman stop to complete
| * | | | | Wait for podman stop to completeBrent Baude2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | if users run podman machine stop && podman machine ls, the status of the machine in the subsequent ls command would running. now we wait for everything to complete for stop so that scripting is more accurate. Fixes: #12815 [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #12834 from giuseppe/fix-systemd-session-warningOpenShift Merge Robot2022-01-12
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | libpod: fix check for systemd session
| * | | | | libpod: fix check for systemd sessionGiuseppe Scrivano2022-01-12
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | move the check after the cgroup manager is set, so to correctly detect --cgroup-manager=cgroupfs and do not raise a warning about dbus not being present. Closes: https://github.com/containers/podman/issues/12802 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #12151 from rhatdan/nooutOpenShift Merge Robot2022-01-12
|\ \ \ \ \ | | | | | | | | | | | | Add --noout option to prevent the output of ids
| * | | | | Add --noout option to prevent the output of idsDaniel J Walsh2022-01-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/11515 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #12827 from edsantiago/image_scp_quietOpenShift Merge Robot2022-01-12
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | podman image scp: implement --quiet
| * | | | | podman image scp: implement --quietEd Santiago2022-01-12
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Relay --quiet to save & load commands, in both Rootless and Rootful transfer functions. Also, a little cleanup: - remove unuseful SOURCE/DEST printfs - refactor duplication in execMachine() - fix Debug("Executing") statements to include the actual command they're executing [NO NEW TESTS NEEDED] : Tests are being slowly implemented in #12797 Signed-off-by: Charlie Doern <cdoern@redhat.com> Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #12824 from ↵OpenShift Merge Robot2022-01-12
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/BurntSushi/toml-1.0.0 Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0
| * | | | Bump github.com/BurntSushi/toml from 0.4.1 to 1.0.0dependabot[bot]2022-01-12
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/BurntSushi/toml](https://github.com/BurntSushi/toml) from 0.4.1 to 1.0.0. - [Release notes](https://github.com/BurntSushi/toml/releases) - [Commits](https://github.com/BurntSushi/toml/compare/v0.4.1...v1.0.0) --- updated-dependencies: - dependency-name: github.com/BurntSushi/toml dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #12821 from vrothberg/vendor-commonOpenShift Merge Robot2022-01-12
|\ \ \ \ | |/ / / |/| | | vendor latest c/common
| * | | vendor latest c/commonValentin Rothberg2022-01-12
| | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #12819 from rhatdan/machineDaniel J Walsh2022-01-12
|\ \ \ \ | |/ / / |/| | | add additional fields to podman machine ls --json
| * | | add additional fields to podman machine ls --jsonDaniel J Walsh2022-01-11
| | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #12813 from rhatdan/secretsOpenShift Merge Robot2022-01-12
|\ \ \ \ | | | | | | | | | | Fix permission on secrets directory
| * | | | Fix permission on secrets directoryDaniel J Walsh2022-01-11
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This directory needs to be world searchable so users can access it from different user namespaces. Fixes: https://github.com/containers/podman/issues/12779 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #12818 from edsantiago/emergency_buildah_skipsOpenShift Merge Robot2022-01-12
|\ \ \ \ | |/ / / |/| | | buildah bud tests: skip failing tests
| * | | buildah bud tests: skip failing testsEd Santiago2022-01-11
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Emergency workaround for github's deprecation of git:// https://github.blog/2021-09-01-improving-git-protocol-security-github/ Two buildah tests rely on 'git://' URLs. These now fail. They have been fixed in the buildah repo[1] but it will take time to vendor that in. ITM, we need to get CI passing. Skip those two failing tests. [1] https://github.com/containers/buildah/pull/3701 Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #12694 from rhatdan/dependDaniel J Walsh2022-01-11
|\ \ \ | | | | | | | | Add podman rm --depend
| * | | Add podman rm --dependDaniel J Walsh2022-01-11
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This option causes Podman to not only remove the specified containers but all of the containers that depend on the specified containers. Fixes: https://github.com/containers/podman/issues/10360 Also ran codespell on the code Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #12807 from Luap99/macvlan-hostipDaniel J Walsh2022-01-11
|\ \ \ | |/ / |/| | fix host.containers.internal entry for macvlan networks
| * | fix host.containers.internal entry for macvlan networksPaul Holzinger2022-01-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For ip/macvlan networks we cannot use the gateway as address for this hostname. In this case the gateway is normally not on the host so we just try to use a local ip instead. [NO NEW TESTS NEEDED] We cannot run macvlan networks in CI. Fixes #11351 Signed-off-by: Paul Holzinger <pholzing@redhat.com>