summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Do not use "true" after "syslog" in exit commandsMatthew Heon2020-12-01
| | | | | | | | | | | | | | | | | | | | | Instead of being interpreted as an argument to the boolean flag, the 'true' is being intepreted as the Podman command to be run - so we're trying to run `podman true`, which does not exist. This causes the cleanup command to fail when `--log-level=debug` is set, so containers are not cleaned up or removed. This problem is easily reproduced with any command combining the `--rm`, `-d`, and `--log-level=debug` flags - the command will execute and exit, but the container will not be removed. Separate, but worth looking into later: the errors we get on trying `podman true` with any flags are terrible - if you just type `podman true` you get a quite sane "Unrecognized command" error, but if you try `podman true --rm` you get an "unknown flag --rm" error - which makes very little sense given the command itself doesn't exist. Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #8126 from matejvasek/impl-apiv2-archiveOpenShift Merge Robot2020-12-01
|\ | | | | Implement containers/{id or name}/archive api
| * test resource cleanupMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * more testsMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * not forcing unmountMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * few more testsMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * add testMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * add commentMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * fix: unmount container without forceMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * style: wslMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * fix lintMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Implement containers/{id or name}/archiveMatej Vasek2020-11-19
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | Merge pull request #8535 from edsantiago/batsOpenShift Merge Robot2020-12-01
|\ \ | | | | | | BATS: add ping test, ps filters, multi-option
| * | BATS: add ping testEd Santiago2020-12-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - run test : tweaks to recently-added network-conflict test: * remove "-d" in run * confirm exact warning text, and also that container runs successfully * test multiple --net options (regression #8057) - images, run, build, exec tests: add multiple-flag testing for various flags, confirming as appropriate whether options are overridden or accumulated. - ps test : add --filter and --sort tests - pod test: run 'ping' inside container (confirms that container gets PING capability) Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #8525 from mheon/readme_220OpenShift Merge Robot2020-12-01
|\ \ \ | | | | | | | | [CI:DOCS] Bump version in README to v2.2.0
| * | | Bump version in README to v2.2.0Matthew Heon2020-11-30
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #8515 from baude/netconnectstateOpenShift Merge Robot2020-12-01
|\ \ \ \ | | | | | | | | | | network connect disconnect on non-running containers
| * | | | network connect disconnect on non-running containersbaude2020-11-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | a container can connect and disconnet to networks even when not in a running state. Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #8400 from rhatdan/varlinkOpenShift Merge Robot2020-12-01
|\ \ \ \ \ | | | | | | | | | | | | Remove varlink support from podman
| * | | | | Remove varlink support from PodmanDaniel J Walsh2020-11-26
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #8519 from rhatdan/manOpenShift Merge Robot2020-12-01
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | [CI:DOCS] Document volume mounts of source directories do NOT get created
| * | | | | Document volume mounts of source directories do NOT get createdDaniel J Walsh2020-12-01
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We differ from Docker, in that we do not create the source directory in a --volume mount if it does not exists. We return an error. We do not believe that a `typo` from the user should cause a directory to be created and silently ignored by Podman. Fixes: https://github.com/containers/podman/issues/8513 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #8427 from rhatdan/psOpenShift Merge Robot2020-12-01
|\ \ \ \ \ | | | | | | | | | | | | Handle ps container created field as a time.Time
| * | | | | Handle ps container created field as a time.TimeDaniel J Walsh2020-11-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In the current code we were translating the created time from a time.Time to a unix epoch, this was leading to a loss of precession, and some unexpected results where the sorting order of containers was misordered because of the precession loss. If we pass around created as time.Time, we do not loose the precission. Fixes: https://github.com/containers/podman/issues/8414 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #8475 from rhatdan/subscriptionsOpenShift Merge Robot2020-12-01
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Switch from pkg/secrets to pkg/subscriptions
| * | | | | Switch from pkg/secrets to pkg/subscriptionsDaniel J Walsh2020-11-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The buildah/pkg/secrts package was move to containers/common/pkg/subscriptions. Switch to using this by default. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #8523 from mheon/bump_30_devOpenShift Merge Robot2020-12-01
|\ \ \ \ \ \ | | | | | | | | | | | | | | Bump master to v3.0.0-dev
| * | | | | | Bump master to v3.0.0-devMatthew Heon2020-11-30
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | Merge pull request #8520 from mheon/release_notes_220_finalOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Update release notes for v2.2.0
| * | | | | | Update release notes for v2.2.0Matthew Heon2020-11-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | | Merge pull request #8517 from rhatdan/manOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [CI:DOCS] Fix option names --subuidname and --subgidname
| * | | | | | | Fix option names --subuidname and --subgidnameDaniel J Walsh2020-11-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Options --subuid and --subgid does not exists Fixes: https://github.com/containers/podman/issues/8510 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | | | Merge pull request #8518 from mheon/fix_extra_quoteOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | [CI:DOCS] Fix extra quotation mark in manpages.
| * | | | | | | Fix extra quotation mark in manpages.Matthew Heon2020-11-30
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | | Merge pull request #8465 from rhatdan/pullOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Document docker transport is the only supported remote transport
| * | | | | | | Document docker transport is the only supported remote transportDaniel J Walsh2020-11-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal is to improve errors when users use the wrong transport in certain cases we stutter, in other cases we don't give enough information. Remove stutters when failing to pull remote images, because of lack of support. Fix errors returned by reference.Parse to wrap in image that was being checked. Fixes: https://github.com/containers/podman/issues/7116 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | | | Merge pull request #8514 from Luap99/revert-8410-fix-multiple-networksOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Revert "Allow multiple --network flags for podman run/create"
| * | | | | | | | Revert "Allow multiple --network flags for podman run/create"Luap992020-11-30
| | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As described in issue #8507 this commit contains a breaking change which is not wanted in v2.2. We can discuss later if we want this in 3.0 or not. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | | | | Merge pull request #8230 from mheon/port_net_host_conflictOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Ensure that --net=host/pod/container conflicts with -p
| * | | | | | | Ensure that --net=host/pod/container/none warn with -pMatthew Heon2020-11-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Setting port mappings only works when CNI is configuring our network (or slirp4netns, in the rootless case). This is not the case with `--net=host`, `--net=container:`, and joining the network namespace of the pod we are part of. Instead of allowing users to do these things and then be confused why they do nothing, let's match Docker and return a warning that your port mappings will do nothing. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | | | | Merge pull request #8420 from jortkoopmans/patch-1OpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ \ | |_|/ / / / / / |/| | | | | | | [CI:DOCS] Update Tutorials.rst
| * | | | | | | Merge branch 'master' into patch-1jortkoopmans2020-11-30
| |\ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | |
* | | | | | | | Merge pull request #8511 from Edward5hen/kube-testOpenShift Merge Robot2020-11-30
|\ \ \ \ \ \ \ \ | |_|_|/ / / / / |/| | | | | | | Add APIv2 tests for kube generate
| * | | | | | | Add APIv2 tests for kube generateEdward Shen2020-11-30
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Edward Shen <weshen@redhat.com>
* | | | | | | Merge pull request #8493 from Luap99/net-rm-macvlanOpenShift Merge Robot2020-11-28
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Fix problems with network remove
| * | | | | | | Fix problems with network removePaul Holzinger2020-11-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | First, make sure we are only trying to remove the network interface if we are root. Second, if we cannot get the interface name (e.g macvlan config) then we should not fail. Just remove the config file. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | | | | | Merge pull request #8497 from AlbanBedel/kube-volumeOpenShift Merge Robot2020-11-28
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | Add support for persistent volume claims in kube files
| * | | | | | | | Add support for persistent volume claims in kube filesAlban Bedel2020-11-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In k8s a persistent volume claim (PVC) allow pods to define a volume by referencing the name of a PVC. The PVC basically contains criterias that k8s then use to select which storage source it will use for the volume. Podman only provide one abtracted storage, the named volumes, and create them if they don't exists yet. So this patch simply use a volume with the name of the PVC. Signed-off-by: Alban Bedel <albeu@free.fr>
| * | | | | | | | Prepare support in kube play for other volume types than hostPathAlban Bedel2020-11-27
| | |_|_|_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replace the simple map of names to paths with a map of names to a struct to allow passing more parameters. Also move the code to parse the volumes to its own file to avoid making the playKubePod() function overly complex. Finally rework the kube volumes test to also be ready to support more volume types. Signed-off-by: Alban Bedel <albeu@free.fr>
* | | | | | | | Merge pull request #8500 from giuseppe/set-xdg-dirsOpenShift Merge Robot2020-11-28
|\ \ \ \ \ \ \ \ | |/ / / / / / / |/| | | | | | | runtime: set XDG_* env variables if missing
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-02 18:32:26 +0000