summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* image removal: refactor part 2Valentin Rothberg2020-05-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Continue the refactoring of image removal. I didn't manage to break all the following changes into smaller and easier to digest commits due to time constraints: * Return an error slice instead of a single error. Use multierror only in the client/frontend. Reflect that in the types. * Use the batch image removal in the client while preserving the more rest-idiomatic single-image removal endpoint. * Add a new handler for the single-image removal endpoint to make it share the same code as the batch endpoint. * Expose bindings for the single and batch endpoints, so we can properly test them. * Add several convenience functions for error handling to pkg/errorhandling. * Set the correct error type in libpod to set the exit code to 2 when one or more containers are using an image. * Massage the bindings tests a bit and tackle compilation errors. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6051 from rhatdan/containers.confOpenShift Merge Robot2020-05-04
|\ | | | | Fixes for test/e2e/containers_conf_test.go
| * Fix errors found in coverity scanDaniel J Walsh2020-05-01
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Remove skip on containers.conf testsDaniel J Walsh2020-05-01
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * cgroupsns was not following containers.confDaniel J Walsh2020-05-01
| | | | | | | | | | | | Implement ParseCgroupsNamespace to handle defaults. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Properly handle default capabilities listed in containers.confDaniel J Walsh2020-05-01
| | | | | | | | | | | | | | If user/admin specifies a different list of default capabilties we need to honor these. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Properly handle containers.conf devicesDaniel J Walsh2020-05-01
| | | | | | | | | | | | We need to add the default devices listed in containers.conf Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #6066 from TomSweeneyRedHat/dev/tsweeney/fixquayioOpenShift Merge Robot2020-05-03
|\ \ | | | | | | [CI:DOC]Use full repo name in podmanimage Dockerfiles
| * | [CI:DOC]Use full repo name in podmanimage DockerfilesTomSweeneyRedHat2020-05-01
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | In the Buildah images, we had a problem where the testing image was installed with an older version of Buildah than the stable image. This was apparently due to quay.io using Docker and Dockerhub which has a version of Fedora that did not let testing version of Buildah to be installed as it should have been. This change fully specifies the name of the fedora image to use. This has not been a problem in Podman, but I'm carrying this change here to avoid future problems. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #6058 from rhatdan/coverityOpenShift Merge Robot2020-05-01
|\ \ | | | | | | Fix errors found in coverity scan
| * | Fix errors found in coverity scanDaniel J Walsh2020-05-01
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6061 from QiWang19/getloginOpenShift Merge Robot2020-05-01
|\ \ \ | | | | | | | | check --get-login when login
| * | | check --get-login when loginQi Wang2020-05-01
| | | | | | | | | | | | | | | | | | | | | | | | Check --get-login is set in podman since it is not shared option from c/common and does not valid by the package. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #6060 from sujil02/systemprune-v2OpenShift Merge Robot2020-05-01
|\ \ \ \ | | | | | | | | | | And system prune feature for v2.
| * | | | And system prune feature for v2.Sujil022020-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adds podman system prune for v2. Refactoring for code reuse from pods containers images and volume prune. Adds and enables testcases to support the added feature. Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | | Merge pull request #6062 from jwhonce/wip/docsOpenShift Merge Robot2020-05-01
|\ \ \ \ \ | |_|_|_|/ |/| | | | [CI:DOC] Bring README.md up to date
| * | | | [CI:DOCS] Bring README.md up to dateJhon Honce2020-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add notes on helper functions * Update example Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #6059 from QiWang19/search-limitOpenShift Merge Robot2020-05-01
|\ \ \ \ \ | |_|_|_|/ |/| | | | search --limit compatible with docker
| * | | | search --limit compatible with dockerQi Wang2020-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Check --limit range and update --limit manpage explanation. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | Merge pull request #6057 from baude/v2networkingOpenShift Merge Robot2020-05-01
|\ \ \ \ \ | |_|_|_|/ |/| | | | v2networking enable commands
| * | | | add provided cni networks to spec genbaude2020-05-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | enable final integration tests for networking. Signed-off-by: baude <bbaude@redhat.com>
| * | | | v2networking enable commandsbaude2020-04-30
| |/ / / | | | | | | | | | | | | | | | | | | | | Enable the networking commands for v2. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #6004 from rhatdan/ulimitsOpenShift Merge Robot2020-05-01
|\ \ \ \ | | | | | | | | | | Set up ulimits for rootless containers.
| * | | | Set up ulimits for rootless containers.Daniel J Walsh2020-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we are setting the maximum limits for rootful podman containers, no reason not to set them by default for rootless users as well Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #6016 from giuseppe/fix-createOpenShift Merge Robot2020-05-01
|\ \ \ \ \ | |_|_|_|/ |/| | | | v2, podman: fix create and entrypoint tests
| * | | | test: enable start testsGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `docker start` doesn't resolve partial ID -> full ID, adapt test. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | podman, start: propagate back the raw inputGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this is necessary as we expect "podman start $ID_NAME" to print the same arguments the user passed in instead of the full ID. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | test: enable remaining run testsGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | test: enable entrypoint testsGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | test: enable create testsGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | cmd, podman: do not override entrypoint if unsetGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | cmd, podman: use String instead of variable+StringVarGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | cmd, podman: handle --pod new:PODGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | create: propagate override-arch and override-osGiuseppe Scrivano2020-04-30
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #6044 from cevich/update_f32OpenShift Merge Robot2020-05-01
|\ \ \ \ \ | | | | | | | | | | | | Cirrus: Update to Fedora 32 proper
| * | | | | Cirrus: Utilize new cache imagesChris Evich2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | | | Cirrus: Utilize new base imagesChris Evich2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | | | | cirrus: Update to Fedora 32 properChris Evich2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now that it's officially released, update to it from the beta. Also (and significant), adjust the SELinux context of the GCP metadata service. Add a comment to the code explaining why this is necessary. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | Merge pull request #6055 from baude/v2argsOpenShift Merge Robot2020-04-30
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | fix commands without input
| * | | | | fix commands without inputbaude2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in cases where commands require input and we dont provide it, we often would segv. This can be attributed in many cases to the subcommand not picked up the cobra Args attribute or neither had them. Signed-off-by: baude <bbaude@redhat.com>
| * | | | | System tests: help messages: check required-argEd Santiago2020-04-30
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a usage message is of the form '... [flags] ARGNAME', where ARGNAME is all-caps and not in brackets, it must be a required argument. Try running podman subcommand without ARGNAME, and make sure that podman bails out with an informative message. (Since this message is freeform in each subcommand, not Cobra-generated, we have a lot of possible variations to check for). Fix podman login/logout Use messages to indicate that REGISTRY is now optional (as of #5233). This test has actually been in place for over a year but due to a typo on my part -- a missing space -- it was not being run. "For want of a space, much testing was lost". Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #6056 from jwhonce/wip/rootlessOpenShift Merge Robot2020-04-30
|\ \ \ \ \ | | |_|_|/ | |/| | | V2 Commands that require ParentNS (rootful) are report error
| * | | | V2 Commands that require ParentNS (rootful) are report errorJhon Honce2020-04-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Updated unmount to require ParentNS Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #5861 from ↵OpenShift Merge Robot2020-04-30
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/psgo-1.5.0 Bump github.com/containers/psgo from 1.4.0 to 1.5.0
| * | | | | Bump github.com/containers/psgo from 1.4.0 to 1.5.0dependabot-preview[bot]2020-04-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/psgo](https://github.com/containers/psgo) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/containers/psgo/releases) - [Commits](https://github.com/containers/psgo/compare/v1.4.0...v1.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #6052 from sujil02/enable-prune-testOpenShift Merge Robot2020-04-30
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Enable prune integration test. Fixes container prune
| * | | | | Enable prune integration test. Fixes container prune.Sujil022020-04-30
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes container prune to prune created and configured containers. Disables couple of system prune test as not yet in with v2. Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | | Merge pull request #6046 from jwhonce/jira/822OpenShift Merge Robot2020-04-30
|\ \ \ \ \ | |/ / / / |/| | | | V2 enable ps tests
| * | | | V2 enable ps testsJhon Honce2020-04-29
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | * Combine cobra.Command helper functions into validate package from registry and common packages * Introduce ChoiceValue for flags Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #6047 from QiWang19/attach-testOpenShift Merge Robot2020-04-30
|\ \ \ \ | |/ / / |/| | | testv2: enable attach test
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-15 11:24:18 +0000