summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* oci: do not set XDG_RUNTIME_DIR twiceGiuseppe Scrivano2019-02-11
| | | | | | we are doing it few lines above. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* pod: drop not valid check for rootlessGiuseppe Scrivano2019-02-11
| | | | | | | rootless networks support port binding if the underlying slirp4netns is new enough. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #2286 from rhatdan/troubleshootingOpenShift Merge Robot2019-02-11
|\ | | | | Add troubleshooting information about running a rootless containers.
| * Add troubleshooting information about running a rootless containers.Daniel J Walsh2019-02-10
|/ | | | | | | Add a problem statement about shadow-utils and missing entries from /etc/subuid and /etc/subgid. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #2280 from TomSweeneyRedHat/dev/tsweeney/trusty2OpenShift Merge Robot2019-02-09
|\ | | | | Update image-trust man with further comments
| * Update image-trust man with further commentsTomSweeneyRedHat2019-02-08
| | | | | | | | | | | | | | | | | | Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com> After the last update, @mtrmac had some great suggestions which I've incorporated. I've updated the G:oogle doc and have added this PR in case it's easier to see the diffs. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #2296 from baude/psShowMountOpenShift Merge Robot2019-02-09
|\ \ | | | | | | Add volume mounts to PS output
| * | Add volume mounts to PS outputbaude2019-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | When listing containers, you should be able to list the mounts with something like --format "table{{".Mounts}}". Resolves: #2238 Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2297 from baude/issue2246OpenShift Merge Robot2019-02-09
|\ \ \ | |/ / |/| | do not crash when displaying dangling images
| * | do not crash when displaying dangling imagesbaude2019-02-08
|/ / | | | | | | | | | | | | | | | | | | | | the previous method required a populated image template to create the headers and always selected the first image in the slice. when dealing with dangling images, they are not populated and therefore would panic. Resolves: #2246 Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2274 from baude/cobraprepOpenShift Merge Robot2019-02-08
|\ \ | | | | | | Migrate to cobra CLI
| * | Migrate to cobra CLIbaude2019-02-08
|/ / | | | | | | | | | | | | | | We intend to migrate to the cobra cli from urfave/cli because the project is more well maintained. There are also some technical reasons as well which extend into our remote client work. Signed-off-by: baude <bbaude@redhat.com>
* | Merge pull request #2292 from nalind/remove-dead-typesOpenShift Merge Robot2019-02-07
|\ \ | | | | | | Remove some dead type declarations
| * | Remove some dead type declarationsNalin Dahyabhai2019-02-07
|/ / | | | | | | Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | Merge pull request #2290 from giuseppe/cleanup-use-correct-runtimeOpenShift Merge Robot2019-02-07
|\ \ | | | | | | cleanup: use the correct runtime
| * | cleanup: use the correct runtimeGiuseppe Scrivano2019-02-07
| | | | | | | | | | | | | | | | | | | | | make sure "containers cleanup" uses the correct runtime if it was overriden. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #2271 from cevich/search_gateOpenShift Merge Robot2019-02-07
|\ \ \ | | | | | | | | Fix down/missing registry.access.redhat.com
| * | | Fix down/missing registry.access.redhat.comChris Evich2019-02-07
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This registry responds differently depending on the the platform accessing it. It also occasionally goes down or returns 404s. Improve the reliability of the e2e tests by using the registry/image used for gating pull-requests. This way, if there's a registry/networking problem, the gating test will fail and prevent anything else from running. This is a better failure to have early, rather than wait and need to re-run all the e2e tests again later. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #2288 from vrothberg/vendor-docsOpenShift Merge Robot2019-02-07
|\ \ \ | | | | | | | | Vendor docs
| * | | make vendor: always check for latest vndrValentin Rothberg2019-02-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | @baude and I have recently debugged a `make vendor` issue, where different versions of `vndr` leave slightly different states behind. This ultimately leads to inconsistencies with the CI, which always fetches the latest version. To avoid such issues in the future, always use the latest version of `vndr` by checking for new versions of it prior to execution. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | install.md: add section about vendoringValentin Rothberg2019-02-07
| |/ / | | | | | | | | | | | | | | | Add a section about how `make vendor` works and how to troubleshoot it. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #2287 from 4383/add-make-docOpenShift Merge Robot2019-02-07
|\ \ \ | |/ / |/| | Add varlink generate to the make documentation
| * | Add varlink generate to the make documentationHervé Beraud2019-02-07
|/ / | | | | | | | | | | | | Minor improvement who add helping comment to the varlink generate target. Signed-off-by: Hervé Beraud <hberaud@redhat.com>
* | Merge pull request #2269 from rhatdan/selinuxOpenShift Merge Robot2019-02-07
|\ \ | |/ |/| Add documentation on running systemd on SELinux systems
| * Add documentation on running systemd on SELinux systemsDaniel J Walsh2019-02-06
| | | | | | | | | | | | | | | | Lots of users are attempting to run systemd within a container. They are being blocked from running SELinux systems since they need the container_manage_cgroup which is not enabled by default. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2278 from rhatdan/varlinkOpenShift Merge Robot2019-02-07
|\ \ | | | | | | Fix handling of memory limits via varlink
| * | Fix handling of memory limits via varlinkDaniel J Walsh2019-02-06
| |/ | | | | | | | | | | | | | | | | | | | | | | | | Currently handlin memory via varlink is hard coded to 0 Changing to Memory: create.Resources.Memory, MemoryReservation: create.Resources.Memory_reservation, MemorySwap: create.Resources.Memory_swap, MemorySwappiness: int(create.Resources.Memory_swappiness), KernelMemory: create.Resources.Kernel_memory, Allows callers to modify these memory settings. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2237 from fulldecent/patch-1OpenShift Merge Robot2019-02-06
|\ \ | | | | | | Mention officially supported OSes, fixes #2208
| * | Mention OSes that pass the buildWilliam Entriken2019-02-06
| | | | | | | | | | | | Signed-off-by: William Entriken <github.com@phor.net>
* | | Merge pull request #2268 from mheon/force_storage_refreshOpenShift Merge Robot2019-02-06
|\ \ \ | | | | | | | | Unconditionally refresh storage options from config
| * | | Unconditionally refresh storage options from configMatthew Heon2019-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to our unconditionally setting some storage options, we are not always reading storage options from storage.conf. This can lead to some fields in the storage config (most notably extra storage options) being ignored, despite being set in storage.conf. Resolve this by unconditionally refreshing our storage config from storage.conf (this was previously only done for rootless Podman) Fixes #2217 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | Merge pull request #2252 from rhatdan/systemOpenShift Merge Robot2019-02-06
|\ \ \ \ | | | | | | | | | | Add podman system prune and info commands
| * | | | Capatilize all usage and descriptionsDaniel J Walsh2019-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have no consistancy in out option usages and descritions on whether or not the first letter should be capatalized. This patch forces them all to be capatilized. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | | Add podman system prune and info commandsDaniel J Walsh2019-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are missing the equivalence of the docker system commands This patch set adds `podman system prune` and `podman system info` Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #2283 from 4383/improve-makefileOpenShift Merge Robot2019-02-06
|\ \ \ \ \ | | | | | | | | | | | | Generate make helping message dynamicaly.
| * | | | | Generate make helping message dynamicaly.Hervé Beraud2019-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Generate make helping message dynamicaly by using python code snippet inside Makefile. All commented make targets will be added to the help message. To be added to the helping message comment need to start with '## '. These specials comments are detected by the python code. Python code generate the helping output from these results. Notice that this commit introduce a dependency with python (compatible python 2 and 3). Signed-off-by: Hervé Beraud <hberaud@redhat.com>
* | | | | | Merge pull request #2284 from edsantiago/gomega_cleanupOpenShift Merge Robot2019-02-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | Makefile: minor fix to reenable system tests
| * | | | | | Makefile: minor fix to reenable system testsEd Santiago2019-02-06
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PR #2259 removed the .install.gomega Makefile target but didn't clean up two references to it. Do so now. Also, when setting up GOPKGBASEDIR symlink, use -f (force) flag; otherwise subsequent makes will fail. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #2279 from giuseppe/pts-no-override-if-not-neededOpenShift Merge Robot2019-02-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | rootless: do not override /dev/pts if not needed
| * | | | | | rootless: do not override /dev/pts if not neededGiuseppe Scrivano2019-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when running in rootless mode we were unconditionally overriding /dev/pts to take ride of gid=5. This is not needed when multiple gids are present in the namespace, which is always the case except when running the tests suite with only one mapping. So change it to check how many gids are present before overriding the default mount. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | | Merge pull request #2282 from nalind/healthconfig-startperiodOpenShift Merge Robot2019-02-06
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Add StartPeriod to cmd/podman/docker.HealthConfig
| * | | | | | Add StartPeriod to cmd/podman/docker.HealthConfigNalin Dahyabhai2019-02-06
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Backport the addition of the StartPeriod field to our copy of the HealthConfig type, added in docker v17.05.0-ce. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | | | | | Merge pull request #2275 from edsantiago/fix_blocking_fifoOpenShift Merge Robot2019-02-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | e2e tests: sigproxy: fix rare hang condition
| * | | | | | e2e tests: sigproxy: fix rare hang conditionEd Santiago2019-02-05
| | |/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The sig-proxy test creates a FIFO, runs podman with actions that write to it, then tries reading from the FIFO. Opening a FIFO for read or write blocks until the other end is opened for the corresponding write/read. If our podman process fails for any reason, the test's FIFO open will hang forever. Solution: open with O_NONBLOCK. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #2273 from mheon/preserve_exited_stateOpenShift Merge Robot2019-02-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | Preserve exited state across reboot
| * | | | | | Preserve exited state across rebootMatthew Heon2019-02-05
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Instead of unconditionally resetting to ContainerStateConfigured after a reboot, allow containers in the Exited state to remain there, preserving their exit code in podman ps after a reboot. This does not affect the ability to use and restart containers after a reboot, as the Exited state can be used (mostly) interchangeably with Configured for starting and managing containers. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #2270 from cevich/fail_fasterOpenShift Merge Robot2019-02-06
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Apply 45min timeout to integration tests
| * | | | | Apply 50min timeout to integration testsChris Evich2019-02-05
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | IMHO, longer than this waiting for automated testing is "too long". Scientificaly speaking, based on thousands of runs across many platforms, successful runs always happen in less time. Normally Ubuntu passes in 35-40 minutes, and the Fedoras do it in 25-30. If they take longer, something is likely badly broken. In that case, it's better to fail within a short/defined time, than wait for the (much longer) automation-level timeout and inevitable failure. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #2259 from vrothberg/vendor-checkOpenShift Merge Robot2019-02-06
|\ \ \ \ \ | | | | | | | | | | | | Vendor check
| * | | | | Cirrus: add vendor_check_taskValentin Rothberg2019-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Make sure that all vendored dependencies are in sync with the code and the vendor.conf by running `make vendor` with a follow-up status check of the git tree. * Vendor ginkgo and gomega to include the test dependencies. Signed-off-by: Chris Evic <cevich@redhat.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-19 13:25:00 +0000