summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Refactor runtime functions to pass options structureSascha Grunert2020-02-07
| | | | | | | This makes the code easier to read but should not change the overall behavior. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* Merge pull request #5120 from nalind/varlink-build-idOpenShift Merge Robot2020-02-07
|\ | | | | LibpodAPI.BuildImage: don't require a name for the new image
| * LibpodAPI.BuildImage: don't require a name for the new imageNalin Dahyabhai2020-02-06
| | | | | | | | | | | | | | | | | | | | When we finish building an image, we try to look up its ID by looking up the image using the name that we were asked to assign to the image. If we weren't asked to assign a name to the image, that would produce an error. The BuildImage() API we're using returns the image's ID anyway, so we can skip the lookup and just return the ID directly. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* | Merge pull request #5119 from mheon/bump-1.8.0OpenShift Merge Robot2020-02-07
|\ \ | |/ |/| Bump to v1.8.0
| * Bump to v1.8.1-devMatthew Heon2020-02-06
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Bump to v1.8.0v1.8.0Matthew Heon2020-02-06
|/ | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Merge pull request #5118 from baude/podmansystemservicesucks2OpenShift Merge Robot2020-02-06
|\ | | | | [CI:DOCS]update contrib systemd user
| * [CI:DOCS]update contrib systemd userBrent Baude2020-02-06
| | | | | | | | | | | | one more update Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #5111 from mheon/service_to_system_serviceOpenShift Merge Robot2020-02-06
|\ \ | |/ |/| Move podman-service to podman-system-service
| * Move podman-service to podman-system-serviceMatthew Heon2020-02-06
| | | | | | | | | | | | Fixes #5108 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #5117 from baude/podmansystemservicesucksOpenShift Merge Robot2020-02-06
|\ \ | | | | | | [CI:DOCS]fix systemd files for apiv2
| * | [CI:DOCS]fix systemd files for apiv2Brent Baude2020-02-06
| | | | | | | | | | | | | | | | | | the paths and instructions for running the new api via systemd needed updates due to a change in the command. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5116 from mheon/release_notes_1.8.0_finalOpenShift Merge Robot2020-02-06
|\ \ \ | |/ / |/| | [CI:DOCS] Update release notes for final release of v1.8.0
| * | Update release notes for final release of v1.8.0Matthew Heon2020-02-06
|/ / | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #5099 from mheon/fix_pod_cgroup_pidsOpenShift Merge Robot2020-02-06
|\ \ | |/ |/| Only modify conmon cgroup if we have running containers
| * Only modify conmon cgroup if we have running containersMatthew Heon2020-02-06
| | | | | | | | | | | | | | | | | | | | | | | | | | If there are no running containers - for example, if the pod was just created - the cgroup in question may not exist (under certain circumstances that we're not 100% sure about). However, regardless, we don't need to set a PID limit, as nothing will be making cleanup processes (no running conmon processes), so not changing the cgroup is safe regardless. Fixes #5072 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5098 from rhatdan/memory-swapOpenShift Merge Robot2020-02-06
|\ \ | | | | | | Special case memory-swap=-1
| * | Special case memory-swap=-1Daniel J Walsh2020-02-05
| | | | | | | | | | | | | | | | | | | | | We document that memory-swap==-1 means unlimited, but currently we won't allow the user to specify the -1 value. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5048 from TomSweeneyRedHat/dev/tsweeney/install.mdOpenShift Merge Robot2020-02-06
|\ \ \ | | | | | | | | Move install.md to podman.io, leave link page
| * | | Move install.md to podman.io, leave link pageTomSweeneyRedHat2020-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The installation instructions for podman were on this site and a second copy on podman.io. I've created https://github.com/containers/podman.io/pull/193 which has a merging of the installation instructions from both sites. Since the one on podman.io was created a few months ago, we've had a number of divergences. Maintaining only one copy should assist with that problem plus make it easier for people updating them. This PR should NOT be merged before the one in podman.io. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #5089 from baude/fixswaggeraddvalidateOpenShift Merge Robot2020-02-05
|\ \ \ \ | | | | | | | | | | fix swagger docs and make sure docs validation runs
| * | | | fix swagger docs and make sure docs validation runsBrent Baude2020-02-05
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5056 from ↵OpenShift Merge Robot2020-02-05
|\ \ \ \ | |/ / / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.12.0 build(deps): bump github.com/onsi/ginkgo from 1.11.0 to 1.12.0
| * | | build(deps): bump github.com/onsi/ginkgo from 1.11.0 to 1.12.0dependabot-preview[bot]2020-02-04
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.11.0 to 1.12.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.11.0...v1.12.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5062 from vrothberg/update-imageOpenShift Merge Robot2020-02-05
|\ \ \ | | | | | | | | vendor github.com/containers/image/v5@v5.2.0
| * | | vendor github.com/mtrmac/gpgme@v0.1.2Valentin Rothberg2020-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes a build regression on CentOS 7 and RHEL 7 with older gpgme versions. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * | | vendor github.com/containers/image/v5@v5.2.0Valentin Rothberg2020-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | See release notes: https://github.com/containers/image/releases/tag/v5.2.0 Fixes: #4877 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #5090 from openSUSE/containerfile-location-testOpenShift Merge Robot2020-02-05
|\ \ \ \ | | | | | | | | | | Add Containerfile location e2e test
| * | | | Add Containerfile location e2e testSascha Grunert2020-02-05
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | As a follow up of the location fix in #5080 we now add an e2e test for that use case. Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | | Merge pull request #5052 from mheon/cleanup_net_on_restartOpenShift Merge Robot2020-02-05
|\ \ \ \ | |/ / / |/| | | Tear down network when restarting containers
| * | | Tear down network when restarting containersMatthew Heon2020-02-02
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes restart a bit slower for root containers, but it does make it more consistent with `podman stop` and `podman start` on a container. Importantly, `podman restart` will now recreate firewall rules if they were somehow purged. Fixes #5051 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #5085 from rhatdan/closeOpenShift Merge Robot2020-02-04
|\ \ \ | | | | | | | | Close tarSource when finished using it
| * | | Close tarSource when finished using itDaniel J Walsh2020-02-04
| | |/ | |/| | | | | | | | | | | | | Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1797599 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5075 from mheon/filter_forces_allOpenShift Merge Robot2020-02-04
|\ \ \ | | | | | | | | Force --all when --filter is passed to podman ps
| * | | Force --all when --filter is passed to podman psMatthew Heon2020-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we filter, it should be out of all containers, not just running ones, by default - this is necessary to ensure Docker compatability. Fixes #5050 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #5082 from baude/specOpenShift Merge Robot2020-02-04
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Spec proposal
| * | | | [CI:DOCS]addition of specgen packageBrent Baude2020-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | warning: the naming of this might change as well as the location. this is a build on a PR from mheon from last year that proposes a shift from our current approach of creating containers based on the arbitrarily made createconfig. the new approach would be to have a specification that is detached from the podman cli. the spec could then be generated and used to make a container. this theoretically is the beginning of a long-needed refactor involving how we get from the cli -> libpod | apiv2 -> libpod with code re-use and less duplication. the intent is to build the apiv2 container creation based on this approach only. wiring to the podman cli will happen after the fact. Signed-off-by: Brent Baude <bbaude@redhat.com>
| * | | | Initial implementation of a spec generator packageMatthew Heon2020-02-04
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current Libpod pkg/spec has become a victim of the better part of three years of development that tied it extremely closely to the current Podman CLI. Defaults are spread across multiple places, there is no easy way to produce a CreateConfig that will actually produce a valid container, and the logic for generating configs has sprawled across at least three packages. This is an initial pass at a package that generates OCI specs that will supersede large parts of the current pkg/spec. The CreateConfig will still exist, but will effectively turn into a parsed CLI. This will be compiled down into the new SpecGenerator struct, which will generate the OCI spec and Libpod create options. The preferred integration point for plugging into Podman's Go API to create containers will be the new CreateConfig, as it's less tied to Podman's command line. CRI-O, for example, will likely tie in here. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #5086 from baude/fmtbeforelintOpenShift Merge Robot2020-02-04
|\ \ \ \ | | | | | | | | | | {CI:DOCS] run gofmt before lint
| * | | | {CI:DOCS] run gofmt before lintBrent Baude2020-02-04
|/ / / / | | | | | | | | | | | | | | | | | | | | the linting task identifies gofmt issues; therefore it makes more sense to run our make gofmt first, which actually fixes the gofmt issues. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #5033 from sujil02/new-testOpenShift Merge Robot2020-02-04
|\ \ \ \ | | | | | | | | | | Adding test to check Tag and list images endpoints in apis.
| * | | | Add a binding test to check image tag and list commands.Sujil022020-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Include testcase to validate tag api responses and check if all the image instaces are shown list command. Also, Update the binding process and the response Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | | Merge pull request #5080 from openSUSE/containerfile-context-fixOpenShift Merge Robot2020-02-04
|\ \ \ \ \ | |_|_|/ / |/| | | | Fix wrong Containerfile location on build
| * | | | Fix wrong Containerfile location on buildSascha Grunert2020-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Podman does select the wrong Containerfile if the current working directory contains a Containerfile but we specify one from a different location. Reproducer: ``` > mkdir 1 > echo FROM scratch > Containerfile > echo FROM golang > 1/Containerfile > podman build -f 1/Containerfile -t test STEP 1: FROM scratch ``` Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | | | Merge pull request #5079 from openSUSE/error-image-sizeOpenShift Merge Robot2020-02-04
|\ \ \ \ \ | |/ / / / |/| | | | Wrap error for failing ImageSize calls
| * | | | Wrap error for failing ImageSize callsSascha Grunert2020-02-04
| | |/ / | |/| | | | | | | | | | Signed-off-by: Sascha Grunert <sgrunert@suse.com>
* | | | Merge pull request #5060 from vrothberg/v2-libpod-image-endpointsOpenShift Merge Robot2020-02-04
|\ \ \ \ | | | | | | | | | | [CI:DOCS] swagger: v2: libpod/images/{import,load,pull}
| * | | | swagger: v2: libpod/images/{import,load,pull}Valentin Rothberg2020-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Note: this commit is merely adding swagger documentation and the golang stubs and types for the proposed endpoints. The implementation will follow in separate individual changes in the future. The ultimate goal is to prevent the libpod API from exposing the rather complex /images/create endpoint from Docker and split it into easier to implement, use and comprehend endpoints with a more narrow focus. # Import Add the v2 swagger documentation for the libpod/images/import endpoint. Note that we have intend to have separate backend and not mix it up with load since import allows for specifying a URL instead of a local tarball. # Load Complete the v2 swagger documentation for the libpod/images/load endpoint. Note that we are accounting for future plans to be able to load multiple images from one oci/docker archive by returning an array of image-load responses. Also move the (incomplete) implementation of the generic endpoint to the corresponding package and create a stub for the libpod handler, which will be implemented once there's an agreement on the proposed API. # Pull Add the v2 swagger documentation for the libpod/images/pull endpoint. Similar to the load endpoint, we return an array since more than one image can be pulled when the `all-tags` parameter is set. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #5073 from baude/sepnetoptionsOpenShift Merge Robot2020-02-04
|\ \ \ \ \ | |/ / / / |/| | | | seperate container create network options
| * | | | seperate container create network optionsBrent Baude2020-02-03
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this pr splits off some of the network container create options into a different flag set. the options in question are: --add-host --dns --dns-opt --dns-search --ip --mac-address --network --no-hosts --publish in the future, these options are going to be added to the pod create flags. this makes that transition easier and provides for less code duplication. Signed-off-by: Brent Baude <bbaude@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-30 20:23:24 +0000