summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* podman stats: work with network connect/disconnectPaul Holzinger2022-05-31
| | | | | | | | | | | | | | | | | Hardcoding the interface name is a bad idea. We have no control over the actual interface name since the user can change it. The correct thing is to read them from the network status. Since the contianer can have more than one interface we have to add the RX/TX values. The other values are currently not used. For podman 5.0 we should change it so that the API can return the statistics per interface and the client should sum the TX/RX for the command output. This is what docker is doing. Fixes #13824 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Merge pull request #14383 from jwhonce/wip/info_todoOpenShift Merge Robot2022-05-27
|\ | | | | Add Authorization field to Plugins for Info
| * Refactor populating uptimeJhon Honce2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor populating uptime field to use standard library parsing and math for populating the hour, minute, seconds fields. Note: the go-humanize package does not cover time.Duration just time.time. ```release-note NONE ``` [NO NEW TESTS NEEDED] Signed-off-by: Jhon Honce <jhonce@redhat.com>
| * Add Authorixation field to Plugins for InfoJhon Honce2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The Authorization field lists the plugins for granting access to the Docker daemon. This field will always be nil for Podman as there is no daemon. The field is included for compatibility. ```release-note NONE ``` [NO NEW TESTS NEEDED] Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #14393 from jwhonce/wip/archive_todoOpenShift Merge Robot2022-05-27
|\ \ | | | | | | Add API support for NoOverwriteDirNonDir
| * | Add API support for NoOverwriteDirNonDirJhon Honce2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update method signatures and structs to pass option to buildah code ```release-note NONE ``` [NO NEW TESTS NEEDED] Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #14320 from flouthoc/build-honor-squash-and-layersOpenShift Merge Robot2022-05-27
|\ \ \ | | | | | | | | build: allow using `cache` explicitly with `--squash-all` using `--layers`
| * | | vendor: bump buildah to v1.26.1-0.20220524184833-5500333c2e06Aditya R2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | Bump buildah to v1.26.1-0.20220524184833-5500333c2e06 Signed-off-by: Aditya R <arajan@redhat.com>
| * | | build: allow using cache explicitly with --squash-all using --layersAditya R2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Buildah already supports using `--layers` with `--squash` after https://github.com/containers/buildah/pull/3674 if user wants to do so hence podman must honor similar configuration in `--squash-all` behaviour if user wants to using cache. PS: We cannot alter behaviour of `podman build --squash` for docker-compat reasons hence this feature can be easily supported by `--squash-all`. Closes: https://github.com/containers/buildah/issues/4011 Signed-off-by: Aditya R <arajan@redhat.com>
| * | | cmd, build: remove redundant squash processing logicAditya R2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Same block contains similar lines above this is not needed as this looks redundant. [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
* | | | Merge pull request #14387 from TomSweeneyRedHat/dev/tsweeney/quickdocOpenShift Merge Robot2022-05-27
|\ \ \ \ | |_|/ / |/| | | [CI:DOCS] Quick typo for troubleshooting
| * | | [CI:DOCS] Quick typo for troubleshootingtomsweeneyredhat2022-05-26
|/ / / | | | | | | | | | | | | | | | | | | After lgtming the latest from @flouthouc, I spotted one more minor typo in the troubleshooting guide. This corrects it. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
* | | Merge pull request #14382 from jwhonce/wip/init_todoOpenShift Merge Robot2022-05-26
|\ \ \ | | | | | | | | Remove TODO comment
| * | | Remove TODO commentJhon Honce2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allowing custom flags to provider has the potential to break all the hand-crafted commands currently in use. This could become a support nightmare. ```release-note NONE ``` [NO NEW TESTS NEEDED] Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #14377 from SoMuchForSubtlety/fix/pod-inspect-responseOpenShift Merge Robot2022-05-26
|\ \ \ \ | | | | | | | | | | Fix swagger model of `InspectPodResponse`
| * | | | Fix swagger model of `InspectPodResponse`Jakob Ahrer2022-05-26
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `net.IP` gets marshalled as `string` and not `[]uint8` [NO TESTS NEEDED] [NO NEW TESTS NEEDED] Signed-off-by: Jakob Ahrer <jakob@ahrer.dev>
* | | | Merge pull request #14374 from umohnani8/todo-3OpenShift Merge Robot2022-05-26
|\ \ \ \ | | | | | | | | | | Combine the CheckAllLatest CID and PodID functions
| * | | | Combine the CheckAllLatest CID and PodID functionsUrvashi Mohnani2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These two functions were doing the exact same thing just with cidfile and pod-id-file separately. Combine the functionality to one function to remove repetative code. Fix the TODO in cmd/podman/validate/args.go [NO NEW TESTS NEEDED] Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | | | | Merge pull request #14355 from flouthoc/server-client-compat-for-bug-fixOpenShift Merge Robot2022-05-26
|\ \ \ \ \ | |_|_|_|/ |/| | | | [CI:Docs]: note regarding version compatablity between server and client for bug fixes.
| * | | | docs: note regarding version compatablity between server and client for bug ↵Aditya R2022-05-26
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | fixes Add a small note to troubleshooting docs regaring version parity between podman-client and podman-server when looking for bug fixes. [NO TESTS NEEDED] [NO NEW TESTS NEEDED] Closes: https://github.com/containers/podman/issues/12660 Signed-off-by: Aditya R <arajan@redhat.com>
* | | | Merge pull request #14381 from cevich/fix_cirrus_todoOpenShift Merge Robot2022-05-26
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Cirrus: Fix several TODOs
| * | | | Cirrus: Fix several TODOsChris Evich2022-05-26
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most were simply deleted, the main one addressed is in the "pre-testing" `ext_svc_check.sh` script. It will now verify accessibility of several key test images we maintain in `quay.io`. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #14373 from umohnani8/todo-2OpenShift Merge Robot2022-05-26
|\ \ \ \ | |/ / / |/| | | Fix TODO in pod/ps.go and parse/net.go
| * | | Fix TODO in parse/net.goUrvashi Mohnani2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix up the parseEnv function to differentiate between a label and env when parsing. Don't do a system lookup when parsing labels. [NO NEW TESTS NEEDED] Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
| * | | Remove TODO from pods/ps.goUrvashi Mohnani2022-05-26
| |/ / | | | | | | | | | | | | | | | | | | | | | The TODO has already been fixed. Filters is now a []string [NO NEW TESTS NEEDED] Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | | Merge pull request #14378 from SoMuchForSubtlety/fix-contributing-docsOpenShift Merge Robot2022-05-26
|\ \ \ | | | | | | | | [CI:DOCS] Fix test block bypass instructions
| * | | Fix test block bypass instructionsJakob Ahrer2022-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A new string was added in 521c0cb and the old one removed with 2ed31f9 [NO NEW TESTS NEEDED] Signed-off-by: Jakob Ahrer <jakob@ahrer.dev>
* | | | Merge pull request #14318 from umohnani8/play-kubeOpenShift Merge Robot2022-05-26
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Add play kube support docs
| * | | | [CI:DOCS] Add play kube support docsUrvashi Mohnani2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a doc to outline which kube yaml fields the play kube command currently supports. This will be updated as more fields are supported in the future. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | | | | Merge pull request #14369 from mheon/fixmes_2OpenShift Merge Robot2022-05-26
|\ \ \ \ \ | |_|_|_|/ |/| | | | Remove more FIXMEs
| * | | | Remove more FIXMEsMatthew Heon2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mostly, just removing the comments. These either have been done, or are no longer a good idea. No code changes. [NO NEW TESTS NEEDED] as such. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #14366 from jwhonce/wip/rm_todoOpenShift Merge Robot2022-05-25
|\ \ \ \ \ | | | | | | | | | | | | Support remote deadlock errors in rm
| * | | | | Support remote deadlock errors in rmJhon Honce2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Refactor test for deadlock by comparing error text vs. actual ErrWillDeadlock constant. When running with --remote the error constant will always be not equal to the error returned by the API. ```release-note NONE ``` [NO NEW TESTS NEEDED] Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | Merge pull request #14329 from mheon/fixmes_1OpenShift Merge Robot2022-05-25
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | First batch of resolutions to FIXMEs
| * | | | | First batch of resolutions to FIXMEsMatthew Heon2022-05-25
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Most of these are no longer relevant, just drop the comments. Most notable change: allow `podman kill` on paused containers. Works just fine when I test it. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #14364 from jwhonce/wip/diff_todoOpenShift Merge Robot2022-05-25
|\ \ \ \ \ | |/ / / / |/| | | | Remove unused archive flag from diff commands
| * | | | Remove unused archive flag from diff commandsJhon Honce2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Option left in images/diff.go CLI as comment implies it is needed for backwards compatibility. ```release-note NONE ``` [NO NEW TESTS NEEDED] Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #14342 from ↵Daniel J Walsh2022-05-25
|\ \ \ \ \ | |_|/ / / |/| | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.2 build(deps): bump github.com/vbauerster/mpb/v7 from 7.4.1 to 7.4.2
| * | | | build(deps): bump github.com/vbauerster/mpb/v7 from 7.4.1 to 7.4.2dependabot[bot]2022-05-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/vbauerster/mpb/v7](https://github.com/vbauerster/mpb) from 7.4.1 to 7.4.2. - [Release notes](https://github.com/vbauerster/mpb/releases) - [Commits](https://github.com/vbauerster/mpb/compare/v7.4.1...v7.4.2) --- updated-dependencies: - dependency-name: github.com/vbauerster/mpb/v7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #14361 from Luap99/netflakeOpenShift Merge Robot2022-05-25
|\ \ \ \ \ | |_|/ / / |/| | | | fix f35 integration test network flake
| * | | | fix f35 integration test network flakePaul Holzinger2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I am not 100% sure if this is actually causing the problem but I was able to reproduce locally and this change fixed it there. Without the `-n` option iptables tries to reverse lookup the ips to domain names. This is extremely slow for unknown reasons. Given the large amount of iptables entries due parallel test runs it will not succeed in the default 90 sec timeout. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #14358 from vrothberg/todo-part-2OpenShift Merge Robot2022-05-25
|\ \ \ \ \ | | | | | | | | | | | | Todo part 2
| * | | | | test/system/250-systemd.bats: clean up outdated TODOValentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `podman auto-update` is now properly exercised in the system tests, so we can safely remove the outdated TODO. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | pkg/bindings/play/play.go: drop TODO messageValentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As already done in a previous commit: a global system context does not make sense for bindings, so remove the message. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | pkg/bindings/containers/archive.go: drop TODOValentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We are already passed 4.0 and a wrapper like this really does not hurt. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | pkg/auth: drop the TODOValentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is not a TODO item and if, it should be added to c/image. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | pkg/api/handlers/compat/images.go: drop TODO messageValentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | An undefined "this" or "that" is terrible. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | libpod/pod_top_linux.go: s/TODO/NOTE/Valentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As it really is a note and not a TODO item. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | events: drop TODO commentValentin Rothberg2022-05-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can evaluate a solution in case adding more events really turns into a problem. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | | | Merge pull request #14357 from rhatdan/codespellOpenShift Merge Robot2022-05-25
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | Fix codespell errors
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-20 16:38:37 +0000