summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #2523 from jwhonce/bug/2521OpenShift Merge Robot2019-03-04
|\ | | | | Fix #2521
| * Fix #2521Jhon Honce2019-03-04
| | | | | | | | | | | | * Bad merge against podman stop, restored overwritten code Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #2513 from mheon/log_timestamps_newlineOpenShift Merge Robot2019-03-04
|\ \ | |/ |/| Ensure that each log line is newline-terminated
| * Add additional defense against 0-length log segfaultsMatthew Heon2019-03-03
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * When logging with timestamps, append only until newlineMatthew Heon2019-03-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we log time timestamps, don't print a new timestamp for each input - instead, print one at the start of every line, and then wait until we hit a newline to print a new timestamp. This still doesn't exactly mirror the Docker behavior (they don't print until they receive an entire line, while we print any time the logs file is appended to - so you can see partial lines being typed in our system). Also, timestamps are recorded as the start of a line being typed, as opposed to when the enter key is pressed (on Docker). (Worth noting that, while characters are printed as they are typed, logs does respect the backspace key - so you'll also see them disappear as the person typing realizes they've made a mistake and retypes their command). This is the closest we can get to Docker without major surgery on the Kubernetes log-printing library, so I'm content to call this an adequate solution. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Ensure that each log line is newline-terminatedMatthew Heon2019-03-03
| | | | | | | | | | | | | | | | | | When writing logs with timestamps to the terminal, ensure that each line is newline-terminated, so we don't end up with an unreadable mess with timestamps interspersed with the actual content being displayed. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #2511 from rhatdan/testOpenShift Merge Robot2019-03-04
|\ \ | | | | | | Add missing short flag -l for run/create
| * | Add missing short flag -l for run/createDaniel J Walsh2019-03-03
| | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #2517 from QiWang19/i2509OpenShift Merge Robot2019-03-04
|\ \ \ | | | | | | | | Don't extract tar file in podman cp
| * | | Don't extract tar file in podman cpQi Wang2019-03-04
| | | | | | | | | | | | | | | | Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | Merge pull request #2515 from giuseppe/fill_tmp_dir_for_confOpenShift Merge Robot2019-03-04
|\ \ \ \ | | | | | | | | | | runtime: fill a proper default tmpdir when --config is used
| * | | | runtime: fill a proper default tmpdir when --config is usedGiuseppe Scrivano2019-03-04
| | |/ / | |/| | | | | | | | | | | | | | | | | | Closes: https://github.com/containers/libpod/issues/2408 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #2512 from edsantiago/yet_more_usage_fixesOpenShift Merge Robot2019-03-04
|\ \ \ \ | |_|/ / |/| | | A few more usage-message tweaks
| * | | A few more usage-message tweaksEd Santiago2019-03-03
| |/ / | | | | | | | | | | | | | | | Minor stuff, but it corrects some errors in usage messages. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #2364 from jwhonce/wip/remote_stopOpenShift Merge Robot2019-03-04
|\ \ \ | |/ / |/| | Support podman-remote stop container
| * | Support podman-remote stop container(s)Jhon Honce2019-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Clean up adapter code * Add GetContainersByContext to Varlink API * Add missing comments * Restore save command * Restore error type mapping when using varlink Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #2477 from rhatdan/testOpenShift Merge Robot2019-03-03
|\ \ \ | |/ / |/| | Add tests to make sure podman container and podman image commands work
| * | Fix aliased commands to actually workDaniel J Walsh2019-03-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current aliased commands podman container list and podman image list podman image rm Do not work properly. The global storage options are broken. This patch fixes this issue. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | Add tests to make sure podman container and podman image commands workDaniel J Walsh2019-03-02
|/ / | | | | | | | | | | | | | | | | We have little to no testing to make sure we don't break podman image and podman container commands that wrap traditional commands. This PR adds tests for each of the commands. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #2499 from mheon/bump-1.1.1OpenShift Merge Robot2019-03-01
|\ \ | | | | | | Bump to v1.1.1
| * | Bump gitvalidation epochMatthew Heon2019-03-01
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump to v1.2.0-devMatthew Heon2019-03-01
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump to v1.1.1v1.1.1Matthew Heon2019-03-01
|/ / | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2497 from mheon/release_notes_v1.1.1OpenShift Merge Robot2019-03-01
|\ \ | | | | | | Update release notes for v1.1.1
| * | Update release notes for v1.1.1Matthew Heon2019-03-01
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #2495 from baude/runlabelpulldefaultOpenShift Merge Robot2019-03-01
|\ \ \ | | | | | | | | Pull image for runlabel if not local
| * | | Pull image for runlabel if not localbaude2019-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In cases where a user issues the podman container runlabel command and the image is not local, we now default to pulling the image automatically to mimic the atomic cli behavior. Fixes: BZ #1677905 Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #2482 from edsantiago/podman_image_rmOpenShift Merge Robot2019-03-01
|\ \ \ \ | | | | | | | | | | Fix usage messages for podman image list, rm
| * | | | Fix usage messages for podman image list, rmEd Santiago2019-02-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pr #2480 fixed the missing 'podman image list/rm' commands; it broke their usage messages. This corrects both usage messages and also their examples. Also: add an e2e test for 'podman image rm' (untested) Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #2452 from edsantiago/no_more_argsOpenShift Merge Robot2019-03-01
|\ \ \ \ \ | | | | | | | | | | | | Command-line input validation: reject unused args
| * | | | | Command-line input validation: reject unused argsEd Santiago2019-02-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Several podman commands accept no subcommands. Some of those were not actually checking, though, which could lead to user confusion. Added validation where missing; and, refactored to minimize duplication. (Side note: I decided against using cobra.NoArgs because its error message, "unknown command", misleadingly implies that there are known ones). Also added validation to varlink Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #2451 from baude/playrenamepodoncollisionOpenShift Merge Robot2019-03-01
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | rename pod when we have a name collision with a container
| * | | | | rename pod when we have a name collision with a containerbaude2019-02-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when podman generate kube runs, it names the pod based on the first container it finds. the resulting yaml file is perfectly acceptable in a kubernetes environment. But when replaying the YAML file with podman, we cannot have a container and pod with the same name. therefore, we rename the pod if find a collision to name_pod. Signed-off-by: baude <bbaude@redhat.com>
* | | | | | Merge pull request #2485 from adrianreber/oci-checkOpenShift Merge Robot2019-03-01
|\ \ \ \ \ \ | | | | | | | | | | | | | | Verify that used OCI runtime supports checkpoint
| * | | | | | Verify that used OCI runtime supports checkpointAdrian Reber2019-03-01
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To be able to use OCI runtimes which do not implement checkpoint/restore this adds a check to the checkpoint code path and the checkpoint/restore tests to see if it knows about the checkpoint subcommand. If the used OCI runtime does not implement checkpoint/restore the tests are skipped and the actual 'podman container checkpoint' returns an error. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | | | Merge pull request #2483 from cevich/important_contrib_noteOpenShift Merge Robot2019-03-01
|\ \ \ \ \ \ | | | | | | | | | | | | | | [ci skip] Add critical note about skip-ci and merge bot
| * | | | | | [ci skip] Critical note about merge botChris Evich2019-02-28
| |/ / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | Merge pull request #2486 from edsantiago/podman_command_compareEd Santiago2019-03-01
|\ \ \ \ \ \ | | | | | | | | | | | | | | podman-commands script: refactor
| * | | | | | podman-commands script: refactorEd Santiago2019-02-28
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make more general-purpose: instead of hardcoding a list of known subcommands, and duplicating sed pipelines for each, rely on 'podman help' itself to tell us which podman commands have subcommands; and examine each in turn. Should there ever be new subcommands, this will identify and test them. A special case is needed for 'podman image trust', whose documentation format doesn't match the others. The change to `common.go` fixes an inconsistency: the Usage message for commands with subcommands had an unnecessary blank line, making it harder to parse automatically. This simply produces consistent Usage messages for all podman commands. This script will not pass until #2480 is merged. After that, the goal is to add this as a CI hook. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #2493 from edsantiago/broken_doc_linksEd Santiago2019-03-01
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix link inconsistencies in man pages
| * | | | | | Fix link inconsistencies in man pagesEd Santiago2019-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Found via: for i in docs/*.md;do x=$(perl -ne 'if (/\[(podman-.*?)\(1\)\]\((podman-.*?)\.1\.md/) { print " $1 != $2\n" if $1 ne $2; print " ENOENT $2\n" unless -e "docs/$2.1.md" }' <$i); if [ -n "$x" ]; then echo $i; echo "$x";fi;done ...which is probably a good candidate for another CI hook, except I have no idea how to rewrite it in awk. Additionally, mark `podman refresh` and `podman container refresh` as hidden, remove its man page, and remove references to it from all other man pages. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #2481 from cevich/sysexec_waitcompleteOpenShift Merge Robot2019-03-01
|\ \ \ \ \ \ \ | |_|_|_|_|_|/ |/| | | | | | Fix SystemExec completion race
| * | | | | | Fix SystemExec completion raceChris Evich2019-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some callers assume when SystemExec returns, the command has completed. Other callers explicitly wait for completion (as required). However, forgetting to do that is an incredibly easy mistake to make. Fix this by adding an explicit parameter to the function. This requires every caller to deliberately state whether or not a completion-check is required. Also address **many** resource naming / cleanup completion-races. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | | | Merge pull request #2492 from rhatdan/pullOpenShift Merge Robot2019-03-01
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | Should be defaulting to pull not pull-always
| * | | | | | Should be defaulting to pull not pull-alwaysDaniel J Walsh2019-02-28
|/ / / / / / | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #2484 from rhatdan/manOpenShift Merge Robot2019-02-28
|\ \ \ \ \ \ | | | | | | | | | | | | | | No podman container ps command exists
| * | | | | | Move Alias lines to descriptions of commandsDaniel J Walsh2019-02-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | | | | No podman container ps command existsDaniel J Walsh2019-02-28
| | |/ / / / | |/| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #2461 from adrianreber/disableOpenShift Merge Robot2019-02-28
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Skip checkpoint/restore tests on Fedora for now
| * | | | | Skip checkpoint/restore tests on Fedora for nowAdrian Reber2019-02-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is currently still one SELinux related checkpoint/restore problem: https://github.com/containers/libpod/issues/2334 To avoid unnecessary CI failures the checkpoint/restore tests are temporarily disabled on Fedora. It is not necessary to disable the tests on Ubuntu as it is running without SELinux and it is also not necessary to disable the RHEL 7 tests as RHEL's CRIU is too old to run the checkpoint/restore tests at all. Signed-off-by: Adrian Reber <areber@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-12 20:41:17 +0000