summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #3082 from mheon/pod_removal_reliabilityOpenShift Merge Robot2019-05-08
|\ | | | | Improve robustness of pod removal
| * Preserve errors returned by removing podsMatthew Heon2019-05-07
| | | | | | | | | | | | | | | | Ensure that, if an error occurs somewhere along the way when we remove a pod, it's preserved until the end and returned, even as we continue to remove the pod. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Improve robustness of pod removalMatthew Heon2019-05-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removing a pod must first removal all containers in the pod. Libpod requires the state to remain consistent at all times, so references to a deleted pod must all be cleansed first. Pods can have many containers in them. We presently iterate through all of them, and if an error occurs trying to clean up and remove any single container, we abort the entire operation (but cannot recover anything already removed - pod removal is not an atomic operation). Because of this, if a removal error occurs partway through, we can end up with a pod in an inconsistent state that is no longer usable. What's worse, if the error is in the infra container, and it's persistent, we get zombie pods - completely unable to be removed. When we saw some of these same issues with containers not in pods, we modified the removal code there to aggressively purge containers from the database, then try to clean up afterwards. Take the same approach here, and make cleanup errors nonfatal. Once we've gone ahead and removed containers, we need to see pod deletion through to the end - we'll log errors but keep going. Also, fix some other small things (most notably, we didn't make events for the containers removed). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #3085 from cevich/snuffleupagusOpenShift Merge Robot2019-05-08
|\ \ | | | | | | Add simple test to confirm bad command-line arguments
| * | Add negative command-line testChris Evich2019-05-08
|/ / | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #3076 from baude/healthcheckmanOpenShift Merge Robot2019-05-07
|\ \ | | | | | | podman-run|create man updates
| * | podman-run|create man updatesbaude2019-05-07
| | | | | | | | | | | | | | | | | | | | | the healthcheck commands were not being specified in the man pages for run and create. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #2977 from baude/makeitrainOpenShift Merge Robot2019-05-07
|\ \ \ | | | | | | | | enable integration tests for remote-client
| * | | enable integration tests for remote-clientbaude2019-05-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | first pass at enabling a swath of integration tests for the remote-client. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #3080 from baude/remotepsnamespaceOpenShift Merge Robot2019-05-07
|\ \ \ \ | |/ / / |/| | | fix podman-remote ps --ns
| * | | fix podman-remote ps --nsbaude2019-05-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the namespace for the remote client was being incorrectly derived from the "remote" client. fixes: #2938 Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #3073 from mheon/force_lock_reallocOpenShift Merge Robot2019-05-07
|\ \ \ \ | |/ / / |/| | | When refreshing after a reboot, force lock allocation
| * | | Remove tests for deprecated podman-refresh commandMatthew Heon2019-05-06
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | When refreshing after a reboot, force lock allocationMatthew Heon2019-05-06
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After a reboot, when we refresh Podman's state, we retrieved the lock from the fresh SHM instance, but we did not mark it as allocated to prevent it being handed out to other containers and pods. Provide a method for marking locks as in-use, and use it when we refresh Podman state after a reboot. Fixes #2900 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #3074 from baude/checkoutpointmenuOpenShift Merge Robot2019-05-07
|\ \ \ | |_|/ |/| | remote-podman checkpoint and restore add to container submenu
| * | remote-podman checkpoint and restore add to container submenubaude2019-05-06
| | | | | | | | | | | | | | | | | | | | | the remote-podman checkpoint and restore commands were done some time ago but for some reason not added to the container subcommand Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #3070 from baude/generatesystemdtestsOpenShift Merge Robot2019-05-06
|\ \ \ | |/ / |/| | add unit tests for generate systemd
| * | add unit tests for generate systemdbaude2019-05-06
| | | | | | | | | | | | | | | | | | it looks like i forgot to add the unit tests for generate systemd Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #3048 from cevich/varlink_api_checkOpenShift Merge Robot2019-05-06
|\ \ \ | |_|/ |/| | Cirrus: Add check for make varlink_api_generate
| * | Fix API.mdChris Evich2019-05-03
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Add missing task dependenciesChris Evich2019-05-03
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Add check for make varlink_api_generateChris Evich2019-05-03
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #3069 from mheon/bump-1.3.0OpenShift Merge Robot2019-05-06
|\ \ \ | |_|/ |/| | Bump to v1.3.0
| * | Bump gitvalidation epochMatthew Heon2019-05-06
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump to v1.3.1-devMatthew Heon2019-05-06
| | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | Bump to v1.3.0v1.3.0Matthew Heon2019-05-06
|/ / | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #3065 from mheon/release_notes_1.3.0OpenShift Merge Robot2019-05-06
|\ \ | | | | | | Update release notes for 1.3.0 release
| * | Update release notes for 1.3.0 releaseMatthew Heon2019-05-05
| |/ | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #3067 from TomSweeneyRedHat/dev/tsweeney/buildah1.8.2OpenShift Merge Robot2019-05-04
|\ \ | | | | | | Bump to Buildah v1.8.2
| * | Bump to Buildah v1.8.2TomSweeneyRedHat2019-05-03
| | | | | | | | | | | | | | | | | | As the title suggests. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #3066 from mheon/events_libpod_manpageOpenShift Merge Robot2019-05-04
|\ \ \ | |/ / |/| | Document events logger options in libpod.conf manpage
| * | Document events logger options in libpod.conf manpageMatthew Heon2019-05-03
| |/ | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2826 from mheon/restart_policyOpenShift Merge Robot2019-05-03
|\ \ | |/ |/| Add restart policy for containers
| * Try and fix restart-policy testsMatthew Heon2019-05-03
| | | | | | | | | | | | | | Theory: it's SELinux blowing up and preventing us from creating files as the container. Try and use a fresh dir and :Z to fix. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Fix manpage typosMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Small code fixMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Fix 'restart' event in journaldMatthew Heon2019-05-03
| | | | | | | | | | | | | | Ensure that we can decode the restart event with the new journald events. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Address review comments on restart policyMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Add a test for restart policyMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Add a restart event, and make one during restart policyMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Restart policy should not run if a container is runningMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Restart policy conflicts with the --rm flagMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Move to using constants for valid restart policy typesMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Add manpage information for restart policyMatthew Heon2019-05-03
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Add support for retry count with --restart flagMatthew Heon2019-05-03
| | | | | | | | | | | | | | | | | | The on-failure restart option supports restarting only a given number of times. To do this, we need one additional field in the DB to track restart count (which conveniently fills a field in Inspect we weren't populating), plus some plumbing logic. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Sending signals to containers prevents restart policyMatthew Heon2019-05-03
| | | | | | | | | | | | Noticed this when testing some behavior with Docker. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Add container restart policy to Libpod & PodmanMatthew Heon2019-05-03
| | | | | | | | | | | | | | This initial version does not support restart count, but it works as advertised otherwise. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Add a StoppedByUser field to the DBMatthew Heon2019-05-03
| | | | | | | | | | | | | | | | This field indicates that a container was explciitly stopped by an API call, and did not exit naturally. It's used when implementing restart policy for containers. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #2971 from QiWang19/logoutcheckOpenShift Merge Robot2019-05-03
|\ \ | | | | | | fix logout message if login only with docker
| * | fix logout message if login only with dockerQi Wang2019-05-03
| | | | | | | | | | | | | | | | | | if checkAuth() success but not logged in with podman, assume it's logged in with docker and retrun the message. Signed-off-by: Qi Wang <qiwan@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-20 03:44:02 +0000