summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #13588 from flouthoc/import-os-archOpenShift Merge Robot2022-03-23
|\ | | | | import: allow users to set `--os`, `--arch` and `--variant` of image imports
| * import: allow users to set os, arch and variant of importsAditya R2022-03-23
| | | | | | | | | | | | | | | | | | | | Allows users to set `--os` , `--arch` and `--variant` of the image created from the custom import. Following is useful when user is already aware of the values which are correct for their generated rootfs Signed-off-by: Aditya R <arajan@redhat.com>
* | Merge pull request #13576 from ↵OpenShift Merge Robot2022-03-23
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/ocicrypt-1.1.3 build(deps): bump github.com/containers/ocicrypt from 1.1.2 to 1.1.3
| * | build(deps): bump github.com/containers/ocicrypt from 1.1.2 to 1.1.3dependabot[bot]2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/ocicrypt](https://github.com/containers/ocicrypt) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/containers/ocicrypt/releases) - [Commits](https://github.com/containers/ocicrypt/compare/v1.1.2...v1.1.3) --- updated-dependencies: - dependency-name: github.com/containers/ocicrypt dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | Merge pull request #13567 from n1hility/upgradesOpenShift Merge Robot2022-03-23
|\ \ \ | | | | | | | | Add Windows installer support for upgrades
| * | | Add Windows installer support for upgradesJason T. Greene2022-03-19
| | | | | | | | | | | | | | | | | | | | | | | | Fixes duplicate installer entries after multiple installs Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
* | | | Merge pull request #13605 from jerrykan/docsOpenShift Merge Robot2022-03-23
|\ \ \ \ | | | | | | | | | | [CI:DOCS] docs: Fix links to Containerfile and containerignore
| * | | | docs: Fix links to Containerfile and containerignoreJohn Kristensen2022-03-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The documentation files for `Containerfile` and `containerignore` have been moved from the `buildah` repository to the `common` repository. ref: https://github.com/containers/buildah/commit/488e8654ea Signed-off-by: John Kristensen <john@jerrykan.com>
* | | | | Merge pull request #13604 from jwhonce/issues/12804OpenShift Merge Robot2022-03-23
|\ \ \ \ \ | |/ / / / |/| | | | Update swagger to improve compatibility
| * | | | Update swagger to improve compatibilityJhon Honce2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Improve swagger and handler code compatibility. Fixes #12804 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | Merge pull request #13598 from Luap99/unshare-docOpenShift Merge Robot2022-03-22
|\ \ \ \ \ | |/ / / / |/| | | | [CI:DOCS] podman unshare: document that command cannot be used with remote
| * | | | podman unshare: document that command cannot be used with remotePaul Holzinger2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #13596 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #13593 from Luap99/compose-flakev2OpenShift Merge Robot2022-03-22
|\ \ \ \ \ | | | | | | | | | | | | fix compose test error in retry logic
| * | | | | fix compose test error in retry logicPaul Holzinger2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We cannot use local var outside of a function. We have to use a global one. Log: https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/5970023511490560/html/compose_v2-podman-fedora-35-root-host.log.html Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | | Merge pull request #13595 from edsantiago/logformatter_netavarkOpenShift Merge Robot2022-03-22
|\ \ \ \ \ \ | | | | | | | | | | | | | | Fix unreadable netavark logs
| * | | | | | Fix unreadable netavark logsEd Santiago2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ginkgo netavark logs (and, to a lesser extent, cni logs) are unreadable because the hide-boring-opts code did not know about --network-backend. Now it does. Manually filtered an existing netavark log to confirm there are no other new options we should know about. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #13518 from edsantiago/size_check_part1OpenShift Merge Robot2022-03-22
|\ \ \ \ \ \ \ | |_|_|/ / / / |/| | | | | | Binary growth check, part 1 of 2
| * | | | | | Binary growth check, part 1 of 2Ed Santiago2022-03-22
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a CI check to prevent unwanted bloat in binary images, by building a baseline (pre-PR) binary then comparing file sizes post-PR. We piggyback onto the existing 'Build Each Commit' CI check because it gives us an easy way to run 'make' against the parent commit. This is part 1 of 2: adding the script, not the Makefile rule. We can't add the Makefile rule now because the script it would invoke does not exist in the parent commit. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #13398 from giuseppe/fix-warning-pod-create-rmOpenShift Merge Robot2022-03-22
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | libpod: drop warning if cgroup doesn't exist
| * | | | | libpod: drop warning if cgroup doesn't existGiuseppe Scrivano2022-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | do not print a warning on cgroup removal if it doesn't exist. Closes: https://github.com/containers/podman/issues/13382 [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | | Merge pull request #13580 from vrothberg/enable-lintersOpenShift Merge Robot2022-03-22
|\ \ \ \ \ \ | | | | | | | | | | | | | | enable linters
| * | | | | | fix a number of errcheck issuesValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Numerous issues remain, especially in tests/e2e. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | fix a number of `godot` issuesValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Still an unknown number remains but I am running out of patience. Adding dots is not the best use of my time. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: enable makezeroValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: enable nilerrValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A number of cases looked suspicious, so I marked them with `FIXME`s to leave some breadcrumbs. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: document nolintlintValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to keep disabling the `nolintlint` linter to continue using `nolint` directives in the code. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: document tagliatelleValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disabling tagliatelle would mean disabling it for hundreds of fields that cannot be changed due to K8s or Docker or backwards compat. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | test/e2e/inspect_test.go: wait for sessionsValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we're waiting for the ls container to finish to prevent potential flakes or future regressions. Spotted while enabling a linter. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: enable ineffassignValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: enable errchkjsonValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: enable wastedassignValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | | | linter: enable interfacerValentin Rothberg2022-03-22
| | |/ / / / | |/| | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | | | Merge pull request #13590 from giuseppe/add-note-for-additional-stores-deletionsOpenShift Merge Robot2022-03-22
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | [CI:DOCS] troubleshooting: document rm in image stores
| * | | | | [CI:DOCS] troubleshooting: document rm in image storesGiuseppe Scrivano2022-03-22
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes: https://github.com/containers/podman/issues/13003 [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #13585 from flouthoc/fix-no-healthcheckOpenShift Merge Robot2022-03-22
|\ \ \ \ \ | |/ / / / |/| | | | healthcheck: stop showing wrong status when `--no-healthcheck` is set
| * | | | healthcheck: stop showing wrong status when --no-healthcheck is setAditya R2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Containers started with `--no-healthcheck` are configured to contain no healthcheck and test configured as `NONE`. Podman shows wrong status as such use cases. Following commit fixes the faulty behavior of stauts field for containers started with `--no-healthcheck` Signed-off-by: Aditya R <arajan@redhat.com>
* | | | | Merge pull request #13584 from lsm5/fix-podman-remote-staticOpenShift Merge Robot2022-03-22
|\ \ \ \ \ | | | | | | | | | | | | Makefile: build podman-remote-static with cgo disabled
| * | | | | Makefile: build podman-remote-static with cgo disabledLokesh Mandvekar2022-03-21
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Resolves: #13557 [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | | Merge pull request #13577 from giuseppe/drop-fedora-31-warningOpenShift Merge Robot2022-03-22
|\ \ \ \ \ | |_|_|_|/ |/| | | | libpod: drop warning for Fedora 31
| * | | | libpod: drop warning for Fedora 31Giuseppe Scrivano2022-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | drop a warning for runc not supporting cgroup v2 on Fedora 31. [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | | Merge pull request #13536 from dcermak/storage-autodetect-mount_programOpenShift Merge Robot2022-03-22
|\ \ \ \ \ | |_|/ / / |/| | | | Storage autodetect mount program
| * | | | vendor containers/storage with https://github.com/containers/storage/pull/1165Dan Čermák2022-03-21
| |/ / / | | | | | | | | | | | | Signed-off-by: Dan Čermák <dcermak@suse.com>
* | | | Merge pull request #13575 from Luap99/percentOpenShift Merge Robot2022-03-21
|\ \ \ \ | | | | | | | | | | podman system df: fix percent calculation
| * | | | podman system df: fix percent calculationPaul Holzinger2022-03-21
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The calculate the percentage we need floating point numbers. The current code however casted the result of reclaimable/size to an int first. Casting to an int in go will just discard the decimal points, thus the result was either 0 or 1 so if multiplied by 100 it would show up as 0% or 100%. To fix this we have to multiply by 100 first before casting the result to an int. Also add a check for div by zero which results in NaN and use math.Round() to correctly round a number. Ref #13516 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #13574 from edsantiago/batsOpenShift Merge Robot2022-03-21
|\ \ \ \ | | | | | | | | | | pod system tests: clean up stray image
| * | | | pod system tests: clean up stray imageEd Santiago2022-03-21
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the pod tests was leaving a stray image behind, causing scary red warnings in CI logs. Clean that up. Also, now that #13541 has merged, use 'rmi --ignore' instead of ignoring exit status from rmi Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #13573 from vrothberg/golangci-lintOpenShift Merge Robot2022-03-21
|\ \ \ \ | |/ / / |/| | | bump golangci-lint to v1.45.0
| * | | bump golangci-lint to v1.45.0Valentin Rothberg2022-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * supports Go 1.18 * disable a number of new linters * fix minor stylecheck issues [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | Merge pull request #13541 from vrothberg/rmi-ignoreOpenShift Merge Robot2022-03-21
|\ \ \ \ | |/ / / |/| | | podman rmi --ignore
| * | | podman rmi --ignoreValentin Rothberg2022-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an `--ignore` flag to `podman image rm` to instruct ignoring image if a specified image does not exist and to not throw an error. Other commands (e.g., `podman container rm`) already support this flag. Such an `--ignore` flag can come in handy in clean-up scripcts such as the teardown phases in the Podman tests. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-07 22:52:29 +0000