summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #1865 from baude/existsOpenShift Merge Robot2018-11-26
|\ | | | | add podman container|image exists
| * add podman container|image existsbaude2018-11-26
|/ | | | | | | | | | Add an exists subcommand to podman container and podman image that allows users to verify the existence of a container or image by ID or name. The return code can be 0 (success), 1 (failed to find), or 125 (failed to work with runtime). Issue #1845 Signed-off-by: baude <bbaude@redhat.com>
* Merge pull request #1860 from TomasTomecek/version-add-formatOpenShift Merge Robot2018-11-25
|\ | | | | implement --format for version command
| * implement --format for version commandTomas Tomecek2018-11-25
| | | | | | | | Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
* | Merge pull request #1862 from elimisteve/patch-1OpenShift Merge Robot2018-11-25
|\ \ | |/ |/| podman_tutorial.md typo: arguement -> argument
| * podman_tutorial.md typos: arguement -> argument; missing 'a'Steve Phillips2018-11-24
|/ | | | Signed-off-by: Steve Phillips <steve@tryingtobeawesome.com>
* Merge pull request #1858 from adrianreber/paprOpenShift Merge Robot2018-11-23
|\ | | | | Load NAT modules to fix tests involving CRIU
| * Load NAT modules to fix tests involving CRIUAdrian Reber2018-11-23
|/ | | | | | | | | CRIU uses iptables to lock and unlock the network during checkpoint and restore. If Podman is running in Podman the automatic loading of modules does not work and thus this commit pre-loads the necessary modules to make sure the checkpoint test cases are not failing. Signed-off-by: Adrian Reber <areber@redhat.com>
* Merge pull request #1835 from adrianreber/masterOpenShift Merge Robot2018-11-21
|\ | | | | Added option to keep container running after checkpointing
| * Update checkpoint/restore man pagesAdrian Reber2018-11-20
| | | | | | | | | | | | | | | | This adds the '--leave-running, -R' to the container-checkpoint man page. As the information for '--all, -a' and '--latest, -l' was also still missing it is included in this commit. Signed-off-by: Adrian Reber <areber@redhat.com>
| * Added option to keep containers running after checkpointingAdrian Reber2018-11-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | CRIU supports to leave processes running after checkpointing: -R|--leave-running leave tasks in running state after checkpoint runc also support to leave containers running after checkpointing: --leave-running leave the process running after checkpointing With this commit the support to leave a container running after checkpointing is brought to Podman: --leave-running, -R leave the container running after writing checkpoint to disk Now it is possible to checkpoint a container at some point in time without stopping the container. This can be used to rollback the container to an early state: $ podman run --tmpfs /tmp --name podman-criu-test -d docker://docker.io/yovfiatbeb/podman-criu-test $ curl 10.88.64.253:8080/examples/servlets/servlet/HelloWorldExample 3 $ podman container checkpoint -R -l $ curl 10.88.64.253:8080/examples/servlets/servlet/HelloWorldExample 4 $ curl 10.88.64.253:8080/examples/servlets/servlet/HelloWorldExample 5 $ podman stop -l $ podman container restore -l $ curl 10.88.64.253:8080/examples/servlets/servlet/HelloWorldExample 4 So after checkpointing the container kept running and was stopped after some time. Restoring this container will restore the state right at the checkpoint. Signed-off-by: Adrian Reber <areber@redhat.com>
| * Use a struct to pass options to Checkpoint()Adrian Reber2018-11-20
| | | | | | | | | | | | | | | | | | For upcoming changes to the Checkpoint() functions this commit switches checkpoint options from a boolean to a struct, so that additional options can be passed easily to Checkpoint() without changing the function parameters all the time. Signed-off-by: Adrian Reber <areber@redhat.com>
* | Merge pull request #1810 from baude/inspectToKubeOpenShift Merge Robot2018-11-20
|\ \ | | | | | | generate kubernetes YAML from a libpod container
| * | output libpod container to kubernetes yamlbaude2018-11-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | scope out new kube subcommand where we can add generate. you can now generate kubernetes YAML that will allow you to run the container in a kubernetes environment. When The YAML description will always "wrap" a container in a simple v1.Pod description. Tests and further documentation will be added in additional PRs. This function should be considered very much "under heavy development" at this point. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #1829 from baude/enableportbindinginpodsOpenShift Merge Robot2018-11-20
|\ \ \ | | | | | | | | Allow users to expose ports from the pod to the host
| * | | Allow users to expose ports from the pod to the hostbaude2018-11-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | we need to allow users to expose ports to the host for the purposes of networking, like a webserver. the port exposure must be done at the time the pod is created. strictly speaking, the port exposure occurs on the infra container. Signed-off-by: baude <bbaude@redhat.com>
* | | | Merge pull request #1831 from jwhonce/wip/cmdOpenShift Merge Robot2018-11-20
|\ \ \ \ | |_|_|/ |/| | | Improve speed of containers.list()
| * | | Improve speed of containers.list()Jhon Honce2018-11-19
|/ / / | | | | | | | | | | | | | | | | | | | | | * Clean up code in containers.py * Pass pylint tests * Pass tox tests Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #1824 from afbjorklund/pypodman_userOpenShift Merge Robot2018-11-19
|\ \ \ | | | | | | | | pypodman: Don't use $HOST and $USER variables for remote
| * | | Don't use $HOST and $USER variables for remoteAnders F Björklund2018-11-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also, don't use $PORT. These are too generic. Make sure to read $LOGNAME _after_ the config. Prefix all the remote variables with PODMAN_ Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
* | | | Merge pull request #1806 from giuseppe/rootless-create-default-filesOpenShift Merge Robot2018-11-19
|\ \ \ \ | |_|/ / |/| | | rootless: create user conf files when they don't exist
| * | | rootless: create empty mounts.conf if it doesn't existGiuseppe Scrivano2018-11-19
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | registries: check user registries file only in rootless modeGiuseppe Scrivano2018-11-19
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | rootless: create storage.conf when it doesn't existGiuseppe Scrivano2018-11-19
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | rootless: create libpod.conf when it doesn't existGiuseppe Scrivano2018-11-19
| |/ / | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #1823 from jwhonce/wip/cmdOpenShift Merge Robot2018-11-19
|\ \ \ | |_|/ |/| | Implement pypodman start command
| * | Implement pypodman start commandJhon Honce2018-11-16
| |/ | | | | | | | | | | | | | | | | * Improve error messages from argparse Actions * Silence more pylint errors when supporting a given API * Refactor BooleanAction to support lower and mixed case input * Remove spurious print() Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #1780 from cevich/un-magicOpenShift Merge Robot2018-11-19
|\ \ | |/ |/| Reveal magic, parallel system-testing and system-testing simplification
| * Cirrus: Add documentation for system-testingChris Evich2018-11-13
| | | | | | | | | | | | ***CIRRUS: REBUILD IMAGES*** Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Simplify optional system-test scriptChris Evich2018-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously it was required to call the verify, unit, and integration scripts in order to build/install dependencies, and libpod. This wastes time during the (optional) system-testing, since the actual unit/integration testing is also happening in parallel. Consolidate only the distribution-specific build steps into the system-testing script. This way, only the required steps are performed in their respective (parallel) tasks. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Reveal magic, parallel system-testingChris Evich2018-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | Previously, several magic strings were in place to affect cirrus-ci operations. Two were buried within scripts. One to optionally execute system-tests within a PR. Another to avoid re-building cache-images upon every merge. Move these magic strings out into the open, buy locating their logic up-front in the ``.cirrus.yml`` file. This improves readability and reduces surprise/astonishment at runtime. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #1385 from ypu/systemtestOpenShift Merge Robot2018-11-16
|\ \ | | | | | | Add system test with ginkgo
| * | Add a rule to compile system test in MakefileYiqiao Pu2018-11-16
| | | | | | | | | | | | Signed-off-by: Yiqiao Pu <ypu@redhat.com>
| * | Fix no-new-privileges testYiqiao Pu2018-11-16
| | | | | | | | | | | | | | | | | | Update the test to compare the output from different containers. Signed-off-by: Yiqiao Pu <ypu@redhat.com>
| * | The system test write with ginkgoYiqiao Pu2018-11-16
| | | | | | | | | | | | | | | | | | | | | | | | The tests can be filter by --focus and --skip to fit different test target. Also be able to set global options and cmd options by export it to ENV to fit different test matrix. Signed-off-by: Yiqiao Pu <ypu@redhat.com>
| * | Separate common used test functions and structs to test/utilsYiqiao Pu2018-11-16
| | | | | | | | | | | | | | | | | | | | | Put common used test functions and structs to a separated package. So we can use them for more testsuites. Signed-off-by: Yiqiao Pu <ypu@redhat.com>
* | | Merge pull request #1822 from vrothberg/runlabel-shlexingOpenShift Merge Robot2018-11-16
|\ \ \ | | | | | | | | runlabel: use shlex for splitting commands
| * | | runlabel: use shlex for splitting commandsValentin Rothberg2018-11-16
|/ / / | | | | | | | | | | | | | | | | | | | | | Use github.com/google/shlex for splitting commands instead of splitting at whitespaces. This way, we avoid accidentally splitting single string arguments into mutliple ones. Signed-off-by: Valentin Rothberg <vrothberg@suse.com>
* | | Merge pull request #1813 from rhatdan/versionOpenShift Merge Robot2018-11-16
|\ \ \ | | | | | | | | Add version command to pypodman
| * | | Add version command to pypodmanDaniel J Walsh2018-11-15
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | pypodman does not currently support the version command. We want to have as close to the same functionality between podman and pypodman, so adding this command. Also had to fix some validate errors. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #1756 from isimluk/update-dependent-metalinterOpenShift Merge Robot2018-11-16
|\ \ \ | | | | | | | | Update metalinter dependency
| * | | Lint: Silence few given goconst lint warningsŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While we have these string literals on repeated on multiple places in the library, I cannot see real tangible benefit extracting these to constants considering following facts: (1) while 'unknown' or 'host' are repeated, they are often times used in different context and thus perhaps worth extra const per each use. (2) while these string literals repeat, the library is full of string literals with special meaning that should be made constants too (3) readability would suffer Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | | Lint: Extract constant unknownPackageŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | Addressing goconst warning: 3 other occurrence(s) of "Unknown" found Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | | Lint: Tests: add missing assertionsŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Addressing: ineffectual assignment to err (ineffassign) Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | | Lint: Do not ignore errors from docker run command when selinux enabledŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Redefining err by := operator within block makes this err variable block local. Addressing lint: libpod/oci.go:368:3:warning: ineffectual assignment to err (ineffassign) Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | | Lint: InspectImage varlink api should return errors that occurredŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Not just nil. Addressing: pkg/varlinkapi/images.go:273:15:warning: ineffectual assignment to err (ineffassign) Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | | Lint: Exclude autogenerated files from lint testŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
| * | | Lint: Update metalinter dependencyŠimon Lukašík2018-11-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We fixated on old metalinter dependency in past based on experience of metalinter being oftentimes broke and hence broking our build. See 762f508d9ca97cdbaee6053b663e98aee9cae081 in cri-o for more details. Now, dated metalinter is messing up with my environment (like it is panicing on containters/storage) so let's see if we can move to more current version of metalinter. Signed-off-by: Šimon Lukašík <slukasik@redhat.com>
* | | | Merge pull request #1769 from umohnani8/buildOpenShift Merge Robot2018-11-16
|\ \ \ \ | |_|/ / |/| | | Set --force-rm for podman build to true by default
| * | | Set --force-rm for podman build to true by defaultUrvashi Mohnani2018-11-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we use buildah containers for the build process, the user will not know if we have any buildah containers lingering due to a failed build. Setting this to true by default till we figure out a better way to solve this. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>