summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* play kube: refactor test suitePeter Hunt2019-10-11
| | | | | | | | | | The play kube test suite has many different cases to cover, and should only grow in coverage over time The old design was difficult to extend, and there was lots of duplicated code. The largest pain point was the Container struct needed to be changed often, and doing so caused changes every test case Instead, adopt the `withOption` idiom. Now, adding a new option for customizing just involves adding a new withOption function, and changing the struct definition and initialization in one place. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* Merge pull request #4197 from vrothberg/fix-4192OpenShift Merge Robot2019-10-10
|\ | | | | vendor c/psgo@v1.3.2
| * vendor c/psgo@v1.3.2Valentin Rothberg2019-10-07
| | | | | | | | | | | | | | Now supports cgroupsv2. Fixes: #4192 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #4216 from baude/catchv2runcOpenShift Merge Robot2019-10-10
|\ \ | | | | | | catch runc v2 error
| * | catch runc v2 errorbaude2019-10-09
| | | | | | | | | | | | | | | | | | | | | when runc returns an error about not being v2 complient, catch the error and logrus an actionable message for users. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #4225 from giuseppe/rootless-create-pause-automaticallyOpenShift Merge Robot2019-10-09
|\ \ \ | | | | | | | | rootless: automatically recreate the pause.pid file
| * | | rootless: automatically recreate the pause.pid fileGiuseppe Scrivano2019-10-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | if the pause process cannot be joined, remove the pause.pid while keeping a lock on it, and try to recreate it. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | rootless: do not close files twiceGiuseppe Scrivano2019-10-09
| | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | refresh: do not access network ns if not in the namespaceGiuseppe Scrivano2019-10-09
| |/ / | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #4222 from cevich/collect_varlink_logOpenShift Merge Robot2019-10-09
|\ \ \ | | | | | | | | Cirrus: Produce and collect varlink output
| * | | Cirrus: Produce and collect varlink outputChris Evich2019-10-08
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When executing 'make remotesystem' testing, a varlink process is started up but it's stdio is dumped due to the production of excessive data. However, this also means if the process has a problem, any errors will not be accessible. Instead, grab only the last 100 lines and direct them into a file. Also update automation's log collection to retrieve this file when the `$REMOTE_CLIENT` env. var. is `true`. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #4200 from mheon/fix_sigproxy_startOpenShift Merge Robot2019-10-09
|\ \ \ | |_|/ |/| | Respect --sig-proxy flag with podman start --attach
| * | Respect --sig-proxy flag with podman start --attachMatthew Heon2019-10-09
|/ / | | | | | | | | | | | | If it's explicitly set, use it, instead of trying to set a sane default. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #4218 from jlebon/pr/drop-alsoOpenShift Merge Robot2019-10-09
|\ \ | | | | | | io.podman.socket: drop Also=multi-user.target
| * | io.podman.socket: drop Also=multi-user.targetJonathan Lebon2019-10-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using `Also=` means that the target unit will also be installed/uninstalled together with our unit. Doing `Also=multi-user.target` essentially says: disable `multi-user.target` if `io.podman.socket` is disabled, which sounds... not at all like what we want. In practice, systemd thankfully ignores this (likely because it's the default target). I think having `Also=io.podman.socket` in the `io.podman.service` already does what we want here: it gets installed under `sockets.target` whenever the service is. (And the fact that systemd ignored this means that it wasn't actually playing a role in resolving #3998.) This was causing `systemctl preset-all` to dump core in Fedora CoreOS: https://github.com/coreos/fedora-coreos-tracker/issues/290 (Likely there's a systemd bug around here too.) Signed-off-by: Jonathan Lebon <jonathan@jlebon.com>
* | | Merge pull request #4189 from cevich/install_conmonOpenShift Merge Robot2019-10-08
|\ \ \ | |/ / |/| | Cirrus: Install conmon in Fedora VMs
| * | Cirrus: Remove broken/failing testing_crun taskChris Evich2019-10-07
| | | | | | | | | | | | | | | | | | | | | | | | This task was to enable cross-environment testing of crun. However it was decided to only run testing w/ crun on F31. Since F31 release is imminent, remove this task. Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Use new VM cache imagesChris Evich2019-10-07
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Install conmon in Fedora VMsChris Evich2019-10-07
| |/ | | | | | | | | | | | | | | | | | | This is needed because older versions of podman (1.5.1) do not automatically install the new conmon package. Also, include removal of `/usr/libexec/podman/conmon` when preparing to install and test podman built from source. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #4032 from rhatdan/pids-limitOpenShift Merge Robot2019-10-07
|\ \ | |/ |/| Setup a reasonable default for pids-limit 4096
| * Setup a reasonable default for pids-limit 4096Daniel J Walsh2019-10-04
| | | | | | | | | | | | | | | | | | | | | | CRI-O defaults to 1024 for the maximum pids in a container. Podman should have a similar limit. Once we have a containers.conf, we can set the limit in this file, and have it easily customizable. Currently the documentation says that -1 sets pids-limit=max, but -1 fails. This patch allows -1, but also indicates that 0 also sets the max pids limit. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #4196 from mheon/normal_remove_on_evictOpenShift Merge Robot2019-10-07
|\ \ | | | | | | When evicting containers, perform a normal remove first
| * | When evicting containers, perform a normal remove firstMatthew Heon2019-10-04
| | | | | | | | | | | | | | | | | | | | | | | | This ensures that containers that didn't require an evict will be dealt with normally, and we only break out evict for containers that refuse to be removed by normal means. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #4165 from mtrmac/c-image-4OpenShift Merge Robot2019-10-04
|\ \ \ | |_|/ |/| | Update c/image to v4.0.0 + Buildah to 1.11.3
| * | Update c/image to v4.0.1 and buildah to 1.11.3Miloslav Trmač2019-10-04
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | This requires updating all import paths throughout, and a matching buildah update to interoperate. I can't figure out the reason for go.mod tracking github.com/containers/image v3.0.2+incompatible // indirect ((go mod graph) lists it as a direct dependency of libpod, but (go list -json -m all) lists it as an indirect dependency), but at least looking at the vendor subdirectory, it doesn't seem to be actually used in the built binaries. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
* | Merge pull request #4180 from cevich/update_download_linksOpenShift Merge Robot2019-10-04
|\ \ | | | | | | Docs: Update links, add links to latest
| * | Docs: Update links, add links to latestChris Evich2019-10-03
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Cirrus: Fix log URIs & add optional $ALSO_FILENAMEChris Evich2019-10-03
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #4194 from ↵OpenShift Merge Robot2019-10-04
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/gopkg.in/yaml.v2-2.2.4 Bump gopkg.in/yaml.v2 from 2.2.3 to 2.2.4
| * | | Bump gopkg.in/yaml.v2 from 2.2.3 to 2.2.4dependabot-preview[bot]2019-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.3 to 2.2.4. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](https://github.com/go-yaml/yaml/compare/v2.2.3...v2.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #4186 from cevich/log_runc_crunOpenShift Merge Robot2019-10-04
|\ \ \ \ | |_|_|/ |/| | | Cirrus: Simplify package NVR logging
| * | | Cirrus: Simplify package NVR loggingChris Evich2019-10-03
| | |/ | |/| | | | | | | | | | | | | Also include runc/crun version for Fedora Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #3549 from marcov/evict-containerOpenShift Merge Robot2019-10-04
|\ \ \ | |_|/ |/| | Add ability to evict a container
| * | rm: add containers eviction with `rm --force`Marco Vedovati2019-09-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add ability to evict a container when it becomes unusable. This may happen when the host setup changes after a container creation, making it impossible for that container to be used or removed. Evicting a container is done using the `rm --force` command. Signed-off-by: Marco Vedovati <mvedovati@suse.com>
* | | Merge pull request #4188 from Mrigank11/validate_network_nameOpenShift Merge Robot2019-10-04
|\ \ \ | | | | | | | | podman network create: validate user input
| * | | podman network create: validate user inputMrigank Krishan2019-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Disallow invalid/confusing names such as '../bar' or 'foo ' Closes #4184 Signed-off-by: Mrigank Krishan <mrigankkrishan@gmail.com>
* | | | Merge pull request #4161 from afbjorklund/machine-envOpenShift Merge Robot2019-10-03
|\ \ \ \ | |/ / / |/| | | Handle environment variables from podman-machine
| * | | Apply changes also to the windows implementationAnders F Björklund2019-10-02
| | | | | | | | | | | | | | | | Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
| * | | Allow setting default parameters with env varsAnders F Björklund2019-10-01
| | | | | | | | | | | | | | | | Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
| * | | Avoid hard-coding path to varlink and podmanAnders F Björklund2019-10-01
| | | | | | | | | | | | | | | | Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
| * | | Allow changing IdentityFile and to IgnoreHostsAnders F Björklund2019-10-01
| | | | | | | | | | | | | | | | Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
* | | | Merge pull request #4174 from cevich/use_bash_not_shOpenShift Merge Robot2019-10-03
|\ \ \ \ | | | | | | | | | | System-tests: Use bash explicitly
| * | | | System-tests: Use bash explicitlyChris Evich2019-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On Ubuntu, /bin/sh != /bin/bash. Update system-tests to only use bash for testing consistency across platforms. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #4173 from mheon/bump_release_in_readmeOpenShift Merge Robot2019-10-03
|\ \ \ \ \ | | | | | | | | | | | | Podman 1.6.0 has been released, update the README
| * | | | | Podman 1.6.0 has been released, update the READMEMatthew Heon2019-10-02
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #4163 from ↵OpenShift Merge Robot2019-10-03
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/gopkg.in/yaml.v2-2.2.3 Bump gopkg.in/yaml.v2 from 2.2.2 to 2.2.3
| * | | | | | Bump gopkg.in/yaml.v2 from 2.2.2 to 2.2.3dependabot-preview[bot]2019-10-02
| | |_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [gopkg.in/yaml.v2](https://github.com/go-yaml/yaml) from 2.2.2 to 2.2.3. - [Release notes](https://github.com/go-yaml/yaml/releases) - [Commits](https://github.com/go-yaml/yaml/compare/v2.2.2...v2.2.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Matthew Heon <mheon@redhat.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #4179 from edsantiago/batsOpenShift Merge Robot2019-10-03
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | system tests: info: deal with hyphen in username
| * | | | | system tests: info: deal with hyphen in usernameEd Santiago2019-10-03
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ...e.g. cloud-user. 9822f54ac was intended to fix this, but it doesn't. Simple and standard solution is to move the dash to the end of the character class. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #4169 from TomSweeneyRedHat/dev/tsweeney/tutreadfix2OpenShift Merge Robot2019-10-03
|\ \ \ \ \ | | | | | | | | | | | | Add api link to tutorials