summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* logs: k8s-file: fix raceValentin Rothberg2021-06-08
| | | | | | | | | | | | | | | | | | | | Fix a race in the k8s-file logs driver. When "following" the logs, Podman will print the container's logs until the end. Previously, Podman logged until the state transitioned into something non-running which opened up a race with the container still running, possibly in the "stopping" state. To fix the race, log until we've seen the wait event for the specific container. In that case, conmon will have finished writing all logs to the file, and Podman will read it until EOF. Further tweak the integration tests for testing `logs -f` on a running container. Previously, the test only checked for one of two lines stating that there was a race. Indeed the race was in using `run --rm` where a log file may be removed before we could fully read it. Fixes: #10596 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10540 from ↵OpenShift Merge Robot2021-06-03
|\ | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.16.4 Bump github.com/onsi/ginkgo from 1.16.3 to 1.16.4
| * Bump github.com/onsi/ginkgo from 1.16.3 to 1.16.4dependabot[bot]2021-06-03
|/ | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.16.3 to 1.16.4. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.16.3...v1.16.4) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* Merge pull request #10514 from vrothberg/fix-10507OpenShift Merge Robot2021-06-02
|\ | | | | events: support disjunctive filters
| * events: support disjunctive filtersValentin Rothberg2021-06-02
| | | | | | | | | | | | | | | | | | While different filters are applied in conjunction, the same filter (but with different values) should be applied in disjunction. This allows, for instance, to query the events of two containers. Fixes: #10507 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #10523 from rhatdan/docsOpenShift Merge Robot2021-06-02
|\ \ | | | | | | [CI:DOCS] Use secrets and machine rst file properly
| * | Use secrets and machine rst file properlyDaniel J Walsh2021-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | This change makes secrets and machine handling match the handling of other subcommands of Podman. Possible fixes: https://github.com/containers/podman/issues/10513 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #10527 from edsantiago/batsOpenShift Merge Robot2021-06-01
|\ \ \ | | | | | | | | System tests: add :Z to volume mounts
| * | | System tests: add :Z to volume mountsEd Santiago2021-06-01
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | selinux-policy-34.9-1.fc34 breaks a behavior we've relied on since (at least) January 2020: - Revert "Add permission open to files_read_inherited_tmp_files() interface" That's probably the correct thing to do, but it breaks our existing tests. Solution: add ':Z' where needed. Tested on Ed's laptop, which has the offending selinux-policy as of 2021-05-31. Tests pass root and rootless. (I mention this because tests will obviously pass in CI, which has a much older selinux-policy). Also: add a 'podman rmi' for cleanup in one test, to avoid noise in test logs. Fixes: #10522 Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #10517 from cdoern/masterOpenShift Merge Robot2021-06-01
|\ \ \ | | | | | | | | API one-shot query implementation/handling
| * | | added tests in python rest apicdoern2021-06-01
| | | | | | | | | | | | | | | | Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | Merge pull request #10486 from vrothberg/tag-digest-supportOpenShift Merge Robot2021-06-01
|\ \ \ \ | | | | | | | | | | support tag@digest notation
| * | | | support tag@digest notationValentin Rothberg2021-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Vendor in the latest HEAd of containers/common to implicitly support the tag@digest notation for images. To remain compatible with Docker, the tag will be stripped off the image reference and is entirely ignored. Fixes: #6721 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #10519 from matejvasek/use-req-ctxOpenShift Merge Robot2021-06-01
|\ \ \ \ \ | | | | | | | | | | | | Use request context instead of background
| * | | | | Use request context instead of backgroundMatej Vasek2021-06-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This prevents goroutine leak: If background context were used then push operation would continue even if client aborted request by closing connection. [NO TESTS NEEDED] Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | | | | Merge pull request #10524 from rugk/patch-1OpenShift Merge Robot2021-06-01
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | [CI:DOCS] Fix link error
| * | | | | Fix link errorrugk2021-06-01
|/ / / / / | | | | | | | | | | | | | | | Signed-off-by: rugk <rugk+git@posteo.de>
* | | | | Merge pull request #10488 from baude/machinehostnetworkOpenShift Merge Robot2021-06-01
|\ \ \ \ \ | | | | | | | | | | | | Enable port forwarding on host
| * | | | | Enable port forwarding on hostBrent Baude2021-06-01
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using the gvproxy application on the host, we can now port forward from the machine vm on the host. It requires that 'gvproxy' be installed in an executable location. gvproxy can be found in the containers/gvisor-tap-vsock github repo. [NO TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #10508 from matejvasek/fix-from-imgOpenShift Merge Robot2021-06-01
|\ \ \ \ \ | | | | | | | | | | | | Better error handing for images/create compat api
| * | | | | Better error handing for images/create compat apiMatej Vasek2021-05-31
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If server cannot resolve short name due to enforcing policy send non-2xx status code. [NO TESTS NEEDED] Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | | | Merge pull request #10510 from matejvasek/improve-creat-from-imgOpenShift Merge Robot2021-06-01
|\ \ \ \ \ | | | | | | | | | | | | Use request context instead of background context
| * | | | | Use request context instead of background contextMatej Vasek2021-06-01
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This fixes a goroutine leak. Previously if request was cancelled the image pulling goroutine kept running regardless. [NO TESTS NEEDED] Signed-off-by: Matej Vasek <mvasek@redhat.com>
* | | | | Merge pull request #10516 from vrothberg/fix-10512OpenShift Merge Robot2021-06-01
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] rm containers-mounts.conf.5.md
| * | | | | [CI:DOCS] rm containers-mounts.conf.5.mdValentin Rothberg2021-06-01
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The code for mounts.conf including the man page lives in containers/common, so remove it from Podman to prevent divergence among the two repositories. Fixes: #10512 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #10518 from zhangguanzhang/api-networks-listOpenShift Merge Robot2021-06-01
|\ \ \ \ \ | |/ / / / |/| | | | [NO TESTS NEEDED] Fixes API list networks returns "null" instead of empty array when used with no networks
| * | | | [NO TESTS NEEDED] API list networks should return [] when used with no networkszhangguanzhang2021-06-01
|/ / / / | | | | | | | | | | | | Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
* | | | Merge pull request #10504 from ↵OpenShift Merge Robot2021-06-01
|\ \ \ \ | |_|_|/ |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/ginkgo-1.16.3 Bump github.com/onsi/ginkgo from 1.16.2 to 1.16.3
| * | | Bump github.com/onsi/ginkgo from 1.16.2 to 1.16.3dependabot[bot]2021-05-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/ginkgo](https://github.com/onsi/ginkgo) from 1.16.2 to 1.16.3. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/ginkgo/compare/v1.16.2...v1.16.3) Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #10450 from ↵OpenShift Merge Robot2021-05-31
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/uber/jaeger-client-go-2.29.1incompatible Bump github.com/uber/jaeger-client-go from 2.28.0+incompatible to 2.29.1+incompatible
| * | | Bump github.com/uber/jaeger-client-godependabot[bot]2021-05-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/uber/jaeger-client-go](https://github.com/uber/jaeger-client-go) from 2.28.0+incompatible to 2.29.1+incompatible. - [Release notes](https://github.com/uber/jaeger-client-go/releases) - [Changelog](https://github.com/jaegertracing/jaeger-client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber/jaeger-client-go/compare/v2.28.0...v2.29.1) Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #10506 from vrothberg/fix-10493OpenShift Merge Robot2021-05-31
|\ \ \ \ | |/ / / |/| | | generate systemd: make mounts portable
| * | | generate systemd: make mounts portableValentin Rothberg2021-05-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Commit 748826fc88fc fixed a bug where slow mounting of the runroot was causing issues when the units are started at boot. The fix was to add the container's runroot to the required mounts; the graph root has been added as well. Hard-coding the run- and graphroot to the required mounts, however, breaks the portability of units generated with --now. Those units are intended to be running on any machine as, theoreticaly, any user. Make the mounts portable by using the `%t` macro for the run root. Since the graphroot's location varies across root and ordinary users, drop it from the list of required mounts. The graphroot was not causing issues. Fixes: #10493 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #10502 from rugk/patch-1OpenShift Merge Robot2021-05-31
|\ \ \ | |/ / |/| | [CI:DOCS] fix: add missing space
| * | add missing spacerugk2021-05-31
|/ / | | | | | | | | | | Fixes a small typo in the man page. :slightly_smiling_face: Signed-off-by: rugk <rugk+git@posteo.de>
* | Merge pull request #10481 from flouthoc/fix-sigsegv-rootlessOpenShift Merge Robot2021-05-30
|\ \ | | | | | | rootless: fix SIGSEGV, Make `LISTEN_FDNAMES` optional
| * | rootless: fix SIGSEGV ,make LISTEN_FDNAMES optional [Closes #10435].flouthoc2021-05-29
| | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: flouthoc <flouthoc.git@gmail.com>
* | | Merge pull request #10499 from edsantiago/liberaOpenShift Merge Robot2021-05-30
|\ \ \ | |/ / |/| | [CI:DOCS] point IRC to libera.chat
| * | [CI:DOCS] point IRC to libera.chatEd Santiago2021-05-29
|/ / | | | | | | | | | | | | | | Project IRC comms are moving to Libera. Update docs. Confirmation cookie: libera-ieVeeGahbiaf1einguw1xav6bahquie Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #10477 from Procyhon/manpage_syntaxOpenShift Merge Robot2021-05-29
|\ \ | | | | | | [CI:DOCS] Manpage syntax proposal
| * | Manpage syntax proposalAlexander Richter2021-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I looked at the man pages and found that while they are consistent in their basic concept, many things concerning formatting are not. For example, it is not consistent that options are behind an H4 header. The biggest criticism, however, is how commands and options are handled when referencing them in a text. There is no clear structure between the man pages regarding this. Sometimes backticks are used and sometimes they are written in italic. Also, the formatting regarding the appearance of the commands is not consistent either. I would like to propose a uniform formatting and, if accepted, apply it to all man pages. Uniformity is very important to me and it should be clear to the user when reading several man pages what exactly their content and references are about. Signed-off-by: Alexander Richter <67486332+Procyhon@users.noreply.github.com>
* | | Merge pull request #10487 from rhatdan/docsOpenShift Merge Robot2021-05-28
|\ \ \ | | | | | | | | [CI:DOCS] Update a way out of date transfer document
| * | | Update a way out of date transfer documentDaniel J Walsh2021-05-28
| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #10385 from jwhonce/wip/engine_modeOpenShift Merge Robot2021-05-28
|\ \ \ \ | |/ / / |/| | | [Techinal Debt][NO TESTS NEEDED] Cleanup ABI vs. Tunnel CLI commands
| * | | [Techinal Debt] Cleanup ABI vs. Tunnel CLI commandsJhon Honce2021-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] This commit cleans up two issues: * Most commands support all EngineModes so default to that. Let outlayers declare their intent. * Use cobra.Annotations to set supported EngineMode. This simplies instantiating commands as there is now one method to communicate a commands requirements rather than two. * Combined aliased commands into one file * Fixed aliased commands where Args field did not match * Updated examples in README.md for writing commands * Remove redundant flag DisableFlagsInUseLine in cobra.Command initialization. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #10383 from rhatdan/kubeOpenShift Merge Robot2021-05-27
|\ \ \ \ | | | | | | | | | | Handle image user and exposed ports in podman play kube
| * | | | Handle image user and exposed ports in podman play kubeDaniel J Walsh2021-05-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently if a user runs an image with a user specified or exposed ports with podman play kube, the fields are ignored. Fixed: https://github.com/containers/podman/issues/9609 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #10490 from rhatdan/VENDOROpenShift Merge Robot2021-05-27
|\ \ \ \ \ | |_|/ / / |/| | | | Vendor in containers/storage v1.32.1
| * | | | Vendor in containers/storage v1.32.1Daniel J Walsh2021-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Theoretically this should fix the aweful flake we have been suffering with. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #10489 from vrothberg/fix-data-raceOpenShift Merge Robot2021-05-27
|\ \ \ \ \ | | | | | | | | | | | | create libimage-events channel in main routine
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-09-29 09:22:54 +0000