summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* fix reported compat issuesBrent Baude2020-03-19
| | | | | | | | | | honor -1 in in list containers for compatibility mode. it is commonly used to indicate no limit. change the json id parameter to Id in container create. Fixes: #5553 Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #5550 from giuseppe/rootless-hidepidOpenShift Merge Robot2020-03-19
|\ | | | | rootless: fix usage with hidepid=1
| * rootless: fix usage with hidepid=1Giuseppe Scrivano2020-03-19
|/ | | | | | | | | | | when /proc is mounted with hidepid=1 a process doesn't see processes from the outer user namespace. This causes an issue reading the cmdline from the parent process. To address it, always read the command line from /proc/self instead of using /proc/PARENT_PID. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #5542 from rhatdan/vendorOpenShift Merge Robot2020-03-18
|\ | | | | Vendor in containers/buildah v1.14.3
| * Vendor in containers/buildah v1.14.3Daniel J Walsh2020-03-18
| | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5540 from jwhonce/issues/5531OpenShift Merge Robot2020-03-18
|\ \ | | | | | | Reduce CPU usage when --timeout=0
| * | Reduce CPU usage when --timeout=0Jhon Honce2020-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Add second go routine for when a Timer is not needed. * goimports updated some project files Fixes #5531 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #5544 from baude/apiv2serveswaggerOpenShift Merge Robot2020-03-18
|\ \ \ | | | | | | | | serve swagger when present
| * | | serve swagger when presentBrent Baude2020-03-18
| | |/ | |/| | | | | | | | | | | | | register the swagger endpoint and add some error handling for when the swagger file does not exist Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5543 from edsantiago/swagger_fixesOpenShift Merge Robot2020-03-18
|\ \ \ | |/ / |/| | swagger: more consistency fixes
| * | swagger: more consistency fixesEd Santiago2020-03-18
|/ / | | | | | | | | | | Some new 'manifests' entries have the wrong {name} parameter Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #5480 from vrothberg/auto-updatesOpenShift Merge Robot2020-03-18
|\ \ | |/ |/| auto update containers in systemd units
| * auto updatesValentin Rothberg2020-03-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support to auto-update containers running in systemd units as generated with `podman generate systemd --new`. `podman auto-update` looks up containers with a specified "io.containers.autoupdate" label (i.e., the auto-update policy). If the label is present and set to "image", Podman reaches out to the corresponding registry to check if the image has been updated. We consider an image to be updated if the digest in the local storage is different than the one of the remote image. If an image must be updated, Podman pulls it down and restarts the container. Note that the restarting sequence relies on systemd. At container-creation time, Podman looks up the "PODMAN_SYSTEMD_UNIT" environment variables and stores it verbatim in the container's label. This variable is now set by all systemd units generated by `podman-generate-systemd` and is set to `%n` (i.e., the name of systemd unit starting the container). This data is then being used in the auto-update sequence to instruct systemd (via DBUS) to restart the unit and hence to restart the container. Note that this implementation of auto-updates relies on systemd and requires a fully-qualified image reference to be used to create the container. This enforcement is necessary to know which image to actually check and pull. If we used an image ID, we would not know which image to check/pull anymore. Fixes: #3575 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * pkg/systemd: add dbus supportValentin Rothberg2020-03-17
| | | | | | | | | | | | | | Move the dbus-connection code from libpod's healthcheck to pkg/systemd to allow for sharing the logic. Needed for the auto-updates work. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #5532 from baude/filetimeoutflakeOpenShift Merge Robot2020-03-18
|\ \ | | | | | | fix timeout file flake
| * | Fix vendoring on masterMatthew Heon2020-03-17
| | | | | | | | | | | | | | | | | | | | | It looks like something snuck in and now make vendor fails on master. This should make things happy. Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | fix timeout file flakeBrent Baude2020-03-17
| | | | | | | | | | | | | | | | | | this is a temporary fix for the flake that has been troubling us. once conmon is in fedora 30 and 31 stable, we can remove this fix. the images will just need to be rebuilt. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5533 from mheon/bump-1.8.2-rc1OpenShift Merge Robot2020-03-18
|\ \ \ | | | | | | | | Bump to v1.8.2-RC1
| * | | Bump to v1.8.2-devMatthew Heon2020-03-17
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * | | Bump to v1.8.2-rc1v1.8.2-rc1Matthew Heon2020-03-17
| | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | Merge pull request #5536 from giuseppe/avoid-conmon-zombieOpenShift Merge Robot2020-03-18
|\ \ \ \ | |/ / / |/| | | podman: avoid conmon zombie on exec
| * | | podman: avoid conmon zombie on execGiuseppe Scrivano2020-03-18
| | |/ | |/| | | | | | | | | | | | | | | | conmon forks itself, so make sure we reap the first process and not leave a zombie process. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #5528 from mheon/fix_master_vendorOpenShift Merge Robot2020-03-17
|\ \ \ | |_|/ |/| | Fix vendoring on master
| * | Fix vendoring on masterMatthew Heon2020-03-17
| | | | | | | | | | | | | | | | | | | | | It looks like something snuck in and now make vendor fails on master. This should make things happy. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #5529 from mheon/release_notes_182_rc1OpenShift Merge Robot2020-03-17
|\ \ \ | |/ / |/| | [CI:DOCS] Update release notes for v1.8.2-RC1
| * | Update release notes for v1.8.2-rc1Matthew Heon2020-03-17
|/ / | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | Merge pull request #5524 from rhatdan/vendorOpenShift Merge Robot2020-03-17
|\ \ | | | | | | Update containers/storage to v1.16.5
| * | Update containers/storage to v1.16.5Daniel J Walsh2020-03-17
| |/ | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #5449 from baude/manifestsOpenShift Merge Robot2020-03-17
|\ \ | | | | | | apiv2 addition of manifests
| * | apiv2 addition of manifestsBrent Baude2020-03-16
| | | | | | | | | | | | | | | | | | | | | | | | add endpoints for create, add, remove, inspect, and push. this allows manifests to be managed through the restful interfaces. also added go-bindings and tests Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #5520 from giuseppe/make-warning-clearerOpenShift Merge Robot2020-03-17
|\ \ \ | |_|/ |/| | config: make warning clearer
| * | config: make warning clearerGiuseppe Scrivano2020-03-17
|/ / | | | | | | | | | | | | | | | | make clearer that the warning could also happen because the logger is set to use systemd. Closes: https://github.com/containers/libpod/issues/5443 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #5515 from edsantiago/ci_sundry_small_fixesOpenShift Merge Robot2020-03-16
|\ \ | | | | | | Four small CI fixes:
| * | Four small CI fixes:Ed Santiago2020-03-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1) 'podman system info' (in logcollector): has been silently failing in special_testing_rootless, with: logcollector.sh: line 16: podman: command not found Use ./bin/podman instead of just podman; this is probably the right thing to do in the general case anyway 2) logformatter: highlight 'panic:', seen in bindings test: https://storage.googleapis.com/cirrus-ci-5385732420009984-fcae48/artifacts/containers/libpod/6693715108429824/html/integration_test.log.html 3) logformatter: handle Unicode bullet in front of 'Running', seen in bindings test. 4) logformatter: turn down contrast on BATS 'ok' results, for legibility Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #5490 from containers/dependabot/go_modules/k8s.io/api-0.17.4OpenShift Merge Robot2020-03-16
|\ \ \ | | | | | | | | Bump k8s.io/api from 0.17.3 to 0.17.4
| * | | Bump k8s.io/api from 0.17.3 to 0.17.4dependabot-preview[bot]2020-03-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.17.3 to 0.17.4. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.17.3...v0.17.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #5489 from ↵OpenShift Merge Robot2020-03-16
|\ \ \ \ | |_|/ / |/| | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/common-0.5.0 Bump github.com/containers/common from 0.4.2 to 0.5.0
| * | | Bump github.com/containers/common from 0.4.2 to 0.5.0dependabot-preview[bot]2020-03-13
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/common](https://github.com/containers/common) from 0.4.2 to 0.5.0. - [Release notes](https://github.com/containers/common/releases) - [Commits](https://github.com/containers/common/compare/v0.4.2...v0.5.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #5514 from vrothberg/fix-ciEd Santiago2020-03-16
|\ \ \ | | | | | | | | fix systemd generate tests
| * | | fix systemd generate testsValentin Rothberg2020-03-16
|/ / / | | | | | | | | | | | | | | | Add the `default.target` to the failing tests. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #5439 from ttys3/fixup-systemdgen-with-new-paramOpenShift Merge Robot2020-03-16
|\ \ \ | | | | | | | | systemd generator: force run container detached if CreateCommand has no detach param
| * | | force run container detached if container CreateCommand missing the detach param荒野無燈2020-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | the podman generated systemd service file has `Type=forking` service, so the command after `ExecStart=` should not run in front. if someone created a container and has the detach(`-d`) param missing like this ``` podman create --name ngxdemo -P nginxdemos/hello ``` and generate the file with `--new` param: ``` podman generate systemd --name --new ngxdemo ``` because `podman run xxx` has no `-d` param, so the container is not run in background and nerver exit. and systemd will fail to start the service: ``` sudo systemctl start container-ngxdemo.service Job for container-ngxdemo.service failed because a timeout was exceeded. See "systemctl status container-ngxdemo.service" and "journalctl -xe" for details. ``` Signed-off-by: 荒野無燈 <ttys3@outlook.com>
* | | | Merge pull request #5252 from QiWang19/not-reset-tempdirOpenShift Merge Robot2020-03-16
|\ \ \ \ | | | | | | | | | | Fix bug podman reset to not remove $XDG_RUNTIME_DIR
| * | | | Fix bug podman reset to not remove $XDG_RUNTIME_DIRQi Wang2020-03-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In some older systems we point the temporary directory to /run/user/1000 which leads podman system reset to clear unrelated files under XDG_RUNTIME_DIR. This patch only removes files created by podman if TmpDir is the same as the XDG_RUNTIME_DIR. Signed-off-by: Qi Wang <qiwan@redhat.com>
* | | | | Merge pull request #5505 from tonybenoy/tony_typoOpenShift Merge Robot2020-03-16
|\ \ \ \ \ | | | | | | | | | | | | Missing double quotes in troubleshooting guide.
| * | | | | Missing double quotes in troubleshooting guide.Tony Benoy2020-03-15
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Tony Benoy <me@tonybenoy.com>
* | | | | | Merge pull request #5476 from edsantiago/run_rmi_test_fixOpenShift Merge Robot2020-03-16
|\ \ \ \ \ \ | | | | | | | | | | | | | | run --rmi test: make it work
| * | | | | | run --rmi test: make it workEd Santiago2020-03-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The recently-added 'run --rmi' test was not actually doing what it thinks it was doing: for one, 'run_podman | grep' is never going to work; also, the test was leaving behind stray images. Rework to do what I believe the intention was; and, combine into one test (down from two) for readability. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | | Merge pull request #5508 from baude/buildaddarchosOpenShift Merge Robot2020-03-16
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | add os|arch attributes when building
| * | | | | | add os|arch attributes when buildingBrent Baude2020-03-15
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when building images, we can now add the os and arch of the image using overrides from the commandline. the commandline options set sane defaults so we use those as well. Fixes: #5503 Signed-off-by: Brent Baude <bbaude@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-06 03:03:59 +0000