summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #6281 from rhatdan/fipsOpenShift Merge Robot2020-05-21
|\ | | | | Fix mountpont in SecretMountsWithUIDGID
| * Fix mountpont in SecretMountsWithUIDGIDDaniel J Walsh2020-05-19
| | | | | | | | | | | | | | In FIPS Mode we expect to work off of the Mountpath not the Rundir path. This is causing FIPS Mode checks to fail. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #6308 from giuseppe/update-seccomp-containers-golangOpenShift Merge Robot2020-05-21
|\ \ | | | | | | vendor: update seccomp/containers-golang to v0.4.1
| * | vendor: update seccomp/containers-golang to v0.4.1Giuseppe Scrivano2020-05-21
| | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #6280 from mheon/switch_off_noexecOpenShift Merge Robot2020-05-21
|\ \ \ | |/ / |/| | Turn off 'noexec' option by default for named volumes
| * | Turn off 'noexec' option by default for named volumesMatthew Heon2020-05-20
| |/ | | | | | | | | | | | | | | | | We previously enforced this for security reasons, but as Dan has explained on several occasions, it's not very valuable there (it's trivially easy to bypass) and it does seriously annoy folks trying to use named volumes. Flip the default from 'on' to 'off'. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | Merge pull request #6310 from mheon/update_api_tutorialOpenShift Merge Robot2020-05-21
|\ \ | | | | | | Update Derivative API tutorial to reflect the HTTP API
| * | Update Derivative API tutorial to reflect the HTTP APIMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | Once the HTTP API becomes stable, I think we want to drive people towards using it, as opposed to directly calling our CLI (when possible). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | Merge pull request #6199 from rhatdan/manOpenShift Merge Robot2020-05-21
|\ \ \ | | | | | | | | [ci:docs] Update troubleshoot page
| * | | Update troubleshoot pageDaniel J Walsh2020-05-19
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Add information about podman with SELinux and using container_init_t. Add informantion about Centos7 as well as RHEL7 init containers not working on a cgroups V2 system. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6304 from baude/v2remotehctestsOpenShift Merge Robot2020-05-21
|\ \ \ | | | | | | | | Fix remote integration for healthchecks
| * | | Fix remote integration for healthchecksBrent Baude2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | the one remaining test that is still skipped do to missing exec function Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #6270 from mheon/detached_execOpenShift Merge Robot2020-05-21
|\ \ \ \ | | | | | | | | | | Implement detached exec
| * | | | Add a test for detached execMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Update manpage for `podman exec` to include detach flagMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Enable cleanup processes for detached execMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The cleanup command creation logic is made public as part of this and wired such that we can call it both within SpecGen (to make container exit commands) and from the ABI detached exec handler. Exit commands are presently only used for detached exec, but theoretically could be turned on for all exec sessions if we wanted (I'm declining to do this because of potential overhead). I also forgot to copy the exit command from the exec config into the ExecOptions struct used by the OCI runtime, so it was not being added. There are also two significant bugfixes for exec in here. One is for updating the status of running exec sessions - this was always failing as I had coded it to remove the exit file *before* reading it, instead of after (oops). The second was that removing a running exec session would always fail because I inverted the check to see if it was running. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add ability to clean up exec sessions with cleanupMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to be able to use cleanup processes to remove exec sessions as part of detached exec. This PR adds that ability. A new flag is added to `podman container cleanup`, `--exec`, to specify an exec session to be cleaned up. As part of this, ensure that `ExecCleanup` can clean up exec sessions that were running, but have since exited. This ensures that we can come back to an exec session that was running but has since stopped, and clean it up. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add CLI frontend for detached execMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a new ContainerEngine method for creating a detached exec session, and wire in the frontend code to do this. As part of this, move Streams out of ExecOptions to the function signature in an effort to share the struct between both methods. Fixes #5884 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add backend code for detached execMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As part of the massive exec rework, I stubbed out a function for non-detached exec, which is implemented here. It's largely similar to the existing exec functions, but missing a few pieces. This also involves implemented a new OCI runtime call for detached exec. Again, very similar to the other functions, but with a few missing pieces. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | Add exit commands to exec sessionsMatthew Heon2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These are required for detached exec, where they will be used to clean up and remove exec sessions when they exit. As part of this, move all Exec related functionality for the Conmon OCI runtime into a separate file; the existing one was around 2000 lines. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #6307 from baude/v2remoteinitOpenShift Merge Robot2020-05-21
|\ \ \ \ \ | | | | | | | | | | | | enable remote integration tests for init
| * | | | | enable remote integration tests for initBrent Baude2020-05-20
| |/ / / / | | | | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #6315 from containers/dependabot/go_modules/k8s.io/api-0.18.3OpenShift Merge Robot2020-05-21
|\ \ \ \ \ | | | | | | | | | | | | Bump k8s.io/api from 0.18.2 to 0.18.3
| * | | | | Bump k8s.io/api from 0.18.2 to 0.18.3dependabot-preview[bot]2020-05-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.18.2 to 0.18.3. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](https://github.com/kubernetes/api/compare/v0.18.2...v0.18.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #6317 from ↵OpenShift Merge Robot2020-05-21
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/onsi/gomega-1.10.1 Bump github.com/onsi/gomega from 1.10.0 to 1.10.1
| * | | | | | Bump github.com/onsi/gomega from 1.10.0 to 1.10.1dependabot-preview[bot]2020-05-21
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.10.0 to 1.10.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](https://github.com/onsi/gomega/compare/v1.10.0...v1.10.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | | Merge pull request #6311 from mheon/fix_darwin_buildOpenShift Merge Robot2020-05-21
|\ \ \ \ \ \ | |/ / / / / |/| | | | | Fix build on OS X
| * | | | | Fix build on OS XMatthew Heon2020-05-20
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We disabled the OS X and Windows cross-building tests. This, predictably, led us to regress a bit in our ability to build for both of these. This fixes the build on OS X and fixes one obvious Windows bug. Unfortunately, we're dragging in all of `pkg/spec` somewhere on Windows, and things are blowing up spectacularly because of it (plus a few uses of the `syscall` package in the bindings). I've giving up for the day. This fixes OS X, but does not fully enable the cross-build CI (need Windows fixes for that). Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #6284 from baude/v2remotetestfixesOpenShift Merge Robot2020-05-21
|\ \ \ \ \ | | | | | | | | | | | | Test fixes for remote integration
| * | | | | Test fixes for remote integrationBrent Baude2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #6295 from edsantiago/bats_podOpenShift Merge Robot2020-05-20
|\ \ \ \ \ \ | | | | | | | | | | | | | | system tests: more podman-pod tests
| * | | | | | system tests: more podman-pod testsEd Santiago2020-05-20
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * rename pod-top.bats to pod.bats * add test for TCP port communication between pods * add test for various podman-pod-create options Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #6161 from kunalkushwaha/network-inspectOpenShift Merge Robot2020-05-20
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | `--format` and `--filter` options for `network ls` and `network inspect` command
| * | | | | Testcase added for network commandsKunal Kushwaha2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | New testcase for network ls --filter and inspect --format added. Also bash completion options updated. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
| * | | | | format option added to network inspect command.Kunal Kushwaha2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This helps user to print the inspect output in go template format. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
| * | | | | filter option added to network ls command.Kunal Kushwaha2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | filter option helps to filter output based on name or supported plugins by CNI networks. Signed-off-by: Kunal Kushwaha <kunal.kushwaha@gmail.com>
* | | | | | Merge pull request #6305 from baude/v2podcreatetestOpenShift Merge Robot2020-05-20
|\ \ \ \ \ \ | | | | | | | | | | | | | | enable pod_create remote integration tests
| * | | | | | enable pod_create remote integration testsBrent Baude2020-05-20
| | |/ / / / | |/| | | | | | | | | | | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #6300 from baude/v2governattachOpenShift Merge Robot2020-05-20
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | govern remote attach and start
| * | | | | govern remote attach and startBrent Baude2020-05-20
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | fixes a race where container would start before attach could occur resulting in an error. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #6297 from mheon/minor_fix_attachOpenShift Merge Robot2020-05-20
|\ \ \ \ \ | | | | | | | | | | | | Print container state when erroring that it is improper
| * | | | | Print container state when erroring that it is improperMatthew Heon2020-05-20
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a nice little convenience - lets people know why we won't let them attach to a container. Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #6302 from baude/v2remotecreateOpenShift Merge Robot2020-05-20
|\ \ \ \ \ | | | | | | | | | | | | Fix create_test for remote integration
| * | | | | Fix create_test for remote integrationBrent Baude2020-05-20
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | fixes tests to pass for remote integration. the two remaining tests that are skipped are due to lack of logs command. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #6291 from haircommander/journald-container-nameOpenShift Merge Robot2020-05-20
|\ \ \ \ \ | | | | | | | | | | | | oci conmon: tell conmon to log container name
| * | | | | don't skip log tests unless remotePeter Hunt2020-05-20
| | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Peter Hunt <pehunt@redhat.com>
| * | | | | oci conmon: tell conmon to log container namePeter Hunt2020-05-20
| | |_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | specifying `-n=ctr-name` tells conmon to log CONTAINER_NAME=name if the log driver is journald add this, and a test! also, refactor the args slice creation to not append() unnecessarily. Signed-off-by: Peter Hunt <pehunt@redhat.com>
* | | | | Merge pull request #6271 from jwhonce/wip/versionOpenShift Merge Robot2020-05-20
|\ \ \ \ \ | |_|/ / / |/| | | | V2 API Version Support
| * | | | V2 API Version SupportJhon Honce2020-05-20
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Update blang/semver to allow ParseTolerant() support * Provide helper functions for API handlers to obtain client's 'version' path variable focused on API endpoint tree: libpod vs. compat * Introduce new errors: * version not given in path, endpoints may determine if this is a hard error (ErrVersionNotGiven) * given version not supported (ErrVersionNotSupported), only a soft error if the handler is going to hijack the connection * Added unit tests for version parsing * bindings check version on connect: * client <= Server API version connection is continued * client >= Server API version connection fails Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | Merge pull request #6273 from vrothberg/registry_helperOpenShift Merge Robot2020-05-20
|\ \ \ \ | | | | | | | | | | Registry helper : go bindings
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-10-08 02:56:19 +0000