summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* migrate Podman to containers/common/libimageValentin Rothberg2021-05-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Migrate the Podman code base over to `common/libimage` which replaces `libpod/image` and a lot of glue code entirely. Note that I tried to leave bread crumbs for changed tests. Miscellaneous changes: * Some errors yield different messages which required to alter some tests. * I fixed some pre-existing issues in the code. Others were marked as `//TODO`s to prevent the PR from exploding. * The `NamesHistory` of an image is returned as is from the storage. Previously, we did some filtering which I think is undesirable. Instead we should return the data as stored in the storage. * Touched handlers use the ABI interfaces where possible. * Local image resolution: previously Podman would match "foo" on "myfoo". This behaviour has been changed and Podman will now only match on repository boundaries such that "foo" would match "my/foo" but not "myfoo". I consider the old behaviour to be a bug, at the very least an exotic corner case. * Futhermore, "foo:none" does *not* resolve to a local image "foo" without tag anymore. It's a hill I am (almost) willing to die on. * `image prune` prints the IDs of pruned images. Previously, in some cases, the names were printed instead. The API clearly states ID, so we should stick to it. * Compat endpoint image removal with _force_ deletes the entire not only the specified tag. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #10199 from edsantiago/system_tests_with_runc_overrideOpenShift Merge Robot2021-05-04
|\ | | | | System tests: honor $OCI_RUNTIME (for CI)
| * System tests: honor $OCI_RUNTIME (for CI)Ed Santiago2021-05-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some CI systems set $OCI_RUNTIME as a way to override the default crun. Integration (e2e) tests honor this, but system tests were not aware of the convention; this means we haven't been testing system tests with runc, which means RHEL gating tests are now failing. The proper solution would be to edit containers.conf on CI systems. Sorry, that would involve too much CI-VM work. Instead, this PR detects $OCI_RUNTIME and creates a dummy containers.conf file using that runtime. Add: various skips for tests that don't work with runc. Refactor: add a helper function so we don't need to do the complicated 'podman info blah blah .OCIRuntime.blah' thing in many places. BUG: we leave a tmp file behind on exit. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #8828 from boaz0/closes_8779OpenShift Merge Robot2021-05-04
|\ \ | | | | | | Add --all to podman start
| * | is this a bug?Boaz Shuster2021-05-04
| | | | | | | | | | | | Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
| * | Add --all to podman startBoaz Shuster2021-05-03
| | | | | | | | | | | | | | | Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com> Co-authored-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #10206 from Luap99/fix-9837OpenShift Merge Robot2021-05-04
|\ \ \ | | | | | | | | compat api: Networks must be empty instead of null
| * | | compat api: Networks must be empty instead of nullPaul Holzinger2021-05-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The compat endpoint for container inspect must return {} instead of null for NetworkSettings.Networks. Fixes #9837 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #10200 from edsantiago/batsOpenShift Merge Robot2021-05-04
|\ \ \ \ | |/ / / |/| | | system test image: add arm64v8 image
| * | | system test image: add arm64v8 imageEd Santiago2021-05-03
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | The RHEL multi-arch team informed me that we were missing aarch64; add it, using the new name (arm64v8). (This is from last week, so the image date tag does not match today's date. I was waiting for confirmation that things were working). Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #10194 from rhatdan/docsOpenShift Merge Robot2021-05-03
|\ \ \ | | | | | | | | [CI:DOCS] Fix troubleshooting documentation on handling supplemental groups.
| * | | Fix troubleshooting documentation on handling sublemental groups.Daniel J Walsh2021-05-03
| | |/ | |/| | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/10166 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #10195 from cevich/fix_no_tagOpenShift Merge Robot2021-05-03
|\ \ \ | |_|/ |/| | [CI:DOCS] Fix variable reference typo. in multi-arch image action
| * | Fix variable reference typo. in multi-arch image actionChris Evich2021-05-03
| |/ | | | | | | | | | | | | | | | | | | | | | | Bug introduced by #10150 Also, in case of failure of one matrix-leg, do not terminate execution of all others. There are many reasons why an item could fail (i.e. temporary networking problem). Since the job runs periodically, we can simply allow the subsequent run to cover for any missed images pushes due to sporadic job failures. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #10191 from ↵OpenShift Merge Robot2021-05-03
|\ \ | | | | | | | | | | | | containers/dependabot/go_modules/github.com/uber/jaeger-client-go-2.28.0incompatible Bump github.com/uber/jaeger-client-go from 2.27.0+incompatible to 2.28.0+incompatible
| * | Bump github.com/uber/jaeger-client-godependabot[bot]2021-05-03
| |/ | | | | | | | | | | | | | | Bumps [github.com/uber/jaeger-client-go](https://github.com/uber/jaeger-client-go) from 2.27.0+incompatible to 2.28.0+incompatible. - [Release notes](https://github.com/uber/jaeger-client-go/releases) - [Changelog](https://github.com/jaegertracing/jaeger-client-go/blob/master/CHANGELOG.md) - [Commits](https://github.com/uber/jaeger-client-go/compare/v2.27.0...v2.28.0) Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #10177 from giuseppe/always-honor-cgroup-parentOpenShift Merge Robot2021-05-03
|\ \ | |/ |/| cgroup: always honor --cgroup-parent
| * cgroup: always honor --cgroup-parent with cgroupfsGiuseppe Scrivano2021-05-03
| | | | | | | | | | | | | | | | | | if --cgroup-parent is specified, always honor it without doing any detection whether cgroups are supported or not. Closes: https://github.com/containers/podman/issues/10173 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #10183 from cevich/fix_multi_arch_syntaxOpenShift Merge Robot2021-05-01
|\ \ | | | | | | Fix multi-arch image workflow typo
| * | Don't require tests for github-actions & metadataChris Evich2021-04-30
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
| * | Fix multi-arch image workflow typoChris Evich2021-04-30
| | | | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #10182 from baude/machineCNIOpenShift Merge Robot2021-05-01
|\ \ \ | |/ / |/| | Detect if in podman machine virtual vm
| * | Detect if in podman machine virtual vmBrent Baude2021-04-30
|/ / | | | | | | | | | | | | | | | | | | | | | | When in podman machine virtual machines, podman needs to be able to detect as such. One implementation for this is when creating networks, the podman-machine cni plugin needs to be added to the configuration. This PR also includes the latest containers-common. [NO TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #10179 from rcowsill/remote-doc-titlesOpenShift Merge Robot2021-04-30
|\ \ | | | | | | [CI:DOCS] Add titles to remote docs (windows)
| * | [CI:DOCS] Add titles to remote docs (windows)Rob Cowsill2021-04-29
| |/ | | | | | | | | | | | | | | Previously the podman-remote windows docs had no HTML titles This gives them the same titles as the equivalent Sphinx HTML pages Signed-off-by: Rob Cowsill <42620235+rcowsill@users.noreply.github.com>
* | Merge pull request #10174 from rhatdan/volumeOpenShift Merge Robot2021-04-30
|\ \ | | | | | | Remove unused VolumeList* structs
| * | Remove unused VolumeList* structsDaniel J Walsh2021-04-29
| | | | | | | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] since we are just removing unused code. Replaces: https://github.com/containers/podman/pull/9558 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #10150 from cevich/update_multi_arch_docsOpenShift Merge Robot2021-04-29
|\ \ \ | |_|/ |/| | [CI:DOCS] Update container image docs + fix unstable execution
| * | Update container image docs + fix unstable executionChris Evich2021-04-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the order of image documentation to be from most to least stable. Similarly, avoid depending on execution of upstream podman, when building/pushing. It's easily possible for this build to function but execution to fail due to some partially implemented feature. Also, ensure images tagged `latest` are pushed for every matrix item. For 'upstream' and 'testing', this replaces use of the 'master' tag. Lastly, update workflow comments and split the 'podman' and 'containers' FQIN steps and outputs to improve readability. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #10175 from cevich/update_f34OpenShift Merge Robot2021-04-29
|\ \ \ | | | | | | | | Cirrus: Update F34beta -> F34
| * | | Cirrus: Update F34beta -> F34Chris Evich2021-04-29
| |/ / | | | | | | | | | Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #10063 from ParkerVR/autoupdate-localOpenShift Merge Robot2021-04-29
|\ \ \ | |/ / |/| | Autoupdate Local
| * | TODO completeParker Van Roy2021-04-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | changed struct to policyMapper change "image" to "registry" in multiple locations Updated documentation with registry alias & autoupdate local Added relevant test Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
| * | VendoredParker Van Roy2021-04-28
| | | | | | | | | | | | Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
| * | Autoupdate local label functionalParker Van Roy2021-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Digests were used to compare local image and container image Registry alias added for Image Policy Refactored to integrate new feature + change some naming conventions Tested this using a modified version of the docs autoupdate instructions & it worked successfully Signed-off-by: Parker Van Roy <pvanroy@redhat.com>
* | | Merge pull request #10170 from ashley-cui/machineoneOpenShift Merge Robot2021-04-29
|\ \ \ | | | | | | | | [NO TESTS NEEDED] Check if another VM is running on machine start
| * | | Check if another VM is running on machine startAshley Cui2021-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Only one VM can be up at a time. If another VM is running, or the current VM is running, error out on a podman machine start [NO TESTS NEEDED] Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #10171 from rhatdan/eventsOpenShift Merge Robot2021-04-29
|\ \ \ \ | |_|_|/ |/| | | Docker returns 'die' status rather then 'died' status
| * | | Docker returns 'die' status rather then 'died' statusDaniel J Walsh2021-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In order to be more compatible with Docker, we should return a container die status rather then a "container died", Too late to change this for Podman. Partially fixes: https://github.com/containers/podman/issues/10168 [NO TESTS NEEDED] No easy way to test this. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #10172 from ↵OpenShift Merge Robot2021-04-29
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.30.1 Bump github.com/containers/storage from 1.30.0 to 1.30.1
| * | | | Bump github.com/containers/storage from 1.30.0 to 1.30.1dependabot[bot]2021-04-29
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.30.0 to 1.30.1. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/master/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.30.0...v1.30.1) Signed-off-by: dependabot[bot] <support@github.com>
* | | | Merge pull request #10155 from pablofsf/fix-default-seccompOpenShift Merge Robot2021-04-28
|\ \ \ \ | |/ / / |/| | | Use seccomp_profile as default profile if defined in containers.conf
| * | | Use seccomp_profile as default profile if defined in containers.confPablo Correa Gómez2021-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Edits `podman info` to provide the default seccomp profile detected in the output Signed-off-by: Pablo Correa Gómez <ablocorrea@hotmail.com>
* | | | Merge pull request #10167 from rcowsill/html-doc-titlesOpenShift Merge Robot2021-04-28
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Improve titles of command HTML pages
| * | | | [CI:DOCS] Improve titles of command HTML pagesRob Cowsill2021-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When building Sphinx HTML docs, preprocess markdown files and convert pandoc-style title lines into recommonmark eval_rst blocks This gives command HTML pages the same title as the equivalent manpage Fixes: containers/podman.io#385 Signed-off-by: Rob Cowsill <42620235+rcowsill@users.noreply.github.com>
* | | | | Merge pull request #10165 from edsantiago/batsOpenShift Merge Robot2021-04-28
|\ \ \ \ \ | |/ / / / |/| | | | system tests: networking: fix another race condition
| * | | | system tests: networking: fix another race conditionEd Santiago2021-04-28
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | Our current #1 flake; this is a simple one: we can't run 'logs' on a container run with '-d --rm'. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #10139 from rhatdan/troubleshootOpenShift Merge Robot2021-04-28
|\ \ \ \ | |/ / / |/| | | [CI:DOCS] Add troubleshooting advice about the --userns option.
| * | | Add troubleshooting advice about the --userns option.Josh Berkus2021-04-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also a link to the troubleshooting guide into the issue template. Replaces: https://github.com/containers/podman/pull/9770 Signed-off-by: Josh Berkus <josh@agliodbs.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #10162 from ↵OpenShift Merge Robot2021-04-28
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/json-iterator/go-1.1.11 Bump github.com/json-iterator/go from 1.1.10 to 1.1.11
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-09-25 08:43:32 +0000