summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #12712 from flouthoc/volume_overlay_advancedOpenShift Merge Robot2022-01-28
|\ | | | | volume: add support for non-volatile `upperdir`,`workdir` for overlay volumes
| * volume: add support for non-volatile upperdir,workdir for overlay volumesAditya Rajan2022-01-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Often users want their overlayed volumes to be `non-volatile` in nature that means that same `upper` dir can be re-used by one or more containers but overall of nature of volumes still have to be `overlay` so work done is still on a overlay not on the actual volume. Following PR adds support for more advanced options i.e custom `workdir` and `upperdir` for overlayed volumes. So that users can re-use `workdir` and `upperdir` across new containers as well. Usage ```console $ podman run -it -v myvol:/data:O,upperdir=/path/persistant/upper,workdir=/path/persistant/work alpine sh ``` Signed-off-by: Aditya R <arajan@redhat.com>
* | Merge pull request #13048 from cevich/fix_get_ci_vmOpenShift Merge Robot2022-01-28
|\ \ | | | | | | [CI:DOCS] Cirrus: Fix get_ci_vm.sh initial setup
| * | Cirrus: Fix get_ci_vm.sh initial setupChris Evich2022-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Due to some recent changes in the Makefile, the setup part of the script is now breaking with the error: ``` install: cannot stat 'bin/rootlessport': No such file or directory make: *** [Makefile:767: install.bin] Error 1 ``` The root-cause seems to be the `install` targets not properly specifying their build dependencies. This may lead to other problems WRT automation, but for now I'm just patching this tool to workaround the issue. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #13052 from Luap99/issues2OpenShift Merge Robot2022-01-28
|\ \ \ | | | | | | | | [CI:DOCS] github: label issues based on os fix regex
| * | | github: label issues based on os fix regexPaul Holzinger2022-01-27
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Good news the github action works, however I noticed that we cannot use a multiline regex so we have to use serviceIsRemote to detect if this is a remote client. Also change the os regex so that it matches both the output of podman version and podman info. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #13050 from Luap99/issuesOpenShift Merge Robot2022-01-27
|\ \ \ | | | | | | | | [CI:DOCS] github: label issues based on os
| * | | github: label issues based on osPaul Holzinger2022-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We get a lot of issues for podman-remote on macos. Since the fact that this is a remote client is often overlooked by us lets add windows, macos and remote label automatically based on a regex which should match the output of podman version. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #13049 from edsantiago/batsDaniel J Walsh2022-01-27
|\ \ \ \ | | | | | | | | | | System tests: emergency skip of checkpoint tests
| * | | | System tests: emergency skip of checkpoint testsEd Santiago2022-01-27
| | |/ / | |/| | | | | | | | | | | | | | | | | | ...on kernel 5.17, because it's broken Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #13042 from Luap99/subnetsOpenShift Merge Robot2022-01-27
|\ \ \ \ | |/ / / |/| | | network create: allow multiple subnets
| * | | network create: allow multiple subnetsPaul Holzinger2022-01-27
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman network create --subnet, --gateway and --ip-range can now be specified multiple times to join the network to more than one subnet. This is very useful if you want to use a dual stack network and assign a fixed ipv4 and ipv6 subnet. The order of the options is important here, the first --gateway/--ip-range will be assigned to the first subnet and so on. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #13035 from rhatdan/docs1OpenShift Merge Robot2022-01-27
|\ \ \ | | | | | | | | CI:DOCS: Add troublshooting info on podman machine remove followed by podman machine init
| * | | Update troubleshooting.mdbazhang872022-01-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Bart Zhang bazhang@redhat.com Co-authored-by: Erik Sjölund <erik.sjolund@gmail.com> Co-authored-by: Tom Sweeney <tsweeney@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #13034 from rhatdan/docsOpenShift Merge Robot2022-01-27
|\ \ \ \ | |_|_|/ |/| | | CI:DOCS: Unify podman prune filter description: volumes, networks, system
| * | | Fix sort ordering of filtersDaniel J Walsh2022-01-27
| | | | | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | Unify podman prune filter description: volumes, networks, systemPatrycja Guzik2022-01-27
| | | | | | | | | | | | | | | | | | | | | | | | follow up of #12976 Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
* | | | Merge pull request #13029 from TomSweeneyRedHat/dev/tsweeney/mergepull2OpenShift Merge Robot2022-01-27
|\ \ \ \ | |_|_|/ |/| | | Bump Buildah to v1.24.0
| * | | Bump Buildah to v1.24.0tomsweeneyredhat2022-01-27
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | Bumps Buildah to v1.24.0 and adopts the new values for pull: true, false, never, and always. The pull-never and pull-always options for the build command are still usable, but they have been removed from the man page documentation with this change. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
* | | Merge pull request #12867 from cdoern/scpOpenShift Merge Robot2022-01-27
|\ \ \ | |_|/ |/| | switch podman image scp from depending on machinectl to just os/exec
| * | switch podman image scp from depending on machinectl to just os/execcdoern2022-01-26
| |/ | | | | | | | | | | | | | | | | machinectl does not propogate error messages and adds extra lines in the output, exec.Cmd is able to clear the env besides PATH and TERM, and use the given UID and GID to execute the command properly. machinectl is still used to create a user session. Ubuntu support is limited by this. Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #13031 from ↵OpenShift Merge Robot2022-01-27
|\ \ | |/ |/| | | | | giuseppe/drop-permission-check-privileged-rootless-devices rootless: drop permission check for devices
| * rootless: drop permission check for devicesGiuseppe Scrivano2022-01-27
|/ | | | | | | | | | | | | commit 350ede1eeb6ab33bce2918d7768b940c255e63c6 added the feature. Do not check whether the device is usable by the rootless user before adding to the container. Closes: https://github.com/containers/podman/issues/12704 [NO NEW TESTS NEEDED] it requires changes on the host to test it Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #13017 from ↵OpenShift Merge Robot2022-01-26
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containers/image/v5-5.19.0 Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0
| * Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0dependabot[bot]2022-01-26
|/ | | | | | | | | | | | | | Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.18.0 to 5.19.0. - [Release notes](https://github.com/containers/image/releases) - [Commits](https://github.com/containers/image/compare/v5.18.0...v5.19.0) --- updated-dependencies: - dependency-name: github.com/containers/image/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* Merge pull request #13016 from ↵OpenShift Merge Robot2022-01-26
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.38.1 Bump github.com/containers/storage from 1.38.0 to 1.38.1
| * Bump github.com/containers/storage from 1.38.0 to 1.38.1dependabot[bot]2022-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.38.0 to 1.38.1. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.38.0...v1.38.1) --- updated-dependencies: - dependency-name: github.com/containers/storage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #13013 from danielhelfand/osx-build-docsOpenShift Merge Robot2022-01-26
|\ \ | |/ |/| [CI:DOCS] change location of where make outputs podman binary on osx
| * change location of where make outputs podman binary on osxDaniel Helfand2022-01-25
|/ | | | Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
* Merge pull request #13008 from cevich/fix_jqOpenShift Merge Robot2022-01-25
|\ | | | | [CI:DOCS] Github workflow: Fix parsing of GraphQL response JSON
| * Github workflow: Fix parsing of GraphQL response JSONChris Evich2022-01-25
|/ | | | | | | | | | | | | | | | While #12998 fixed the query string, it neglected to address presence of the old `githubRepository` field name in the reply. This resulted in the job throwing an error: `jq: error (at ./artifacts/reply.json:0): Cannot iterate over null` However, the job did preserve an artifacts archive containing the new response data. As a test for the fix in this commit, I ran the raw response data through the corrected jq command-line. This confirmed the change by properly parsing the data as expected by the workflow. Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #12998 from cevich/fix_queryOpenShift Merge Robot2022-01-25
|\ | | | | [CI:DOCS] Github workflow: Update Cirrus-cron GraphQL query
| * Github workflow: Update Cirrus-cron GraphQL queryChris Evich2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometime on Jan. 14th the GraphQL schema for Cirrus-CI changed, leading to the following error: `Validation error of type FieldUndefined: Field 'githubRepository' in type 'Root' is undefined @ 'githubRepository'` After some exploration, it was determined the field had been replaced with a new root-level field `ownerRepository`. Manual experimentation revealed the scalar value `LINUX` was appropriate to use for the new `platform` parameter. The query reply appears to remain compatible. Update the script which performs this query to use the new field name and parameter. ***NOTE*** This script is shared across multiple containers-org repos. All of which are/were affected by the schema change. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #13005 from cevich/fix_notifyOpenShift Merge Robot2022-01-25
|\ \ | | | | | | [CI:DOCS] Github-workflow: Fix YAML syntax
| * | Github-workflow: Fix YAML syntaxChris Evich2022-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `body` string value must be quoted because it contains a colon. Also fix an incorrect URL substitution reference in error-notice e-mail body text. (In my defense...testing this workflow is basically impractical without merging it) Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #12999 from jwhonce/issues/12987OpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | Update godoc, swagger using wrong struct
| * | | Update godoc, swagger using wrong structJhon Honce2022-01-25
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Documentation for API volume list, pointed to a different struct than the code. [NO NEW TESTS NEEDED] Fixes #12987 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #12966 from lsm5/makefile-separate-build-installOpenShift Merge Robot2022-01-25
|\ \ \ | |/ / |/| | Makefile: install targets independent of build
| * | Makefile: install targets independent of buildLokesh Mandvekar2022-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Building from source would involve separate `make` and `make install` steps. This removes a lot of unnecessary `-nobuild` targets which were otherwise needed for packaging. This commit also removes spec files for unused copr jobs. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #12857 from giuseppe/fix-rm-dir-not-emptyOpenShift Merge Robot2022-01-25
|\ \ \ | |/ / |/| | exec: retry rm -rf on ENOTEMPTY and EBUSY
| * | exec: retry rm -rf on ENOTEMPTY and EBUSYGiuseppe Scrivano2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when running on NFS, a RemoveAll could cause EBUSY because of some unlinked files that are still kept open and "silly renamed" to .nfs$ID. This is only half of the fix, as conmon needs to be fixed too. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2040379 Related: https://github.com/containers/conmon/pull/319 [NO NEW TESTS NEEDED] as it requires NFS as the underlying storage. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | libpod: fix leaking fdGiuseppe Scrivano2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | the config.json file for the OCI runtime is never closed, this is a problem when running on NFS, since it leaves around stale files that cannot be unlinked. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | libpod: fix connection leakGiuseppe Scrivano2022-01-24
| |/ | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #13000 from eriksjolund/fix_typos_and_improve_language_2OpenShift Merge Robot2022-01-25
|\ \ | | | | | | [CI:DOCS] Fix typos and improve language (add 3 missing)
| * | [CI:DOCS] Fix typos and improve languageErik Sjölund2022-01-24
| | | | | | | | | | | | | | | | | | | | | * Add more documentation fixes similar to 8099a61b648a1cfc862461487f1db9ecd47d065e Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | Merge pull request #12997 from cevich/notify_on_errorOpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | [CI:DOCS] Github workflow: Send e-mail on job error
| * | | Github workflow: Send e-mail on job errorChris Evich2022-01-24
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This job is designed to be silent when Cirrus-cron executions pass. Unless specifically instructed, the workflow itself will also remain silent if there's an error. Fix this by catching workflow errors and sending a notification e-mail containing a link to the failed run. This also requires listing the recipient addresses directly in the workflow. Otherwise (as previouslly implemented) the value would not be retrieved if/when any previous step raised an error. **Note**: Due to the way this workflow is implemented, there is no way easy way to test it other than directly on the `main` repo. branch. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #12993 from edsantiago/test_rootless_remoteOpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | CI: enable rootless-remote system tests
| * | | CI: enable rootless-remote system testsEd Santiago2022-01-24
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Minimal: only test Fedora.Latest. Reason: podman 4.0.0-0.2.rc2 broke bodhi gating tests: https://github.com/containers/podman/issues/12989 Requires skipping two recently-added tests that use 'podman unshare', which doesn't work on remote. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #12974 from kolyshkin/typoOpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | pkg/specgen/generate/security: fix error message text
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-08 06:00:29 +0000