| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
| |
Signed-off-by: Qi Wang <qiwan@redhat.com>
|
| |\
| |
| | |
lock and sync container before checking mountpoint
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
when checking for a container's mountpoint, you must lock and sync
the container or the result may be "".
Fixes: #2304
Signed-off-by: baude <bbaude@redhat.com>
|
| |\ \
| |/
|/| |
Podman pod stats -- fix GO template output
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Go templates were not being processed or printed correctly for podman
pod stats. Added the ability to do templates as well as honor the
table identifier.
Fixes #2258
Signed-off-by: baude <bbaude@redhat.com>
|
| |\ \
| | |
| | | |
pod: drop invalid check for rootless
|
| | | |
| | |
| | |
| | |
| | |
| | | |
we are doing it few lines above.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
rootless networks support port binding if the underlying slirp4netns
is new enough.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| |\ \ \
| |/ /
|/| | |
Add common_test.go to single test instructions
|
| | |/
| |
| |
| |
| |
| |
| | |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Add e2e/test/common_test.go to the single integration test
instructions. Without it the documented process fails.
|
| |\ \
| |/
|/| |
Add troubleshooting information about running a rootless containers.
|
| |/
|
|
|
|
|
| |
Add a problem statement about shadow-utils and missing entries from
/etc/subuid and /etc/subgid.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\
| |
| | |
Update image-trust man with further comments
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
After the last update, @mtrmac had some great suggestions which I've incorporated.
I've updated the G:oogle doc and have added this PR in case it's easier to see the diffs.
Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
|
| |\ \
| | |
| | | |
Add volume mounts to PS output
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When listing containers, you should be able to list the mounts
with something like --format "table{{".Mounts}}".
Resolves: #2238
Signed-off-by: baude <bbaude@redhat.com>
|
| |\ \ \
| |/ /
|/| | |
do not crash when displaying dangling images
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
the previous method required a populated image template to create
the headers and always selected the first image in the slice. when
dealing with dangling images, they are not populated and therefore
would panic.
Resolves: #2246
Signed-off-by: baude <bbaude@redhat.com>
|
| |\ \
| | |
| | | |
Migrate to cobra CLI
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
We intend to migrate to the cobra cli from urfave/cli because the
project is more well maintained. There are also some technical reasons
as well which extend into our remote client work.
Signed-off-by: baude <bbaude@redhat.com>
|
| |\ \
| | |
| | | |
Remove some dead type declarations
|
| |/ /
| |
| |
| | |
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
| |\ \
| | |
| | | |
cleanup: use the correct runtime
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
make sure "containers cleanup" uses the correct runtime if it was
overriden.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| |\ \ \
| | | |
| | | | |
Fix down/missing registry.access.redhat.com
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This registry responds differently depending on the the platform
accessing it. It also occasionally goes down or returns 404s. Improve
the reliability of the e2e tests by using the registry/image used
for gating pull-requests.
This way, if there's a registry/networking problem, the gating test
will fail and prevent anything else from running. This is a better
failure to have early, rather than wait and need to re-run all the
e2e tests again later.
Signed-off-by: Chris Evich <cevich@redhat.com>
|
| |\ \ \
| | | |
| | | | |
Vendor docs
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
@baude and I have recently debugged a `make vendor` issue, where
different versions of `vndr` leave slightly different states behind.
This ultimately leads to inconsistencies with the CI, which always
fetches the latest version.
To avoid such issues in the future, always use the latest version of
`vndr` by checking for new versions of it prior to execution.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
| | |/ /
| | |
| | |
| | |
| | |
| | | |
Add a section about how `make vendor` works and how to troubleshoot it.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
|
| |\ \ \
| |/ /
|/| | |
Add varlink generate to the make documentation
|
| |/ /
| |
| |
| |
| |
| |
| | |
Minor improvement who add helping comment to the
varlink generate target.
Signed-off-by: Hervé Beraud <hberaud@redhat.com>
|
| |\ \
| |/
|/| |
Add documentation on running systemd on SELinux systems
|
| | |
| |
| |
| |
| |
| |
| |
| | |
Lots of users are attempting to run systemd within a container. They are
being blocked from running SELinux systems since they need the
container_manage_cgroup which is not enabled by default.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\ \
| | |
| | | |
Fix handling of memory limits via varlink
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Currently handlin memory via varlink is hard coded to 0
Changing to
Memory: create.Resources.Memory,
MemoryReservation: create.Resources.Memory_reservation,
MemorySwap: create.Resources.Memory_swap,
MemorySwappiness: int(create.Resources.Memory_swappiness),
KernelMemory: create.Resources.Kernel_memory,
Allows callers to modify these memory settings.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\ \
| | |
| | | |
Mention officially supported OSes, fixes #2208
|
| | | |
| | |
| | |
| | | |
Signed-off-by: William Entriken <github.com@phor.net>
|
| |\ \ \
| | | |
| | | | |
Unconditionally refresh storage options from config
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Due to our unconditionally setting some storage options, we
are not always reading storage options from storage.conf. This
can lead to some fields in the storage config (most notably extra
storage options) being ignored, despite being set in
storage.conf.
Resolve this by unconditionally refreshing our storage config
from storage.conf (this was previously only done for rootless
Podman)
Fixes #2217
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
|
| |\ \ \ \
| | | | |
| | | | | |
Add podman system prune and info commands
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We have no consistancy in out option usages and descritions
on whether or not the first letter should be capatalized.
This patch forces them all to be capatilized.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
We are missing the equivalence of the docker system commands
This patch set adds `podman system prune`
and `podman system info`
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
| |\ \ \ \ \
| | | | | |
| | | | | | |
Generate make helping message dynamicaly.
|
| | | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Generate make helping message dynamicaly by using
python code snippet inside Makefile.
All commented make targets will be added to the
help message. To be added to the helping message
comment need to start with '## '.
These specials comments are detected by the python code.
Python code generate the helping output from these results.
Notice that this commit introduce a dependency with python (compatible python 2 and 3).
Signed-off-by: Hervé Beraud <hberaud@redhat.com>
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
Makefile: minor fix to reenable system tests
|
| | |/ / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
PR #2259 removed the .install.gomega Makefile target but
didn't clean up two references to it. Do so now.
Also, when setting up GOPKGBASEDIR symlink, use -f (force)
flag; otherwise subsequent makes will fail.
Signed-off-by: Ed Santiago <santiago@redhat.com>
|
| |\ \ \ \ \ \
| | | | | | |
| | | | | | | |
rootless: do not override /dev/pts if not needed
|
| | | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | |
| | | | | | | |
when running in rootless mode we were unconditionally overriding
/dev/pts to take ride of gid=5. This is not needed when multiple gids
are present in the namespace, which is always the case except when
running the tests suite with only one mapping. So change it to check
how many gids are present before overriding the default mount.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
| |\ \ \ \ \ \ \
| |_|/ / / / /
|/| | | | | | |
Add StartPeriod to cmd/podman/docker.HealthConfig
|
| |/ / / / / /
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | | |
Backport the addition of the StartPeriod field to our copy of the
HealthConfig type, added in docker v17.05.0-ce.
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
