summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #13029 from TomSweeneyRedHat/dev/tsweeney/mergepull2OpenShift Merge Robot2022-01-27
|\ | | | | Bump Buildah to v1.24.0
| * Bump Buildah to v1.24.0tomsweeneyredhat2022-01-27
| | | | | | | | | | | | | | | | | | Bumps Buildah to v1.24.0 and adopts the new values for pull: true, false, never, and always. The pull-never and pull-always options for the build command are still usable, but they have been removed from the man page documentation with this change. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
* | Merge pull request #12867 from cdoern/scpOpenShift Merge Robot2022-01-27
|\ \ | | | | | | switch podman image scp from depending on machinectl to just os/exec
| * | switch podman image scp from depending on machinectl to just os/execcdoern2022-01-26
| |/ | | | | | | | | | | | | | | | | machinectl does not propogate error messages and adds extra lines in the output, exec.Cmd is able to clear the env besides PATH and TERM, and use the given UID and GID to execute the command properly. machinectl is still used to create a user session. Ubuntu support is limited by this. Signed-off-by: cdoern <cdoern@redhat.com>
* | Merge pull request #13031 from ↵OpenShift Merge Robot2022-01-27
|\ \ | |/ |/| | | | | giuseppe/drop-permission-check-privileged-rootless-devices rootless: drop permission check for devices
| * rootless: drop permission check for devicesGiuseppe Scrivano2022-01-27
|/ | | | | | | | | | | | | commit 350ede1eeb6ab33bce2918d7768b940c255e63c6 added the feature. Do not check whether the device is usable by the rootless user before adding to the container. Closes: https://github.com/containers/podman/issues/12704 [NO NEW TESTS NEEDED] it requires changes on the host to test it Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* Merge pull request #13017 from ↵OpenShift Merge Robot2022-01-26
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containers/image/v5-5.19.0 Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0
| * Bump github.com/containers/image/v5 from 5.18.0 to 5.19.0dependabot[bot]2022-01-26
|/ | | | | | | | | | | | | | Bumps [github.com/containers/image/v5](https://github.com/containers/image) from 5.18.0 to 5.19.0. - [Release notes](https://github.com/containers/image/releases) - [Commits](https://github.com/containers/image/compare/v5.18.0...v5.19.0) --- updated-dependencies: - dependency-name: github.com/containers/image/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* Merge pull request #13016 from ↵OpenShift Merge Robot2022-01-26
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containers/storage-1.38.1 Bump github.com/containers/storage from 1.38.0 to 1.38.1
| * Bump github.com/containers/storage from 1.38.0 to 1.38.1dependabot[bot]2022-01-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.38.0 to 1.38.1. - [Release notes](https://github.com/containers/storage/releases) - [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md) - [Commits](https://github.com/containers/storage/compare/v1.38.0...v1.38.1) --- updated-dependencies: - dependency-name: github.com/containers/storage dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #13013 from danielhelfand/osx-build-docsOpenShift Merge Robot2022-01-26
|\ \ | |/ |/| [CI:DOCS] change location of where make outputs podman binary on osx
| * change location of where make outputs podman binary on osxDaniel Helfand2022-01-25
|/ | | | Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
* Merge pull request #13008 from cevich/fix_jqOpenShift Merge Robot2022-01-25
|\ | | | | [CI:DOCS] Github workflow: Fix parsing of GraphQL response JSON
| * Github workflow: Fix parsing of GraphQL response JSONChris Evich2022-01-25
|/ | | | | | | | | | | | | | | | While #12998 fixed the query string, it neglected to address presence of the old `githubRepository` field name in the reply. This resulted in the job throwing an error: `jq: error (at ./artifacts/reply.json:0): Cannot iterate over null` However, the job did preserve an artifacts archive containing the new response data. As a test for the fix in this commit, I ran the raw response data through the corrected jq command-line. This confirmed the change by properly parsing the data as expected by the workflow. Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #12998 from cevich/fix_queryOpenShift Merge Robot2022-01-25
|\ | | | | [CI:DOCS] Github workflow: Update Cirrus-cron GraphQL query
| * Github workflow: Update Cirrus-cron GraphQL queryChris Evich2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sometime on Jan. 14th the GraphQL schema for Cirrus-CI changed, leading to the following error: `Validation error of type FieldUndefined: Field 'githubRepository' in type 'Root' is undefined @ 'githubRepository'` After some exploration, it was determined the field had been replaced with a new root-level field `ownerRepository`. Manual experimentation revealed the scalar value `LINUX` was appropriate to use for the new `platform` parameter. The query reply appears to remain compatible. Update the script which performs this query to use the new field name and parameter. ***NOTE*** This script is shared across multiple containers-org repos. All of which are/were affected by the schema change. Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #13005 from cevich/fix_notifyOpenShift Merge Robot2022-01-25
|\ \ | | | | | | [CI:DOCS] Github-workflow: Fix YAML syntax
| * | Github-workflow: Fix YAML syntaxChris Evich2022-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The `body` string value must be quoted because it contains a colon. Also fix an incorrect URL substitution reference in error-notice e-mail body text. (In my defense...testing this workflow is basically impractical without merging it) Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #12999 from jwhonce/issues/12987OpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | Update godoc, swagger using wrong struct
| * | | Update godoc, swagger using wrong structJhon Honce2022-01-25
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Documentation for API volume list, pointed to a different struct than the code. [NO NEW TESTS NEEDED] Fixes #12987 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #12966 from lsm5/makefile-separate-build-installOpenShift Merge Robot2022-01-25
|\ \ \ | |/ / |/| | Makefile: install targets independent of build
| * | Makefile: install targets independent of buildLokesh Mandvekar2022-01-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Building from source would involve separate `make` and `make install` steps. This removes a lot of unnecessary `-nobuild` targets which were otherwise needed for packaging. This commit also removes spec files for unused copr jobs. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #12857 from giuseppe/fix-rm-dir-not-emptyOpenShift Merge Robot2022-01-25
|\ \ \ | |/ / |/| | exec: retry rm -rf on ENOTEMPTY and EBUSY
| * | exec: retry rm -rf on ENOTEMPTY and EBUSYGiuseppe Scrivano2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | when running on NFS, a RemoveAll could cause EBUSY because of some unlinked files that are still kept open and "silly renamed" to .nfs$ID. This is only half of the fix, as conmon needs to be fixed too. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2040379 Related: https://github.com/containers/conmon/pull/319 [NO NEW TESTS NEEDED] as it requires NFS as the underlying storage. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | libpod: fix leaking fdGiuseppe Scrivano2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | the config.json file for the OCI runtime is never closed, this is a problem when running on NFS, since it leaves around stale files that cannot be unlinked. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | libpod: fix connection leakGiuseppe Scrivano2022-01-24
| |/ | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #13000 from eriksjolund/fix_typos_and_improve_language_2OpenShift Merge Robot2022-01-25
|\ \ | | | | | | [CI:DOCS] Fix typos and improve language (add 3 missing)
| * | [CI:DOCS] Fix typos and improve languageErik Sjölund2022-01-24
| | | | | | | | | | | | | | | | | | | | | * Add more documentation fixes similar to 8099a61b648a1cfc862461487f1db9ecd47d065e Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | Merge pull request #12997 from cevich/notify_on_errorOpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | [CI:DOCS] Github workflow: Send e-mail on job error
| * | | Github workflow: Send e-mail on job errorChris Evich2022-01-24
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This job is designed to be silent when Cirrus-cron executions pass. Unless specifically instructed, the workflow itself will also remain silent if there's an error. Fix this by catching workflow errors and sending a notification e-mail containing a link to the failed run. This also requires listing the recipient addresses directly in the workflow. Otherwise (as previouslly implemented) the value would not be retrieved if/when any previous step raised an error. **Note**: Due to the way this workflow is implemented, there is no way easy way to test it other than directly on the `main` repo. branch. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #12993 from edsantiago/test_rootless_remoteOpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | CI: enable rootless-remote system tests
| * | | CI: enable rootless-remote system testsEd Santiago2022-01-24
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Minimal: only test Fedora.Latest. Reason: podman 4.0.0-0.2.rc2 broke bodhi gating tests: https://github.com/containers/podman/issues/12989 Requires skipping two recently-added tests that use 'podman unshare', which doesn't work on remote. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #12974 from kolyshkin/typoOpenShift Merge Robot2022-01-25
|\ \ \ | | | | | | | | pkg/specgen/generate/security: fix error message text
| * | | pkg/specgen/generate/security: fix error messageKir Kolyshkin2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should be Network Namespace, not Host Namespace. [NO NEW TESTS NEEDED] Fixes: 0d70df11 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
* | | | Merge pull request #12969 from rhatdan/remoteOpenShift Merge Robot2022-01-25
|\ \ \ \ | |_|/ / |/| | | Fix handling of duplicate matches on id expansion
| * | | Fix handling of duplicate matches on id expansionDaniel J Walsh2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/12963 [NO NEW TESTS NEEDED] I don't know how to create two containers with the same first digit of the digest, which I could them attempt to remove. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #12996 from Luap99/buildah-rootlessOpenShift Merge Robot2022-01-24
|\ \ \ \ | |_|/ / |/| | | remote build: set rootless oci isolation correctly
| * | | remote build: set rootless oci isolation correctlyPaul Holzinger2022-01-24
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we run rootless buildah needs to have IsolationOCIRootless set otherwise it will run code which cannot be used as rootless user. Podman should use the buildah default if possible and change it to rootless mode if needed. [NO NEW TESTS NEEDED] Should be covered by existing tests once we have podman-remote rootless tests. Fixes #12989 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #12995 from eriksjolund/fix_typos_and_improve_languageOpenShift Merge Robot2022-01-24
|\ \ \ | | | | | | | | [CI:DOCS] Fix typos and improve language
| * | | [CI:DOCS] Fix typos and improve languageErik Sjölund2022-01-24
| |/ / | | | | | | | | | Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | Merge pull request #12982 from rhatdan/defaultOpenShift Merge Robot2022-01-24
|\ \ \ | | | | | | | | Show correct default values or show none
| * | | Show correct default values or show noneDaniel J Walsh2022-01-24
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | Before this PR, the podman --help command shows the defaults as runc and overlay even if the storage.conf and containers.conf files do not match. This PR changes them to show the actual defaults and in the case of storage driver, does not show the default at all. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #12991 from Luap99/aliasesOpenShift Merge Robot2022-01-24
|\ \ \ | |_|/ |/| | container create: do not check for network dns support
| * | container create: do not check for network dns supportPaul Holzinger2022-01-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should not check if the network supports dns when we create a container with network aliases. This could be the case for containers created by docker-compose for example if the dnsname plugin is not installed or the user uses a macvlan config where we do not support dns. Fixes #12972 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #12973 from jmguzik/api-unused-paramOpenShift Merge Robot2022-01-24
|\ \ \ | |_|/ |/| | Remove unused param from utils.Error in pkg/api and clean API handlers
| * | Remove unused param and clean API handlersJakub Guzik2022-01-22
| | | | | | | | | | | | | | | | | | | | | | | | This commit removes error message string from utils.Error in pkg/api. Param was not used inside a function for quite a long time [NO NEW TESTS NEEDED] Signed-off-by: Jakub Guzik <jguzik@redhat.com>
* | | Merge pull request #12976 from patrycja-guzik/docs-labelsOpenShift Merge Robot2022-01-24
|\ \ \ | |_|/ |/| | [CI:DOCS] Fix filter description and unify filters docs for containers/images prune
| * | Fix filter description and unify filters docs for containers/images prunePatrycja Guzik2022-01-22
| |/ | | | | | | Signed-off-by: Patrycja Guzik <patrycja.k.guzik@gmail.com>
* | Merge pull request #12979 from eriksjolund/fix_typo_subpordinateOpenShift Merge Robot2022-01-23
|\ \ | |/ |/| [CI:DOCS] fix typo subpordinate
| * [CI:DOCS] fix typo subpordinateErik Sjölund2022-01-22
|/ | | | Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-26 18:47:05 +0000