summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Fix podman pod inspect show wrong MAC stringzhangguanzhang2020-11-18
| | | | Signed-off-by: zhangguanzhang <zhangguanzhang@qq.com>
* Merge pull request #8382 from dbaker-rh/helppageOpenShift Merge Robot2020-11-18
|\ | | | | [CI:DOCS] Fix example for manifest push
| * Fix example for manifest pushDave Baker2020-11-17
| | | | | | | | Signed-off-by: Dave Baker <dbaker@redhat.com>
* | Merge pull request #8378 from jwhonce/issues/8366OpenShift Merge Robot2020-11-18
|\ \ | | | | | | Swap out json-iterator for golang default
| * | Swap out json-iterator for golang defaultJhon Honce2020-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | json-iterator library failed to pretty print json for all inspection types. Fixes #8366 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #8355 from baude/compatnetworkconnectdisconnectOpenShift Merge Robot2020-11-17
|\ \ \ | | | | | | | | add network connect|disconnect compat endpoints
| * | | add network connect|disconnect compat endpointsbaude2020-11-17
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this enables the ability to connect and disconnect a container from a given network. it is only for the compatibility layer. some code had to be refactored to avoid circular imports. additionally, tests are being deferred temporarily due to some incompatibility/bug in either docker-py or our stack. Signed-off-by: baude <bbaude@redhat.com>
* | | Merge pull request #8381 from Luap99/rename-test-filesOpenShift Merge Robot2020-11-17
|\ \ \ | | | | | | | | Rename e2e test files to include _test.go suffix
| * | | Rename e2e test files to include _test.go suffixPaul Holzinger2020-11-17
| | |/ | |/| | | | | | | | | | | | | | | | The test were working fine. Just my IDE doesn't like the files without the suffix and I don't like red errors. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #8363 from AlbanBedel/play-kube-create-onlyOpenShift Merge Robot2020-11-17
|\ \ \ | | | | | | | | Add an option to control if play kube should start the pod
| * | | Add an option to control if play kube should start the podAlban Bedel2020-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Having play kube start the pod is not always appropriate, one might for example like to have the pod running as a set of systemd services. Add a `start` option to the command line and API to control if the pod should be started or not; it defaults to true for backward compatibility. Signed-off-by: Alban Bedel <albeu@free.fr>
* | | | Merge pull request #8380 from AlbanBedel/fix-client-play-kube-tls-verifyOpenShift Merge Robot2020-11-17
|\ \ \ \ | |_|/ / |/| | | Client call to /play/kube incorrectly set tlsVerify
| * | | Client call to /play/kube incorrectly set tlsVerifyAlban Bedel2020-11-17
| | |/ | |/| | | | | | | | | | | | | | | | The API parameter `tlsVerify` should be the invert of the internal option `SkipTLSVerify`, fix this conversion. Signed-off-by: Alban Bedel <albeu@free.fr>
* | | Merge pull request #8377 from jwhonce/wip/formatsOpenShift Merge Robot2020-11-17
|\ \ \ | | | | | | | | Fix missing headers in `network ls`
| * | | Fix missing headers in `network ls`Jhon Honce2020-11-17
| | |/ | |/| | | | | | | Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #8371 from vrothberg/rm-gateOpenShift Merge Robot2020-11-17
|\ \ \ | | | | | | | | remove contrib/gate
| * | | remove contrib/gateValentin Rothberg2020-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove references on contrib/gate. The gating image is currently not maintained and was replaced in the CI rewrite. We can disable builds in Quay once the change is merged. Note that running `make validate` in a container is still desired. A similar approach may be re-added in the future. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #8356 from rhatdan/docsOpenShift Merge Robot2020-11-17
|\ \ \ \ | |_|_|/ |/| | | [CI:DOCS] Cleanup tutorials
| * | | Cleanup tutorialsDaniel J Walsh2020-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Inspired by @kannkyo PR. Eliminate sudo when commands will work fine in rootless mode. Make all commands in tutorials easily cut and pastable, by eliminating $ and > symbols. This should make them all consistant agross different tutorials. Also make all systemctl enable calls use the --now option. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8373 from TomSweeneyRedHat/dev/tsweeney/nitpickOpenShift Merge Robot2020-11-17
|\ \ \ \ | |_|_|/ |/| | | [CI:DOCS] fix an apostrophe nit in man page
| * | | [CI:DOCS] fix an apostrophe nit in man pageTomSweeneyRedHat2020-11-17
| | |/ | |/| | | | | | | | | | | | | | | | A quick follow up to #8367 to add a missing apostrophe in three man pages. Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | Merge pull request #8370 from rhatdan/wrapOpenShift Merge Robot2020-11-17
|\ \ \ | |/ / |/| | Remove some more excessive wrapping and stuttering
| * | Remove some more excessive wrapping and stutteringDaniel J Walsh2020-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Stop over wrapping API Calls The API calls will return an appropriate error, and this wrapping just makes the error message look like it is stuttering and a big mess. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #8290 from vrothberg/fix-8265OpenShift Merge Robot2020-11-17
|\ \ \ | |/ / |/| | use container cgroups path
| * | use container cgroups pathValentin Rothberg2020-11-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | When looking up a container's cgroup path, parse /proc/[PID]/cgroup. This will work across all cgroup managers and configurations and is supported on cgroups v1 and v2. Fixes: #8265 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #8347 from rhatdan/hostnameOpenShift Merge Robot2020-11-17
|\ \ \ | |_|/ |/| | Make sure /etc/hosts populated correctly with networks
| * | Make sure /etc/hosts populated correctly with networksDaniel J Walsh2020-11-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The --hostname and containername should always be added to containers. Added some tests to make sure you can always ping the hostname and container name from within the container. Fixes: https://github.com/containers/podman/issues/8095 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #8346 from Luap99/shell-completionOpenShift Merge Robot2020-11-17
|\ \ \ | | | | | | | | Improve the shell completion api
| * | | Improve the shell completion apiPaul Holzinger2020-11-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One main advantage of the new shell completion logic is that we can easly parse flags and adjust based on the given flags the suggestions. For example some commands accept the `--latest` flag only if no arguments are given. This commit implements this logic in a simple maintainable way since it reuses the already existing `Args` function in the cmd struct. I also refactored the `getXXX` function to match based on the namei/id which could speed up the shell completion with many containers, images, etc... I also added the degraded status to the valid pod status filters which was implemented in #8081. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | | Merge pull request #8359 from TomSweeneyRedHat/dev/tsweeney/buildahv1.18.0OpenShift Merge Robot2020-11-17
|\ \ \ \ | | | | | | | | | | Bump Buildah to v1.18.0, c/storage to v1.24.0
| * | | | Bump Buildah to v1.18.0, c/storage to v1.24.0TomSweeneyRedHat2020-11-16
| | |/ / | |/| | | | | | | | | | | | | | | | | | Update to Buildah v1.18.0 and c/storage to v1.24 Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | | | Merge pull request #8367 from Luap99/docs-network-podOpenShift Merge Robot2020-11-17
|\ \ \ \ | |_|_|/ |/| | | [CI:DOCS] Explain the relation between --pod and --network
| * | | Explain the relation between --pod and --networkPaul Holzinger2020-11-17
|/ / / | | | | | | | | | Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #8360 from edsantiago/logformatterOpenShift Merge Robot2020-11-17
|\ \ \ | |/ / |/| | logformatter: highlight timing results
| * | logformatter: highlight timing resultsEd Santiago2020-11-16
|/ / | | | | | | | | | | | | | | Add a :hover style to rows in the 'integration timing results' section. Without that, it's really hard for my eye to scan across and match a time to a test name. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #8335 from Luap99/fix-html-tablesOpenShift Merge Robot2020-11-16
|\ \ | | | | | | [CI:DOCS] Fix markdown tables on docs.podman.io
| * | Fix markdown tables on docs.podman.ioPaul Holzinger2020-11-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Sphinx with recommonmark cannot render markdown tables at all. There is a python package called `sphinx-markdown-tables` which adds the markdown table support to recommonmark. https://pypi.org/project/sphinx-markdown-tables/ By utilising this package we don't have to change our doc format. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* | | Merge pull request #8339 from rhatdan/dfOpenShift Merge Robot2020-11-16
|\ \ \ | | | | | | | | Wrap missing container errors with container ID
| * | | Wrap missing container errors with container IDDaniel J Walsh2020-11-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | While playing around with podman system df, I saw that my container database was in bad state. Basically podman new about containers that were no longer in container/storage. The podman system df was just erroring out early stating "container does not exist" with no indicator of which container. This Patch wraps the podman system df errors to indicate which container does not exist. It also logs errors on containers that get into this state, but continues on to work on all containers. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8324 from baude/speedupe2eremoteOpenShift Merge Robot2020-11-16
|\ \ \ \ | | | | | | | | | | use lookaside storage for remote tests
| * | | | use lookaside storage for remote testsbaude2020-11-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in an effort to speed up the remote testing, we should be using lookaside storage to avoid pull images as well as importing multiple images into the RW store. one test was removed and added into system test by Ed in #8325 Signed-off-by: baude <bbaude@redhat.com>
* | | | | Merge pull request #8351 from ↵OpenShift Merge Robot2020-11-16
|\ \ \ \ \ | |/ / / / |/| | | | | | | | | | | | | | containers/dependabot/go_modules/k8s.io/apimachinery-0.19.4 Bump k8s.io/apimachinery from 0.19.3 to 0.19.4
| * | | | Bump k8s.io/apimachinery from 0.19.3 to 0.19.4dependabot-preview[bot]2020-11-16
|/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.19.3 to 0.19.4. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](https://github.com/kubernetes/apimachinery/compare/v0.19.3...v0.19.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8345 from afbjorklund/volume-filterOpenShift Merge Robot2020-11-15
|\ \ \ \ | |/ / / |/| | | Add support for volume ls --filter label=key=value
| * | | Add support for volume ls --filter label=key=valueAnders F Björklund2020-11-14
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Supposed to be able to search for labels with a given value. Previously it meant searching for label key and label value: --filter label=key --filter label=value Add some documentation and integration tests for it as well. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
* | | Merge pull request #8325 from edsantiago/batsOpenShift Merge Robot2020-11-15
|\ \ \ | | | | | | | | system tests: various
| * | | system tests: variousEd Santiago2020-11-14
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - images: confirm that 'podman images' emits headings even if there are no images present. Intended to replace e2e test which is difficult to get working under podman-remote. - build: add test for #8092, podman-build gobbling stdin. Workaround needed for issues #8342 and #8343, in which podman-remote output differs from podman local. - volumes: add test for #8307, double-lock on same volume. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #8333 from rhatdan/buildahOpenShift Merge Robot2020-11-14
|\ \ \ | | | | | | | | Podman-remote build is getting ID twice
| * | | Podman-remote build is getting ID twiceDaniel J Walsh2020-11-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR eliminates the second sending of the image id to the podman-remote client. Fixes: https://github.com/containers/podman/issues/8332 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #8336 from TomSweeneyRedHat/dev/tsweeney/podmanmanOpenShift Merge Robot2020-11-14
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Touch up Podman description in man page menu
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-06 15:40:23 +0000