summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Binary growth check, part 2 of 2Ed Santiago2022-03-22
| | | | | | | | | | | | | | | | Add a CI check to prevent unwanted bloat in binary images, by building a baseline (pre-PR) binary then comparing file sizes post-PR. Part 1 (#13518) added a new script that runs multiple 'make's, comparing image sizes against an original, and failing loudly if growth is too big. An override mechanism is defined. This is part 2 of 2: adding the CI rule. We couldn't do that in part 1, because the rule would call a script that didn't exist in the pre-PR commit. Signed-off-by: Ed Santiago <santiago@redhat.com>
* Merge pull request #13593 from Luap99/compose-flakev2OpenShift Merge Robot2022-03-22
|\ | | | | fix compose test error in retry logic
| * fix compose test error in retry logicPaul Holzinger2022-03-22
| | | | | | | | | | | | | | | | | | We cannot use local var outside of a function. We have to use a global one. Log: https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/5970023511490560/html/compose_v2-podman-fedora-35-root-host.log.html Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #13595 from edsantiago/logformatter_netavarkOpenShift Merge Robot2022-03-22
|\ \ | | | | | | Fix unreadable netavark logs
| * | Fix unreadable netavark logsEd Santiago2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ginkgo netavark logs (and, to a lesser extent, cni logs) are unreadable because the hide-boring-opts code did not know about --network-backend. Now it does. Manually filtered an existing netavark log to confirm there are no other new options we should know about. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #13518 from edsantiago/size_check_part1OpenShift Merge Robot2022-03-22
|\ \ \ | | | | | | | | Binary growth check, part 1 of 2
| * | | Binary growth check, part 1 of 2Ed Santiago2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a CI check to prevent unwanted bloat in binary images, by building a baseline (pre-PR) binary then comparing file sizes post-PR. We piggyback onto the existing 'Build Each Commit' CI check because it gives us an easy way to run 'make' against the parent commit. This is part 1 of 2: adding the script, not the Makefile rule. We can't add the Makefile rule now because the script it would invoke does not exist in the parent commit. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #13398 from giuseppe/fix-warning-pod-create-rmOpenShift Merge Robot2022-03-22
|\ \ \ \ | |_|/ / |/| | | libpod: drop warning if cgroup doesn't exist
| * | | libpod: drop warning if cgroup doesn't existGiuseppe Scrivano2022-03-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | do not print a warning on cgroup removal if it doesn't exist. Closes: https://github.com/containers/podman/issues/13382 [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #13580 from vrothberg/enable-lintersOpenShift Merge Robot2022-03-22
|\ \ \ \ | | | | | | | | | | enable linters
| * | | | fix a number of errcheck issuesValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Numerous issues remain, especially in tests/e2e. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | fix a number of `godot` issuesValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Still an unknown number remains but I am running out of patience. Adding dots is not the best use of my time. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: enable makezeroValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: enable nilerrValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A number of cases looked suspicious, so I marked them with `FIXME`s to leave some breadcrumbs. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: document nolintlintValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We need to keep disabling the `nolintlint` linter to continue using `nolint` directives in the code. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: document tagliatelleValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Disabling tagliatelle would mean disabling it for hundreds of fields that cannot be changed due to K8s or Docker or backwards compat. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | test/e2e/inspect_test.go: wait for sessionsValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure we're waiting for the ls container to finish to prevent potential flakes or future regressions. Spotted while enabling a linter. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: enable ineffassignValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: enable errchkjsonValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: enable wastedassignValentin Rothberg2022-03-22
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | linter: enable interfacerValentin Rothberg2022-03-22
| | |/ / | |/| | | | | | | | | | Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | Merge pull request #13590 from giuseppe/add-note-for-additional-stores-deletionsOpenShift Merge Robot2022-03-22
|\ \ \ \ | |_|_|/ |/| | | [CI:DOCS] troubleshooting: document rm in image stores
| * | | [CI:DOCS] troubleshooting: document rm in image storesGiuseppe Scrivano2022-03-22
| |/ / | | | | | | | | | | | | | | | | | | | | | Closes: https://github.com/containers/podman/issues/13003 [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #13585 from flouthoc/fix-no-healthcheckOpenShift Merge Robot2022-03-22
|\ \ \ | |/ / |/| | healthcheck: stop showing wrong status when `--no-healthcheck` is set
| * | healthcheck: stop showing wrong status when --no-healthcheck is setAditya R2022-03-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Containers started with `--no-healthcheck` are configured to contain no healthcheck and test configured as `NONE`. Podman shows wrong status as such use cases. Following commit fixes the faulty behavior of stauts field for containers started with `--no-healthcheck` Signed-off-by: Aditya R <arajan@redhat.com>
* | | Merge pull request #13584 from lsm5/fix-podman-remote-staticOpenShift Merge Robot2022-03-22
|\ \ \ | | | | | | | | Makefile: build podman-remote-static with cgo disabled
| * | | Makefile: build podman-remote-static with cgo disabledLokesh Mandvekar2022-03-21
| |/ / | | | | | | | | | | | | | | | | | | | | | Resolves: #13557 [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #13577 from giuseppe/drop-fedora-31-warningOpenShift Merge Robot2022-03-22
|\ \ \ | | | | | | | | libpod: drop warning for Fedora 31
| * | | libpod: drop warning for Fedora 31Giuseppe Scrivano2022-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | drop a warning for runc not supporting cgroup v2 on Fedora 31. [NO NEW TESTS NEEDED] Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #13536 from dcermak/storage-autodetect-mount_programOpenShift Merge Robot2022-03-22
|\ \ \ \ | |_|/ / |/| | | Storage autodetect mount program
| * | | vendor containers/storage with https://github.com/containers/storage/pull/1165Dan Čermák2022-03-21
| |/ / | | | | | | | | | Signed-off-by: Dan Čermák <dcermak@suse.com>
* | | Merge pull request #13575 from Luap99/percentOpenShift Merge Robot2022-03-21
|\ \ \ | | | | | | | | podman system df: fix percent calculation
| * | | podman system df: fix percent calculationPaul Holzinger2022-03-21
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The calculate the percentage we need floating point numbers. The current code however casted the result of reclaimable/size to an int first. Casting to an int in go will just discard the decimal points, thus the result was either 0 or 1 so if multiplied by 100 it would show up as 0% or 100%. To fix this we have to multiply by 100 first before casting the result to an int. Also add a check for div by zero which results in NaN and use math.Round() to correctly round a number. Ref #13516 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #13574 from edsantiago/batsOpenShift Merge Robot2022-03-21
|\ \ \ | | | | | | | | pod system tests: clean up stray image
| * | | pod system tests: clean up stray imageEd Santiago2022-03-21
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | One of the pod tests was leaving a stray image behind, causing scary red warnings in CI logs. Clean that up. Also, now that #13541 has merged, use 'rmi --ignore' instead of ignoring exit status from rmi Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #13573 from vrothberg/golangci-lintOpenShift Merge Robot2022-03-21
|\ \ \ | |/ / |/| | bump golangci-lint to v1.45.0
| * | bump golangci-lint to v1.45.0Valentin Rothberg2022-03-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * supports Go 1.18 * disable a number of new linters * fix minor stylecheck issues [NO NEW TESTS NEEDED] Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | Merge pull request #13541 from vrothberg/rmi-ignoreOpenShift Merge Robot2022-03-21
|\ \ \ | |/ / |/| | podman rmi --ignore
| * | podman rmi --ignoreValentin Rothberg2022-03-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add an `--ignore` flag to `podman image rm` to instruct ignoring image if a specified image does not exist and to not throw an error. Other commands (e.g., `podman container rm`) already support this flag. Such an `--ignore` flag can come in handy in clean-up scripcts such as the teardown phases in the Podman tests. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | Merge pull request #13572 from Kuldz/mainOpenShift Merge Robot2022-03-21
|\ \ \ | | | | | | | | [CI:DOCS] Fix inconsistency in documentation
| * | | Fix documentation typoKuldar Kaasik2022-03-21
|/ / / | | | | | | | | | Signed-off-by: Kuldar Kaasik <kaasikkuldar@gmail.com>
* | | Merge pull request #13562 from n1hility/misc-cleanupOpenShift Merge Robot2022-03-19
|\ \ \ | | | | | | | | Fix type-o and cleanup doc punctuation
| * | | Fix type-o and cleanup doc punctuationJason T. Greene2022-03-18
| |/ / | | | | | | | | | Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
* | | Merge pull request #13558 from Luap99/compose-flakeOpenShift Merge Robot2022-03-19
|\ \ \ | |/ / |/| | fix compose test flake
| * | fix compose test flakePaul Holzinger2022-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Reading from the nc socket is flaky because docker-compose only starts the containers. We cannot know at this point if the container did already send the message. Give the container 5 seconds time to send the message to prevent flakes. This happened rarely with compose v1 but it looks like it will happen a lot more with compose v2. Example failure log: https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/6567556239589376/html/compose_v2-podman-fedora-35-rootless-host.log.html Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #13554 from vrothberg/vendor-commonOpenShift Merge Robot2022-03-18
|\ \ \ | | | | | | | | vendor c/common@0ededd18a1f9
| * | | vendor c/common@0ededd18a1f9Valentin Rothberg2022-03-18
| |/ / | | | | | | | | | | | | | | | | | | Update the login tests to reflect the latest changes to allow http{s} prefixes (again) to address bugzilla.redhat.com/show_bug.cgi?id=2062072. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | Merge pull request #13556 from Luap99/dualstack-flakeOpenShift Merge Robot2022-03-18
|\ \ \ | |/ / |/| | fix dual stack network e2e flake
| * | fix dual stack network e2e flakePaul Holzinger2022-03-18
|/ / | | | | | | | | | | | | | | | | | | | | | | | | We need to use different ipv6 subnets for the tests since they can collide otherwise when the tests are run in parallel. In the future we should rethink hardcoding subnets for ipv4/ipv6. This will make it impossible to run these tests if the subnet is already used on the host. Example log: https://storage.googleapis.com/cirrus-ci-6707778565701632-fcae48/artifacts/containers/podman/5711403297275904/html/int-podman-fedora-35-root-host-netavark.log.html#t--podman-network-create-with-multiple-subnets-dual-stack-with-gateway-and-range--1 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #13540 from mheon/fix_11822OpenShift Merge Robot2022-03-18
|\ \ | | | | | | Deduplicate between Volumes and Mounts in compat API
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-11-08 13:00:56 +0000