summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* QEMU Apple Silicon: Find BIOS FD whereverJonathan Springer2021-09-07
| | | | | | | | | | | | QEmu normally install BIOS images under `/usr/local` prefix, but Homebrew installs them under `/opt/homebrew`. This change searches both locations and then puts back to an unpathed name if it doesn't find the BIOS. (I imitated other architectures' implemenations in that failback behavior.) [NO TESTS NEEDED] Signed-off-by: Jonathan Springer <jonpspri@gmail.com>
* Merge pull request #11464 from vrothberg/fix-11461OpenShift Merge Robot2021-09-07
|\ | | | | logs -f: file: fix dead lock
| * logs -f: file: fix dead lockValentin Rothberg2021-09-07
| | | | | | | | | | | | | | | | Fix a dead lock in the file log driver where one goroutine would wait on the tail to hit EOF but reading is blocked for the function to return. Fixes: 11461 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #11402 from Luap99/macvlan-docOpenShift Merge Robot2021-09-07
|\ \ | | | | | | network create: add warning for deprecated macvlan flag
| * | network create: add warning for deprecated macvlan flagPaul Holzinger2021-09-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The macvlan driver is not deprecated, only the --macvlan flag is. Remove the flag from the man page since it is deprecated and add a warning to podman network create if it is used. [NO TESTS NEEDED] Fixes #11400 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #11442 from scottschreckengaust/mainOpenShift Merge Robot2021-09-07
|\ \ \ | |_|/ |/| | Adding `-cpu host` for qemu for MacOS
| * | Fix warning of unsupported feature on MacOSScott Schreckengaust2021-09-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adding the `-cpu host` option to the `addArchOptions` function for darwin removes the warning message, "host doesn't support requested feature: CPUID.80000001H:ECX.svm [bit 2]" by qemu-system-x86_64 when using the `podman machine start` command on MacOS Closes #11421 [NO TESTS NEEDED] Signed-off-by: Scott Schreckengaust <scottschreckengaust@users.noreply.github.com>
* | | Merge pull request #11463 from flouthoc/cgroup-info-fix-panicOpenShift Merge Robot2021-09-07
|\ \ \ | | | | | | | | cgroup-info: check if user.slice is valid before accessing value
| * | | cgroup-info: check if user.slice is valid before accessing valueAditya Rajan2021-09-07
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | Prevent hitting `panic: runtime error: index out of range [1] with length 1` while performing `podman info` when unexpected values for user.slice is found. [NO TESTS NEEDED] Signed-off-by: Aditya Rajan <arajan@redhat.com>
* | | Merge pull request #11451 from jonpspri/qemu-apple-silicon-hvf-tcgOpenShift Merge Robot2021-09-06
|\ \ \ | | | | | | | | Qemu TCG Accel fallback for Apple Silicon. Iss #10577
| * | | TCG Accel fallback for Apple Silicon. Iss #10577Jonathan Springer2021-09-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Cause qemu to fall back to using TCG acceleration when HVP acceleration is not available on Darwin Aarch64. Qemu prints a warning which it is desirable to leave to embarrass the upstream Qemu into approving the HVF patches. [NO TESTS NEEDED] Signed-off-by: Jonathan Springer <jspringer@us.ibm.com> Signed-off-by: Jonathan Springer <jonpspri@gmail.com>
* | | | Merge pull request #11432 from Utopiah/patch-1OpenShift Merge Robot2021-09-05
|\ \ \ \ | | | | | | | | | | [CI:DOCS] Example says there is not IP then in the next command suggests to use it
| * | | | Example says there is not IP then in the next command suggests to use itFabien Benetou2021-09-05
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Utopiah <fabien-services@benetou.fr>
* | | | | Merge pull request #11445 from 1995parham/mainOpenShift Merge Robot2021-09-05
|\ \ \ \ \ | |_|/ / / |/| | | | Add localhost into hosts based on network mode
| * | | | feat: add localhost into hosts if the networking mode is not hostParham Alvani2021-09-04
| | |/ / | |/| | | | | | | | | | Signed-off-by: Parham Alvani <1995parham@tuta.io>
* | | | Merge pull request #11441 from jesperpedersen/readmeOpenShift Merge Robot2021-09-05
|\ \ \ \ | | | | | | | | | | Bump release to 3.3.1
| * | | | Bump release to 3.3.1jesperpedersen2021-09-04
| |/ / / | | | | | | | | | | | | | | | | | | | | Signed-off-by: jesperpedersen <jesper.pedersen@redhat.com> [NO TESTS NEEDED]
* | | | Merge pull request #11439 from coypoop/libvirt-unusedOpenShift Merge Robot2021-09-04
|\ \ \ \ | |/ / / |/| | | Remove unused stubs intended to start a machine with libvirt
| * | | Remove unused stubs intended to start a machine with libvirtMaya Rashish2021-09-03
| | | | | | | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: Maya Rashish <maya@NetBSD.org>
* | | | Merge pull request #11428 from guillaumerose/missingcheckOpenShift Merge Robot2021-09-03
|\ \ \ \ | | | | | | | | | | machine: always check error of net.Dial, even after last try
| * | | | machine: always check error of net.Dial, even after last tryGuillaume Rose2021-09-03
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When net.Dial always fail in the above loop, the code following the loop is executed. This error check prevents this. [NO TESTS NEEDED] Signed-off-by: Guillaume Rose <gurose@redhat.com>
* | | | Merge pull request #11414 from edsantiago/batsOpenShift Merge Robot2021-09-03
|\ \ \ \ | |/ / / |/| | | auto-update systemd test: skip on RHEL
| * | | auto-update systemd test: skip on RHELEd Santiago2021-09-02
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "auto-update using systemd" test is failing on RHEL rootless. Reason: it uses journalctl, which does not work on RHEL rootless. Solution: add skip_if_journald_unavailable. ALSO: add debugging info to test failure. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #11410 from jesperpedersen/issue11408OpenShift Merge Robot2021-09-02
|\ \ \ | |/ / |/| | [#11408] podman help machine init
| * | [#11408] podman help machine initjesperpedersen2021-09-02
| | | | | | | | | | | | | | | | | | Signed-off-by: jesperpedersen <jesper.pedersen@redhat.com> [NO TESTS NEEDED]
* | | Merge pull request #11406 from flouthoc/manifest-rm-only-manifestOpenShift Merge Robot2021-09-02
|\ \ \ | | | | | | | | manifest: `rm` should not remove referenced images.
| * | | manifest: rm should not remove referenced images.Aditya Rajan2021-09-02
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | Following PR makes sure that `podman manifest rm <list>` only removes the named manifest list and not referenced images. Bumping and squashing c/common to v0.43.3-0.20210902095222-a7acc160fb25 in same commit in order to make sure build commit test passes. Signed-off-by: Aditya Rajan <arajan@redhat.com>
* | | Merge pull request #11405 from Luap99/systemd-arg-caseOpenShift Merge Robot2021-09-02
|\ \ \ | |_|/ |/| | make podman run --systemd case insensitive
| * | make podman run --systemd case insensitivePaul Holzinger2021-09-02
| |/ | | | | | | | | | | | | | | | | Since boolean flags accept `True` and `False` the systemd flag should do this as well. Fixes #11387 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | Merge pull request #11404 from Luap99/ip-delOpenShift Merge Robot2021-09-02
|\ \ | |/ |/| Drop dependency on iproute
| * Drop dependency on iproutePaul Holzinger2021-09-02
|/ | | | | | | | | | | We only use the `ip` util to remove a network interface. We can do this directly via the netlink lib, no need to call a external binary. [NO TESTS NEEDED] Fixes #11403 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Merge pull request #11395 from edsantiago/batsOpenShift Merge Robot2021-09-02
|\ | | | | System tests: add cleanup & debugging output
| * System tests: add cleanup & debugging outputEd Santiago2021-09-01
| | | | | | | | | | | | | | | | | | | | | | | | Cleanup: the final 'play' test wasn't cleaning up after itself, leading to angry warning messages when rerunning tests (in my environment; never in CI) Debug: I'm seeing a lot of "Could not parse READY=1 as MAINPID=nnn" flakes in the sdnotify:container test (nine in the past month). Add debug traces to help diagnose in future flakes. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | Merge pull request #11368 from giuseppe/fix-man-formatDaniel J Walsh2021-09-01
|\ \ | |/ |/| [CI:DOCS] fix indentation for userns modes
| * docs: fix indentation for userns modesGiuseppe Scrivano2021-08-31
| | | | | | | | | | | | Closes: https://github.com/containers/podman/issues/11364 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #11391 from Luap99/rootlessport-socketOpenShift Merge Robot2021-09-01
|\ \ | | | | | | rootlessport: allow socket paths with more than 108 chars
| * | rootlessport: allow socket paths with more than 108 charsPaul Holzinger2021-09-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Creating the rootlessport socket can fail with `bind: invalid argument` when the socket path is longer than 108 chars. This is the case for users with a long runtime directory. Since the kernel does not allow to use socket paths with more then 108 chars use a workaround to open the socket path. [NO TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #11388 from Luap99/stop-cleanupOpenShift Merge Robot2021-09-01
|\ \ \ | | | | | | | | podman stop always cleanup
| * | | podman stop always cleanupPaul Holzinger2021-09-01
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a container is configured for auto removal podman stop should still do cleanup, there is no guarantee the the cleanup process spawned by conmon will be successful. Also a user expects after podman stop that the network/mounts are cleaned up. Therefore podman stop should not return early and instead do the cleanup and ignore errors if the container was already removed. [NO TESTS NEEDED] I don't know how to test this. Fixes #11384 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #11376 from ashley-cui/envsecOpenShift Merge Robot2021-09-01
|\ \ \ | | | | | | | | Make secret env var available to exec session
| * | | Make secret env var available to exec sessionAshley Cui2021-08-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Secret environment variables were only available to a podman run/start. This commit makes sure that exec sessions can see them as well. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | Merge pull request #11371 from vrothberg/fix-11370OpenShift Merge Robot2021-09-01
|\ \ \ \ | |_|/ / |/| | | [CI:DOCS] generate systemd: clarify limitations of `--new`
| * | | generate systemd: clarify limitations of `--new`Valentin Rothberg2021-09-01
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `generate systemd --new` is looking at the "create command" of the container/pod which is simply the os.Args at creation time. It does not work on containers or pods created via the REST API since the create command is not set. `--new` does work on such containers and pods since there is no reliable way to reverse-map their configs to command-line arguments of podman. Fixes: #11370 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #11375 from vrothberg/fix-11346OpenShift Merge Robot2021-08-31
|\ \ \ | | | | | | | | [CI:DOCS] podman cp: highlight globbing and multi-file copy
| * | | [CI:DOCS] podman cp: highlight globbing and multi-file copyValentin Rothberg2021-08-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | `podman cp` does not allow for globbing or filtering copied data in any form. `docker cp` does not either, so Podman remains compatible. Due to a number of requests, highlight how users can effectively achieve that by means of chaining with tools such as xargs(1) or find(1), or by making use of `podman mount`. Closes: #11346 Closes: #11194 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #11372 from cevich/apiv2_updateOpenShift Merge Robot2021-08-31
|\ \ \ | | | | | | | | Cirrus: Reduce APIv2 task timeout
| * | | Cirrus: Reduce APIv2 task timeoutChris Evich2021-08-31
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the time of this commit, a significant problem has been identified (introduced in f5ce02b227f4). The effect is, `podman pull` has a chance of hanging, especially when re-pulling an existing image. While a fix is in the works, there's no reason to make developers wait the full (default) 1-hour timeout for the APIv2 task. Reduce it to 2x nominal test runtime, so if the hang/flake is hit, the task can be re-run more quickly. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | Merge pull request #11316 from vrothberg/fix-10443OpenShift Merge Robot2021-08-31
|\ \ \ | |/ / |/| | pass LISTEN_* environment into container
| * | pass LISTEN_* environment into containerValentin Rothberg2021-08-31
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make sure that Podman passes the LISTEN_* environment into containers. Similar to runc, LISTEN_PID is set to 1. Also remove conditionally passing the LISTEN_FDS as extra files. The condition was wrong (inverted) and introduced to fix #3572 which related to running under varlink which has been dropped entirely with Podman 3.0. Note that the NOTIFY_SOCKET and LISTEN_* variables are cleared when running `system service`. Fixes: #10443 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com> Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #11373 from mtrmac/mpb-replaceOpenShift Merge Robot2021-08-31
|\ \ | | | | | | Use UNMERGED vbauerster/mpb PR to fix a pull deadlock
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2024-12-26 08:34:56 +0000