summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #10594 from ↵OpenShift Merge Robot2021-06-08
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containers/buildah-1.21.1 Bump github.com/containers/buildah from 1.21.0 to 1.21.1
| * Bump github.com/containers/buildah from 1.21.0 to 1.21.1dependabot[bot]2021-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containers/buildah](https://github.com/containers/buildah) from 1.21.0 to 1.21.1. - [Release notes](https://github.com/containers/buildah/releases) - [Changelog](https://github.com/containers/buildah/blob/v1.21.1/CHANGELOG.md) - [Commits](https://github.com/containers/buildah/compare/v1.21.0...v1.21.1) --- updated-dependencies: - dependency-name: github.com/containers/buildah dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #10600 from vrothberg/fix-10596OpenShift Merge Robot2021-06-08
|\ \ | | | | | | logs: k8s-file: fix race
| * | logs: k8s-file: fix raceValentin Rothberg2021-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix a race in the k8s-file logs driver. When "following" the logs, Podman will print the container's logs until the end. Previously, Podman logged until the state transitioned into something non-running which opened up a race with the container still running, possibly in the "stopping" state. To fix the race, log until we've seen the wait event for the specific container. In that case, conmon will have finished writing all logs to the file, and Podman will read it until EOF. Further tweak the integration tests for testing `logs -f` on a running container. Previously, the test only checked for one of two lines stating that there was a race. Indeed the race was in using `run --rm` where a log file may be removed before we could fully read it. Fixes: #10596 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #10598 from Luap99/systemd-resolvedOpenShift Merge Robot2021-06-08
|\ \ \ | | | | | | | | Improve systemd-resolved detection
| * | | Improve systemd-resolved detectionPaul Holzinger2021-06-08
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When 127.0.0.53 is the only nameserver in /etc/resolv.conf assume systemd-resolved is used. This is better because /etc/resolv.conf does not have to be symlinked to /run/systemd/resolve/stub-resolv.conf in order to use systemd-resolved. [NO TESTS NEEDED] Fixes: #10570 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #10597 from Luap99/pruneOpenShift Merge Robot2021-06-08
|\ \ \ | | | | | | | | Fix network prune api docs
| * | | Fix network prune api docsPaul Holzinger2021-06-08
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The api doc used wrong response examples for both the compat and libpod network prune endpoints. Change the doc so that it matches the actual return values. Also fix the endpoints to return an empty array instead of null when no networks are removed. [NO TESTS NEEDED] Fixes: #10564 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #10548 from cdoern/imgFeatureOpenShift Merge Robot2021-06-08
|\ \ \ | | | | | | | | API images/create added missing parameters platform, message, repo
| * | | made requested changes, fixed api testscdoern2021-06-04
| | | | | | | | | | | | | | | | Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
* | | | Merge pull request #10599 from Luap99/remote-pull-cancelOpenShift Merge Robot2021-06-08
|\ \ \ \ | |_|/ / |/| | | remote pull: cancel pull when connection is closed
| * | | remote pull: cancel pull when connection is closedPaul Holzinger2021-06-08
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a client closes the http connection during image pull, the service should cancel the pull operation. [NO TESTS NEEDED] I have no idea how we could test this reliable. Fixes: #7558 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #10592 from edsantiago/batsOpenShift Merge Robot2021-06-08
|\ \ \ | | | | | | | | auto-update tests: various fixes
| * | | auto-update tests: various fixesEd Santiago2021-06-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Followup to #9740. Nice work, but the _confirm_update() helper was dangerously broken and I just wasn't able to communicate that. Given the time zone difference, and my weekly time cost in reviewing, it's easier for me to fix it myself. (The problem is that the function was a complete NOP, which would lead to flakes). Also: got rid of some clutter, restructured a few minor places for maintainability. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | Merge pull request #10591 from mheon/fix_10569OpenShift Merge Robot2021-06-08
|\ \ \ \ | | | | | | | | | | Fix compat create with NetworkMode=default
| * | | | Fix compat create with NetworkMode=defaultMatthew Heon2021-06-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The rework of namespace handling for rootless CNI broke this, as CNI networks were being computed incorrectly. Fix handling of CNI networks for the Compat Create REST API for containers, and add a test so we don't regress again. Fixes #10569 Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | | | Merge pull request #10565 from baude/macdocsOpenShift Merge Robot2021-06-07
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS]instructions for podman machine on macs
| * | | | | [CI:DOCS]instructions for podman machine on macsBrent Baude2021-06-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | first pass for instructions on using podman machine on Intel and M1 macs. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #10586 from lsm5/bump-mainline-versionOpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | | | | | | | | | | | | | | Version bump: 3.3.0-dev
| * | | | | | Version bump: 3.3.0-devLokesh Mandvekar2021-06-07
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Keep master branch version ahead of that on any other branch. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | | | Merge pull request #10526 from Procyhon/31052021_manpageOpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | [CI:DOCS] UPDATE MANPAGE_SYNTAX (commit,attach,auto-update)
| * | | | | UPDATE MANPAGE_SYNTAX (commit,attach,auto-update)Alexander Richter2021-06-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Updated version for the MANPAGE_SYNTAX and adaption of the syntax for the manpages of podman-commit, podman-attach, and podman-auto-update. Signed-off-by: Alexander Richter <67486332+Procyhon@users.noreply.github.com>
* | | | | | Merge pull request #9740 from ypu/auto-updateOpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | System test: Add tests for podman auto-update
| * | | | | System test: Add podman auto-update related test casesYiqiao Pu2021-06-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add some cases for podman auto-update: 1. Test with different value for label io.containers.autoupdate 2. Run podman auto-update as systemd timer Signed-off-by: Yiqiao Pu <ypu@redhat.com>
* | | | | | Merge pull request #10381 from adrianreber/2021-05-18-publishOpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add --publish to container restore
| * | | | | | Add restore --publish to the man pageAdrian Reber2021-06-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Reber <areber@redhat.com>
| * | | | | | Add test for restore --publishAdrian Reber2021-06-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Reber <areber@redhat.com>
| * | | | | | Allow changing of port forward rules on restoreAdrian Reber2021-06-04
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Restored containers, until now, had the same port mappings as the original started container. This commit adds the parameter '--publish' to 'podman container restore' with the same semantic as during create/run. With this change it is possible to create a copy from a container with a '--publish' rule and replace the original '--publish' setting with a new one. # podman run -p 2345:8080 container # podman container checkpoint -l --export=dump.tar # podman container restore -p 5432:8080 --import=dump.tar The restored container will now listen on localhost:5432 instead of localhost:2345 as the original created container. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | | | Merge pull request #10557 from vrothberg/fix-5572OpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | | | | | | | | | | | | | | systemd/generate: change type to notify
| * | | | | | systemd/generate: change type to notifyValentin Rothberg2021-06-04
| | |_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change the type of units generated with --new from "forking" to "notify". This brings Podman closer to systemd and opens up Podman to a number of use cases (see #5572). Units generated without --new remain with `type=forking`. I experimented a bit with adding a `--sdnotify` flag to `podman start` but it doesn't really work well since we're competing with the default sdnotify mode set during container creation. Fixes: #5572 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #10567 from adrianreber/2021-06-04-compressOpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | | | | | | | | | | | | | | Add support for selectable checkpoint archive compression algorithm
| * | | | | | Added tests for different checkpoint archive compressionsAdrian Reber2021-06-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Reber <areber@redhat.com>
| * | | | | | Add --compress to podman-container-checkpoint.1.mdAdrian Reber2021-06-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Adrian Reber <areber@redhat.com>
| * | | | | | Add parameter to specify checkpoint archive compressionAdrian Reber2021-06-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The checkpoint archive compression was hardcoded to `archive.Gzip`. There have been requests to make the used compression algorithm selectable. There was especially the request to not compress the checkpoint archive to be able to create faster checkpoints when not compressing it. This also changes the default from `gzip` to `zstd`. This change should not break anything as the restore code path automatically handles whatever compression the user provides during restore. Signed-off-by: Adrian Reber <areber@redhat.com>
| * | | | | | Order checkpoint options in man page alphabeticallyAdrian Reber2021-06-07
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This just reorders the options in the podman-container-checkpoint man page alphabetically. No actual content changed. Signed-off-by: Adrian Reber <areber@redhat.com>
* | | | | | Merge pull request #10561 from vrothberg/fix-remote-events-labelOpenShift Merge Robot2021-06-07
|\ \ \ \ \ \ | | | | | | | | | | | | | | remote events: support labels
| * | | | | | remote events: support labelsValentin Rothberg2021-06-04
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Certain event meta data was lost when converting the remote events to libpod events and vice versa. Enable the skipped system tests for remote. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | | Merge pull request #10568 from jwhonce/issues/10562OpenShift Merge Robot2021-06-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Document which CNI fields are encoded
| * | | | | | [CI:DOCS] Document which CNI fields are encodedJhon Honce2021-06-04
| | |_|_|/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The CNI configuration fields named Bytes are typed []byte which the GO JSON encoded automatically Base64 encodes. Note: Future major versions of Podman will refactor the networking endpoints to encapsulate/abstract the CNI structures which will allow better documenation and encoding. Fixes #10562 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | | | | Merge pull request #10574 from rogercoll/fix-bindings-docsOpenShift Merge Robot2021-06-06
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:DOCS] Fix outdated docs
| * | | | | | fix go-bindings examples with v3 new parametersRoger Coll2021-06-05
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Signed-off-by: Roger Coll <rogercoll@protonmail.com>
* | | | | | | Merge pull request #10500 from gigatexal/expand-podman-remote-docs-add-key-helpOpenShift Merge Robot2021-06-06
|\ \ \ \ \ \ \ | |/ / / / / / |/| | | | | | [CI:DOCS] extend docs to include help for when pub/priv key is signing issue
| * | | | | | extend docs to include help for when pub/priv key is signed with an ↵alex narayan2021-06-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | unsupported algo Signed-off-by: alex narayan <alexandar.narayan@deliveryhero.com>
* | | | | | | Merge pull request #10549 from Luap99/fix-9859OpenShift Merge Robot2021-06-05
|\ \ \ \ \ \ \ | |_|/ / / / / |/| | | | | | remote: always send resize before the container starts
| * | | | | | remote: always send resize before the container startsPaul Holzinger2021-06-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There is race condition in the remote client attach logic. Because the resize api call was handled in an extra goroutine the container was started before the resize call happend. To fix this we have to call resize in the same goroutine as attach. When the first resize is done start a goroutine to listen on SIGWINCH in the background and resize again if the signal is received. Fixes #9859 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | | | Merge pull request #10546 from boaz0/closes_8645OpenShift Merge Robot2021-06-04
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | Add CORS support
| * | | | | | | Add CORS supportBoaz Shuster2021-06-04
| | |_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
* | | | | | | Merge pull request #10563 from Luap99/fix-10494OpenShift Merge Robot2021-06-04
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | [CI:DOCS] fix incorrect network remove api doc
| * | | | | | | [CI:DOCS] fix incorrect network remove api docPaul Holzinger2021-06-04
| | |/ / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The endpoint returns an array and not a single entry. Fixes #10494 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | | | Merge pull request #10558 from vrothberg/fix-10529OpenShift Merge Robot2021-06-04
|\ \ \ \ \ \ \ | |_|_|_|/ / / |/| | | | | | remote events: fix --stream=false