summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Merge pull request #15813 from praveenkumar/podman-remote-container-fileOpenShift Merge Robot2022-09-26
|\ | | | | [CI:BUILD] Contrib: Add containerfile to create podman-remote binary image
| * Contrib: Add containerfile to create podman-remote binary imagePraveen Kumar2022-09-26
| | | | | | | | | | | | Try to partial address #14664 Signed-off-by: Praveen Kumar <kumarpraveen.nitdgp@gmail.com>
* | Merge pull request #15936 from edsantiago/docs_dedup_sigproxyOpenShift Merge Robot2022-09-26
|\ \ | | | | | | [CI:DOCS] Man pages: Refactor common options: --sig-proxy
| * | Man pages: Refactor common options: --sig-proxyEd Santiago2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Unusually, I discarded the podman-run version and went with the one common to attach and start. (The defaults are left out of the common file, because 'start' is different by necessity). Please review extra-carefully to make sure the new wording applies to podman-run, in particular the "non-TTY mode" words. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #15935 from edsantiago/xref_manpage_titleOpenShift Merge Robot2022-09-26
|\ \ \ | |/ / |/| | [CI:DOCS] man page xref: verify page title
| * | man page xref: verify page titleEd Santiago2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | Issue #15923 should have never happened: the problem should've been autodetected. Make it so henceforth (and fix another existing discrepancy) Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #15926 from eriksjolund/remove_redundant_log_outputOpenShift Merge Robot2022-09-26
|\ \ \ | | | | | | | | Remove redundant log message
| * | | Remove redundant log messageErik Sjölund2022-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Fixes: https://github.com/containers/podman/issues/15925 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #15893 from cevich/ioutil_whineOpenShift Merge Robot2022-09-26
|\ \ \ \ | |_|/ / |/| | | [CI:BUILD] Cirrus: Catch use of deprecated ioutils package
| * | | Cirrus: Catch use of deprecated io/ioutil packageChris Evich2022-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | At the time of this commit, there's no easier way to detect this using `golangci-lint` or the go tool (that I could find). A future update to the `go list` command may support detection, for now use a CI script. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | Merge pull request #15924 from eriksjolund/fix_podman_system_service_man_pageOpenShift Merge Robot2022-09-26
|\ \ \ \ | | | | | | | | | | [CI:DOCS] man pages: fix incorrect title
| * | | | [CI:DOCS] man pages: fix incorrect titleErik Sjölund2022-09-24
| | |/ / | |/| | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/15923 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #15820 from vrothberg/fix-15800OpenShift Merge Robot2022-09-26
|\ \ \ \ | | | | | | | | | | kube: notifyproxy: fix lost READY message
| * | | | notifyproxy: don't set a read deadlineValentin Rothberg2022-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The read deadline may yield the READY message to be lost in space. Instead, use a more Go-idiomatic alternative by using two goroutines; one reading from the connection, the other watching the container. [NO NEW TESTS NEEDED] since existing tests are exercising this functionality already. Fixes: #15800 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
| * | | | kube play: sdnotify proxy: use a wait groupValentin Rothberg2022-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Use a wait group to a) wait for all proxies in parallel b) avoid the potential for ABBA deadlocks [NO NEW TESTS NEEDED] as it is not changing functionality Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | | | Merge pull request #15911 from yrro/fix-libsubid-detectionOpenShift Merge Robot2022-09-26
|\ \ \ \ \ | |_|/ / / |/| | | | Fix libsubid detection
| * | | | Fix libsubid detectionSam Morris2022-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Library arguments must be positioned after sources when invoking GCC. Signed-off-by: Sam Morris <sam@robots.org.uk>
* | | | | Merge pull request #15900 from rhatdan/VENDOROpenShift Merge Robot2022-09-23
|\ \ \ \ \ | | | | | | | | | | | | Update vendor of containers(image, common, buildah, storage)
| * | | | | Fixup Buildah mergeEd Santiago2022-09-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Changes since 2022-09-09: - man page: add --skip-unused-stages (buildah 4249) - man page: bring in new Note for --cache-ttl (4248) - system tests: de-stutter (4205) - (internal): in skip() applier: escape asterisk, otherwise the "bud with --dns* flags" sed expression never applies. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * | | | | Update vendor or containers/buildahDaniel J Walsh2022-09-23
| | |_|/ / | |/| | | | | | | | | | | | | Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #15873 from ashley-cui/prettysecretsOpenShift Merge Robot2022-09-23
|\ \ \ \ \ | | | | | | | | | | | | Add --pretty to podman secret inspect
| * | | | | Add --pretty to podman secret inspectAshley Cui2022-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pretty-print podman secret inspect output in a human-readable format Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | | | Merge pull request #15463 from mheon/fix_15408OpenShift Merge Robot2022-09-23
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Events for containers in pods now include the pod's ID
| * | | | | Events for containers in pods now include the pod's IDMatthew Heon2022-09-22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows tools like Cockpit to know that the pod in question has also been updated, so they can refresh the list of containers in the pod. Fixes #15408 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | | Merge pull request #15905 from lsm5/fix-coprOpenShift Merge Robot2022-09-23
|\ \ \ \ \ \ | | | | | | | | | | | | | | [CI:BUILD] Copr: also define _user_tmpfilesdir for f35
| * | | | | | [CI:BUILD] Copr: also define _user_tmpfilesdir for f35Lokesh Mandvekar2022-09-22
| |/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some users are still on f35, so we need to account for that for some time. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | | | Merge pull request #15841 from mheon/image_driverOpenShift Merge Robot2022-09-23
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Add support for 'image' volume driver
| * | | | | Add support for 'image' volume driverMatthew Heon2022-09-22
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We added the concept of image volumes in 2.2.0, to support inspecting an image from within a container. However, this is a strictly read-only mount, with no modification allowed. By contrast, the new `image` volume driver creates a c/storage container as its underlying storage, so we have a read/write layer. This, in and of itself, is not especially interesting, but what it will enable in the future is. If we add a new command to allow these image volumes to be committed, we can now distribute volumes - and changes to them - via a standard OCI image registry (which is rather new and quite exciting). Future work in this area: - Add support for `podman volume push` (commit volume changes and push resulting image to OCI registry). - Add support for `podman volume pull` (currently, we require that the image a volume is created from be already pulled; it would be simpler if we had a dedicated command that did the pull and made a volume from it) - Add support for scratch images (make an empty image on demand to use as the base of the volume) - Add UOR support to `podman volume push` and `podman volume pull` to enable both with non-image volume drivers Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #15854 from anjannath/issue_15831OpenShift Merge Robot2022-09-22
|\ \ \ \ \ | |/ / / / |/| | | | pkginstaller: use path_helper to add podman and helpers to path
| * | | | pkginstaller: use path_helper to add podman and helpers to pathAnjan Nath2022-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | path_helper(8) appends the contents of /etc/paths.d/podman-pkg to the PATH env [NO NEW TESTS NEEDED] Signed-off-by: Anjan Nath <kaludios@gmail.com>
* | | | | Merge pull request #15895 from dcermak/don-expose-dev-for-privilegedOpenShift Merge Robot2022-09-22
|\ \ \ \ \ | | | | | | | | | | | | Don't mount /dev/ inside privileged containers running systemd
| * | | | | Don't mount /dev/tty* inside privileged containers running systemdDan Čermák2022-09-22
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | According to https://systemd.io/CONTAINER_INTERFACE/, systemd will try take control over /dev/ttyN if exported, which can cause conflicts with the host's tty in privileged containers. Thus we will not expose these to privileged containers in systemd mode, as this is a bad idea according to systemd's maintainers. Additionally, this commit adds a bats regression test to check that no /dev/ttyN are present in a privileged container in systemd mode This fixes https://github.com/containers/podman/issues/15878 Signed-off-by: Dan Čermák <dcermak@suse.com>
* | | | | Merge pull request #15131 from boaz0/closes_14707OpenShift Merge Robot2022-09-22
|\ \ \ \ \ | |/ / / / |/| | | | Add support to sig-proxy for podman-remote
| * | | | Add support to sig-proxy for podman-remoteBoaz Shuster2022-09-20
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
* | | | | Merge pull request #15870 from idleroamer/podman-saveOpenShift Merge Robot2022-09-22
|\ \ \ \ \ | | | | | | | | | | | | podman-save: Add signature-policy flag
| * | | | | cli: Add signature-policy flag to podman save😎Mostafa Emami2022-09-21
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allow overwrite of the signature-policy file by passing signature-policy flag to podman save command Closes: https://github.com/containers/podman/issues/15869 Signed-off-by: 😎Mostafa Emami <mustafaemami@gmail.com>
* | | | | Merge pull request #15894 from edsantiago/reenable_some_aarch64_testsOpenShift Merge Robot2022-09-22
|\ \ \ \ \ | | | | | | | | | | | | System tests: reenable some skipped aarch64 tests
| * | | | | System tests: reenable some skipped aarch64 testsEd Santiago2022-09-21
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Background: in order to add aarch64 tests, we had to add emergency skips to a lot of failing tests. No attempt was ever made to understand why they were failing. Fast forward to today, I filed #15888 just to see if tests are still failing. Looks like a number of them are fixed. (Yes, magically). Remove those skips. See: #15074, #15277 Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | Merge pull request #15890 from cevich/more_ioutil_fixesOpenShift Merge Robot2022-09-21
|\ \ \ \ \ | | | | | | | | | | | | Fix a few missed io/ioutil -> os updates
| * | | | | Fix a few missed io/ioutil -> os updatesChris Evich2022-09-21
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | Ref: https://github.com/containers/podman/pull/15871 Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #15871 from cevich/replace_ioutilOpenShift Merge Robot2022-09-21
|\ \ \ \ \ | | | | | | | | | | | | Replace deprecated ioutil
| * | | | | Replace deprecated ioutilChris Evich2022-09-20
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Package `io/ioutil` was deprecated in golang 1.16, preventing podman from building under Fedora 37. Fortunately, functionality identical replacements are provided by the packages `io` and `os`. Replace all usage of all `io/ioutil` symbols with appropriate substitutions according to the golang docs. Signed-off-by: Chris Evich <cevich@redhat.com>
* | | | | Merge pull request #15837 from rhatdan/formatOpenShift Merge Robot2022-09-21
|\ \ \ \ \ | | | | | | | | | | | | Improve generate systemd format
| * | | | | Improve generate systemd formatDaniel J Walsh2022-09-21
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/14897 Followup to #13814 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | | Merge pull request #15856 from dfr/freebsd-copyOpenShift Merge Robot2022-09-21
|\ \ \ \ \ | | | | | | | | | | | | Add support for 'podman cp' on FreeBSD
| * | | | | libpod: Implement 'podman cp' for FreeBSDDoug Rabson2022-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | | | libpod: Move jointMountAndExec to container_copy_linux.goDoug Rabson2022-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This also moves the logic for resolving paths in running and stopped containers tp container_copy_linux.go. On FreeBSD, we can execute the function argument to joinMountAndExec directly using host-relative paths since the host mount namespace includes all the container mounts. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | | | libpod: Move part of (*Container).stat to container_stat_linux.goDoug Rabson2022-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The logic that treats running containers differently from stopped containers is not needed on FreeBSD where the container mounts live in a global mount namespace. [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | | | libpod: Move container_copy_linux.go to container_copy_common.goDoug Rabson2022-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>
| * | | | | libpod: Move container_stat_linux.go to container_stat_common.goDoug Rabson2022-09-20
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Doug Rabson <dfr@rabson.org>