summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* apply-podman-deltas: skip modified test case for --add-host which adds anomalyAditya R2022-03-14
| | | | | | | | | | All podman tests in CI expects exit code 125, which might not be true since exit code from runtime is relayed as it is without any modification both in `buildah` and `podman`. Following behviour is seen when PR https://github.com/containers/buildah/pull/3809 added a test here https://github.com/containers/buildah/blob/main/tests/bud.bats#L3183 which relays exit code from runtime as it is, in case of both `podman` and `buildah`. However apart from this test case no other test case was able to trigger this behviour hence marking this test as an anomaly. Since its debatable if we should override this returned error number or not hence adding a note here. Signed-off-by: Aditya R <arajan@redhat.com>
* docs: podman-build add --no-hostsAditya R2022-03-14
| | | | | | | Add newly added `--no-hosts` to build docs and document its conflicting nature with `--add-host` Signed-off-by: Aditya R <arajan@redhat.com>
* vendor: bump buildah, c/image and c/storageAditya R2022-03-14
| | | | | | | | | | Bumps c/buildah to -> `v1.24.3-0.20220310160415-5ec70bf01ea5` c/storage to -> `v1.38.3-0.20220308085612-93ce26691863` c/image to -> `v5.20.1-0.20220310094651-0d8056ee346f` Signed-off-by: Aditya R <arajan@redhat.com>
* Merge pull request #13481 from PascalBourdier/golang-1.17OpenShift Merge Robot2022-03-13
|\ | | | | Bump golang to 1.17
| * Bump golang to 1.17 in `vendor-in-container`Pascal Bourdier2022-03-11
| | | | | | | | | | | | Go 1.17 compiler got faster Signed-off-by: Pascal Bourdier <pascal.bourdier@gmail.com>
* | Merge pull request #13494 from n1hility/fix-ttyOpenShift Merge Robot2022-03-13
|\ \ | | | | | | Fixes TTY & resizing on Mac and Windows
| * | Fixes TTY & resizing on Mac and WindowsJason T. Greene2022-03-12
| | | | | | | | | | | | Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
* | | Merge pull request #13486 from lsm5/copr-auto-build-rhel-8OpenShift Merge Robot2022-03-13
|\ \ \ | |/ / |/| | podman.spec.rpkg: enable rhel8 builds on copr
| * | podman.spec.rpkg: enable rhel8 builds on coprLokesh Mandvekar2022-03-11
| | | | | | | | | | | | | | | | | | | | | | | | fix conditionals and buildtags to enable rhel8 builds [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #13483 from ↵OpenShift Merge Robot2022-03-11
|\ \ \ | |/ / |/| | | | | | | | containers/dependabot/go_modules/github.com/spf13/cobra-1.4.0 Bump github.com/spf13/cobra from 1.3.0 to 1.4.0
| * | Bump github.com/spf13/cobra from 1.3.0 to 1.4.0dependabot[bot]2022-03-11
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](https://github.com/spf13/cobra/compare/v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #13484 from ↵OpenShift Merge Robot2022-03-11
|\ \ | |/ |/| | | | | containers/dependabot/go_modules/github.com/docker/docker-20.10.13incompatible Bump github.com/docker/docker from 20.10.12+incompatible to 20.10.13+incompatible
| * Bump github.com/docker/dockerdependabot[bot]2022-03-11
|/ | | | | | | | | | | | | | | Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.12+incompatible to 20.10.13+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Changelog](https://github.com/moby/moby/blob/master/CHANGELOG.md) - [Commits](https://github.com/docker/docker/compare/v20.10.12...v20.10.13) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* Merge pull request #13445 from rhatdan/annotationOpenShift Merge Robot2022-03-10
|\ | | | | Add podman play kube --annotation
| * Add podman play kube --annotationDaniel J Walsh2022-03-09
| | | | | | | | | | | | | | | | | | | | Allow users to add annotions in the podman play kube command. This PR Also fixes the fact that annotations in the pod spec were not being passed down to containers. Fixes: https://github.com/containers/podman/issues/12968 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #13440 from eriksjolund/remove_web_tab_numberOpenShift Merge Robot2022-03-10
|\ \ | | | | | | [CI:DOCS] Remove "(1)" from web tab text
| * | [CI:DOCS] Remove "(1)" from web tab textErik Sjölund2022-03-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Remove the ending text "(1)" to avoid it from being displayed in the web tab title for a command man page on the web. Often such a text indicates that a web page got an update. For instance GitHub issues shows the number of new comments that have been written after the user's last visit. Fixes #13438 Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | Merge pull request #13475 from PascalBourdier/golangci-lint-install-fixOpenShift Merge Robot2022-03-10
|\ \ \ | | | | | | | | CI: fix golangci-lint installation
| * | | CI: fix golangci-lint installationPascal Bourdier2022-03-10
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | avoid this warn: ``` golangci/golangci-lint info installed ./bin/golangci-lint golangci/golangci-lint err this script is deprecated, please do not use it anymore. check https://github.com/goreleaser/godownloader/issues/207 ``` Signed-off-by: Pascal Bourdier <pascal.bourdier@gmail.com>
* | | Merge pull request #13477 from ↵OpenShift Merge Robot2022-03-10
|\ \ \ | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/containernetworking/plugins-1.1.1 Bump github.com/containernetworking/plugins from 1.1.0 to 1.1.1
| * | | Bump github.com/containernetworking/plugins from 1.1.0 to 1.1.1dependabot[bot]2022-03-10
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.1.0 to 1.1.1. - [Release notes](https://github.com/containernetworking/plugins/releases) - [Commits](https://github.com/containernetworking/plugins/compare/v1.1.0...v1.1.1) --- updated-dependencies: - dependency-name: github.com/containernetworking/plugins dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | Merge pull request #13476 from ↵OpenShift Merge Robot2022-03-10
|\ \ \ | |/ / |/| | | | | | | | containers/dependabot/go_modules/github.com/vbauerster/mpb/v7-7.4.1 Bump github.com/vbauerster/mpb/v7 from 7.3.2 to 7.4.1
| * | Bump github.com/vbauerster/mpb/v7 from 7.3.2 to 7.4.1dependabot[bot]2022-03-10
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/vbauerster/mpb/v7](https://github.com/vbauerster/mpb) from 7.3.2 to 7.4.1. - [Release notes](https://github.com/vbauerster/mpb/releases) - [Commits](https://github.com/vbauerster/mpb/compare/v7.3.2...v7.4.1) --- updated-dependencies: - dependency-name: github.com/vbauerster/mpb/v7 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
* | Merge pull request #12913 from rhatdan/kubeOpenShift Merge Robot2022-03-09
|\ \ | | | | | | Add --context-dir option to podman play kube
| * | Add --context-dir option to podman play kubeDaniel J Walsh2022-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This option was requested so that users could specify alternate locations to find context directories for each image build. It requites the --build option to be set. Partion Fix: https://github.com/containers/podman/issues/12485 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #13455 from rhatdan/dockerOpenShift Merge Robot2022-03-09
|\ \ \ | | | | | | | | Fix handling of tmpfs-mode for tmpfs creation in compat mode
| * | | Fix handling of tmpfs-mode for tmpfs creation in compat modeDaniel J Walsh2022-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The permissions on disk were wrong since we were not converting to octal. Fixes: https://github.com/containers/podman/issues/13108 [NO NEW TESTS NEEDED] Since we don't currently test using the docker client Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | | Merge pull request #13471 from Luap99/bump-mpbv7OpenShift Merge Robot2022-03-09
|\ \ \ \ | | | | | | | | | | Use github.com/vbauerster/mpb/v7 in pkg/machine
| * | | | Use github.com/vbauerster/mpb/v7 in pkg/machinePaul Holzinger2022-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We already use v7 in c/image so podman should use the same version to prevent duplication. This saves 170 KB binary size. [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | | Merge pull request #13470 from Luap99/yamlv2OpenShift Merge Robot2022-03-09
|\ \ \ \ \ | |/ / / / |/| | | | use gopkg.in/yaml.v2 instead of v3
| * | | | use gopkg.in/yaml.v2 instead of v3Paul Holzinger2022-03-09
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many dependencies already import gopkg.in/yaml.v2, podman is the only user of the v3 version except github.com/stretchr/testify but this is only a testing dependency so it will not end up in the binary. This change reduces the podman binary size from 54740 to 54260 KB on my system. [NO NEW TESTS NEEDED] Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | | Merge pull request #13421 from hshiina/device-ruleOpenShift Merge Robot2022-03-09
|\ \ \ \ | | | | | | | | | | Set default rule at the head of device configuration
| * | | | Set default rule at the head of device configurationHironori Shiina2022-03-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The default rule should be set at the head of device configuration. Otherwise, rules for user devices are overridden by the default rule so that any access to the user devices are denied. Signed-off-by: Hironori Shiina <shiina.hironori@jp.fujitsu.com>
* | | | | Merge pull request #13469 from ↵OpenShift Merge Robot2022-03-09
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | containers/dependabot/go_modules/github.com/docker/distribution-2.8.1incompatible Bump github.com/docker/distribution from 2.8.0+incompatible to 2.8.1+incompatible
| * | | | | Bump github.com/docker/distributiondependabot[bot]2022-03-09
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/docker/distribution](https://github.com/docker/distribution) from 2.8.0+incompatible to 2.8.1+incompatible. - [Release notes](https://github.com/docker/distribution/releases) - [Commits](https://github.com/docker/distribution/compare/v2.8.0...v2.8.1) --- updated-dependencies: - dependency-name: github.com/docker/distribution dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
* | | | | Merge pull request #13465 from n1hility/improve-install-msgOpenShift Merge Robot2022-03-09
|\ \ \ \ \ | |/ / / / |/| | | | Improve agent install message to add restart instructions
| * | | | Improve agent install message to add restart instructionsJason T. Greene2022-03-08
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
* | | | | Merge pull request #13466 from baude/machinermfOpenShift Merge Robot2022-03-09
|\ \ \ \ \ | | | | | | | | | | | | machine rm -f stops and removes machine
| * | | | | machine rm -f stops and removes machineBrent Baude2022-03-08
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If you want to remove a running machine, you can now pass the --force/-f to podman machine rm and the machine will be stopped and removed without confirmations. Fixes: #13448 [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #13447 from eriksjolund/add_chown_tip_to_troubleshooting.mdOpenShift Merge Robot2022-03-09
|\ \ \ \ \ | | | | | | | | | | | | [CI:DOCS] troubleshooting.md: mention "podman unshare chown 0:0 path"
| * | | | | [CI:DOCS] troubleshooting.md: mention "podman unshare chown 0:0 path"Erik Sjölund2022-03-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Mention the command "podman unshare chown 0:0 dir1/a" that changes file ownership to the regular user's UID and GID on the host. Co-authored-by: Tom Sweeney <tsweeney@redhat.com> Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | | | Merge pull request #13460 from edsantiago/skip_flaky_pprof_testOpenShift Merge Robot2022-03-08
|\ \ \ \ \ \ | | | | | | | | | | | | | | Skip flaky pprof tests
| * | | | | | Skip flaky pprof testsEd Santiago2022-03-08
|/ / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pprof tests are way too flaky, and are causing problems for community contributors who don't have privs to press Re-run. There has been no activity or interest in fixing the bug, and it's not something I can fix. So, just disable the test. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | | | | Merge pull request #13457 from ashley-cui/flakeOpenShift Merge Robot2022-03-08
|\ \ \ \ \ \ | |_|/ / / / |/| | | | | Move secret-verify-leak containerfile into its own Directory
| * | | | | Move secret-verify-leak containerfile into its own DirectoryAshley Cui2022-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Secret-verify-leak is causing flakes, when running in parallel tests. This is because remote secrets are copied into the context directory to send to the API server, and secret-verify-leak is doing a COPY * and then checking if the temporary secret file ends up in the container or not. Since all the temporary files are prefixed with "podman-build-secret", this test checks if podman-build-secret is in the image. However, when run in parallel with other tests, other temporary podman-build-secrets might be in the context dir. Moving secret-verify-leak into its own directory makes sure that the context dir is used only by this one test. Also renamed Dockerfile -> Containerfile and cleaned up unused Containerfiles. Signed-off-by: Ashley Cui <acui@redhat.com>
* | | | | | Merge pull request #13366 from idleroamer/inspect-joined-network-ns-mainOpenShift Merge Robot2022-03-08
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | Inspect network info of a joined network namespace
| * | | | | Inspect network info of a joined network namespace😎 Mostafa Emami2022-03-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Closes: https://github.com/containers/podman/issues/13150 Signed-off-by: 😎 Mostafa Emami <mustafaemami@gmail.com>
* | | | | | Merge pull request #13409 from baude/virtfsdarwinOpenShift Merge Robot2022-03-07
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | | MacOS improvements
| * | | | | MacOS improvementsBrent Baude2022-03-07
| | |/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Enable support of virtfs in Podman and darwin. At the time of this writing, it requires a special patch not yet included in upstream qemu. * Prefer to use a specially built qemu to support virtfs. The qemu is installed under libexec/podman. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #13414 from rvandernoort/exec_delayOpenShift Merge Robot2022-03-07
|\ \ \ \ \ | |_|/ / / |/| | | | Add ExitCommandDelay configuration use in API exec handler