summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* test/system/255-auto-update.bats: add an SELinux commentValentin Rothberg2022-08-04
| | | | | | | | Drop a comment on using `chcon` to let the local rollback test pass. It took me a while to understand why the test failed and future souls may appreciated the extra breadcrumb. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* pkg/autoupdate: introduce the notion of a `task`Valentin Rothberg2022-08-04
| | | | | | | | | | A `task` includes data and state for updating a given container image. It will come in handy in future changes, but we are going there in baby steps to have smaller incremental changes. [NO NEW TESTS NEEDED] - should not change behaviour. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* pkg/autoupdate: remove redundant branchValentin Rothberg2022-08-04
| | | | | | [NO NEW TESTS NEEDED] - should not change behavior. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* pkg/autoupdate: move policy map into updaterValentin Rothberg2022-08-04
| | | | | | [NO NEW TESTS NEEDED] - should not change behavior. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* pkg/autoupdate: introduce `updater` for shared stateValentin Rothberg2022-08-04
| | | | | | | | | Introduce an `updater` type to allow for sharing state. This will be more useful for future changes. [NO NEW TESTS NEEDED] as it does not change behavior. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* Merge pull request #15145 from cevich/ec2_get_ci_vmopenshift-ci[bot]2022-08-04
|\ | | | | [CI:DOCS] Cirrus: Support EC2 instances in hack/get_ci_vm.sh
| * Cirrus: Support EC2 instances in hack/get_ci_vm.shChris Evich2022-08-03
| | | | | | | | | | | | | | ***Depends on:*** https://github.com/containers/automation_images/pull/160 Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #15158 from cdoern/secretsDaniel J Walsh2022-08-04
|\ \ | | | | | | add omitempty to Secret in k8s VolumeSource
| * | add omitempty to Secret in k8s VolumeSourceCharlie Doern2022-08-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | Secret was populating a generated kube as `null`. Add omitempty so that when the volume source is not a secret, we do not print unnecessary info resolves #15156 Signed-off-by: Charlie Doern <cdoern@redhat.com>
* | | Merge pull request #15188 from Luap99/docsopenshift-ci[bot]2022-08-04
|\ \ \ | | | | | | | | fix hack/markdown-preprocess to support older python versions
| * | | fix hack/markdown-preprocess to support older python versionsPaul Holzinger2022-08-04
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | str.removeprefix() and str.removesuffix() is python 3.9+ only but we need to support older versions for the OSX cross task. This fixes broken CI on main. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #15068 from n1hility/wsl-as-useropenshift-ci[bot]2022-08-04
|\ \ \ | |/ / |/| | Default to rootless via Windows WSL prompt / Lock to WSL2
| * | Add support, and default to rootless w/WSL promptJason T. Greene2022-08-02
| | | | | | | | | | | | | | | | | | Also force installation to use WSL2 to prevent accidental usage of WSL1 Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
| * | Disable F36 service that is incompat with WSL kernJason T. Greene2022-08-02
| | | | | | | | | | | | | | | | | | (requires psi) Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
* | | Merge pull request #15174 from edsantiago/docs_dedup_phase1openshift-ci[bot]2022-08-03
|\ \ \ | |_|/ |/| | [CI:DOCS] Refactor common options in man pages
| * | Refactor common options in man pagesEd Santiago2022-08-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman-create and -run have many options in common. To date, these are copy-pasted and haphazardly maintained. Solution: add an include mechanism, '@@option foo', such that multiple md source files can fetch from one common file. This is a Phase One commit, a very small subset of what's possible. Purpose of this commit is ease of review. If this passes review, much more (trickier stuff) will be forthcoming. Signed-off-by: Ed Santiago <santiago@redhat.com>
* | | Merge pull request #15105 from anjannath/sign-qemuopenshift-ci[bot]2022-08-03
|\ \ \ | | | | | | | | Add steps to sign included qemu and notarize the built pkg
| * | | pkginstaller: makefile improvements to avoid redownloadingAnjan Nath2022-08-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | this updates downloading of gvproxy and qemu using a standard makefile rule which will avoid downloading them again if its already downloaded [NO NEW TESTS NEEDED] Signed-off-by: Anjan Nath <kaludios@gmail.com>
| * | | pkginstaller: add makefile target to notarize the built pkgAnjan Nath2022-08-03
| | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Anjan Nath <kaludios@gmail.com>
| * | | pkginstaller: sign qemu-system-* binary for the pkgAnjan Nath2022-08-03
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | add file hvf.entitlements which has the com.apple.security.hypervisor entitlement needed for qemu [NO NEW TESTS NEEDED] Signed-off-by: Anjan Nath <kaludios@gmail.com>
* | | Merge pull request #15084 from sstosh/rm-filteropenshift-ci[bot]2022-08-03
|\ \ \ | | | | | | | | Add rm --filter option
| * | | Add rm --filter optionToshiki Sonoda2022-07-30
| | | | | | | | | | | | | | | | | | | | | | | | --filter : remove the filtered container. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | Merge pull request #15161 from lsm5/switch-to-dnfopenshift-ci[bot]2022-08-03
|\ \ \ \ | | | | | | | | | | Cirrus: use dnf instead of rpm to install packages
| * | | | skip pod resource limits test on aarch64Lokesh Mandvekar2022-08-03
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
| * | | | Cirrus: use dnf instead of rpm to install packagesLokesh Mandvekar2022-08-02
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | | Merge pull request #15166 from sstosh/ci-mount-rootlessopenshift-ci[bot]2022-08-03
|\ \ \ \ \ | |_|_|_|/ |/| | | | Cirrus: Fix e2e tests for "mount_rootless_test"
| * | | | Cirrus: Fix e2e tests for "mount_rootless_test"Toshiki Sonoda2022-08-03
| |/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e2e `mount_rootless_test` did not load `podman binary path` successfully. This PR fix this problem. [It] podman unshare podman mount: ``` [+1596s] Running: ... unshare mount <cid> [+1596s] Error: exec: no command [+1596s] output: ``` [It] podman unshare image podman mount: ``` [+1599s] Running: ... unshare image mount quay.io/libpod/alpine:latest [+1599s] Error: exec: no command [+1599s] output: ``` Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
* | | | Merge pull request #14974 from nicrowe00/kubedown1openshift-ci[bot]2022-08-03
|\ \ \ \ | |/ / / |/| | | add "podman kube down" command
| * | | add "podman kube down" commandNiall Crowe2022-08-02
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | The "podman kube down" reads in a structured file of Kubernetes YAML and removes pods based on the Kubernetes kind described in the YAML, similiar to "podman play kube --down". Users will still be able to use "podman play kube --down" and "podman kube play --down" to perform the same function. Signed-off-by: Niall Crowe <nicrowe@redhat.com>
* | | Merge pull request #15119 from nicrowe00/15071OpenShift Merge Robot2022-08-02
|\ \ \ | | | | | | | | switch from "kube/play" endpoint to "play/kube" endpoint.
| * | | switch from "kube/play" endpoint to "play/kube" endpoint.Niall Crowe2022-08-02
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | When podman kube play was added the endpoint for the kube play/play kube commands was switched from the "play kube" endpoint to the new "kube play" endpoint. This caused issues with the remote client, requiring the need to use the "play kube" endpoint again in order to avoid these issues. Signed-off-by: Niall Crowe <nicrowe@redhat.com>
* | | Merge pull request #15136 from Luap99/systemd-generate-hostnameOpenShift Merge Robot2022-08-02
|\ \ \ | |/ / |/| | podman generate systemd --new: allow -h hostname
| * | podman generate systemd --new: allow -h hostnamePaul Holzinger2022-08-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | podman run/create can accept `-h <hostname>` as argument. When parsing flags -h throws an help requested error from pflag. To prevent this error we have to define the help flag. Fixes #15124 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* | | Merge pull request #15097 from flouthoc/check-common-manifest-inspectOpenShift Merge Robot2022-08-02
|\ \ \ | |/ / |/| | manifest,test: `inspect` should contain `OCI` annotations.
| * | test: verify manifest inspect must contain OCI annotationsAditya R2022-08-01
|/ / | | | | | | Signed-off-by: Aditya R <arajan@redhat.com>
* | Merge pull request #15139 from vrothberg/fix-ciOpenShift Merge Robot2022-08-01
|\ \ | | | | | | fix e2e sign tests
| * | fix e2e sign testsValentin Rothberg2022-08-01
| | | | | | | | | | | | | | | | | | | | | The key used in the tests has expired. Remove the expiration date to turn CI happy and green. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
* | | Merge pull request #15127 from Zocker1999NET/patch-1OpenShift Merge Robot2022-08-01
|\ \ \ | |/ / |/| | [CI:DOCS] man podman-volume-import: Clarify that merge happens
| * | podman-volume-import: Reword "precendence"Felix Stupp2022-07-31
| | | | | | | | | Signed-off-by: Felix Stupp <me+github@banananet.work>
| * | man podman-volume-import: Clarify that merge happensFelix Stupp2022-07-30
| |/ | | | | | | | | Current directories and files stay the same with the current implementation as long as the tarball does not contain a directories or files with the same name. Signed-off-by: Felix Stupp <me+github@banananet.work>
* | Merge pull request #15108 from mtrmac/sigstore-signOpenShift Merge Robot2022-08-01
|\ \ | | | | | | Sigstore sign
| * | Add support for creating sigstore signatures, and providing passphrasesMiloslav Trmač2022-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Allow creating sigstore signatures via --sign-by-sigstore-private-key . Like existing --sign-by, it does not work remote (in this case because we would have to copy the private key to the server). - Allow passing a passphrase (which is mandatory for sigstore private keys) via --sign-passphrase-file; if it is not provided, prompt interactively. - Also, use that passphrase for --sign-by as well, allowing non-interactive GPG use. (But --sign-passphrase-file can only be used with _one of_ --sign-by and --sign-by-sigstore-private-key.) Note that unlike the existing code, (podman build) does not yet implement sigstore (I'm not sure why it needs to, it seems not to push images?) because Buildah does not expose the feature yet. Also, (podman image sign) was not extended to support sigstore. The test for this follows existing (podman image sign) tests and doesn't work rootless; that could be improved by exposing a registries.d override option. The test for push is getting large; I didn't want to start yet another registry container, but that would be an alternative. In the future, Ginkgo's Ordered/BeforeAll would allow starting a registry once and using it for two tests. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Hide podman manifest push --sign-by on remoteMiloslav Trmač2022-07-30
| | | | | | | | | | | | | | | | | | ... because it is documented to be ignored. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Use signByFlagName instead of copy&pasting the stringMiloslav Trmač2022-07-30
| | | | | | | | | | | | Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Remove libpod/commonMiloslav Trmač2022-07-30
| | | | | | | | | | | | | | | | | | AFAICS it is not used anywhere. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Update c/common to an unreleased versionMiloslav Trmač2022-07-30
| | | | | | | | | | | | | | | | | | ... to get https://github.com/containers/common/pull/1106 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| * | Merge branch 'registry-2.8' into HEADMiloslav Trmač2022-07-30
| |\ \ | | |/ | |/|
| | * Update the registry server we test against from 2.6 to 2.8Miloslav Trmač2022-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... primarily so that it can support OCI artifacts. 2.8 already seems to exist in the repo. This requires changing WaitContainerReady to also check stderr (ultimately because docker/distribution was updated to a more recent sirupsen/logrus, which logs by default to stderr instead of stdout). Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| | * Use existing REGISTRY_IMAGE variables in more placesMiloslav Trmač2022-07-30
| | | | | | | | | | | | | | | | | | | | | | | | | | | ... instead of hard-coding a copy of the value. Notably this makes hack/podman_registry actually support the documented -i option. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
| | * Use httpasswd from the surrouding OS instead of the registry imageMiloslav Trmač2022-07-30
| |/ | | | | | | | | | | | | | | | | | | | | htpasswd is no longer included in docker.io/library/distribution after 2.7.0, per https://github.com/docker/distribution-library-image/issues/107 , and we want to upgrade to a recent version. At least system tests currently execute htpasswd from the OS, so it seems that it is likely to be available. Signed-off-by: Miloslav Trmač <mitr@redhat.com>