aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* pull/search options: tls verify -> skipValentin Rothberg2020-04-29
| | | | | | | | | Change the logic in the options from tls-verify to skipping verification. It require a constant brain yoga to translate from doing verification (CLI logic) to skipping it (c/image logic). As the code is using c/image, let's make it consistent. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #6037 from vrothberg/enable-push-testsOpenShift Merge Robot2020-04-29
|\ | | | | Enable push tests
| * login system test: enable "push ok"Valentin Rothberg2020-04-29
| | | | | | | | Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * enable the push e2e testsValentin Rothberg2020-04-29
| | | | | | | | | | | | With the recent changes, push is working now. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * push: fix --tls-verifyValentin Rothberg2020-04-29
| | | | | | | | | | | | | | | | Fix --tls-verify parsing and make the associated options reflect the correct logic. Other commands are affected as well but will be fixed later. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * push: simplify cmdValentin Rothberg2020-04-29
| | | | | | | | | | | | The indirection via a 2nd variable isn't needed. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * push: fix push with one argumentValentin Rothberg2020-04-29
| | | | | | | | | | | | | | When doing a `podman push $IMG`, $IMG acts as the source and the destination. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #6036 from giuseppe/fix-rootlessport-panicOpenShift Merge Robot2020-04-29
|\ \ | | | | | | rootlessport: use two different channels
| * | rootlessport: use two different channelsGiuseppe Scrivano2020-04-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The same channel is written to by two different goroutines. Use a different channel for each of them so to avoid writing to a closed channel. Closes: https://github.com/containers/libpod/issues/6018 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | specgen: honor slirp4netnsGiuseppe Scrivano2020-04-29
| |/ | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | Merge pull request #6031 from mheon/release_191_in_masterOpenShift Merge Robot2020-04-29
|\ \ | | | | | | Update release notes and README for 1.9.1 release
| * | Update release notes and README for 1.9.1 releaseMatthew Heon2020-04-28
| | | | | | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* | | Merge pull request #6035 from giuseppe/move-rootless-open-before-forkOpenShift Merge Robot2020-04-29
|\ \ \ | |_|/ |/| | rootless: move ns open before fork
| * | rootless: move ns open before forkGiuseppe Scrivano2020-04-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | commit 788fdc685b00dee5ccb594bef845204250c4c123 introduced a race where the target process dies before the child process opens the namespace files. Move the open before the fork so if it fails the parent process can attempt to join a different container instead of failing. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #6022 from vrothberg/enable-inspect-testsOpenShift Merge Robot2020-04-29
|\ \ \ | | | | | | | | enable inspect tests
| * | | enable inspect testsValentin Rothberg2020-04-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A surprisingly big change. A core problem was that `podman inspect` allows for passing containers AND images with the default `--type=all`. This only worked partially as the data was processed in isolation which caused various issues (e.g., two separate outputs instead of one) but it also caused issues regarding error handling. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | Merge pull request #5998 from vrothberg/generate-systemdOpenShift Merge Robot2020-04-29
|\ \ \ \ | |_|/ / |/| | | generate systemd
| * | | generate systemdValentin Rothberg2020-04-29
| |/ / | | | | | | | | | | | | | | | | | | Implement `podman generate systemd` for Podman v2 and enable associated tests. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | Merge pull request #6029 from rhatdan/envOpenShift Merge Robot2020-04-29
|\ \ \ | |/ / |/| | User specified environment happen after other environments are set
| * | User specified environment happen after other environments are setDaniel J Walsh2020-04-28
| | | | | | | | | | | | | | | | | | | | | When using varlink we want to make sure that user specified environment variables take precedence over http-proxy environment. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | | Merge pull request #6026 from baude/v2forcesystemtestsOpenShift Merge Robot2020-04-28
|\ \ \ | | | | | | | | system tests must pass
| * | | system tests must passBrent Baude2020-04-28
| | |/ | |/| | | | | | | Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #6011 from sujil02/podman-save-issue-5234OpenShift Merge Robot2020-04-28
|\ \ \ | | | | | | | | Fixes podman save fails when specifying an image using a digest fixes-5234
| * | | Fixes podman save fails when specifying an image using a digest #5234Sujil022020-04-28
| | |/ | |/| | | | | | | | | | | | | | | | Adds check to parse normalized name and create docker archive dst reference for tagged untagged image. Relevant test case added. Signed-off-by: Sujil02 <sushah@redhat.com>
* | | Merge pull request #5991 from sujil02/pod-rm-testOpenShift Merge Robot2020-04-28
|\ \ \ | |_|/ |/| | Fix typos in messages pod rm
| * | Fix typos in rm messagesSujil022020-04-28
| | | | | | | | | | | | | | | | | | Fix typos in pod rm messages Signed-off-by: Sujil02 <sushah@redhat.com>
* | | Merge pull request #6024 from baude/v2checkmediatypewOpenShift Merge Robot2020-04-28
|\ \ \ | | | | | | | | check image media/manifest type for healthchecks
| * | | check image media/manifest type for healthchecksBrent Baude2020-04-28
| | | | | | | | | | | | | | | | | | | | | | | | before looking up a healthcheck in an image, check to make sure it is a dockerv2schema image. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | Merge pull request #6020 from giuseppe/fix-execOpenShift Merge Robot2020-04-28
|\ \ \ \ | | | | | | | | | | v2, podman: fix create tests
| * | | | test: enable exec testsGiuseppe Scrivano2020-04-28
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | pkg, specgen: do not hardcode user=0 in the config if not specifiedGiuseppe Scrivano2020-04-28
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | specgen: remove dead codeGiuseppe Scrivano2020-04-28
| | | | | | | | | | | | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
| * | | | cmd: set correct parent for container execGiuseppe Scrivano2020-04-28
| | |_|/ | |/| | | | | | | | | | Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | | Merge pull request #5907 from sujil02/systemprune-v2OpenShift Merge Robot2020-04-28
|\ \ \ \ | | | | | | | | | | Adding system prune for podman v2
| * | | | Adding system prune for podman v2Sujil022020-04-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Register system prune route, handler to support system prune, Adds testcase to validate the system prune flow. Signed-off-by: Sujil02 <sushah@redhat.com>
* | | | | Merge pull request #5954 from lsm5/usable-Makefile-for-packagingOpenShift Merge Robot2020-04-28
|\ \ \ \ \ | | | | | | | | | | | | Makefile: install targets should not depend on build targets
| * | | | | Makefile: include -nobuild install targetsLokesh Mandvekar2020-04-23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Distro packaging often uses non-default build and linker flags. The current Makefile cannot be used in the package build process as it will end up rebuilding the binaries with the default flags. This commit introduces install targets which do not depend on the build targets. Distro packages should prefer these if they want to use any non-default flags. NOTE: This commit effectively leaves prior targets unchanged, so users won't notice any difference. Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | | | Merge pull request #6007 from baude/v2intvolumesOpenShift Merge Robot2020-04-28
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | enable volume integration tests
| * | | | | enable volume integration testsBrent Baude2020-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | enabled integration tests for volumes. there are two exceptions that still need work because of something not yet implemented. also, add code to deal with the fact that containers conf appears to set a local volume driver where it used to be simply blank. Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | | Merge pull request #6014 from vrothberg/enable-build-testsOpenShift Merge Robot2020-04-28
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | enable build tests
| * | | | | enable build testsValentin Rothberg2020-04-28
|/ / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One test is still being skipped as container creation doesn't yet set certain data from the image (e.g., PATH). Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | | | | Merge pull request #6009 from baude/v2hclogOpenShift Merge Robot2020-04-28
|\ \ \ \ \ | | | | | | | | | | | | separate healthcheck and container log paths
| * | | | | separate healthcheck and container log pathsBrent Baude2020-04-27
| |/ / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | instead of using the container log path to derive where to put the healthchecks, we now put them into the rundir to avoid collision of health check log files when the log path is set by user. Fixes: #5915 Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | | | Merge pull request #6006 from GabyCT/topic/fixtypoOpenShift Merge Robot2020-04-27
|\ \ \ \ \ | |/ / / / |/| | | | install.md: Fix typo
| * | | | install.md: Fix typoGabriela Cervantes2020-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR fixes a typo on the install.md. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
* | | | | Merge pull request #6000 from mheon/volume_backend_flagsOpenShift Merge Robot2020-04-27
|\ \ \ \ \ | | | | | | | | | | | | Add support for volumes-from, image volumes, init
| * | | | | Improve Entrypoint and Command supportMatthew Heon2020-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We should not be overwriting the Specgen's Command and Entrypoint when building the final command to pass in the OCI spec. Both of these will be provided to Libpod for use in `podman inspect` and committing containers, and both must be set to the user's input, not overwritten by the image if unset. Fix this by moving command generation into OCI spec generation and not modifying the SpecGenerator when we do so. Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * | | | | Add support for volumes-from, image volumes, initMatthew Heon2020-04-27
| | |_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This should complete Podmanv2's support for volume-related flags. Most code was sourced from the old pkg/spec implementation with modifications to account for the split between frontend flags (volume, mount, tmpfs) and the backend flags implemented here. Also enables tests for podman run with volumes Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* | | | | Merge pull request #5978 from rhatdan/portsOpenShift Merge Robot2020-04-27
|\ \ \ \ \ | |_|/ / / |/| | | | Make podman container list == podman ps
| * | | | Make podman container list == podman psDaniel J Walsh2020-04-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also make podman create -p PUBLISHPorts work. This PR fixes ps_test.go Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>