aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Bump to v3.0.0v3.0.0Matthew Heon2021-02-11
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Update release notes for v3.0 finalMatthew Heon2021-02-11
| | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
* Rewrite copy-up to use buildah CopierMatthew Heon2021-02-11
| | | | | | | | | | | | | | | | The old copy-up implementation was very unhappy with symlinks, which could cause containers to fail to start for unclear reasons when a directory we wanted to copy-up contained one. Rewrite to use the Buildah Copier, which is more recent and should be both safer and less likely to blow up over links. At the same time, fix a deadlock in copy-up for volumes requiring mounting - the Mountpoint() function tried to take the already-acquired volume lock. Fixes #6003 Signed-off-by: Matthew Heon <mheon@redhat.com>
* Display correct value for unlimited ulimitbaude2021-02-11
| | | | | | | | | | | When doing a container inspect on a container with unlimited ulimits, the value should be -1. But because the OCI spec requires the ulimit value to be uint64, we were displaying the inspect values as a uint64 as well. Simple change to display as an int64. Fixes: #9303 Signed-off-by: baude <bbaude@redhat.com>
* make `podman rmi` more robustValentin Rothberg2021-02-11
| | | | | | | | | | | | | | | | The c/storage library is subject to TOCTOUs as the central container and image storage may be shared by many instances of many tools. As shown in #6510, it's fairly easy to have multiple instances of Podman running in parallel and yield image-lookup errors when removing them. The underlying issue is the TOCTOU of removal being split into multiple stages of first reading the local images and then removing them. Some images may already have been removed in between the two stages. To make image removal more robust, handle errors at stage two when a given image is not present (anymore) in the storage. Fixes: #6510 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Allow path completion for podman create/run --rootfsPaul Holzinger2021-02-11
| | | | | | | | | | | If the --rootfs flag is set podman create/run expect a host path as first argument. The shell completion should provide path completion in that case. [NO TESTS NEEDED] This can manually be verified with `podman run --rootfs [TAB]`. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
* Merge pull request #9287 from vrothberg/3.0-vendor-imageOpenShift Merge Robot2021-02-09
|\ | | | | [3.0] vendor github.com/containers/image v5.10.2
| * vendor github.com/containers/image v5.10.2Valentin Rothberg2021-02-09
| | | | | | | | | | Fixes: #8559 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* | Merge pull request #9285 from jwhonce/issues/8773-v3.0.0OpenShift Merge Robot2021-02-09
|\ \ | |/ |/| Add default template functions
| * Add default template functionsJhon Honce2021-02-09
|/ | | | | | | | | For commands that use the golang template library directly add the compatible template functions Fixes #8773 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* Merge pull request #9273 from mheon/backport_api_changesOpenShift Merge Robot2021-02-08
|\ | | | | [v3.0] Backport final breaking API change to v3.0
| * Fix per review requestMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Increase timeouts in some testsMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Add test for Docker APIv2 waitMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Implement Docker wait conditionsMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Improve ContainerEngine.ContainerWait()Matej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Improve container libpod.Wait*() functionsMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * [NO TESTS NEEDED] style: indendationMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * [NO TESTS NEEDED] fixup: remove debug codeMatej Vasek2021-02-08
| | | | | | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com> <MH: Regenerate bindings> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * [NO TESTS NEEDED] Generated filesMatej Vasek2021-02-08
| | | | | | | | | | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com> <MH: Regenerated bindings> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Cleanup bindings for image pullDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | Remove bindings that are not handled over the API. Leaving this one to not use image pull, since this would break progress handling. We should revisit this in the future. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * [NO TESTS NEEDED] Improve generatorMatej Vasek2021-02-08
| | | | | | | | Signed-off-by: Matej Vasek <mvasek@redhat.com>
| * Fix invalid wait condition on killDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | When using the compatability tests on kill, the kill function goes into an infinite wait loop taking all of the CPU. This change will use the correct wait function and exit properly. Fixes: https://github.com/containers/podman/issues/9206 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Switch podman image push handlers to use abiDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | Change API Handlers to use the same functions that the local podman uses. At the same time: Cleanup and pass proper bindings. Remove cli options from podman-remote push. Cleanup manifest push. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * podman-remote ps --external --pod --sort do not work.Daniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | Fixup the bindings and the handling of the --external --por and --sort flags. The --storage option was renamed --external, make sure we use external up and down the stack. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Fix --arch and --os flags to work correctlyDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently podman implements --override-arch and --overide-os But Podman has made these aliases for --arch and --os. No reason to have to specify --override, since it is clear what the user intends. Currently if the user specifies an --override-arch field but the image was previously pulled for a different Arch, podman run uses the different arch. This PR also fixes this issue. Fixes: https://github.com/containers/podman/issues/8001 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Switch podman stop/kill/wait handlers to use abiDaniel J Walsh2021-02-08
| | | | | | | | | | | | | | | | | | | | | | | | Change API Handlers to use the same functions that the local podman uses. At the same time: implement remote API for --all and --ignore flags for podman stop implement remote API for --all flags for podman stop Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
| * Fix handling of container removeDaniel J Walsh2021-02-08
|/ | | | | | | | | | | | | | | | | | | | I found several problems with container remove podman-remote rm --all Was not handled podman-remote rm --ignore Was not handled Return better errors when attempting to remove an --external container. Currently we return the container does not exists, as opposed to container is an external container that is being used. This patch also consolidates the tunnel code to use the same code for removing the container, as the local API, removing duplication of code and potential problems. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* Merge pull request #9267 from mheon/bump_300_rc3OpenShift Merge Robot2021-02-08
|\ | | | | Bump to v3.0.0-RC3
| * Bump to v3.0.0-devMatthew Heon2021-02-08
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v3.0.0-RC3v3.0.0-rc3Matthew Heon2021-02-08
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #9237 from mheon/backports_300_RC3OpenShift Merge Robot2021-02-05
|\ | | | | Backports for v3.0,0-RC3
| * Further release notes for v3.0Matthew Heon2021-02-05
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Bump remote API version to 3.0.0Matthew Heon2021-02-05
| | | | | | | | | | | | Fixes #9175 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * fix logic when not creating a workdirValentin Rothberg2021-02-05
| | | | | | | | | | | | | | | | | | | | | | When resolving the workdir of a container, we may need to create unless the user set it explicitly on the command line. Otherwise, we just do a presence check. Unfortunately, there was a missing return that lead us to fall through into attempting to create and chown the workdir. That caused a regression when running on a read-only root fs. Fixes: #9230 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * play kube selinux test caseSteven Taylor2021-02-05
| | | | | | | | | | | | added skip to test case where selinux not enabled Signed-off-by: Steven Taylor <steven@taylormuff.co.uk>
| * play kube selinux test caseSteven Taylor2021-02-05
| | | | | | | | | | | | fixed typo in the label comparison Signed-off-by: Steven Taylor <steven@taylormuff.co.uk>
| * play kube selinux label test caseSteven Taylor2021-02-05
| | | | | | | | | | | | | | test case added to e2e test suite to validate process label being correctly set on play kube Signed-off-by: Steven Taylor <steven@taylormuff.co.uk>
| * play kube selinux label issueSteven Taylor2021-02-05
| | | | | | | | | | | | | | | | | | play kube function not respecting selinux options in kube yaml, all options were being mapped to role. fixes issue 8710 Signed-off-by: Steven Taylor <steven@taylormuff.co.uk>
| * Fix podman network disconnect wrong NetworkStatus numberPaul Holzinger2021-02-05
| | | | | | | | | | | | | | | | | | | | | | | | | | The allocated `tmpNetworkStatus` must be allocated with the length 0. Otherwise append would add new elements to the end of the slice and not at the beginning of the allocated memory. This caused inspect to fail since the number of networks did not matched the number of network statuses. Fixes #9234 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
| * Update release notes for v3.0.0-RC3Matthew Heon2021-02-04
| | | | | | | | Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * generate kube: handle entrypointValentin Rothberg2021-02-04
| | | | | | | | | | | | | | | | | | | | The spec of a Kube Container has a `Command` and `Args`. While both are slices, the `Command` is the counterpart of the entrypoint of a libpod container. Kube is also happily accepting the arguments to as following items in the slice but it's cleaner to move those to `Args`. Fixes: #9211 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Allow pods to use --net=noneMatthew Heon2021-02-04
| | | | | | | | | | | | | | | | | | | | | | We need an extra field in the pod infra container config. We may want to reevaluate that struct at some point, as storing network modes as bools will rapidly become unsustainable, but that's a discussion for another time. Otherwise, straightforward plumbing. Fixes #9165 Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Report StatusConflict on Pod opt partial failuresJhon Honce2021-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - When one or more containers in the Pod reports an error on an operation report StatusConflict and report the error(s) - jsoniter type encoding used to marshal error as string using error.Error() - Update test framework to allow setting any flag when creating pods - Fix test_resize() result check Fixes #8865 Signed-off-by: Jhon Honce <jhonce@redhat.com> <MH: Fix cherry-pick conflicts> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * bindings: attach: warn correct errorValentin Rothberg2021-02-04
| | | | | | | | | | | | | | | | | | The resize warning logged the wrong error. While this does not fix #9172, it may very well be helpful finding its root cause. [NO TESTS NEEDED] Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
| * Make slirp MTU configurable (network_cmd_options)bitstrings2021-02-04
| | | | | | | | | | | | | | | | The mtu default value is currently forced to 65520. This let the user control it using the config key network_cmd_options, i.e.: network_cmd_options=["mtu=9000"] Signed-off-by: bitstrings <pino.silvaggio@gmail.com>
| * Fix podman generate systemd --new special char handlingPaul Holzinger2021-02-04
| | | | | | | | | | | | | | | | | | | | In a systemd unit dollar and percent signs are used for variables. A backslash is used for escape sequences. If any of these characters are used in the create command we have to properly escape them so systemd does not try to interpret them. Fixes #9176 Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
| * Fix --network parsing for podman pod createPaul Holzinger2021-02-04
| | | | | | | | | | | | | | | | | | | | | | | | The `--network` flag is parsed differently for `podman pod create`. This causes confusion and problems for users. The extra parsing logic ignored unsupported network options such as `none`, `container:...` and `ns:...` and instead interpreted them as cni network names. Tests are added to ensure the correct errors are shown. Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
| * Endpoint that lists containers does not return correct Status valueMilivoje Legenovic2021-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | Eclipse and Intellij Docker plugin determines the state of the container via the Status field, returned from /containers/json call. Podman always returns empty string, and because of that, both IDEs show the wrong state of the container. Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com> <MH: Fixed cherry-pick conflicts> Signed-off-by: Matthew Heon <matthew.heon@pm.me>
| * Docker ignores mount flags that begin with constencyDaniel J Walsh2021-02-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1915332 ``` According to the Docker docs, the consistency option should be ignored on Linux. the possible values are 'cached', 'delegated', and 'consistent', but they should be ignored equally. This is a widely used option in scripts run by developer machines, as this makes file I/O less horribly slow on MacOS. ``` Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2025-01-27 19:31:07 +0000