aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* machine rm -f stops and removes machineBrent Baude2022-03-08
| | | | | | | | | | | | If you want to remove a running machine, you can now pass the --force/-f to podman machine rm and the machine will be stopped and removed without confirmations. Fixes: #13448 [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #13366 from idleroamer/inspect-joined-network-ns-mainOpenShift Merge Robot2022-03-08
|\ | | | | Inspect network info of a joined network namespace
| * Inspect network info of a joined network namespace😎 Mostafa Emami2022-03-08
| | | | | | | | | | Closes: https://github.com/containers/podman/issues/13150 Signed-off-by: 😎 Mostafa Emami <mustafaemami@gmail.com>
* | Merge pull request #13409 from baude/virtfsdarwinOpenShift Merge Robot2022-03-07
|\ \ | | | | | | MacOS improvements
| * | MacOS improvementsBrent Baude2022-03-07
| | | | | | | | | | | | | | | | | | | | | | | | * Enable support of virtfs in Podman and darwin. At the time of this writing, it requires a special patch not yet included in upstream qemu. * Prefer to use a specially built qemu to support virtfs. The qemu is installed under libexec/podman. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | | Merge pull request #13414 from rvandernoort/exec_delayOpenShift Merge Robot2022-03-07
|\ \ \ | |_|/ |/| | Add ExitCommandDelay configuration use in API exec handler
| * | Add ExitCommandDelay configuration use in API exec handlerRover van der Noort2022-03-04
| | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Rover van der Noort <s.r.vandernoort@student.tudelft.nl>
* | | Merge pull request #13431 from eriksjolund/fix_some_typosOpenShift Merge Robot2022-03-07
|\ \ \ | | | | | | | | [CI:DOCS] troubleshooting.md: Improve language and fix typos
| * | | [CI:DOCS] troubleshooting.md: Improve language and fix typosErik Sjölund2022-03-05
| | | | | | | | | | | | | | | | Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
* | | | Merge pull request #13310 from lsm5/packagingOpenShift Merge Robot2022-03-07
|\ \ \ \ | | | | | | | | | | [CI:DOCS] DISTRO_PACKAGE.md: List the packaging changes for v4
| * | | | [CI:DOCS] DISTRO_PACKAGE.md: List the packaging changes for v4Lokesh Mandvekar2022-03-07
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | [NO NEW TESTS NEEDED] Co-authored-by: Ashley Cui <ashleycui16@gmail.com> Co-authored-by: Valentin Rothberg <vrothberg@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | | Merge pull request #13418 from lsm5/release-artifacts-process-2OpenShift Merge Robot2022-03-07
|\ \ \ \ | |/ / / |/| | | [CI:DOCS] RELEASE_PROCESS.md: cosmetic fix
| * | | [CI:DOCS] RELEASE_PROCESS.md: cosmetic fixLokesh Mandvekar2022-03-07
|/ / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Follow up to pr#13416 Insert line breaks to get rid of the horizontal scroll bar. Resolves: https://github.com/containers/podman/pull/13416#discussion_r818991807 Co-authored-by: Ashley Cui <acui@redhat.com> Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #13442 from tricktron/rm-mounted-host-socket-on-macosOpenShift Merge Robot2022-03-07
|\ \ \ | | | | | | | | `podman machine rm` removes the mounted socket file on macOS
| * | | Fixes: #13301 ("machine rm removes the mounted socket file on macos")Thibault Gagnaux2022-03-06
| |/ / | | | | | | | | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Thibault Gagnaux <tgagnaux@gmail.com>
* | | Merge pull request #13406 from jwhonce/wip/docker-pyOpenShift Merge Robot2022-03-07
|\ \ \ | | | | | | | | Move all python tests to pytest
| * | | Move all python tests to pytestJhon Honce2022-03-04
| | |/ | |/| | | | | | | | | | | | | | | | * Add configuration to add report header for python client used in tests * Move report headers into the individual test runners vs runner.sh Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | | Merge pull request #13423 from umohnani8/kubeOpenShift Merge Robot2022-03-07
|\ \ \ | |_|/ |/| | Throw an error if kube yaml has duplicate ctr names
| * | Throw an error if kube yaml has duplicate ctr namesUrvashi Mohnani2022-03-04
|/ / | | | | | | | | | | | | Error out if the kube yaml passed to play kube has more than one container or init container with the same name. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
* | Merge pull request #13413 from giuseppe/pod-no-use-cgroups-if-disabledOpenShift Merge Robot2022-03-04
|\ \ | | | | | | libpod: pods do not use cgroups if --cgroups=disabled
| * | libpod: pods do not use cgroups if --cgroups=disabledGiuseppe Scrivano2022-03-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | do not attempt to use cgroups with pods if the cgroups are disabled. A similar check is already in place for containers. Closes: https://github.com/containers/podman/issues/13411 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
* | | Merge pull request #13416 from lsm5/release-artifacts-processOpenShift Merge Robot2022-03-03
|\ \ \ | | | | | | | | RELEASE_PROCESS.md: build artifacts locally
| * | | RELEASE_PROCESS.md: build artifacts locallyLokesh Mandvekar2022-03-03
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current PR process for release bump has the HEAD commit which bumps version/version.go to the form `release+1-dev`. This makes Cirrus publish release artifacts with `release+1-dev` and not `release`. For example, the msi generated at https://cirrus-ci.com/task/5403901196238848 says podman-v4.0.3-dev.msi . Building locally by checking out the released tag would generate the correct artifacts and would also be faster and more convenient. [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* | | Merge pull request #13404 from flouthoc/bump-to-race-free-depsOpenShift Merge Robot2022-03-03
|\ \ \ | |/ / |/| | deps: bump to race-free `c/image` and `c/storage` along with test to verify `concurrent/parallel` builds
| * | test: add a test to verify race free concurrent/parallel buildsAditya R2022-03-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Invoking parallel/concurrent builds from podman race against each other following behviour was fixed in https://github.com/containers/storage/pull/1153 and https://github.com/containers/image/pull/1480 Test verifies if following bug is fixed in new race-free API or not. Read more about this issue, see bz 2055487 for more details. More details here: https://github.com/containers/buildah/pull/3794 and https://github.com/containers/podman/pull/13339 Co-authored-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Aditya R <arajan@redhat.com>
| * | vendor: bump c/image to main/9a9cd9Aditya R2022-03-02
| | | | | | | | | | | | | | | | | | | | | Bump c/image to upstream main/9a9cd9 so podman could use new race-free code. Signed-off-by: Aditya R <arajan@redhat.com>
| * | vendor: bump c/storage to main/d06b0fAditya R2022-03-02
| |/ | | | | | | | | | | | | Bump c/storage to main/d06b0f so we podman could use new `race-free` `AddNames` and `RemoveNames` api Signed-off-by: Aditya R <arajan@redhat.com>
* | Merge pull request #13399 from flouthoc/resolve-workdir-symlinkOpenShift Merge Robot2022-03-02
|\ \ | |/ |/| container: workdir resolution must consider `symlink` if explicitly configured
| * container: workdir resolution must consider symlink if explicitly configuredAditya R2022-03-02
|/ | | | | | | | | | | | | | | | | | | | | | | While resolving `workdir` we mostly create a `workdir` when `stat` fails with `ENOENT` or `ErrNotExist` however following cases are not true when user explicitly specifies a `workdir` while `running` using `--workdir` which tells `podman` to only use workdir if its exists on the container. Following configuration is implicity set with other `run` mechanism like `podman play kube` Problem with explicit `--workdir` or similar implicit config in `podman play kube` is that currently podman ignores the fact that workdir can also be a `symlink` and actual `link` could be valid. Hence following commit ensures that in such scenarios when a `workdir` is not found and we cannot create a `workdir` podman must perform a check to ensure that if `workdir` is a `symlink` and `link` is resolved successfully and resolved link is present on the container then we return as it is. Docker performs a similar behviour. Signed-off-by: Aditya R <arajan@redhat.com>
* Merge pull request #13375 from kousu/repair-13123OpenShift Merge Robot2022-03-01
|\ | | | | Use storage that better supports rootless overlayfs
| * Use storage that better supports rootless overlayfsNick Guenther2022-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | overlayfs -- the kernel's version, not fuse-overlayfs -- recently learned (as of linux 5.16.0, I believe) how to support rootless users. Previously, rootless users had to use these storage.conf(5) settings: * storage.driver=vfs (aka STORAGE_DRIVER=vfs), or * storage.driver=overlay (aka STORAGE_DRIVER=overlay), storage.options.overlay.mount_program=/usr/bin/fuse-overlayfs (aka STORAGE_OPTS=/usr/bin/fuse-overlayfs) Now that a third backend is available, setting only: * storage.driver=overlay (aka STORAGE_DRIVER=overlay) https://github.com/containers/podman/issues/13123 reported EXDEV errors during the normal operation of their container. Tracing it out, the problem turned out to be that their container was being mounted without 'userxattr'; I don't fully understand why, but mount(8) mentions this is needed for rootless users: > userxattr > > Use the "user.overlay." xattr namespace instead of "trusted.overlay.". > This is useful for unprivileged mounting of overlayfs. https://github.com/containers/storage/pull/1156 found and fixed the issue in podman, and this just pulls in that via go get github.com/containers/storage@ebc90ab go mod vendor make vendor Closes https://github.com/containers/podman/issues/13123 Signed-off-by: Nick Guenther <nick.guenther@polymtl.ca>
* | Merge pull request #13391 from baude/revertOpenShift Merge Robot2022-03-01
|\ \ | | | | | | Revert "use GetRuntimeDir() from c/common"
| * | Revert "use GetRuntimeDir() from c/common"Brent Baude2022-03-01
| |/ | | | | | | | | | | | | | | This reverts commit fc5cf812c81a10f8a021aae11df5f12ab2a6f6f6. [NO NEW TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* | Merge pull request #13380 from jwhonce/wip/docker-pyOpenShift Merge Robot2022-03-01
|\ \ | |/ |/| Refactor docker-py compatibility tests
| * Refactor docker-py compatibility testsJhon Honce2022-03-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add which python client is being used to run tests, see "python client" below. * Remove redundate code from test classes * Update/Add comments to modules and classes ======================================================= test session starts ======================================================== platform linux -- Python 3.10.0, pytest-6.2.4, py-1.10.0, pluggy-0.13.1 python client -- DockerClient rootdir: /home/jhonce/Projects/go/src/github.com/containers/podman plugins: requests-mock-1.8.0 collected 33 items test/python/docker/compat/test_containers.py ...s.............. [ 54%] test/python/docker/compat/test_images.py ............ [ 90%] test/python/docker/compat/test_system.py ... [100%] Note: Follow-up PRs will verify the test results and expand the tests. Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #13362 from keonchennl/pod-logs-add-flagOpenShift Merge Robot2022-03-01
|\ \ | | | | | | Add the names flag for pod logs
| * | Add the names flag for pod logsXueyuan Chen2022-03-01
| |/ | | | | | | | | | | Fixes containers#13261 Signed-off-by: Xueyuan Chen <X.Chen-47@student.tudelft.nl>
* | Merge pull request #13318 from rhatdan/volumeOpenShift Merge Robot2022-03-01
|\ \ | | | | | | Add podman volume mount support
| * | Add podman volume mount supportDaniel J Walsh2022-02-28
| |/ | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/12768 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
* | Merge pull request #13374 from cevich/fix_dupe_docker_testingOpenShift Merge Robot2022-02-28
|\ \ | | | | | | Clarify v2 API testing for podman vs docker clients
| * | Clarify v2 API testing for podman vs docker clientsChris Evich2022-02-28
| |/ | | | | | | | | | | Fixes: #13273 Signed-off-by: Chris Evich <cevich@redhat.com>
* | Merge pull request #13372 from ashley-cui/binarypathOpenShift Merge Robot2022-02-28
|\ \ | |/ |/| Allow setting binarypath from Makefile
| * Allow setting binarypath from MakefileAshley Cui2022-02-28
| | | | | | | | | | | | | | | | | | | | Packagers for other distributions and package managers may put their helper binaries in other location prefixes. Add HELPER_BINARIES_DIR to the makefile so packagers can set the prefix when building Podman. HELPER_BINARIES_DIR will be set at link-time. Example usage: make podman-remote HELPER_BINARIES_DIR=/my/location/prefix Signed-off-by: Ashley Cui <acui@redhat.com>
| * Vendor in containers/common@mainAshley Cui2022-02-28
| | | | | | | | Signed-off-by: Ashley Cui <acui@redhat.com>
* | Merge pull request #13353 from lsm5/copr-packaging-macroOpenShift Merge Robot2022-02-26
|\ \ | |/ |/| copr packaging: use generic macros for tmpfiles and modules load dirs
| * copr packaging: use generic macros for tmpfiles and modules load dirsLokesh Mandvekar2022-02-25
|/ | | | | | [NO NEW TESTS NEEDED] Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* Merge pull request #13343 from afbjorklund/dpkg-packageOpenShift Merge Robot2022-02-25
|\ | | | | Show version of the deb package in info output
| * Show version of the deb package in info outputAnders F Björklund2022-02-24
|/ | | | | | | | | Previously just showing name of the package, followed by the path repeated again (already stated on the line above) [NO NEW TESTS NEEDED] Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
* Merge pull request #13336 from ↵OpenShift Merge Robot2022-02-24
|\ | | | | | | | | containers/dependabot/go_modules/github.com/containernetworking/plugins-1.1.0 Bump github.com/containernetworking/plugins from 1.0.1 to 1.1.0
| * Bump github.com/containernetworking/plugins from 1.0.1 to 1.1.0dependabot[bot]2022-02-24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Bumps [github.com/containernetworking/plugins](https://github.com/containernetworking/plugins) from 1.0.1 to 1.1.0. - [Release notes](https://github.com/containernetworking/plugins/releases) - [Commits](https://github.com/containernetworking/plugins/compare/v1.0.1...v1.1.0) --- updated-dependencies: - dependency-name: github.com/containernetworking/plugins dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>