aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* Add filter params description to volume list/prune docsJakub Guzik2021-08-30
| | | | | | | Description adjusted to the standard seen in other man pages. [CI:DOCS] Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
* logFile until flag issuecdoern2021-08-30
| | | | | | | | | we were adding a negative duration in podman events, causing inputs like -5s to be correct and 5s to be incorrect. fixes #11158 Signed-off-by: cdoern <cdoern@redhat.com>
* Fix file descriptor leaks and add testJhon Honce2021-08-30
| | | | | | | | | | * Add response.Body.Close() where needed to release HTTP connections to API server. * Add tests to ensure no general leaks occur. 100% coverage would be required to ensure no leaks on any call. * Update code comments to be godoc correct Signed-off-by: Jhon Honce <jhonce@redhat.com>
* utils.RunUnderSystemdScope(): always close ConnNalin Dahyabhai2021-08-30
| | | | | | | | | | Make sure we close our private connection to the bus, even if we're not successful in in using it to ask systemd to move a unit's processes to a specific control group. [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
* Use pod netns with --pod-id-filePaul Holzinger2021-08-30
| | | | | | | | | | When `--pod-id-file` is used do not parse the default network namespace and let specgen handle it instead. This regression was introduced in commit 7ef3981abe24. Fixes #11303 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* e2e tests: fix overlay: Unknown option vfs.imagestoreAlex Jia2021-08-30
| | | | | | | | | | | | Fixes: https://github.com/containers/podman/issues/11201 The STORAGE_FS is hard code in test/e2e/config_amd64.go, it will hit error like this "overlay: Unknown option vfs.imagestore" when setting STORAGE_OPTIONS="--storage-driver overlay". With this patch, the STORAGE_FS is exported as environment variable, if STORAGE_FS is set, then set storageOptions to --storage-driver $STORAGE_FS. Signed-off-by: Alex Jia <chuanchang.jia@gmail.com>
* Merge pull request #11341 from baude/v3.3errorcompareOpenShift Merge Robot2021-08-27
|\ | | | | change error comparison for exec.ErrNotFound
| * change error comparison for exec.ErrNotFoundBrent Baude2021-08-27
|/ | | | | | | | | it seeems exec.ErrNotFound does not work with simple equality checks and needs errors.Is() to work correctly. [NO TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #11320 from vrothberg/3.3-fix-11304OpenShift Merge Robot2021-08-25
|\ | | | | [3.3] generate systemd: use --cidfile again
| * generate systemd: use --cidfile againValentin Rothberg2021-08-25
|/ | | | | | | | | | | | | | | | | | | Commit 9ac5267 changed the type of the generated systemd units from `forking` to `notify`. It further stopped using `--cidfile` and instead intended systemd to take care of stopping the container, which turned out to be a bad idea. Systemd will send the stop/kill signals to conmon which in turn may exit non-zero, depending on the signal, and ultimately breaking container cleanup. Hence, we need to use --cidfile again and let podman stop and remove the container to make sure that everything's in order. Backport of commit 74ab2aaf9f27e1495a74c37932a634c82af9a57b. Fixes: #11304 Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #11300 from mheon/bump_330OpenShift Merge Robot2021-08-20
|\ | | | | [CI:DOCS] Bump to v3.3.0
| * Bump to v3.3.1-devMatthew Heon2021-08-20
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v3.3.0v3.3.0Matthew Heon2021-08-20
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #11299 from mheon/330_final_backportsOpenShift Merge Robot2021-08-20
|\ | | | | v3.3.0 Final Backports and Release Notes
| * Final release notes for v3.3.0Matthew Heon2021-08-20
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Fix network aliases with network idPaul Holzinger2021-08-20
| | | | | | | | | | | | | | | | | | | | | | | | When a network id is used to create a container we translate it to use the name internally for the db. The network aliases are also stored with the network name as key so we have to also translate them for the db. Also removed some outdated skips from the e2e tests. Fixes #11285 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * machine: compute sha256 as we read the image fileGuillaume Rose2021-08-20
| | | | | | | | | | | | | | | | It avoids to have the full file in memory. [NO TESTS NEEDED] Signed-off-by: Guillaume Rose <gurose@redhat.com>
| * machine: check for file exists instead of listing directoryGuillaume Rose2021-08-20
| | | | | | | | | | | | [NO TESTS NEEDED] Signed-off-by: Guillaume Rose <gurose@redhat.com>
| * pkg/bindings/images.nTar(): slashify hdr.Name valuesNalin Dahyabhai2021-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | When setting path names in the build context archive, convert path names to use forward slashes, as is normal for those archives, so that directory hierarchies archived on Windows hosts extract correctly everywhere. Not really sure how to run the remote client in CI on a system that uses `\` as a path separator, which is where this error crops up, so [NO TESTS NEEDED] Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
| * Volumes: Only remove from DB if plugin removal succeedsMatthew Heon2021-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Originally, Podman would unconditionally remove volumes from the DB, even if they failed to be removed from the volume plugin; this was a safety measure to ensure that `volume rm` can always remove a volume from the database, even if the plugin is misbehaving. However, this is a significant deivation from Docker, which refuses to remove if the plugin errors. These errors can be legitimate configuration issues which the user should address before the volume is removed, so Podman should also use this behaviour. Fixes #11214 Signed-off-by: Matthew Heon <mheon@redhat.com>
| * For compatibility, ignore Content-TypeJhon Honce2021-08-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Endpoint /build logs an info entry when a client uses the wrong Content-Type for build payload. Given Content-Type is ignored and assumed to be "application/x-tar". Endpoint /libpod/build will fail unless "application/x-tar" or "application/tar" is given for Content-Type. "application/tar" will be logged as an info entry. Fixes #11012 Signed-off-by: Jhon Honce <jhonce@redhat.com>
* | Merge pull request #11297 from TomSweeneyRedHat/dev/tsweeney/danceoffOpenShift Merge Robot2021-08-20
|\ \ | |/ |/| [v3.3] Bump c/image 5.15.2, buildah v1.22.3
| * [v3.3] Bump c/image 5.15.2, buildah v1.22.3TomSweeneyRedHat2021-08-20
| | | | | | | | | | | | | | | | | | | | Bump c/image to v5.15.2 and Buildah to v1.22.3 in preparation for the Podman v3.3.0 release [NO TESTS NEEDED] [NO NEW TESTS NEEDED] Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* | Merge pull request #11294 from vrothberg/3.3-notify-proxyOpenShift Merge Robot2021-08-20
|\ \ | |/ |/| [3.3] Implement SD-NOTIFY proxy in conmon
| * Implement SD-NOTIFY proxy in conmonDaniel J Walsh2021-08-20
|/ | | | | | | | | | | This leverages conmon's ability to proxy the SD-NOTIFY socket. This prevents locking caused by OCI runtime blocking, waiting for SD-NOTIFY messages, and instead passes the messages directly up to the host. Backport of commit c22f3e8b4e25. Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
* Merge pull request #11281 from Luap99/3.3-backOpenShift Merge Robot2021-08-19
|\ | | | | [v3.3] backport rootless networking fixes
| * Fix rootless cni dns without systemd stub resolverPaul Holzinger2021-08-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When a host uses systemd-resolved but not the resolved stub resolver the following symlinks are created: `/etc/resolv.conf` -> `/run/systemd/resolve/stub-resolv.conf` -> `/run/systemd/resolve/resolv.conf`. Because the code uses filepath.EvalSymlinks we put the new resolv.conf to `/run/systemd/resolve/resolv.conf` but the `/run/systemd/resolve/stub-resolv.conf` link does not exists in the mount ns. To fix this we will walk the symlinks manually until we reach the first one under `/run` and use this for the resolv.conf file destination. This fixes a regression which was introduced in e73d4829900c. Fixes #11222 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
| * fix rootlessport flakePaul Holzinger2021-08-19
|/ | | | | | | | | | | | | | | | | | | | | When the rootlessport process is started the stdout/stderr are attached to the podman process. However once everything is setup podman exits and when the rootlessport process tries to write to stdout it will fail with SIGPIPE. The code handles this signal and puts /dev/null to stdout and stderr but this is not robust. I do not understand the exact cause but sometimes the process is still killed by SIGPIPE. Either go lost the signal or the process got already killed before the goroutine could handle it. Instead of handling SIGPIPE just set /dev/null to stdout and stderr before podman exits. With this there should be no race and no way to run into SIGPIPE errors. [NO TESTS NEEDED] Fixes #11248 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
* Merge pull request #11163 from cevich/v3.3_update_imagesOpenShift Merge Robot2021-08-19
|\ | | | | [V3.3] Update images
| * Skip stats test in CGv1 container environmentsChris Evich2021-08-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These tests were originally enabled in a situation where CI provided false-positive results. Now that has been corrected, these tests all fail under a CGv1 container environment with the error: ``` Error: unable to load cgroup at /machine.slice/libpod-e4f...086.scope/libpod_parent/libpod-fbd...425: cgroup deleted ``` This commit simply disables the tests under this specific environment. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Fix AVC denials in tests of volume mountsChris Evich2021-08-17
| | | | | | | | | | | | | | | | | | This becomes a problem on hosts with upgraded policies. Ref: https://github.com/containers/podman/issues/10522 Also, made a small change to compose-test setup to reduce runtime. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Restore buildah-bud test requiring new imagesChris Evich2021-08-17
| | | | | | | | | | | | | | Ref: https://github.com/containers/podman/pull/10829#issuecomment-881355983 Signed-off-by: Chris Evich <cevich@redhat.com>
| * Revert ".cirrus.yml: use fresh images for all VMs"Chris Evich2021-08-17
| | | | | | | | | | | | | | | | | | | | | | This reverts commit 404d5edb1557e3d2cb255d38bd89274586c4c100. The replacement (updated) images include a fix for: https://github.com/containers/common/issues/631 Also minor update to an unrelated FIXME comment. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Fix device tests using ls test filesChris Evich2021-08-17
| | | | | | | | | | | | | | | | | | | | | | The `ls` command is not intended for this purpose and may behave in unexpected ways, leading to false positive or negative results. Update the tests to use the purpose built `test` command instead. Also added several *TODO* comments for possible future testing enhancements. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Enhance priv. dev. checkChris Evich2021-08-17
| | | | | | | | | | | | | | | | Update test to confirm the negative-case, proving the `--privileged` "option is required" for this character device to be present in a container (including rootless). Signed-off-by: Chris Evich <cevich@redhat.com>
| * Workaround host availability of /dev/kvmChris Evich2021-08-17
| | | | | | | | | | | | | | | | | | | | | | | | This test has been failing for a long time but nobody noticed because CI doesn't have the device node (nested-VM support was disabled). After having enabled nested VM support, tests fail due to some unknown special-handling of this device. Fix both problems by removing the `skip()` and switching to a more generic device which is only present when `--privileged` is used. Signed-off-by: Chris Evich <cevich@redhat.com>
| * Skip cgroup-parent test due to frequent flakesChris Evich2021-08-17
| | | | | | | | | | | | Ref: https://github.com/containers/podman/issues/11165 Signed-off-by: Chris Evich <cevich@redhat.com>
| * Cirrus: Fix not uploading logformatter htmlChris Evich2021-08-17
|/ | | | | | | Previously we were generating the annotated results but never uploading them. Fix this so visiting the advertised URL actually works. Signed-off-by: Chris Evich <cevich@redhat.com>
* Merge pull request #11254 from mheon/bump_330_rc3openshift-ci[bot]2021-08-17
|\ | | | | [CI:DOCS] Bump to v3.3.0-RC3
| * Bump to v3.3.0-devMatthew Heon2021-08-17
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Bump to v3.3.0-RC3v3.3.0-rc3Matthew Heon2021-08-17
| | | | | | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
| * Release notes for v3.3.0-RC3Matthew Heon2021-08-17
|/ | | | Signed-off-by: Matthew Heon <mheon@redhat.com>
* Merge pull request #11250 from TomSweeneyRedHat/dev/tsweeney/bumpcstorageopenshift-ci[bot]2021-08-17
|\ | | | | [v3.3] Bump c/storage to v1.34.1 and c/image to v5.15.1
| * [v3.3] Bump c/storage to v1.34.1 and c/image to v5.15.1TomSweeneyRedHat2021-08-17
|/ | | | | | | | | | Bump c/storage to v1.34.1 and c/image to v5.15.1 for Podman v3.3 rc3 [NO TESTS NEEDED] [NO NEW TESTS NEEDED] Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
* Merge pull request #11234 from baude/v3.3fixmacospathopenshift-ci[bot]2021-08-16
|\ | | | | fix gvproxy path search for macos
| * fix gvproxy path search for macosBrent Baude2021-08-16
|/ | | | | | | | | | | macos does not have /usr/libexec/ so we look in the executable paths first. Fixes: #11226 [NO TESTS NEEDED] Signed-off-by: Brent Baude <bbaude@redhat.com>
* Merge pull request #11221 from lsm5/v3.3.0-rc2Daniel J Walsh2021-08-12
|\ | | | | V3.3.0 rc2
| * Bump to v3.3.0-devLokesh Mandvekar2021-08-12
| | | | | | | | Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
| * Bump to v3.3.0-rc2v3.3.0-rc2Lokesh Mandvekar2021-08-12
|/ | | | Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
* Merge pull request #11215 from baude/v3.3gvproxyopenshift-ci[bot]2021-08-12
|\ | | | | Set gvproxy path to /usr/libexec/podman/gvproxy
generated by cgit v1.2.3-54-g00ecf (git 2.39.0) at 2025-03-15 19:39:01 +0000